144580 2015-05-04 09:39:16 -0700 [CMake] Build C code with -std=c89 2022-09-23 05:32:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 zan webkit-unassigned ahmad.saleem792 ap bfulgham gyuyoung.kim lantw44 ossy oldest_to_newest 1091403 0 zan 2015-05-04 09:39:16 -0700 [CMake] Build C code with -std=c11 1091406 1 252315 zan 2015-05-04 09:45:30 -0700 Created attachment 252315 Patch 1091432 2 ossy 2015-05-04 10:40:51 -0700 Let me check the EFL failure. 1091736 3 ossy 2015-05-05 05:52:51 -0700 The problem is that strdup in string.h is ifdef-ed out if we build it with -std=c11. Defining GNU_SOURCE solves the build error in Minibrowser/main.c, but I'm not sure what is the proper fix for it, or if EFL wants to build with c11 or not. 1152194 4 252315 mcatanzaro 2016-01-03 17:10:12 -0800 Comment on attachment 252315 Patch I'm not at all sure this is a good idea. Microsoft has no intention of supporting C11 (or even C99) in MSVCC, so we would have to be careful to only use C11 in code that will never be used by Windows. Since we probably want to support Windows eventually, allowing C11 to creep into our codebase anywhere will make that harder. It also makes it easier to accidentally break Windows when making changes locally, and not find out until the EWS catches it. Now, with GCC 5 the default is currently -std=gnu11, so switching to -std=c11 is more restrictive as it disables GNU extensions, which is good for us. But with Clang the default is -std=gnu99, and with GCC 4.x the default is -std=gnu89. You might call Microsoft's version ms89. So we're compiling with four different standards right now, and there is certainly good benefit to explicitly specifying a standard. But I would suggest we explicitly compile with -std=c89, rather than c11. 1152691 5 zan 2016-01-05 02:09:07 -0800 OK, agreed. Let's settle on c89 (in 2016 :|) 1152692 6 268274 zan 2016-01-05 02:34:53 -0800 Created attachment 268274 Patch 1152701 7 268274 mcatanzaro 2016-01-05 06:38:29 -0800 Comment on attachment 268274 Patch Patch LGTM, except for the roughly bajillion EFL and GTK build failures. :/ 1152713 8 zan 2016-01-05 07:36:01 -0800 The errors are in the Udis86 code. I'm not fixing that since the code is coming from an external project, which I hope doesn't care about C89 compliance. MSVC has some basic support for C99, and no compiler supports it completely anyway. C11 doesn't work with EFL headers. So either C99 should be default, or we should make the -std= C flag port-specific. 1155045 9 zan 2016-01-13 01:50:25 -0800 I'm not bothering with this anymore. The amount of C code that's built is minimal, and every compiler and port have their own quirks around this. 1900609 10 ahmad.saleem792 2022-09-23 05:32:11 -0700 Is this required anymore? Thanks1 252315 2015-05-04 09:45:30 -0700 2016-01-05 02:34:47 -0800 Patch bug-144580-20150504094806.patch text/plain 1328 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzc0 NykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA1 LTA0ICDFvWFuIERvYmVyxaFlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtD TWFrZV0gQnVpbGQgQyBjb2RlIHdpdGggLXN0ZD1jMTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDU4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21h a2U6IEFwcGVuZCB0aGUgLXN0ZD1jMTEgZmxhZworICAgICAgICB0byBDTUFLRV9DX0ZMQUdTLCBl bmZvcmNpbmcgYnVpbGRpbmcgdGhlIEMgY29kZSBpbiB0aGUgV2ViS2l0CisgICAgICAgIHByb2pl Y3QgaW4gQzExIHN0YW5kYXJkIG1vZGUuCisKIDIwMTUtMDUtMDQgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbY21ha2VdIERpc2FibGUgR05VIEdvbGQg bGlua2VyIG9uIENvcnRleCBBNTMKSW5kZXg6IFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNt YWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCShyZXZp c2lvbiAxODM3NDQpCisrKyBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQkod29ya2lu ZyBjb3B5KQpAQCAtMjYsNiArMjYsNyBAQCBzZXRfcHJvcGVydHkoR0xPQkFMIFBST1BFUlRZIFVT RV9GT0xERVJTCiAKIGlmIChDTUFLRV9DT01QSUxFUl9JU19HTlVDWFggT1IgIiR7Q01BS0VfQ1hY X0NPTVBJTEVSX0lEfSIgU1RSRVFVQUwgIkNsYW5nIikKICAgICBzZXQoQ01BS0VfQ19GTEFHU19S RUxFQVNFICIke0NNQUtFX0NfRkxBR1NfUkVMRUFTRX0gLWZuby1leGNlcHRpb25zIC1mbm8tc3Ry aWN0LWFsaWFzaW5nIikKKyAgICBzZXQoQ01BS0VfQ19GTEFHUyAiJHtDTUFLRV9DX0ZMQUdTfSAt c3RkPWMxMSIpCiAgICAgc2V0KENNQUtFX0NYWF9GTEFHU19SRUxFQVNFICIke0NNQUtFX0NYWF9G TEFHU19SRUxFQVNFfSAtZm5vLWV4Y2VwdGlvbnMgLWZuby1zdHJpY3QtYWxpYXNpbmcgLWZuby1y dHRpIikKICAgICBzZXQoQ01BS0VfQ1hYX0ZMQUdTICIke0NNQUtFX0NYWF9GTEFHU30gLXN0ZD1j KysxMSIpCiBlbmRpZiAoKQo= 268274 2016-01-05 02:34:53 -0800 2016-01-05 06:38:29 -0800 Patch bug-144580-20160105023419.patch text/plain 1585 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDMzOWM1N2JiODAyNDVkMTM3ZjFjNjg4ZjI0ZjBmZDEwZGQxNTgzZGQuLjgzNDY0N2ZmNGJiOWY2 Yzk4M2NhYTA2NWQyMmIyYmMyN2VhYjFlOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0yNyw2ICsyNyw3IEBAIHNldF9wcm9wZXJ0eShHTE9CQUwgUFJPUEVSVFkgVVNFX0ZPTERFUlMg T04pCiAKIGlmIChDTUFLRV9DT01QSUxFUl9JU19HTlVDWFggT1IgIiR7Q01BS0VfQ1hYX0NPTVBJ TEVSX0lEfSIgU1RSRVFVQUwgIkNsYW5nIikKICAgICBzZXQoQ01BS0VfQ19GTEFHU19SRUxFQVNF ICIke0NNQUtFX0NfRkxBR1NfUkVMRUFTRX0gLWZuby1leGNlcHRpb25zIC1mbm8tc3RyaWN0LWFs aWFzaW5nIikKKyAgICBzZXQoQ01BS0VfQ19GTEFHUyAiJHtDTUFLRV9DX0ZMQUdTfSAtc3RkPWM4 OSIpCiAgICAgc2V0KENNQUtFX0NYWF9GTEFHU19SRUxFQVNFICIke0NNQUtFX0NYWF9GTEFHU19S RUxFQVNFfSAtZm5vLWV4Y2VwdGlvbnMgLWZuby1zdHJpY3QtYWxpYXNpbmcgLWZuby1ydHRpIikK ICAgICBzZXQoQ01BS0VfQ1hYX0ZMQUdTICIke0NNQUtFX0NYWF9GTEFHU30gLXN0ZD1jKysxMSIp CiBlbmRpZiAoKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDliNDU5 YmE3ZjFhOTcxZGZkMTZmMGMzNDlkMzE1MjE1YTc3NTlhNjIuLjg3MmUzZWZmY2I1ZGJmYmRjMDgw NzBlMTllNjUzMDU1Zjc2N2Q0NjggMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNi0wMS0wNSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2Vr QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBCdWlsZCBDIGNvZGUgd2l0aCAtc3RkPWM4 OQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NTgw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3Vy Y2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZTogQXBwZW5kIHRoZSAtc3RkPWM4OSBmbGFnCisg ICAgICAgIHRvIENNQUtFX0NfRkxBR1MsIGVuZm9yY2luZyBidWlsZGluZyB0aGUgQyBjb2RlIGlu IHRoZSBXZWJLaXQKKyAgICAgICAgcHJvamVjdCBpbiBDODkgc3RhbmRhcmQgbW9kZS4gVGhpcyBt b2RlIHNob3VsZCBiZSB3ZWxsIHN1cHBvcnRlZAorICAgICAgICBieSBhbGwgdGhlIGN1cnJlbnQg YW5kIGZ1dHVyZSBjb21waWxlcnMgdGhhdCB3ZSB3b3VsZCBiZSB1c2luZy4KKyAgICAgICAgQzEx IG1vZGUgd291bGQgYmUgcHJlZmVycmVkLCBidXQgTVNWQyBkb2Vzbid0IHN1cHBvcnQgaXQuCisK IDIwMTYtMDEtMDQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBGaXggTWFjIENNYWtlIGJ1aWxkIGFmdGVyIHIxOTQ0NTQuCg==