144578 2015-05-04 09:17:13 -0700 Add missing vtable override specifiers under Source/WebCore/html 2015-05-05 23:24:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan calvaris commit-queue dino eric.carlson esprehn+autocc gyuyoung.kim kondapallykalyan philipj roger_fong oldest_to_newest 1091397 0 zan 2015-05-04 09:17:13 -0700 Add missing vtable override specifiers under Source/WebCore/html 1091399 1 252314 zan 2015-05-04 09:19:55 -0700 Created attachment 252314 Patch 1091418 2 252314 dbates 2015-05-04 10:19:44 -0700 Comment on attachment 252314 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252314&action=review > Source/WebCore/ChangeLog:1 > +2015-05-04 Žan Doberšek <zdobersek@igalia.com> There seems to be some character encoding issue with respect to the characters on this line. 1091420 3 252314 dbates 2015-05-04 10:20:50 -0700 Comment on attachment 252314 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252314&action=review > Source/WebCore/html/track/TrackListBase.h:54 > + virtual EventTargetInterface eventTargetInterface() const override = 0; There should not be an override specifier here. 1091426 4 252314 dbates 2015-05-04 10:30:33 -0700 Comment on attachment 252314 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252314&action=review >> Source/WebCore/html/track/TrackListBase.h:54 >> + virtual EventTargetInterface eventTargetInterface() const override = 0; > > There should not be an override specifier here. Never mind. As indicated by the comment on line 53, this is a redeclaration of EventTarget::eventTargetInterface(). 1092067 5 zan 2015-05-05 23:13:09 -0700 (In reply to comment #2) > Comment on attachment 252314 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252314&action=review > > > Source/WebCore/ChangeLog:1 > > +2015-05-04 Žan Doberšek <zdobersek@igalia.com> > > There seems to be some character encoding issue with respect to the > characters on this line. This appears to be a bug in PrettyPatch. 1092076 6 252314 zan 2015-05-05 23:24:43 -0700 Comment on attachment 252314 Patch Clearing flags on attachment: 252314 Committed r183858: <http://trac.webkit.org/changeset/183858> 1092077 7 zan 2015-05-05 23:24:51 -0700 All reviewed patches have been landed. Closing bug. 252314 2015-05-04 09:19:55 -0700 2015-05-05 23:24:43 -0700 Patch bug-144578-20150504092231.patch text/plain 4193 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzc0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA1LTA0ICDFvWFuIERv YmVyxaFlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIEFkZCBtaXNzaW5nIHZ0 YWJsZSBvdmVycmlkZSBzcGVjaWZpZXJzIHVuZGVyIFNvdXJjZS9XZWJDb3JlL2h0bWwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDU3OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB2aXJ0dWFs IG1ldGhvZCBvdmVycmlkZXMgdW5kZXIgU291cmNlL1dlYkNvcmUvaHRtbAorICAgICAgICB3aGlj aCBhcmUgbWlzc2luZyB0aGUgb3ZlcnJpZGUgc3BlY2lmaWVyLgorCisgICAgICAgICogaHRtbC9j YW52YXMvV2ViR0wyUmVuZGVyaW5nQ29udGV4dC5oOgorICAgICAgICAqIGh0bWwvY2FudmFzL1dl YkdMUmVuZGVyaW5nQ29udGV4dC5oOgorICAgICAgICAqIGh0bWwvdHJhY2svSW5iYW5kVGV4dFRy YWNrLmg6CisgICAgICAgICogaHRtbC90cmFjay9UcmFja0xpc3RCYXNlLmg6CisKIDIwMTUtMDUt MDQgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXVEZd IFJlbW92ZSBGdW5jdGlvbmFsLmggaW5jbHVzaW9ucwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRt bC9jYW52YXMvV2ViR0wyUmVuZGVyaW5nQ29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMMlJlbmRlcmluZ0NvbnRleHQuaAkocmV2aXNpb24gMTgz NzQ0KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0wyUmVuZGVyaW5nQ29udGV4 dC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0MCw3IEBAIGNsYXNzIFdlYkdMMlJlbmRlcmlu Z0NvbnRleHQgZmluYWwgOiBwdWIKIHB1YmxpYzoKICAgICBXZWJHTDJSZW5kZXJpbmdDb250ZXh0 KEhUTUxDYW52YXNFbGVtZW50KiwgR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMpOwogICAg IFdlYkdMMlJlbmRlcmluZ0NvbnRleHQoSFRNTENhbnZhc0VsZW1lbnQqLCBQYXNzUmVmUHRyPEdy YXBoaWNzQ29udGV4dDNEPiwgR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMpOwotICAgIHZp cnR1YWwgYm9vbCBpc1dlYkdMMigpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KKyAgICB2aXJ0dWFs IGJvb2wgaXNXZWJHTDIoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVlOyB9CiAKICAgICAv KiBCdWZmZXIgb2JqZWN0cyAqLwogICAgIHZvaWQgY29weUJ1ZmZlclN1YkRhdGEoR0MzRGVudW0g cmVhZFRhcmdldCwgR0MzRGVudW0gd3JpdGVUYXJnZXQsIEdDM0RpbnQ2NCByZWFkT2Zmc2V0LCBH QzNEaW50NjQgd3JpdGVPZmZzZXQsIEdDM0RpbnQ2NCBzaXplKTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oCShyZXZpc2lv biAxODM3NDQpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv bnRleHQuaAkod29ya2luZyBjb3B5KQpAQCAtMzQsNyArMzQsNyBAQCBjbGFzcyBXZWJHTFJlbmRl cmluZ0NvbnRleHQgZmluYWwgOiBwdWJsCiBwdWJsaWM6CiAgICAgV2ViR0xSZW5kZXJpbmdDb250 ZXh0KEhUTUxDYW52YXNFbGVtZW50KiwgR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMpOwog ICAgIFdlYkdMUmVuZGVyaW5nQ29udGV4dChIVE1MQ2FudmFzRWxlbWVudCosIFBhc3NSZWZQdHI8 R3JhcGhpY3NDb250ZXh0M0Q+LCBHcmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRlcyk7Ci0gICAg dmlydHVhbCBib29sIGlzV2ViR0wxKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQorICAgIHZpcnR1 YWwgYm9vbCBpc1dlYkdMMSgpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIHRydWU7IH0KICAgICAK ICAgICB2aXJ0dWFsIFdlYkdMRXh0ZW5zaW9uKiBnZXRFeHRlbnNpb24oY29uc3QgU3RyaW5nJikg b3ZlcnJpZGU7CiAgICAgdmlydHVhbCBXZWJHTEdldEluZm8gZ2V0UGFyYW1ldGVyKEdDM0RlbnVt IHBuYW1lLCBFeGNlcHRpb25Db2RlJikgb3ZlcnJpZGU7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9o dG1sL3RyYWNrL0luYmFuZFRleHRUcmFjay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2h0bWwvdHJhY2svSW5iYW5kVGV4dFRyYWNrLmgJKHJldmlzaW9uIDE4Mzc0NCkKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvdHJhY2svSW5iYW5kVGV4dFRyYWNrLmgJKHdvcmtpbmcgY29weSkKQEAg LTQ5LDcgKzQ5LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRNb2RlKGNvbnN0IEF0 b21pY1N0cmluZyYpIG92ZXJyaWRlOwogICAgIHNpemVfdCBpbmJhbmRUcmFja0luZGV4KCk7CiAK LSAgICB2aXJ0dWFsIEF0b21pY1N0cmluZyBpbkJhbmRNZXRhZGF0YVRyYWNrRGlzcGF0Y2hUeXBl KCkgY29uc3Q7CisgICAgdmlydHVhbCBBdG9taWNTdHJpbmcgaW5CYW5kTWV0YWRhdGFUcmFja0Rp c3BhdGNoVHlwZSgpIGNvbnN0IG92ZXJyaWRlOwogCiAgICAgdm9pZCBzZXRQcml2YXRlKFBhc3NS ZWZQdHI8SW5iYW5kVGV4dFRyYWNrUHJpdmF0ZT4pOwogCkBAIC04NCw3ICs4NCw3IEBAIHByaXZh dGU6CiAgICAgdmlydHVhbCB2b2lkIHBhcnNlV2ViVlRUQ3VlRGF0YShJbmJhbmRUZXh0VHJhY2tQ cml2YXRlKiwgY29uc3QgY2hhciosIHVuc2lnbmVkKSBvdmVycmlkZSB7IEFTU0VSVF9OT1RfUkVB Q0hFRCgpOyB9CiAgICAgdmlydHVhbCB2b2lkIHBhcnNlV2ViVlRUQ3VlRGF0YShJbmJhbmRUZXh0 VHJhY2tQcml2YXRlKiwgY29uc3QgSVNPV2ViVlRUQ3VlJikgb3ZlcnJpZGUgeyBBU1NFUlRfTk9U X1JFQUNIRUQoKTsgfQogCi0gICAgdmlydHVhbCBNZWRpYVRpbWUgc3RhcnRUaW1lVmFyaWFuY2Uo KSBjb25zdDsKKyAgICB2aXJ0dWFsIE1lZGlhVGltZSBzdGFydFRpbWVWYXJpYW5jZSgpIGNvbnN0 IG92ZXJyaWRlOwogCiAjaWYgVVNFKFBMQVRGT1JNX1RFWFRfVFJBQ0tfTUVOVSkKICAgICB2aXJ0 dWFsIEluYmFuZFRleHRUcmFja1ByaXZhdGUqIHByaXZhdGVUcmFjaygpIG92ZXJyaWRlIHsgcmV0 dXJuIG1fcHJpdmF0ZS5nZXQoKTsgfQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9U cmFja0xpc3RCYXNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9U cmFja0xpc3RCYXNlLmgJKHJldmlzaW9uIDE4Mzc0NCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwv dHJhY2svVHJhY2tMaXN0QmFzZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw3ICs1MSw3IEBAIHB1 YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlKFRyYWNrQmFzZSosIGJvb2wgc2NoZWR1bGVF dmVudCA9IHRydWUpOwogCiAgICAgLy8gRXZlbnRUYXJnZXQKLSAgICB2aXJ0dWFsIEV2ZW50VGFy Z2V0SW50ZXJmYWNlIGV2ZW50VGFyZ2V0SW50ZXJmYWNlKCkgY29uc3QgPSAwOworICAgIHZpcnR1 YWwgRXZlbnRUYXJnZXRJbnRlcmZhY2UgZXZlbnRUYXJnZXRJbnRlcmZhY2UoKSBjb25zdCBvdmVy cmlkZSA9IDA7CiAgICAgdXNpbmcgUmVmQ291bnRlZDxUcmFja0xpc3RCYXNlPjo6cmVmOwogICAg IHVzaW5nIFJlZkNvdW50ZWQ8VHJhY2tMaXN0QmFzZT46OmRlcmVmOwogICAgIHZpcnR1YWwgU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpIGNvbnN0IG92ZXJy aWRlIGZpbmFsIHsgcmV0dXJuIG1fY29udGV4dDsgfQo=