144564 2015-05-04 03:56:15 -0700 Remove dead code from TestInvocationCairo.cpp 2015-05-04 08:22:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy cgarcia commit-queue gyuyoung.kim ossy zan oldest_to_newest 1091346 0 ossy 2015-05-04 03:56:15 -0700 void TestInvocation::dumpPixelsAndCompareWithExpected(WKImageRef wkImage, WKArrayRef repaintRects) has "PLATFORM(EFL) || PLATFORM(GTK)" and "else" implementation. But there isn't any WK2 Cairo platform different from EFL or GTK, so the else case is simply dead code, let's remove it. 1091347 1 252304 ossy 2015-05-04 03:58:37 -0700 Created attachment 252304 Patch 1091378 2 252304 commit-queue 2015-05-04 08:22:01 -0700 Comment on attachment 252304 Patch Clearing flags on attachment: 252304 Committed r183745: <http://trac.webkit.org/changeset/183745> 1091379 3 commit-queue 2015-05-04 08:22:04 -0700 All reviewed patches have been landed. Closing bug. 252304 2015-05-04 03:58:37 -0700 2015-05-04 08:22:01 -0700 Patch bug-144564-20150504035722.patch text/plain 1792 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNzQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2JjYTlmODkyM2Y1N2M3MTU4NWFhNzhmNWI2NjUyZWVm MzFlNTdiZi4uY2VhOGI3ZjAxMjVkN2U1NmRhMmFlNDk0YTRjMTAwMTZkMTY5YjkyNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA1LTA0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmVtb3ZlIGRlYWQgY29kZSBmcm9tIFRlc3RJbnZvY2F0aW9uQ2Fpcm8uY3BwCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ1NjQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IEVGTCBh bmQgR1RLIHBvcnQgdXNlIFRlc3RJbnZvY2F0aW9uQ2Fpcm8uY3BwLCB0aGVyZSBpc24ndCBvdGhl ciBwbGF0Zm9ybS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvY2Fpcm8vVGVzdEludm9j YXRpb25DYWlyby5jcHA6CisgICAgICAgIChXVFI6OlRlc3RJbnZvY2F0aW9uOjpkdW1wUGl4ZWxz QW5kQ29tcGFyZVdpdGhFeHBlY3RlZCk6CisKIDIwMTUtMDUtMDEgIE1hcmlvIFNhbmNoZXogUHJh ZGEgIDxtYXJpb0BlbmRsZXNzbS5jb20+CiAKICAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIGZh aWxzIGR1ZSB0byBzeXN0ZW0gcHlsaW50CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL2NhaXJvL1Rlc3RJbnZvY2F0aW9uQ2Fpcm8uY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9jYWlyby9UZXN0SW52b2NhdGlvbkNhaXJvLmNwcAppbmRleCA5ZTA1NDY4ODgxYTk0MzY2MGEz ZTQ0YzUxMjA3OTgwNjYzMzRiOGM4Li40ZmFmYjE4MGQ4YjI4MGRjMDI3YjcyNjI1MmExNzY5ZWU3 ZWZmN2M2IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2NhaXJvL1Rlc3RJbnZv Y2F0aW9uQ2Fpcm8uY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvY2Fpcm8vVGVzdElu dm9jYXRpb25DYWlyby5jcHAKQEAgLTEwNiwxNCArMTA2LDkgQEAgc3RhdGljIHZvaWQgcGFpbnRS ZXBhaW50UmVjdE92ZXJsYXkoY2Fpcm9fc3VyZmFjZV90KiBzdXJmYWNlLCBXS0FycmF5UmVmIHJl cGFpbnQKICAgICBjYWlyb19kZXN0cm95KGNvbnRleHQpOwogfQogCi12b2lkIFRlc3RJbnZvY2F0 aW9uOjpkdW1wUGl4ZWxzQW5kQ29tcGFyZVdpdGhFeHBlY3RlZChXS0ltYWdlUmVmIHdrSW1hZ2Us IFdLQXJyYXlSZWYgcmVwYWludFJlY3RzKQordm9pZCBUZXN0SW52b2NhdGlvbjo6ZHVtcFBpeGVs c0FuZENvbXBhcmVXaXRoRXhwZWN0ZWQoV0tJbWFnZVJlZiwgV0tBcnJheVJlZiByZXBhaW50UmVj dHMpCiB7Ci0jaWYgUExBVEZPUk0oRUZMKSB8fCBQTEFURk9STShHVEspCi0gICAgVU5VU0VEX1BB UkFNKHdrSW1hZ2UpOwogICAgIGNhaXJvX3N1cmZhY2VfdCogc3VyZmFjZSA9IFdLSW1hZ2VDcmVh dGVDYWlyb1N1cmZhY2UoVGVzdENvbnRyb2xsZXI6OnNpbmdsZXRvbigpLm1haW5XZWJWaWV3KCkt PndpbmRvd1NuYXBzaG90SW1hZ2UoKS5nZXQoKSk7Ci0jZWxzZQotICAgIGNhaXJvX3N1cmZhY2Vf dCogc3VyZmFjZSA9IFdLSW1hZ2VDcmVhdGVDYWlyb1N1cmZhY2Uod2tJbWFnZSk7Ci0jZW5kaWYK IAogICAgIGlmIChyZXBhaW50UmVjdHMpCiAgICAgICAgIHBhaW50UmVwYWludFJlY3RPdmVybGF5 KHN1cmZhY2UsIHJlcGFpbnRSZWN0cyk7Cg==