144563 2015-05-04 03:29:34 -0700 [WinCairo] Compile error in sharedEGLDisplay() method. 2015-05-04 10:12:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 144517 1 peavo webkit-unassigned achristensen bfulgham cgarcia commit-queue mrobinson ossy zan oldest_to_newest 1091337 0 peavo 2015-05-04 03:29:34 -0700 The PlatformDisplay type is undefined. 1091341 1 252302 peavo 2015-05-04 03:35:19 -0700 Created attachment 252302 Patch 1091343 2 ossy 2015-05-04 03:38:55 -0700 I think it is the fix after bug144517, so cc-ing its author + reviewer. 1091349 3 peavo 2015-05-04 04:07:29 -0700 (In reply to comment #2) > I think it is the fix after bug144517, so cc-ing its author + reviewer. Thanks :) 1091391 4 cgarcia 2015-05-04 08:50:38 -0700 Oops, sorry about this, thanks for fixing it. 1091400 5 252302 commit-queue 2015-05-04 09:23:43 -0700 Comment on attachment 252302 Patch Clearing flags on attachment: 252302 Committed r183747: <http://trac.webkit.org/changeset/183747> 1091401 6 commit-queue 2015-05-04 09:23:47 -0700 All reviewed patches have been landed. Closing bug. 1091416 7 peavo 2015-05-04 10:12:41 -0700 (In reply to comment #4) > Oops, sorry about this, thanks for fixing it. No worries, thanks for the review :) 252302 2015-05-04 03:35:19 -0700 2015-05-04 09:23:43 -0700 Patch bug-144563-20150504123402.patch text/plain 1915 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzc0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTA0ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIENvbXBp bGUgZXJyb3IgaW4gc2hhcmVkRUdMRGlzcGxheSgpIG1ldGhvZC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDU2MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBQbGF0Zm9ybURpc3BsYXkgdHlwZSBp cyB1bmRlZmluZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0 RUdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNoYXJlZEVHTERpc3BsYXkpOgorCiAyMDE1LTA1 LTA0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVt b3ZlIG1vdmUtanMtaGVhZGVycy5zaApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHAJKHJldmlzaW9uIDE4Mzc0MikK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC02NiwxNCArNjYsMTMgQEAgc3RhdGljIEVHTERpc3BsYXkgc2hh cmVkRUdMRGlzcGxheSgpCiAgICAgaWYgKCFpbml0aWFsaXplZCkgewogICAgICAgICBpbml0aWFs aXplZCA9IHRydWU7CiAKLSAgICAgICAgY29uc3QgYXV0byYgc2hhcmVkRGlzcGxheSA9IFBsYXRm b3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgpOwogI2lmIFBMQVRGT1JNKFdBWUxBTkQpCi0gICAg ICAgIGlmIChpczxQbGF0Zm9ybURpc3BsYXlXYXlsYW5kPihzaGFyZWREaXNwbGF5KSkKLSAgICAg ICAgICAgIGdTaGFyZWRFR0xEaXNwbGF5ID0gZWdsR2V0RGlzcGxheShkb3duY2FzdDxQbGF0Zm9y bURpc3BsYXlXYXlsYW5kPihzaGFyZWREaXNwbGF5KS5uYXRpdmUoKSk7CisgICAgICAgIGlmIChp czxQbGF0Zm9ybURpc3BsYXlXYXlsYW5kPihQbGF0Zm9ybURpc3BsYXk6OnNoYXJlZERpc3BsYXko KSkpCisgICAgICAgICAgICBnU2hhcmVkRUdMRGlzcGxheSA9IGVnbEdldERpc3BsYXkoZG93bmNh c3Q8UGxhdGZvcm1EaXNwbGF5V2F5bGFuZD4oUGxhdGZvcm1EaXNwbGF5OjpzaGFyZWREaXNwbGF5 KCkpLm5hdGl2ZSgpKTsKICAgICAgICAgZWxzZSAvLyBOb3RlIHRoYXQgdGhpcyBicmFuY2ggY29u dGludXRlcyBvdXRzaWRlIHRoaXMgI2lmLWd1YXJkZWQgc2VnbWVudC4KICNlbmRpZgogI2lmIFBM QVRGT1JNKFgxMSkKLSAgICAgICAgICAgIGdTaGFyZWRFR0xEaXNwbGF5ID0gZWdsR2V0RGlzcGxh eShkb3duY2FzdDxQbGF0Zm9ybURpc3BsYXlYMTE+KHNoYXJlZERpc3BsYXkpLm5hdGl2ZSgpKTsK KyAgICAgICAgICAgIGdTaGFyZWRFR0xEaXNwbGF5ID0gZWdsR2V0RGlzcGxheShkb3duY2FzdDxQ bGF0Zm9ybURpc3BsYXlYMTE+KFBsYXRmb3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgpKS5uYXRp dmUoKSk7CiAjZWxzZQogICAgICAgICAgICAgZ1NoYXJlZEVHTERpc3BsYXkgPSBlZ2xHZXREaXNw bGF5KEVHTF9ERUZBVUxUX0RJU1BMQVkpOwogI2VuZGlmCg==