144557 2015-05-03 16:50:49 -0700 [GTK] OSX linker doesn't understand --whole-archive 2016-01-14 23:21:55 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified OS X 10.10 RESOLVED FIXED P2 Major --- 126492 1 philip.chimento webkit-unassigned cgarcia commit-queue jeremyhu mrobinson pnormand oldest_to_newest 1091286 0 philip.chimento 2015-05-03 16:50:49 -0700 On OSX, the linker doesn't understand --whole-archive. This causes the build to fail due to ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES) in PlatformGTK.cmake. The corresponding option for the OSX linker is -all_load and -noall_load. 1093047 1 philip.chimento 2015-05-07 23:15:23 -0700 However, using -all_load or -force_load makes MiniBrowser hit an assertion failure on startup: ASSERTION FAILED: m_key != PTHREAD_KEYS_MAX /Users/fliep/gtk/source/webkitgtk-2.8.0/Source/WTF/wtf/ThreadIdentifierDataPthreads.cpp(65) : static ThreadIdentifier WTF::ThreadIdentifierData::identifier() 1 0x11509d1d0 2 0x1150fb11d 3 0x1150fc8cd 4 0x1150a8a06 5 0x112c8ab9e 6 0x112c3fc6e 7 0x112e53ecf 8 0x112e4c558 9 0x112e4c1fd 10 0x112e4c190 11 0x1131e38db 12 0x1131e3865 13 0x1131d97d5 14 0x11a29b452 15 0x11a27fa55 16 0x11a27edce 17 0x11a27ea08 18 0x1131d981b 19 0x10dcc5a03 20 0x10dcbc694 Segmentation fault: 11 Simply leaving off the option seems to work fine. I'll upload a patch to that effect. 1093048 2 252688 philip.chimento 2015-05-07 23:20:04 -0700 Created attachment 252688 Patch 1132317 3 pnormand 2015-10-12 09:12:08 -0700 I'm not sure about this patch. What do you think Martin, Carlos? 1132319 4 252688 mrobinson 2015-10-12 09:21:06 -0700 Comment on attachment 252688 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252688&action=review Seems sensible to me, but this patch needs a bit of work. Thanks! > Source/WebKit2/PlatformGTK.cmake:549 > -ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES) > +if (CMAKE_SYSTEM_NAME MATCHES "Linux") > + ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES) > +endif () It would be better to add this check to the ADD_WHOLE_ARCHIVE_TO_LIBRARIES macro instead of requiring it for every invocation. > Source/WebKit2/PlatformGTK.cmake:875 > - COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS= > + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=-lGObjectDOMBindings This looks unrelated. > Source/WebKit2/PlatformGTK.cmake:890 > + --library=c++ Ditto. 1132447 5 philip.chimento 2015-10-12 12:48:22 -0700 (In reply to comment #4) > Comment on attachment 252688 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252688&action=review > > Seems sensible to me, but this patch needs a bit of work. Thanks! > > > Source/WebKit2/PlatformGTK.cmake:549 > > -ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES) > > +if (CMAKE_SYSTEM_NAME MATCHES "Linux") > > + ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES) > > +endif () > > It would be better to add this check to the ADD_WHOLE_ARCHIVE_TO_LIBRARIES > macro instead of requiring it for every invocation. Sure. I'll also change it to NOT CMAKE_SYSTEM_MATCHES "Darwin" in order to be more specific like I did in #144555. > > Source/WebKit2/PlatformGTK.cmake:875 > > - COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS= > > + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=-lGObjectDOMBindings > > This looks unrelated. These are related though; it's what I was referring to with "link with extra libraries instead" in the patch's changelog. Without --whole-archive, these libraries don't get picked up for linking, so I have to add them manually. I wonder if it might make sense to get rid of the ADD_WHOLE_ARCHIVE_TO_LIBRARIES macro entirely, since all the necessary libraries are now added manually. Alternatively, I could bracket these manual additions inside CMAKE_SYSTEM_NAME checks. 1132454 6 252688 mrobinson 2015-10-12 13:16:04 -0700 Comment on attachment 252688 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252688&action=review >>> Source/WebKit2/PlatformGTK.cmake:875 >>> + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=-lGObjectDOMBindings >> >> This looks unrelated. > > These are related though; it's what I was referring to with "link with extra libraries instead" in the patch's changelog. Without --whole-archive, these libraries don't get picked up for linking, so I have to add them manually. > > I wonder if it might make sense to get rid of the ADD_WHOLE_ARCHIVE_TO_LIBRARIES macro entirely, since all the necessary libraries are now added manually. Alternatively, I could bracket these manual additions inside CMAKE_SYSTEM_NAME checks. If you can get WebKitGTK+ to compile properly on Linux and on the build bots without ADD_WHOLE_ARCHIVE_TO_LIBRARIES, feel free to remove it. >> Source/WebKit2/PlatformGTK.cmake:890 >> + --library=c++ > > Ditto. Hrm. Is c++ a system library or a special value understood by g-ir-scanner? If it's the latter, is it documented somewhere? 1132505 7 philip.chimento 2015-10-12 15:14:34 -0700 (In reply to comment #6) > >> Source/WebKit2/PlatformGTK.cmake:890 > >> + --library=c++ > > > > Ditto. > > Hrm. Is c++ a system library or a special value understood by g-ir-scanner? > If it's the latter, is it documented somewhere? libc++ is LLVM's version of libstdc++, so it's a system library. That makes me realize though, that I'd need to add libstdc++ on normal systems and libc++ on systems using XCode's linker. So I think removing ADD_WHOLE_ARCHIVE_TO_LIBRARIES is a non-starter; better to use --whole-archive when it's available. 1132514 8 262929 philip.chimento 2015-10-12 15:26:44 -0700 Created attachment 262929 Patch 1132515 9 philip.chimento 2015-10-12 15:27:34 -0700 Here's a new patch with the check inside the macro, as suggested, and everything inside CMAKE_SYSTEM_NAME checks. 1132520 10 262929 mrobinson 2015-10-12 15:31:56 -0700 Comment on attachment 262929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262929&action=review Looks good, but I want to suggest one small thing before committing the patch. > Source/WebKit2/PlatformGTK.cmake:929 > + set(DARWIN_ADDITIONAL_LIBRARIES --library=c++) > + set(DARWIN_ADDITIONAL_LDFLAGS -lGObjectDOMBindings) Do you mind renaming these to INTROSPECTION_ADDITIONAL_LIBRARIES and INTROSPECTION_ADDITIONAL_LDFLAGS to make it consistent with INTROSPECTION_ADDITIONAL_LIBRARY_PATH? 1132528 11 262930 philip.chimento 2015-10-12 15:37:16 -0700 Created attachment 262930 Patch 1132530 12 philip.chimento 2015-10-12 15:38:02 -0700 Sure thing, here it is. Thanks for the review. 1132599 13 262930 commit-queue 2015-10-12 17:38:23 -0700 Comment on attachment 262930 Patch Clearing flags on attachment: 262930 Committed r190909: <http://trac.webkit.org/changeset/190909> 1132600 14 commit-queue 2015-10-12 17:38:27 -0700 All reviewed patches have been landed. Closing bug. 1155707 15 jeremyhu 2016-01-14 23:21:55 -0800 This was fixed incorrectly. Following up in bug #153117 252688 2015-05-07 23:20:04 -0700 2015-10-12 15:26:40 -0700 Patch bug-144557-20150507231846.patch text/plain 2293 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTMzNjY1MTY2ZTM3MTJi OTA2ODNhYTQ2MWY0NGNlYWE1ODVhNWQzMy4uZTg1YjhmNWJlOWEzNDUzNGZlNTJhNzhlOGJiYTcx ZDhhMDFkZmUxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA1LTA3ICBQaGls aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIFtHVEtd IE9TWCBsaW5rZXIgZG9lc24ndCB1bmRlcnN0YW5kIC0td2hvbGUtYXJjaGl2ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NTU3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFr ZTogRG9uJ3QgdXNlIC0td2hvbGUtYXJjaGl2ZSBvbiBEYXJ3aW4sIHdob3NlCisgICAgICAgIGxp bmtlciBkb2Vzbid0IHVuZGVyc3RhbmQgaXQ7IGxpbmsgd2l0aCBleHRyYSBsaWJyYXJpZXMgaW5z dGVhZC4KKwogMjAxNS0wNS0wNyAgQ29ucmFkIFNodWx0eiAgPGNvbnJhZF9zaHVsdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIERvbid0IHJlZ2lzdGVyIGZvciBMb29rdXAgbm90aWZpY2F0aW9ucyB1 bnRpbCBuZWVkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtl IGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggOGJiYWE0ZTVkZGMzMWYw MTg2MWY4NzYwNWI4YzA1NmFlYTliODZlMy4uNmNhMTVkNDUwOGE1OGU2NmJiZmYxOWM4MGFlNzRj NzUyMTY0NjJhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UK KysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTU0NCw3ICs1NDQsOSBA QCBsaXN0KEFQUEVORCBXZWJLaXQyX0xJQlJBUklFUwogKQogZW5kaWYgKCkKIAotQUREX1dIT0xF X0FSQ0hJVkVfVE9fTElCUkFSSUVTKFdlYktpdDJfTElCUkFSSUVTKQoraWYgKENNQUtFX1NZU1RF TV9OQU1FIE1BVENIRVMgIkxpbnV4IikKKyAgICBBRERfV0hPTEVfQVJDSElWRV9UT19MSUJSQVJJ RVMoV2ViS2l0Ml9MSUJSQVJJRVMpCitlbmRpZiAoKQogCiBzZXQoV2ViS2l0Ml9NQVJTSEFMX0xJ U1QgJHtXRUJLSVQyX0RJUn0vVUlQcm9jZXNzL0FQSS9ndGsvd2Via2l0Mm1hcnNoYWwubGlzdCkK IGFkZF9jdXN0b21fY29tbWFuZCgKQEAgLTg3MCw3ICs4NzIsNyBAQCBhZGRfY3VzdG9tX2NvbW1h bmQoCiAgICAgT1VUUFVUICR7Q01BS0VfQklOQVJZX0RJUn0vV2ViS2l0MldlYkV4dGVuc2lvbi0k e1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2lyCiAgICAgREVQRU5EUyAke0NNQUtFX0JJTkFSWV9E SVJ9L0phdmFTY3JpcHRDb3JlLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXIKICAgICBERVBF TkRTICR7Q01BS0VfQklOQVJZX0RJUn0vV2ViS2l0Mi0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0u Z2lyCi0gICAgQ09NTUFORCBDQz0ke0NNQUtFX0NfQ09NUElMRVJ9IENGTEFHUz0tV25vLWRlcHJl Y2F0ZWQtZGVjbGFyYXRpb25zIExERkxBR1M9CisgICAgQ09NTUFORCBDQz0ke0NNQUtFX0NfQ09N UElMRVJ9IENGTEFHUz0tV25vLWRlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIExERkxBR1M9LWxHT2Jq ZWN0RE9NQmluZGluZ3MKICAgICAgICAgTERfTElCUkFSWV9QQVRIPSIke0lOVFJPU1BFQ1RJT05f QURESVRJT05BTF9MSUJSQVJZX1BBVEh9IgogICAgICAgICAke0lOVFJPU1BFQ1RJT05fU0NBTk5F Un0KICAgICAgICAgLS1xdWlldApAQCAtODg1LDYgKzg4Nyw3IEBAIGFkZF9jdXN0b21fY29tbWFu ZCgKICAgICAgICAgLS1pbmNsdWRlLXVuaW5zdGFsbGVkPSR7Q01BS0VfQklOQVJZX0RJUn0vSmF2 YVNjcmlwdENvcmUtJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgogICAgICAgICAtLWxpYnJh cnk9d2Via2l0Mmd0ay0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0KICAgICAgICAgLS1saWJyYXJ5 PWphdmFzY3JpcHRjb3JlZ3RrLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfQorICAgICAgICAtLWxp YnJhcnk9YysrCiAgICAgICAgIC1MJHtDTUFLRV9MSUJSQVJZX09VVFBVVF9ESVJFQ1RPUll9CiAg ICAgICAgICR7SU5UUk9TUEVDVElPTl9BRERJVElPTkFMX0xJTktFUl9GTEFHU30KICAgICAgICAg LS1uby1saWJ0b29sCg== 262929 2015-10-12 15:26:44 -0700 2015-10-12 15:37:11 -0700 Patch bug-144557-20151012152608.patch text/plain 4360 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTJjNTFiZmE3OTg5MzE3 ZDdhODQwYmFkMzU2YTI1MGQ3M2ZjNzBmZS4uYmJlOWZiOTc2YjczMjcwOTRmODYyMjA4YmM3MTc2 NzY1MDk2MGY5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEwLTEyICBQaGls aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIFtHVEtd IE9TWCBsaW5rZXIgZG9lc24ndCB1bmRlcnN0YW5kIC0td2hvbGUtYXJjaGl2ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NTU3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFr ZTogTGluayB3aXRoIGV4dHJhIGxpYnJhcmllcyBvbiBEYXJ3aW4sIHNpbmNlCisgICAgICAgIHdl IGRvbid0IGhhdmUgdGhlIC0td2hvbGUtYXJjaGl2ZSBsaW5rZXIgb3B0aW9uLgorCiAyMDE1LTEw LTA5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRG9u J3QgYWxsb3cgcGx1Zy1pbnMgdG8gb3ZlcnJpZGUgaW1hZ2UgdHlwZXMgZm9yIDxlbWJlZD4gZWxl bWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291 cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNGMyYjFkODhkY2FiNWQ3OTI1MzYw NTFlYmYwMTJlMDk0NTBhZGJlYi4uNmUwNmM5NGJhYzE3YjU2N2MxYTU3ZWE1NDA3MDAyMmM0MjZl YTgzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIv U291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTkyMywxMSArOTIzLDE4IEBAIGFk ZF9jdXN0b21fY29tbWFuZCgKICAgICAgICAgJHtXRUJLSVQyX0RJUn0vVUlQcm9jZXNzL0FQSS9n dGsvKi5jcHAKICkKIAorIyBNYW51YWxseSBhZGQgc29tZSBsaWJyYXJpZXMgb24gT1NYIGJlY2F1 c2Ugd2UgZG9uJ3QgaGF2ZSB0aGUgLS13aG9sZS1hcmNoaXZlIGZsYWcKK2lmIChDTUFLRV9TWVNU RU1fTkFNRSBNQVRDSEVTICJEYXJ3aW4iKQorICAgIHNldChEQVJXSU5fQURESVRJT05BTF9MSUJS QVJJRVMgLS1saWJyYXJ5PWMrKykKKyAgICBzZXQoREFSV0lOX0FERElUSU9OQUxfTERGTEFHUyAt bEdPYmplY3RET01CaW5kaW5ncykKK2VuZGlmICgpCisKIGFkZF9jdXN0b21fY29tbWFuZCgKICAg ICBPVVRQVVQgJHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQyV2ViRXh0ZW5zaW9uLSR7V0VCS0lU R1RLX0FQSV9WRVJTSU9OfS5naXIKICAgICBERVBFTkRTICR7Q01BS0VfQklOQVJZX0RJUn0vSmF2 YVNjcmlwdENvcmUtJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgogICAgIERFUEVORFMgJHtD TUFLRV9CSU5BUllfRElSfS9XZWJLaXQyLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXIKLSAg ICBDT01NQU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPS1Xbm8tZGVwcmVjYXRlZC1k ZWNsYXJhdGlvbnMgTERGTEFHUz0KKyAgICBDT01NQU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0g Q0ZMQUdTPS1Xbm8tZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMKKyAgICAgICAgTERGTEFHUz0iJHtE QVJXSU5fQURESVRJT05BTF9MREZMQUdTfSIKICAgICAgICAgTERfTElCUkFSWV9QQVRIPSIke0lO VFJPU1BFQ1RJT05fQURESVRJT05BTF9MSUJSQVJZX1BBVEh9IgogICAgICAgICAke0lOVFJPU1BF Q1RJT05fU0NBTk5FUn0KICAgICAgICAgLS1xdWlldApAQCAtOTQyLDYgKzk0OSw3IEBAIGFkZF9j dXN0b21fY29tbWFuZCgKICAgICAgICAgLS1pbmNsdWRlLXVuaW5zdGFsbGVkPSR7Q01BS0VfQklO QVJZX0RJUn0vSmF2YVNjcmlwdENvcmUtJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgogICAg ICAgICAtLWxpYnJhcnk9d2Via2l0Mmd0ay0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0KICAgICAg ICAgLS1saWJyYXJ5PWphdmFzY3JpcHRjb3JlZ3RrLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfQor ICAgICAgICAke0RBUldJTl9BRERJVElPTkFMX0xJQlJBUklFU30KICAgICAgICAgLUwke0NNQUtF X0xJQlJBUllfT1VUUFVUX0RJUkVDVE9SWX0KICAgICAgICAgJHtJTlRST1NQRUNUSU9OX0FERElU SU9OQUxfTElOS0VSX0ZMQUdTfQogICAgICAgICAtLW5vLWxpYnRvb2wKZGlmZiAtLWdpdCBhL1Nv dXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2UKaW5kZXggMzJhYTYyZjlmZDZmYzMwYWFlODZmYmM0MjU5MjJkZmU3YTBlYjZjOS4uYmI4MWQz MjgxM2NlOTIyZjc1MDkyNTI3MDFjNThjNDNlZGY2NDRmMSAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UK QEAgLTQ3MSwxMiArNDcxLDE1IEBAIGVuZG1hY3JvKCkKICMgQ01ha2UgZG9lcyBub3QgYXV0b21h dGljYWxseSBhZGQgLS13aG9sZS1hcmNoaXZlIHdoZW4gYnVpbGRpbmcgc2hhcmVkIG9iamVjdHMg ZnJvbQogIyBhIGxpc3Qgb2YgY29udmVuaWVuY2UgbGlicmFyaWVzLiBUaGlzIGNhbiBsZWFkIHRv IG1pc3Npbmcgc3ltYm9scyBpbiB0aGUgZmluYWwgb3V0cHV0LgogIyBXZSBhZGQgLS13aG9sZS1h cmNoaXZlIHRvIGFsbCBsaWJyYXJpZXMgbWFudWFsbHkgdG8gcHJldmVudCB0aGUgbGlua2VyIGZy b20gdHJpbW1pbmcKLSMgc3ltYm9scyB0aGF0IHdlIGFjdHVhbGx5IG5lZWQgbGF0ZXIuCisjIHN5 bWJvbHMgdGhhdCB3ZSBhY3R1YWxseSBuZWVkIGxhdGVyLiAoLS13aG9sZS1hcmNoaXZlIGlzbid0 IGFuIG9wdGlvbiBvbiBYQ29kZSdzCisjIGxpbmtlciwgdGhvdWdoLikKIG1hY3JvKEFERF9XSE9M RV9BUkNISVZFX1RPX0xJQlJBUklFUyBfbGlzdF9uYW1lKQotICAgIGZvcmVhY2ggKGxpYnJhcnkg SU4gTElTVFMgJHtfbGlzdF9uYW1lfSkKLSAgICAgIGxpc3QoQVBQRU5EICR7X2xpc3RfbmFtZX1f VE1QIC1XbCwtLXdob2xlLWFyY2hpdmUgJHtsaWJyYXJ5fSAtV2wsLS1uby13aG9sZS1hcmNoaXZl KQotICAgIGVuZGZvcmVhY2ggKCkKLSAgICBzZXQoJHtfbGlzdF9uYW1lfSAiJHske19saXN0X25h bWV9X1RNUH0iKQorICAgIGlmIChOT1QgQ01BS0VfU1lTVEVNX05BTUUgTUFUQ0hFUyAiRGFyd2lu IikKKyAgICAgICAgZm9yZWFjaCAobGlicmFyeSBJTiBMSVNUUyAke19saXN0X25hbWV9KQorICAg ICAgICAgIGxpc3QoQVBQRU5EICR7X2xpc3RfbmFtZX1fVE1QIC1XbCwtLXdob2xlLWFyY2hpdmUg JHtsaWJyYXJ5fSAtV2wsLS1uby13aG9sZS1hcmNoaXZlKQorICAgICAgICBlbmRmb3JlYWNoICgp CisgICAgICAgIHNldCgke19saXN0X25hbWV9ICIkeyR7X2xpc3RfbmFtZX1fVE1QfSIpCisgICAg ZW5kaWYgKCkKIGVuZG1hY3JvKCkKIAogaWYgKENNQUtFX01BSk9SX1ZFUlNJT04gTEVTUyAzKQpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDgzZGQ0ODQzZWJlNTliNjlj OWFhNDNmYWRiMTQ3MjYxYzZkNjBjM2EuLjJkMWQxZDU3YWQ1MDA0N2RjOTJlN2FiYjA3MjM0YzE1 YTNkMjlkZjkgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsNSAr MSwxNiBAQAogMjAxNS0xMC0xMiAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRvQGdt YWlsLmNvbT4KIAorICAgICAgICBbR1RLXSBPU1ggbGlua2VyIGRvZXNuJ3QgdW5kZXJzdGFuZCAt LXdob2xlLWFyY2hpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDU1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IFR1cm4gdGhlIG1hY3JvCisg ICAgICAgIEFERF9XSE9MRV9BUkNISVZFX1RPX0xJQlJBUklFUyBpbnRvIGEgbm8tb3Agb24gRGFy d2luIHN5c3RlbXMsCisgICAgICAgIGJlY2F1c2UgWENvZGUncyBsaW5rZXIgZG9lc24ndCBoYXZl IHRoZSAtLXdob2xlLWFyY2hpdmUgb3B0aW9uLgorCisyMDE1LTEwLTEyICBQaGlsaXAgQ2hpbWVu dG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCiAgICAgICAgIFtHVEtdIFVzZSAtLXZl cnNpb24tc2NyaXB0IG9ubHkgb24gTGludXgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NDU1NQogCg== 262930 2015-10-12 15:37:16 -0700 2015-10-12 17:38:23 -0700 Patch bug-144557-20151012153640.patch text/plain 4388 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTJjNTFiZmE3OTg5MzE3 ZDdhODQwYmFkMzU2YTI1MGQ3M2ZjNzBmZS4uYmJlOWZiOTc2YjczMjcwOTRmODYyMjA4YmM3MTc2 NzY1MDk2MGY5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEwLTEyICBQaGls aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIFtHVEtd IE9TWCBsaW5rZXIgZG9lc24ndCB1bmRlcnN0YW5kIC0td2hvbGUtYXJjaGl2ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NTU3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFr ZTogTGluayB3aXRoIGV4dHJhIGxpYnJhcmllcyBvbiBEYXJ3aW4sIHNpbmNlCisgICAgICAgIHdl IGRvbid0IGhhdmUgdGhlIC0td2hvbGUtYXJjaGl2ZSBsaW5rZXIgb3B0aW9uLgorCiAyMDE1LTEw LTA5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRG9u J3QgYWxsb3cgcGx1Zy1pbnMgdG8gb3ZlcnJpZGUgaW1hZ2UgdHlwZXMgZm9yIDxlbWJlZD4gZWxl bWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291 cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNGMyYjFkODhkY2FiNWQ3OTI1MzYw NTFlYmYwMTJlMDk0NTBhZGJlYi4uNDhmMDBhZDFjNjE3OThlMjhlNGYwNzA0NGU1ZWJjNmFhOTNh NmEzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIv U291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTkyMywxMSArOTIzLDE4IEBAIGFk ZF9jdXN0b21fY29tbWFuZCgKICAgICAgICAgJHtXRUJLSVQyX0RJUn0vVUlQcm9jZXNzL0FQSS9n dGsvKi5jcHAKICkKIAorIyBNYW51YWxseSBhZGQgc29tZSBsaWJyYXJpZXMgb24gT1NYIGJlY2F1 c2Ugd2UgZG9uJ3QgaGF2ZSB0aGUgLS13aG9sZS1hcmNoaXZlIGZsYWcKK2lmIChDTUFLRV9TWVNU RU1fTkFNRSBNQVRDSEVTICJEYXJ3aW4iKQorICAgIHNldChJTlRST1NQRUNUSU9OX0FERElUSU9O QUxfTElCUkFSSUVTIC0tbGlicmFyeT1jKyspCisgICAgc2V0KElOVFJPU1BFQ1RJT05fQURESVRJ T05BTF9MREZMQUdTIC1sR09iamVjdERPTUJpbmRpbmdzKQorZW5kaWYgKCkKKwogYWRkX2N1c3Rv bV9jb21tYW5kKAogICAgIE9VVFBVVCAke0NNQUtFX0JJTkFSWV9ESVJ9L1dlYktpdDJXZWJFeHRl bnNpb24tJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgogICAgIERFUEVORFMgJHtDTUFLRV9C SU5BUllfRElSfS9KYXZhU2NyaXB0Q29yZS0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2lyCiAg ICAgREVQRU5EUyAke0NNQUtFX0JJTkFSWV9ESVJ9L1dlYktpdDItJHtXRUJLSVRHVEtfQVBJX1ZF UlNJT059LmdpcgotICAgIENPTU1BTkQgQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSBDRkxBR1M9LVdu by1kZXByZWNhdGVkLWRlY2xhcmF0aW9ucyBMREZMQUdTPQorICAgIENPTU1BTkQgQ0M9JHtDTUFL RV9DX0NPTVBJTEVSfSBDRkxBR1M9LVduby1kZXByZWNhdGVkLWRlY2xhcmF0aW9ucworICAgICAg ICBMREZMQUdTPSIke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9MREZMQUdTfSIKICAgICAgICAg TERfTElCUkFSWV9QQVRIPSIke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9MSUJSQVJZX1BBVEh9 IgogICAgICAgICAke0lOVFJPU1BFQ1RJT05fU0NBTk5FUn0KICAgICAgICAgLS1xdWlldApAQCAt OTQyLDYgKzk0OSw3IEBAIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICAgICAgLS1pbmNsdWRlLXVu aW5zdGFsbGVkPSR7Q01BS0VfQklOQVJZX0RJUn0vSmF2YVNjcmlwdENvcmUtJHtXRUJLSVRHVEtf QVBJX1ZFUlNJT059LmdpcgogICAgICAgICAtLWxpYnJhcnk9d2Via2l0Mmd0ay0ke1dFQktJVEdU S19BUElfVkVSU0lPTn0KICAgICAgICAgLS1saWJyYXJ5PWphdmFzY3JpcHRjb3JlZ3RrLSR7V0VC S0lUR1RLX0FQSV9WRVJTSU9OfQorICAgICAgICAke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9M SUJSQVJJRVN9CiAgICAgICAgIC1MJHtDTUFLRV9MSUJSQVJZX09VVFBVVF9ESVJFQ1RPUll9CiAg ICAgICAgICR7SU5UUk9TUEVDVElPTl9BRERJVElPTkFMX0xJTktFUl9GTEFHU30KICAgICAgICAg LS1uby1saWJ0b29sCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBi L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDMyYWE2MmY5ZmQ2ZmMzMGFhZTg2 ZmJjNDI1OTIyZGZlN2EwZWI2YzkuLmJiODFkMzI4MTNjZTkyMmY3NTA5MjUyNzAxYzU4YzQzZWRm NjQ0ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1Nv dXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC00NzEsMTIgKzQ3MSwxNSBAQCBlbmRtYWNy bygpCiAjIENNYWtlIGRvZXMgbm90IGF1dG9tYXRpY2FsbHkgYWRkIC0td2hvbGUtYXJjaGl2ZSB3 aGVuIGJ1aWxkaW5nIHNoYXJlZCBvYmplY3RzIGZyb20KICMgYSBsaXN0IG9mIGNvbnZlbmllbmNl IGxpYnJhcmllcy4gVGhpcyBjYW4gbGVhZCB0byBtaXNzaW5nIHN5bWJvbHMgaW4gdGhlIGZpbmFs IG91dHB1dC4KICMgV2UgYWRkIC0td2hvbGUtYXJjaGl2ZSB0byBhbGwgbGlicmFyaWVzIG1hbnVh bGx5IHRvIHByZXZlbnQgdGhlIGxpbmtlciBmcm9tIHRyaW1taW5nCi0jIHN5bWJvbHMgdGhhdCB3 ZSBhY3R1YWxseSBuZWVkIGxhdGVyLgorIyBzeW1ib2xzIHRoYXQgd2UgYWN0dWFsbHkgbmVlZCBs YXRlci4gKC0td2hvbGUtYXJjaGl2ZSBpc24ndCBhbiBvcHRpb24gb24gWENvZGUncworIyBsaW5r ZXIsIHRob3VnaC4pCiBtYWNybyhBRERfV0hPTEVfQVJDSElWRV9UT19MSUJSQVJJRVMgX2xpc3Rf bmFtZSkKLSAgICBmb3JlYWNoIChsaWJyYXJ5IElOIExJU1RTICR7X2xpc3RfbmFtZX0pCi0gICAg ICBsaXN0KEFQUEVORCAke19saXN0X25hbWV9X1RNUCAtV2wsLS13aG9sZS1hcmNoaXZlICR7bGli cmFyeX0gLVdsLC0tbm8td2hvbGUtYXJjaGl2ZSkKLSAgICBlbmRmb3JlYWNoICgpCi0gICAgc2V0 KCR7X2xpc3RfbmFtZX0gIiR7JHtfbGlzdF9uYW1lfV9UTVB9IikKKyAgICBpZiAoTk9UIENNQUtF X1NZU1RFTV9OQU1FIE1BVENIRVMgIkRhcndpbiIpCisgICAgICAgIGZvcmVhY2ggKGxpYnJhcnkg SU4gTElTVFMgJHtfbGlzdF9uYW1lfSkKKyAgICAgICAgICBsaXN0KEFQUEVORCAke19saXN0X25h bWV9X1RNUCAtV2wsLS13aG9sZS1hcmNoaXZlICR7bGlicmFyeX0gLVdsLC0tbm8td2hvbGUtYXJj aGl2ZSkKKyAgICAgICAgZW5kZm9yZWFjaCAoKQorICAgICAgICBzZXQoJHtfbGlzdF9uYW1lfSAi JHske19saXN0X25hbWV9X1RNUH0iKQorICAgIGVuZGlmICgpCiBlbmRtYWNybygpCiAKIGlmIChD TUFLRV9NQUpPUl9WRVJTSU9OIExFU1MgMykKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCA4M2RkNDg0M2ViZTU5YjY5YzlhYTQzZmFkYjE0NzI2MWM2ZDYwYzNhLi4yZDFk MWQ1N2FkNTAwNDdkYzkyZTdhYmIwNzIzNGMxNWEzZDI5ZGY5IDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTUtMTAtMTIgIFBoaWxpcCBD aGltZW50byAgPHBoaWxpcC5jaGltZW50b0BnbWFpbC5jb20+CiAKKyAgICAgICAgW0dUS10gT1NY IGxpbmtlciBkb2Vzbid0IHVuZGVyc3RhbmQgLS13aG9sZS1hcmNoaXZlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ1NTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25z R1RLLmNtYWtlOiBUdXJuIHRoZSBtYWNybworICAgICAgICBBRERfV0hPTEVfQVJDSElWRV9UT19M SUJSQVJJRVMgaW50byBhIG5vLW9wIG9uIERhcndpbiBzeXN0ZW1zLAorICAgICAgICBiZWNhdXNl IFhDb2RlJ3MgbGlua2VyIGRvZXNuJ3QgaGF2ZSB0aGUgLS13aG9sZS1hcmNoaXZlIG9wdGlvbi4K KworMjAxNS0xMC0xMiAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRvQGdtYWlsLmNv bT4KKwogICAgICAgICBbR1RLXSBVc2UgLS12ZXJzaW9uLXNjcmlwdCBvbmx5IG9uIExpbnV4CiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ1NTUKIAo=