144555 2015-05-03 15:58:10 -0700 [GTK] Don't use --version-script on Darwin 2015-10-12 10:01:52 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified OS X 10.10 RESOLVED FIXED P2 Major --- 126492 1 philip.chimento webkit-unassigned cgarcia commit-queue mrobinson ossy oldest_to_newest 1091276 0 philip.chimento 2015-05-03 15:58:10 -0700 --version-script isn't supported by the OSX linker. The build fails with this error: Linking CXX shared library ../../lib/libwebkit2gtk-4.0.dylib ld: unknown option: --version-script clang: error: linker command failed with exit code 1 (use -v to see invocation) 1091277 1 252289 philip.chimento 2015-05-03 15:59:06 -0700 Created attachment 252289 Patch This adds the --version-script option only on Linux. 1091278 2 commit-queue 2015-05-03 16:01:59 -0700 Attachment 252289 did not pass style-queue: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 1091704 3 cgarcia 2015-05-04 23:03:49 -0700 What about other unix os like FreeBSD, is --version-script linux specific? 1093041 4 philip.chimento 2015-05-07 23:02:08 -0700 --version-script is supported by GNU LD and the Solaris linker, according to https://www.gnu.org/software/gnulib/manual/html_node/LD-Version-Scripts.html 1093043 5 252687 philip.chimento 2015-05-07 23:09:02 -0700 Created attachment 252687 Patch 1093044 6 philip.chimento 2015-05-07 23:10:10 -0700 Above is a patch which turns it around; only omits the option on Darwin. 1093051 7 mrobinson 2015-05-07 23:27:43 -0700 Is it possible to collect all of the OS X specific changes in a branch and them merge them when everything is functional? 1093060 8 philip.chimento 2015-05-07 23:37:40 -0700 I assume I don't have privileges to create/commit to a branch in the WebKit repository. Is that correct? Is a GitHub branch OK? If you want to see the patches all together, they're here in a jhbuild module in this work-in-progress commit: https://github.com/ptomato/gtk-osx-build/commit/0a09d53e4d9bf7ae49b19f9e2adea9da9fdf8472 This _should_ yield a working version of WebKitGTK 2.8.0 on OSX. 1105230 9 philip.chimento 2015-06-27 16:13:50 -0700 As discussed on #126492, there's also https://github.com/ptomato/webkit/pull/2 1132318 10 252687 mrobinson 2015-10-12 09:17:40 -0700 Comment on attachment 252687 Patch This patch seems okay, but the commit message is a bit inaccurate. !Darwin doesn't necessary imply Linux. 1132332 11 252687 commit-queue 2015-10-12 10:01:44 -0700 Comment on attachment 252687 Patch Clearing flags on attachment: 252687 Committed r190856: <http://trac.webkit.org/changeset/190856> 1132333 12 commit-queue 2015-10-12 10:01:52 -0700 All reviewed patches have been landed. Closing bug. 252289 2015-05-03 15:59:06 -0700 2015-05-07 23:08:57 -0700 Patch webkit-144555-disable-version-script.patch text/plain 562 philip.chimento LS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UJMjAxNS0wMS0wMSAwMjozNTo0Ni4w MDAwMDAwMDAgLTA3MDAKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UJMjAxNS0w MS0wMSAwMjozNjowNC4wMDAwMDAwMDAgLTA3MDAKQEAgLTk0LDcgKzk0LDkgQEAKIGVsc2UgKCkK ICAgICBzZXQoRU5BQkxFX1RPT0xTIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9S VF9WQUxVRShFTkFCTEVfQVBJX1RFU1RTIE9GRikKLSAgICBzZXQoV2ViS2l0Ml9WRVJTSU9OX1ND UklQVCAiLVdsLC0tdmVyc2lvbi1zY3JpcHQsJHtDTUFLRV9NT0RVTEVfUEFUSH0vZ3Rrc3ltYm9s cy5maWx0ZXIiKQorICAgIGlmIChDTUFLRV9TWVNURU1fTkFNRSBNQVRDSEVTICJMaW51eCIpCisg ICAgICAgIHNldChXZWJLaXQyX1ZFUlNJT05fU0NSSVBUICItV2wsLS12ZXJzaW9uLXNjcmlwdCwk e0NNQUtFX01PRFVMRV9QQVRIfS9ndGtzeW1ib2xzLmZpbHRlciIpCisgICAgZW5kaWYgKCkKIGVu ZGlmICgpCiAKIGlmIChDTUFLRV9TWVNURU1fTkFNRSBNQVRDSEVTICJMaW51eCIpCg== 252687 2015-05-07 23:09:02 -0700 2015-10-12 10:01:44 -0700 Patch bug-144555-20150507230745.patch text/plain 1370 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDI1MDhm Njg3ZjRhNDc4OWJjZTc2YWJiZGI3Y2FhMDVjZTcyNDNhZWQuLjE2ZWJmYzBkYzY4OTFkZGUxNTUw MDNlOTBkZmZjYzllZTRlY2VhMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC04Miw3ICs4Miw5 IEBAIGlmIChERVZFTE9QRVJfTU9ERSkKIGVsc2UgKCkKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFV TFRfUE9SVF9WQUxVRShFTkFCTEVfTUlOSUJST1dTRVIgUFVCTElDIE9GRikKICAgICBXRUJLSVRf T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQVBJX1RFU1RTIFBSSVZBVEUgT0ZGKQot ICAgIHNldChXZWJLaXQyX1ZFUlNJT05fU0NSSVBUICItV2wsLS12ZXJzaW9uLXNjcmlwdCwke0NN QUtFX01PRFVMRV9QQVRIfS9ndGtzeW1ib2xzLmZpbHRlciIpCisgICAgaWYgKE5PVCBDTUFLRV9T WVNURU1fTkFNRSBNQVRDSEVTICJEYXJ3aW4iKQorICAgICAgICBzZXQoV2ViS2l0Ml9WRVJTSU9O X1NDUklQVCAiLVdsLC0tdmVyc2lvbi1zY3JpcHQsJHtDTUFLRV9NT0RVTEVfUEFUSH0vZ3Rrc3lt Ym9scy5maWx0ZXIiKQorICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCiBpZiAoQ01BS0VfU1lTVEVN X05BTUUgTUFUQ0hFUyAiTGludXgiKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9n CmluZGV4IDM0YWU1MTMxMTE4MTkwZDBkYzRiOTk2ZTMyNDMxNTAyZDM5MDBjZjMuLjAyYjQ3MTRh YzQ5NGQ4NGQxMmVlMTM1MDA5N2U0ODAwMjMyNDU1NmYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZwor KysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNS0wNS0wNyAgUGhpbGlwIENoaW1l bnRvICA8cGhpbGlwLmNoaW1lbnRvQGdtYWlsLmNvbT4KKworICAgICAgICBbR1RLXSBVc2UgLS12 ZXJzaW9uLXNjcmlwdCBvbmx5IG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ1NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBEb24n dCBhZGQgLS12ZXJzaW9uLXNjcmlwdAorICAgICAgICBvcHRpb24gb24gRGFyd2luICh3aG9zZSBs aW5rZXIgZG9lc24ndCBzdXBwb3J0IGl0LikKKwogMjAxNS0wNS0wNyAgTXlsZXMgQy4gTWF4Zmll bGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFudXAgYWZ0ZXIgcjE4Mzk0 MAo=