144554 2015-05-03 15:39:32 -0700 [GTK][SOUP] Web and Network processes don't know how to get memory size on OSX 2015-05-10 20:10:41 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified OS X 10.10 RESOLVED FIXED P2 Blocker --- 126492 1 philip.chimento webkit-unassigned commit-queue darin dbates koivisto mrobinson ossy oldest_to_newest 1091269 0 philip.chimento 2015-05-03 15:39:32 -0700 The Soup backend has apparently never been compiled on OSX before, so it needs Darwin-specific code. Although perhaps given #144081's recent landing, WebProcesSoup and NetworkProcessSoup should be ported to use WTF::ramSize? 1091270 1 252287 philip.chimento 2015-05-03 15:42:04 -0700 Created attachment 252287 Patch for 2.6.x This patch applies to 2.6.x, which doesn't have WTF::ramSize yet. 1091272 2 commit-queue 2015-05-03 15:45:17 -0700 Attachment 252287 did not pass style-queue: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 1091381 3 ossy 2015-05-04 08:28:14 -0700 changelog please 1091566 4 darin 2015-05-04 15:54:54 -0700 Should use a shared function, not local copies in two different source files of a function that definitely exists somewhere else in WebKit. 1093037 5 252686 philip.chimento 2015-05-07 22:48:12 -0700 Created attachment 252686 Patch 1093038 6 philip.chimento 2015-05-07 22:48:43 -0700 Added changelog. 1093645 7 252686 commit-queue 2015-05-10 20:10:36 -0700 Comment on attachment 252686 Patch Clearing flags on attachment: 252686 Committed r184064: <http://trac.webkit.org/changeset/184064> 1093646 8 commit-queue 2015-05-10 20:10:41 -0700 All reviewed patches have been landed. Closing bug. 252287 2015-05-03 15:42:04 -0700 2015-05-07 22:48:06 -0700 Patch for 2.6.x webkit-144554-darwin-physical-memory-size.patch text/plain 1759 philip.chimento LS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1Nv dXAuY3BwCTIwMTUtMDEtMDEgMDA6NTg6MjkuMDAwMDAwMDAwIC0wNzAwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAkyMDE1LTAx LTAxIDAxOjM2OjU0LjAwMDAwMDAwMCAtMDcwMApAQCAtNDAsNiArNDAsMTAgQEAKICNpbmNsdWRl IDx3dGYvZ29iamVjdC9HUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR1VuaXF1ZVB0 ci5oPgogCisjaWYgT1MoREFSV0lOKQorI2luY2x1ZGUgPHN5cy9zeXNjdGwuaD4KKyNlbmRpZgor CiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CkBAIC01OSw3 ICs2MywxNCBAQAogc3RhdGljIHVpbnQ2NF90IGdldE1lbW9yeVNpemUoKQogewogICAgIHN0YXRp YyB1aW50NjRfdCBrRGVmYXVsdE1lbW9yeVNpemUgPSA1MTI7Ci0jaWYgIU9TKFdJTkRPV1MpCisj aWYgT1MoREFSV0lOKQorICAgIGludDY0X3QgbWVtU2l6ZTsKKyAgICBzaXplX3QgbGVuID0gc2l6 ZW9mKG1lbVNpemUpOworICAgIGludCBzdWNjZXNzID0gc3lzY3RsYnluYW1lKCJody5tZW1zaXpl IiwgJm1lbVNpemUsICZsZW4sIE5VTEwsIDApOworICAgIGlmIChzdWNjZXNzID09IC0xKQorICAg ICAgICByZXR1cm4ga0RlZmF1bHRNZW1vcnlTaXplOworICAgIHJldHVybiBtZW1TaXplIC8gMTAy NDsKKyNlbGlmICFPUyhXSU5ET1dTKQogICAgIGxvbmcgcGFnZVNpemUgPSBzeXNjb25mKF9TQ19Q QUdFU0laRSk7CiAgICAgaWYgKHBhZ2VTaXplID09IC0xKQogICAgICAgICByZXR1cm4ga0RlZmF1 bHRNZW1vcnlTaXplOwotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViUHJv Y2Vzc1NvdXAuY3BwCTIwMTUtMDEtMDEgMDI6MjY6NDAuMDAwMDAwMDAwIC0wNzAwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHAJMjAxNS0wMS0w MSAwMjoyNzozMC4wMDAwMDAwMDAgLTA3MDAKQEAgLTMxLDYgKzMxLDEwIEBACiAjaW5jbHVkZSAi U2VjY29tcEZpbHRlcnNXZWJQcm9jZXNzRWZsLmgiCiAjZW5kaWYKIAorI2lmIE9TKERBUldJTikK KyNpbmNsdWRlIDxzeXMvc3lzY3RsLmg+CisjZW5kaWYKKwogI2luY2x1ZGUgIkNlcnRpZmljYXRl SW5mby5oIgogI2luY2x1ZGUgIldlYkNvb2tpZU1hbmFnZXIuaCIKICNpbmNsdWRlICJXZWJQcm9j ZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgiCkBAIC02NSw3ICs2OSwxNCBAQAogc3RhdGljIHVpbnQ2 NF90IGdldE1lbW9yeVNpemUoKQogewogICAgIHN0YXRpYyB1aW50NjRfdCBrRGVmYXVsdE1lbW9y eVNpemUgPSA1MTI7Ci0jaWYgIU9TKFdJTkRPV1MpCisjaWYgT1MoREFSV0lOKQorICAgIGludDY0 X3QgbWVtU2l6ZTsKKyAgICBzaXplX3QgbGVuID0gc2l6ZW9mKG1lbVNpemUpOworICAgIGludCBz dWNjZXNzID0gc3lzY3RsYnluYW1lKCJody5tZW1zaXplIiwgJm1lbVNpemUsICZsZW4sIE5VTEws IDApOworICAgIGlmIChzdWNjZXNzID09IC0xKQorICAgICAgICByZXR1cm4ga0RlZmF1bHRNZW1v cnlTaXplOworICAgIHJldHVybiBtZW1TaXplIC8gMTAyNExMOworI2VsaWYgIU9TKFdJTkRPV1Mp CiAgICAgbG9uZyBwYWdlU2l6ZSA9IHN5c2NvbmYoX1NDX1BBR0VTSVpFKTsKICAgICBpZiAocGFn ZVNpemUgPT0gLTEpCiAgICAgICAgIHJldHVybiBrRGVmYXVsdE1lbW9yeVNpemU7Cg== 252686 2015-05-07 22:48:12 -0700 2015-05-10 20:10:36 -0700 Patch bug-144554-20150507224654.patch text/plain 5027 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTMzNjY1MTY2ZTM3MTJi OTA2ODNhYTQ2MWY0NGNlYWE1ODVhNWQzMy4uODFlMzI0ZjZjOTEzNDE2YjNkNDJlNzczZjhlMGIy MjNlNjc4NGUzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA1LTA3ICBQaGls aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIFtHVEtd W1NPVVBdIFdlYiBhbmQgTmV0d29yayBwcm9jZXNzZXMgZG9uJ3Qga25vdyBob3cgdG8gZ2V0IG1l bW9yeSBzaXplIG9uIE9TWAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ0NTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybVNldENhY2hlTW9kZWwpOiBV c2UgV1RGOjpyYW1TaXplKCkKKyAgICAgICAgaW5zdGVhZCBvZiBsb2NhbCBmdW5jdGlvbi4gQWxz byB1c2UgV1RGOjpNQiBpbnN0ZWFkIG9mIGRpdmlkaW5nIGJ5CisgICAgICAgIDEwMjQgKiAxMDI0 LgorICAgICAgICAoV2ViS2l0OjpnZXRNZW1vcnlTaXplKTogRGVsZXRlZC4KKyAgICAgICAgKiBX ZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQ cm9jZXNzOjpwbGF0Zm9ybVNldENhY2hlTW9kZWwpOiBEaXR0by4KKyAgICAgICAgKFdlYktpdDo6 Z2V0TWVtb3J5U2l6ZSk6IERlbGV0ZWQuCisKIDIwMTUtMDUtMDcgIENvbnJhZCBTaHVsdHogIDxj b25yYWRfc2h1bHR6QGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCByZWdpc3RlciBmb3IgTG9v a3VwIG5vdGlmaWNhdGlvbnMgdW50aWwgbmVlZGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAKaW5kZXggM2I3 ODU5NDcyZjc5NmQzYmI4MmZiNjQ4YmMwMDlmNjAzNTBjN2Y4YS4uMjQ1ZTk1MTZlOWJlMzQ2MWU4 ODM2NzNlNmFkOTU0NjcwNDFhYzJmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcApAQCAtMzgsNiArMzgs NyBAQAogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VIYW5kbGUuaD4KICNpbmNsdWRlIDxXZWJD b3JlL1NvdXBOZXR3b3JrU2Vzc2lvbi5oPgogI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgorI2lu Y2x1ZGUgPHd0Zi9SQU1TaXplLmg+CiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR1JlZlB0ci5oPgog I2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dVbmlxdWVQdHIuaD4KIApAQCAtNTksMjAgKzYwLDYgQEAg c3RhdGljIHVpbnQ2NF90IGdldENhY2hlRGlza0ZyZWVTaXplKFNvdXBDYWNoZSogY2FjaGUpCiB9 CiAjZW5kaWYKIAotc3RhdGljIHVpbnQ2NF90IGdldE1lbW9yeVNpemUoKQotewotICAgIHN0YXRp YyB1aW50NjRfdCBrRGVmYXVsdE1lbW9yeVNpemUgPSA1MTI7Ci0gICAgbG9uZyBwYWdlU2l6ZSA9 IHN5c2NvbmYoX1NDX1BBR0VTSVpFKTsKLSAgICBpZiAocGFnZVNpemUgPT0gLTEpCi0gICAgICAg IHJldHVybiBrRGVmYXVsdE1lbW9yeVNpemU7Ci0KLSAgICBsb25nIHBoeXNQYWdlcyA9IHN5c2Nv bmYoX1NDX1BIWVNfUEFHRVMpOwotICAgIGlmIChwaHlzUGFnZXMgPT0gLTEpCi0gICAgICAgIHJl dHVybiBrRGVmYXVsdE1lbW9yeVNpemU7Ci0KLSAgICByZXR1cm4gKChwYWdlU2l6ZSAvIDEwMjQp ICogcGh5c1BhZ2VzKSAvIDEwMjQ7Ci19Ci0KIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnVzZXJQcmVm ZXJyZWRMYW5ndWFnZXNDaGFuZ2VkKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBsYW5ndWFnZXMpCiB7 CiAgICAgU291cE5ldHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLnNldEFjY2VwdExhbmd1 YWdlcyhsYW5ndWFnZXMpOwpAQCAtMTI4LDEzICsxMTUsMTMgQEAgdm9pZCBOZXR3b3JrUHJvY2Vz czo6cGxhdGZvcm1TZXRDYWNoZU1vZGVsKENhY2hlTW9kZWwgY2FjaGVNb2RlbCkKICAgICB1bnNp Z25lZCBsb25nIHVybENhY2hlRGlza0NhcGFjaXR5ID0gMDsKIAogI2lmIEVOQUJMRShORVRXT1JL X0NBQ0hFKQotICAgIHVpbnQ2NF90IGRpc2tGcmVlU2l6ZSA9IFdlYkNvcmU6OmdldFZvbHVtZUZy ZWVTaXplRm9yUGF0aChtX2Rpc2tDYWNoZURpcmVjdG9yeS51dGY4KCkuZGF0YSgpKSAvIDEwMjQg LyAxMDI0OworICAgIHVpbnQ2NF90IGRpc2tGcmVlU2l6ZSA9IFdlYkNvcmU6OmdldFZvbHVtZUZy ZWVTaXplRm9yUGF0aChtX2Rpc2tDYWNoZURpcmVjdG9yeS51dGY4KCkuZGF0YSgpKSAvIFdURjo6 TUI7CiAjZWxzZQogICAgIFNvdXBDYWNoZSogY2FjaGUgPSBTb3VwTmV0d29ya1Nlc3Npb246OmRl ZmF1bHRTZXNzaW9uKCkuY2FjaGUoKTsKLSAgICB1aW50NjRfdCBkaXNrRnJlZVNpemUgPSBnZXRD YWNoZURpc2tGcmVlU2l6ZShjYWNoZSkgLyAxMDI0IC8gMTAyNDsKKyAgICB1aW50NjRfdCBkaXNr RnJlZVNpemUgPSBnZXRDYWNoZURpc2tGcmVlU2l6ZShjYWNoZSkgLyBXVEY6Ok1COwogI2VuZGlm CiAKLSAgICB1aW50NjRfdCBtZW1TaXplID0gZ2V0TWVtb3J5U2l6ZSgpOworICAgIHVpbnQ2NF90 IG1lbVNpemUgPSBXVEY6OnJhbVNpemUoKSAvIFdURjo6TUI7CiAgICAgY2FsY3VsYXRlQ2FjaGVT aXplcyhjYWNoZU1vZGVsLCBtZW1TaXplLCBkaXNrRnJlZVNpemUsCiAgICAgICAgIGNhY2hlVG90 YWxDYXBhY2l0eSwgY2FjaGVNaW5EZWFkQ2FwYWNpdHksIGNhY2hlTWF4RGVhZENhcGFjaXR5LCBk ZWFkRGVjb2RlZERhdGFEZWxldGlvbkludGVydmFsLAogICAgICAgICBwYWdlQ2FjaGVDYXBhY2l0 eSwgdXJsQ2FjaGVNZW1vcnlDYXBhY2l0eSwgdXJsQ2FjaGVEaXNrQ2FwYWNpdHkpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NTb3VwLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHAKaW5kZXgg Nzk0NWFiZTdkMzU3OWU1M2Q4Y2FhZGNjZDI1Y2QxNjI4ZWRkYjIwZi4uNzdlMmI0MjMxMmVkMzA0 OTBmMTkzMDYxZDhmYmE2MTM0MDI2MzVmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAuY3BwCkBAIC00MSw2ICs0MSw3IEBACiAjaW5jbHVk ZSA8V2ViQ29yZS9SZXNvdXJjZUhhbmRsZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU291cE5ldHdv cmtTZXNzaW9uLmg+CiAjaW5jbHVkZSA8bGlic291cC9zb3VwLmg+CisjaW5jbHVkZSA8d3RmL1JB TVNpemUuaD4KICNpbmNsdWRlIDx3dGYvZ29iamVjdC9HUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3Rm L2dvYmplY3QvR1VuaXF1ZVB0ci5oPgogCkBAIC01OCwyMCArNTksNiBAQCBzdGF0aWMgdWludDY0 X3QgZ2V0Q2FjaGVEaXNrRnJlZVNpemUoU291cENhY2hlKiBjYWNoZSkKICAgICByZXR1cm4gV2Vi Q29yZTo6Z2V0Vm9sdW1lRnJlZVNpemVGb3JQYXRoKGNhY2hlRGlyLmdldCgpKTsKIH0KIAotc3Rh dGljIHVpbnQ2NF90IGdldE1lbW9yeVNpemUoKQotewotICAgIHN0YXRpYyB1aW50NjRfdCBrRGVm YXVsdE1lbW9yeVNpemUgPSA1MTI7Ci0gICAgbG9uZyBwYWdlU2l6ZSA9IHN5c2NvbmYoX1NDX1BB R0VTSVpFKTsKLSAgICBpZiAocGFnZVNpemUgPT0gLTEpCi0gICAgICAgIHJldHVybiBrRGVmYXVs dE1lbW9yeVNpemU7Ci0KLSAgICBsb25nIHBoeXNQYWdlcyA9IHN5c2NvbmYoX1NDX1BIWVNfUEFH RVMpOwotICAgIGlmIChwaHlzUGFnZXMgPT0gLTEpCi0gICAgICAgIHJldHVybiBrRGVmYXVsdE1l bW9yeVNpemU7Ci0KLSAgICByZXR1cm4gKChwYWdlU2l6ZSAvIDEwMjRMTCkgKiBwaHlzUGFnZXMp IC8gMTAyNExMOwotfQotCiB2b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtU2V0Q2FjaGVNb2RlbChD YWNoZU1vZGVsIGNhY2hlTW9kZWwpCiB7CiAgICAgdW5zaWduZWQgY2FjaGVUb3RhbENhcGFjaXR5 ID0gMDsKQEAgLTg4LDEwICs3NSwxMCBAQCB2b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtU2V0Q2Fj aGVNb2RlbChDYWNoZU1vZGVsIGNhY2hlTW9kZWwpCiAKICAgICBpZiAoIXVzZXNOZXR3b3JrUHJv Y2VzcygpKSB7CiAgICAgICAgIGNhY2hlID0gV2ViQ29yZTo6U291cE5ldHdvcmtTZXNzaW9uOjpk ZWZhdWx0U2Vzc2lvbigpLmNhY2hlKCk7Ci0gICAgICAgIGRpc2tGcmVlU2l6ZSA9IGdldENhY2hl RGlza0ZyZWVTaXplKGNhY2hlKSAvIDEwMjQgLyAxMDI0OworICAgICAgICBkaXNrRnJlZVNpemUg PSBnZXRDYWNoZURpc2tGcmVlU2l6ZShjYWNoZSkgLyBXVEY6Ok1COwogICAgIH0KIAotICAgIHVp bnQ2NF90IG1lbVNpemUgPSBnZXRNZW1vcnlTaXplKCk7CisgICAgdWludDY0X3QgbWVtU2l6ZSA9 IFdURjo6cmFtU2l6ZSgpIC8gV1RGOjpNQjsKICAgICBjYWxjdWxhdGVDYWNoZVNpemVzKGNhY2hl TW9kZWwsIG1lbVNpemUsIGRpc2tGcmVlU2l6ZSwKICAgICAgICAgICAgICAgICAgICAgICAgIGNh Y2hlVG90YWxDYXBhY2l0eSwgY2FjaGVNaW5EZWFkQ2FwYWNpdHksIGNhY2hlTWF4RGVhZENhcGFj aXR5LCBkZWFkRGVjb2RlZERhdGFEZWxldGlvbkludGVydmFsLAogICAgICAgICAgICAgICAgICAg ICAgICAgcGFnZUNhY2hlU2l6ZSwgdXJsQ2FjaGVNZW1vcnlDYXBhY2l0eSwgdXJsQ2FjaGVEaXNr Q2FwYWNpdHkpOwo=