144553 2015-05-03 15:30:06 -0700 Web Inspector: [REGRESSION] Dashboard's resource count does not reset when main resource navigates 2015-06-05 14:36:48 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg nvasilyev commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1091265 0 burg 2015-05-03 15:30:06 -0700 :( 1091266 1 webkit-bug-importer 2015-05-03 15:30:17 -0700 <rdar://problem/20795132> 1099312 2 nvasilyev 2015-06-03 15:38:03 -0700 Steps: 1. Open inspector for this very page (https://bugs.webkit.org/show_bug.cgi?id=144553) 2. Notice the resource count on the Web Inspector dashboard 3. Reload the page (Command R) Actual: Resource count on the dashboard is twice as it should be 1099899 3 nvasilyev 2015-06-05 12:06:17 -0700 It was broken somewhere between r183323 and r183335, which is actually quite a lot of changes: http://trac.webkit.org/log/trunk/?rev=183335&stop_rev=183323 1099903 4 nvasilyev 2015-06-05 12:11:31 -0700 Diffs: https://github.com/WebKit/webkit/compare/9e11bbf5e1fee6472d6cecb6f0af6c50dd5ad81f...4f9dcbed72cd641f2b00f3adace5577d193b2ac4 1099928 5 254378 nvasilyev 2015-06-05 13:45:21 -0700 Created attachment 254378 Patch 1099959 6 254378 commit-queue 2015-06-05 14:36:44 -0700 Comment on attachment 254378 Patch Clearing flags on attachment: 254378 Committed r185263: <http://trac.webkit.org/changeset/185263> 1099961 7 commit-queue 2015-06-05 14:36:48 -0700 All reviewed patches have been landed. Closing bug. 254378 2015-06-05 13:45:21 -0700 2015-06-05 14:36:44 -0700 Patch patch.txt text/plain 2856 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM3MDQyZjkuLmRjMWRmOTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA2LTA1ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtSRUdS RVNTSU9OXSBEYXNoYm9hcmQncyByZXNvdXJjZSBjb3VudCBkb2VzIG5vdCByZXNldCB3aGVuIG1h aW4gcmVzb3VyY2UgbmF2aWdhdGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDQ1NTMKKworICAgICAgICBBZGQgbWlzc2luZyBfbWFpblJlc291cmNl RGlkQ2hhbmdlLCB3aGljaCB3YXMgcmVtb3ZlZCBhZnRlciBzd2l0Y2hpbmcgdG8gdGhlIHRhYnMg VUkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL01vZGVscy9EZWZhdWx0RGFzaGJvYXJkLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkRlZmF1bHREYXNoYm9hcmQpOgorICAgICAgICBfd2FpdGluZ0ZvckZpcnN0TWFpblJl c291cmNlVG9TdGFydFRyYWNraW5nU2l6ZSBpcyBub3QgdXNlZCBhbnl3aGVyZSwgcmVtb3ZlIGl0 LgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuRGVmYXVsdERhc2hib2FyZC5wcm90b3R5cGUuX21h aW5SZXNvdXJjZURpZENoYW5nZSk6IEFkZGVkLgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuRGVm YXVsdERhc2hib2FyZC5wcm90b3R5cGUuX3Jlc291cmNlU2l6ZURpZENoYW5nZSk6IFJlbW92ZWQu CisgICAgICAgIFVudXNlZC4KKwogMjAxNS0wNi0wNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU3dpdGNoIHRvIGRvdWdobnV0IGNo YXJ0IGFuZCByZW1vdmUgaWRsZSB0aW1lIGluIHRoZSBSZW5kZXJpbmcgRnJhbWVzIHRpbWVsaW5l CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv RGVmYXVsdERhc2hib2FyZC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9EZWZhdWx0RGFzaGJvYXJkLmpzCmluZGV4IDVlMmFmMjIuLmVlMGE3NGIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9EZWZhdWx0 RGFzaGJvYXJkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01v ZGVscy9EZWZhdWx0RGFzaGJvYXJkLmpzCkBAIC0yOSw5ICsyOSw4IEBAIFdlYkluc3BlY3Rvci5E ZWZhdWx0RGFzaGJvYXJkID0gY2xhc3MgRGVmYXVsdERhc2hib2FyZCBleHRlbmRzIFdlYkluc3Bl Y3Rvci5PYmplCiAgICAgewogICAgICAgICBzdXBlcigpOwogCi0gICAgICAgIHRoaXMuX3dhaXRp bmdGb3JGaXJzdE1haW5SZXNvdXJjZVRvU3RhcnRUcmFja2luZ1NpemUgPSB0cnVlOwotCiAgICAg ICAgIC8vIE5lY2Vzc2FyeSBldmVudHMgcmVxdWlyZWQgdG8gdHJhY2sgbG9hZCBvZiByZXNvdXJj ZXMuCisgICAgICAgIFdlYkluc3BlY3Rvci5GcmFtZS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3Bl Y3Rvci5GcmFtZS5FdmVudC5NYWluUmVzb3VyY2VEaWRDaGFuZ2UsIHRoaXMuX21haW5SZXNvdXJj ZURpZENoYW5nZSwgdGhpcyk7CiAgICAgICAgIFdlYkluc3BlY3Rvci5GcmFtZS5hZGRFdmVudExp c3RlbmVyKFdlYkluc3BlY3Rvci5GcmFtZS5FdmVudC5SZXNvdXJjZVdhc0FkZGVkLCB0aGlzLl9y ZXNvdXJjZVdhc0FkZGVkLCB0aGlzKTsKICAgICAgICAgV2ViSW5zcGVjdG9yLmZyYW1lUmVzb3Vy Y2VNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkZyYW1lUmVzb3VyY2VNYW5h Z2VyLkV2ZW50LkZyYW1lV2FzQWRkZWQsIHRoaXMuX2ZyYW1lV2FzQWRkZWQsIHRoaXMpOwogCkBA IC0xMDAsNiArOTksMTUgQEAgV2ViSW5zcGVjdG9yLkRlZmF1bHREYXNoYm9hcmQgPSBjbGFzcyBE ZWZhdWx0RGFzaGJvYXJkIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamUKICAgICAgICAgdGhpcy5k aXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkRlZmF1bHREYXNoYm9hcmQuRXZl bnQuRGF0YURpZENoYW5nZSk7CiAgICAgfQogCisgICAgX21haW5SZXNvdXJjZURpZENoYW5nZShl dmVudCkKKyAgICB7CisgICAgICAgIGlmICghZXZlbnQudGFyZ2V0LmlzTWFpbkZyYW1lKCkpCisg ICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdGhpcy5fcmVzb3VyY2VzQ291bnQgPSAxOwor ICAgICAgICB0aGlzLl9kYXRhRGlkQ2hhbmdlKCk7CisgICAgfQorCiAgICAgX3Jlc291cmNlV2Fz QWRkZWQoZXZlbnQpCiAgICAgewogICAgICAgICArK3RoaXMucmVzb3VyY2VzQ291bnQ7CkBAIC0x MTAsMTEgKzExOCw2IEBAIFdlYkluc3BlY3Rvci5EZWZhdWx0RGFzaGJvYXJkID0gY2xhc3MgRGVm YXVsdERhc2hib2FyZCBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplCiAgICAgICAgICsrdGhpcy5y ZXNvdXJjZXNDb3VudDsKICAgICB9CiAKLSAgICBfcmVzb3VyY2VTaXplRGlkQ2hhbmdlKGV2ZW50 KQotICAgIHsKLSAgICAgICAgdGhpcy5yZXNvdXJjZXNTaXplICs9IGV2ZW50LnRhcmdldC5zaXpl IC0gZXZlbnQuZGF0YS5wcmV2aW91c1NpemU7Ci0gICAgfQotCiAgICAgX2NvbnNvbGVNZXNzYWdl QWRkZWQoZXZlbnQpCiAgICAgewogICAgICAgICB2YXIgbWVzc2FnZSA9IGV2ZW50LmRhdGEubWVz c2FnZTsK