144541 2015-05-03 03:58:47 -0700 [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main loop 2015-05-05 01:17:42 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 144542 1 cgarcia webkit-unassigned commit-queue gustavo svillar zan oldest_to_newest 1091199 0 cgarcia 2015-05-03 03:58:47 -0700 They are currently sent to the main thread run loop, because we are not setting the WorkQueue main context as the default one in the worker thread. 1091200 1 252263 cgarcia 2015-05-03 04:04:40 -0700 Created attachment 252263 Patch 1091201 2 commit-queue 2015-05-03 04:06:52 -0700 Attachment 252263 did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp:58: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1091317 3 252263 zan 2015-05-04 00:14:14 -0700 Comment on attachment 252263 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252263&action=review > Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp:58 > + [](GObject*, GAsyncResult*, gpointer userData) { It's not terribly important here, but if following the usual pattern of condition usage you'd be expected to lock the context.m_lock mutex inside the lambda. 1091718 4 cgarcia 2015-05-05 01:17:42 -0700 Committed r183800: <http://trac.webkit.org/changeset/183800> 252263 2015-05-03 04:04:40 -0700 2015-05-03 12:22:15 -0700 Patch wtf-work-queue-gtk.diff text/plain 6412 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZjFlNmIzNC4uNDU2ZmZhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNS0wNS0wMyAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dU S10gQXN5bmMgb3BlcmF0aW9ucyBydW5uaW5nIGluIHRoZSBXb3JrUXVldWUgdGhyZWFkIHNob3Vs ZCBzY2hlZHVsZSB0aGVpciBzb3VyY2VzIHRvIHRoZSBXb3JrUXVldWUgbWFpbiBsb3BwCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ1NDEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGV5IGFyZSBjdXJy ZW50bHkgc2VudCB0byB0aGUgbWFpbiB0aHJlYWQgcnVuIGxvb3AsIGJlY2F1c2Ugd2UKKyAgICAg ICAgYXJlIG5vdCBzZXR0aW5nIHRoZSBXb3JrUXVldWUgbWFpbiBjb250ZXh0IGFzIHRoZSBkZWZh dWx0IG9uZSBpbgorICAgICAgICB0aGUgd29ya2VyIHRocmVhZC4KKworICAgICAgICAqIHd0Zi9n dGsvV29ya1F1ZXVlR3RrLmNwcDoKKyAgICAgICAgKFdURjo6V29ya1F1ZXVlOjpwbGF0Zm9ybUlu aXRpYWxpemUpOiBDYWxsCisgICAgICAgIGdfbWFpbl9jb250ZXh0X3B1c2hfdGhyZWFkX2RlZmF1 bHQoKSB0byBzZXQgdGhlIFdvcmtRdWV1ZSBtYWluCisgICAgICAgIGNvbnRleHQgYXMgdGhlIGRl ZmF1bHQgb2YgdGhlIHRocmVhZCBiZWZvcmUgcnVubmluZyB0aGUgbWFpbiBsb29wLAorICAgICAg ICBhbmQgZ19tYWluX2NvbnRleHRfcG9wX3RocmVhZF9kZWZhdWx0KCkgd2hlbiB0aGUgbWFpbiBs b29wIHF1aXRzLgorCiAyMDE1LTA1LTAyICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTgzNzIyLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dURi93dGYvZ3RrL1dvcmtRdWV1ZUd0ay5jcHAgYi9Tb3VyY2UvV1RG L3d0Zi9ndGsvV29ya1F1ZXVlR3RrLmNwcAppbmRleCAwMDIwYTlmLi40MWMwNTA5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9ndGsvV29ya1F1ZXVlR3RrLmNwcAorKysgYi9Tb3VyY2UvV1RG L3d0Zi9ndGsvV29ya1F1ZXVlR3RrLmNwcApAQCAtNTYsNyArNTYsMTEgQEAgdm9pZCBXb3JrUXVl dWU6OnBsYXRmb3JtSW5pdGlhbGl6ZShjb25zdCBjaGFyKiBuYW1lLCBUeXBlLCBRT1MpCiAgICAg ICAgIHRocmVhZE5hbWUgKz0gc3RybGVuKHRocmVhZE5hbWUpIC0ga1Zpc3VhbFN0dWRpb1RocmVh ZE5hbWVMaW1pdDsKIAogICAgIFJlZlB0cjxXb3JrUXVldWU+IHByb3RlY3Rvcih0aGlzKTsKLSAg ICBtX3dvcmtRdWV1ZVRocmVhZCA9IGNyZWF0ZVRocmVhZCh0aHJlYWROYW1lLCBbcHJvdGVjdG9y XSB7IGdfbWFpbl9sb29wX3J1bihwcm90ZWN0b3ItPm1fZXZlbnRMb29wLmdldCgpKTsgfSk7Cisg ICAgbV93b3JrUXVldWVUaHJlYWQgPSBjcmVhdGVUaHJlYWQodGhyZWFkTmFtZSwgW3Byb3RlY3Rv cl0geworICAgICAgICBnX21haW5fY29udGV4dF9wdXNoX3RocmVhZF9kZWZhdWx0KHByb3RlY3Rv ci0+bV9ldmVudENvbnRleHQuZ2V0KCkpOworICAgICAgICBnX21haW5fbG9vcF9ydW4ocHJvdGVj dG9yLT5tX2V2ZW50TG9vcC5nZXQoKSk7CisgICAgICAgIGdfbWFpbl9jb250ZXh0X3BvcF90aHJl YWRfZGVmYXVsdChwcm90ZWN0b3ItPm1fZXZlbnRDb250ZXh0LmdldCgpKTsKKyAgICB9KTsKIH0K IAogdm9pZCBXb3JrUXVldWU6OnBsYXRmb3JtSW52YWxpZGF0ZSgpCmRpZmYgLS1naXQgYS9Ub29s cy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2JjYTlmOC4uNTExOGUwNCAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDE1LTA1LTAzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBBc3luYyBvcGVyYXRpb25zIHJ1bm5pbmcgaW4gdGhlIFdv cmtRdWV1ZSB0aHJlYWQgc2hvdWxkIHNjaGVkdWxlIHRoZWlyIHNvdXJjZXMgdG8gdGhlIFdvcmtR dWV1ZSBtYWluIGxvcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDU0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBhIHRlc3QgY2FzZSB0byBXb3JrUXVldWUgdW5pdCB0ZXN0LCB0byBjaGVjayB0 aGF0IHNvdXJjZXMgb2YKKyAgICAgICAgYXN5bmNocm9ub3VzIElPIG9wZXJhdGlvbnMgcnVubmlu ZyBpbiB0aGUgV29ya1F1ZXVlIHRocmVhZCBhcmUKKyAgICAgICAgZGlzcGF0Y2hlZCBieSB0aGUg V29ya1F1ZXVlIG1haW4gbG9vcC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvUGxhdGZvcm1H VEsuY21ha2U6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvZ3RrL1dvcmtRdWV1 ZUd0ay5jcHA6IEFkZGVkLgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMTUt MDUtMDEgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpb0BlbmRsZXNzbS5jb20+CiAKICAgICAg ICAgY2hlY2std2Via2l0LXN0eWxlIGZhaWxzIGR1ZSB0byBzeXN0ZW0gcHlsaW50CmRpZmYgLS1n aXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCBjZmMwZDg3Li4wNmIzMDU3IDEwMDY0NAot LS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTEzNCw0ICsxMzQsNSBAQCBzZXRfdGFy Z2V0X3Byb3BlcnRpZXMoVGVzdFdlYkNvcmUgUFJPUEVSVElFUyBSVU5USU1FX09VVFBVVF9ESVJF Q1RPUlkgJHtURVNUV0VCSwogbGlzdChBUFBFTkQgVGVzdFdURl9TT1VSQ0VTCiAgICAgJHtURVNU V0VCS0lUQVBJX0RJUn0vVGVzdHMvV1RGL2dvYmplY3QvR01haW5Mb29wU291cmNlLmNwcAogICAg ICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dURi9nb2JqZWN0L0dVbmlxdWVQdHIuY3BwCisg ICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV1RGL2d0ay9Xb3JrUXVldWVHdGsuY3BwCiAp CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9ndGsvV29ya1F1ZXVl R3RrLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL2d0ay9Xb3JrUXVldWVHdGsu Y3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjQ1ODE5NjMKLS0tIC9kZXYv bnVsbAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9ndGsvV29ya1F1ZXVlR3Rr LmNwcApAQCAtMCwwICsxLDY4IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDE1IElnYWxpYSBT LkwuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJv dmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBS ZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHly aWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv d2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11 c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0 IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAg IGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBk aXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJ TkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJworICogQU5EIEFOWSBFWFBSRVNTIE9S IElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisgKiBU SEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1Ig QSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFM TCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMKKyAqIEJFIExJQUJMRSBGT1IgQU5ZIERJ UkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IKKyAqIENP TlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NV UkVNRU5UIE9GCisgKiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwg REFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKKyAqIElOVEVSUlVQVElPTikgSE9XRVZFUiBD QVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOCisgKiBDT05U UkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1Ig T1RIRVJXSVNFKQorICogQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMg U09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgorICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKworI2luY2x1ZGUgIlRlc3QuaCIK KyNpbmNsdWRlIDxnaW8vZ2lvLmg+CisjaW5jbHVkZSA8dGhyZWFkPgorI2luY2x1ZGUgPHd0Zi9X b3JrUXVldWUuaD4KKyNpbmNsdWRlIDx3dGYvZ29iamVjdC9HUmVmUHRyLmg+CisjaW5jbHVkZSA8 d3RmL2dvYmplY3QvR1VuaXF1ZVB0ci5oPgorCituYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CisK K1RFU1QoV1RGX1dvcmtRdWV1ZSwgQXN5bmNJTykKK3sKKyAgICBzdHJ1Y3QgVGVzdGluZ0NvbnRl eHQgeworICAgICAgICBNdXRleCBtX2xvY2s7CisgICAgICAgIFRocmVhZENvbmRpdGlvbiBtX3Rl c3RDb21wbGV0ZWQ7CisgICAgICAgIEdNYWluQ29udGV4dCogbV9tYWluQ29udGV4dDsKKyAgICB9 IGNvbnRleHQ7CisKKyAgICBhdXRvIHF1ZXVlID0gV29ya1F1ZXVlOjpjcmVhdGUoImNvbS5hcHBs ZS5XZWJLaXQuVGVzdC5Bc3luY0lPIik7CisgICAgY29udGV4dC5tX21haW5Db250ZXh0ID0gZ19t YWluX2NvbnRleHRfZGVmYXVsdCgpOworICAgIEVYUEVDVF9GQUxTRShnX21haW5fY29udGV4dF9n ZXRfdGhyZWFkX2RlZmF1bHQoKSk7CisKKyAgICBHVW5pcXVlUHRyPGNoYXI+IGN1cnJlbnREaXJl Y3RvcnkoZ19nZXRfY3VycmVudF9kaXIoKSk7CisgICAgR1JlZlB0cjxHRmlsZT4gZmlsZSA9IGFk b3B0R1JlZihnX2ZpbGVfbmV3X2Zvcl9wYXRoKGN1cnJlbnREaXJlY3RvcnkuZ2V0KCkpKTsKKwor ICAgIE11dGV4TG9ja2VyIGxvY2tlcihjb250ZXh0Lm1fbG9jayk7CisgICAgcXVldWUtPmRpc3Bh dGNoKFsmXSh2b2lkKSB7CisgICAgICAgIEVYUEVDVF9UUlVFKGdfbWFpbl9jb250ZXh0X2dldF90 aHJlYWRfZGVmYXVsdCgpKTsKKyAgICAgICAgRVhQRUNUX1RSVUUoZ19tYWluX2NvbnRleHRfZ2V0 X3RocmVhZF9kZWZhdWx0KCkgIT0gY29udGV4dC5tX21haW5Db250ZXh0KTsKKyAgICAgICAgY29u dGV4dC5tX21haW5Db250ZXh0ID0gZ19tYWluX2NvbnRleHRfZ2V0X3RocmVhZF9kZWZhdWx0KCk7 CisgICAgICAgIGdfZmlsZV9xdWVyeV9pbmZvX2FzeW5jKGZpbGUuZ2V0KCksIEdfRklMRV9BVFRS SUJVVEVfU1RBTkRBUkRfU0laRSwgR19GSUxFX1FVRVJZX0lORk9fTk9ORSwgR19QUklPUklUWV9E RUZBVUxULCBudWxscHRyLAorICAgICAgICAgICAgW10oR09iamVjdCosIEdBc3luY1Jlc3VsdCos IGdwb2ludGVyIHVzZXJEYXRhKSB7CisgICAgICAgICAgICAgICAgVGVzdGluZ0NvbnRleHQqIGNv bnRleHQgPSBzdGF0aWNfY2FzdDxUZXN0aW5nQ29udGV4dCo+KHVzZXJEYXRhKTsKKyAgICAgICAg ICAgICAgICBFWFBFQ1RfRVEoZ19tYWluX2NvbnRleHRfZ2V0X3RocmVhZF9kZWZhdWx0KCksIGNv bnRleHQtPm1fbWFpbkNvbnRleHQpOworICAgICAgICAgICAgICAgIGNvbnRleHQtPm1fdGVzdENv bXBsZXRlZC5zaWduYWwoKTsKKyAgICAgICAgICAgIH0sICZjb250ZXh0KTsKKyAgICB9KTsKKwor ICAgIGNvbnRleHQubV90ZXN0Q29tcGxldGVkLndhaXQoY29udGV4dC5tX2xvY2spOworfQorCit9 IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==