144533 2015-05-02 15:41:13 -0700 REGRESSION (r183467): Unable to start downloads on macupdate.com 2015-05-06 11:28:13 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac (Intel) OS X 10.10 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=144259 https://www.macupdate.com/app/mac/39855/soundcloud-downloader/download InRadar P1 Major --- 1 skepticus webkit-unassigned ap koivisto webkit-bug-importer oldest_to_newest 1091150 0 skepticus 2015-05-02 15:41:13 -0700 https://www.macupdate.com/app/mac/39855/soundcloud-downloader/download5/2/15 18:36:24.991 Regular Safari performs this download without problem. Possible relevant Console message- secd[365]: securityd_xpc_dictionary_handler SafariForWebKitD[27320] update The operation couldn’t be completed. (OSStatus error -34018 - client has neither application-identifier nor keychain-access-groups entitlements) 1091151 1 skepticus 2015-05-02 15:41:58 -0700 5/2/15 18:36:24.993 secd[365]: securityd_xpc_dictionary_handler SafariForWebKitD[27320] add The operation couldn’t be completed. (OSStatus error -34018 - client has neither application-identifier nor keychain-access-groups entitlements) Possible relevant Console log. 1091168 2 ap 2015-05-02 18:04:37 -0700 *** Bug 144532 has been marked as a duplicate of this bug. *** 1091661 3 webkit-bug-importer 2015-05-04 19:42:07 -0700 <rdar://problem/20812658> 1092147 4 koivisto 2015-05-06 07:30:49 -0700 I can repro in private browsing mode. 1092148 5 252472 koivisto 2015-05-06 07:41:30 -0700 Created attachment 252472 patch 1092175 6 252472 darin 2015-05-06 09:27:06 -0700 Comment on attachment 252472 patch View in context: https://bugs.webkit.org/attachment.cgi?id=252472&action=review > Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:334 > + ResourceLoadPriority oldPriority = priority(); > + RefPtr<FormData> oldHTTPBody = httpBody(); > + bool isHiddenFromInspector = hiddenFromInspector(); > + auto oldRequester = requester(); What makes these the only 4 we need to preserve? I think there should be a comment here explaining the theory of which properties should be listed here. 1092214 7 koivisto 2015-05-06 10:33:25 -0700 https://trac.webkit.org/r183875 1092240 8 ap 2015-05-06 11:15:54 -0700 This reproduced in regular mode, not in private browsing. Are you sure that you fixed the right bug? 1092242 9 ap 2015-05-06 11:17:42 -0700 From the nature of the fix, it may have depended on Do Not Track settings in Safari, so it may be the right fix. But please test carefully once a nightly comes out. 1092247 10 koivisto 2015-05-06 11:28:13 -0700 Any client feature that mutates the request in willSendRequest would trigger this. One that I could find was private browsing. 252472 2015-05-06 07:41:30 -0700 2015-05-06 09:27:06 -0700 patch private-browsing-download.patch text/plain 6230 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzg2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA1LTA2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTgzNDY3 KTogVW5hYmxlIHRvIHN0YXJ0IGRvd25sb2FkcyBpbiBwcml2YXRlIGJyb3dzaW5nIG1vZGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDUzMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHdpbGxTZW5k UmVxdWVzdCBkZWxlZ2F0ZSBtdXRhdGVkIHRoZSByZXF1ZXN0IHdlIHdvdWxkIGxvc2UgdGhlIHJl cXVlc3RlciBmaWVsZCB2YWx1ZSBmcm9tIHRoZSBvcmlnaW5hbC4KKworICAgICAgICBObyB0ZXN0 IHJ1bm5lciBzdXBwb3J0IGZvciBtdXRhdGluZyByZXF1ZXN0cy4KKworICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvY2YvUmVzb3VyY2VSZXF1ZXN0Q0ZOZXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVzb3VyY2VSZXF1ZXN0Ojp1cGRhdGVGcm9tRGVsZWdhdGVQcmVzZXJ2aW5nT2xkUHJvcGVy dGllcyk6CisKKyAgICAgICAgICAgIFRoaXMgbmVlZHMgdG8ga2VlcCB0aGUgcmVxdWVzdGVyIHRv by4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY29jb2EvUmVzb3VyY2VSZXF1ZXN0Q29j b2EubW06CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OnVwZGF0ZUZyb21EZWxl Z2F0ZVByZXNlcnZpbmdPbGRQcm9wZXJ0aWVzKTogRGVsZXRlZC4KKworICAgICAgICAgICAgU2hh cmUgaW1wbGVtZW50YXRpb25zLgorCiAyMDE1LTA1LTA2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNv cmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRE9NU3RvcmFnZSBleGNl cHRpb24gYW5kIGlzc3VlIHdpdGggc2Vzc2lvblN0b3JhZ2UKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VSZXF1ZXN0Q0ZOZXQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VSZXF1ZXN0Q0ZO ZXQuY3BwCShyZXZpc2lvbiAxODM4NjUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2NmL1Jlc291cmNlUmVxdWVzdENGTmV0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI3LDE5 ICsyMjcsNiBAQCB2b2lkIFJlc291cmNlUmVxdWVzdDo6ZG9VcGRhdGVQbGF0Zm9ybUhUCiAjZW5k aWYKIH0KIAotdm9pZCBSZXNvdXJjZVJlcXVlc3Q6OnVwZGF0ZUZyb21EZWxlZ2F0ZVByZXNlcnZp bmdPbGRQcm9wZXJ0aWVzKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgZGVsZWdhdGVQcm92aWRlZFJl cXVlc3QpCi17Ci0gICAgUmVzb3VyY2VMb2FkUHJpb3JpdHkgb2xkUHJpb3JpdHkgPSBwcmlvcml0 eSgpOwotICAgIFJlZlB0cjxGb3JtRGF0YT4gb2xkSFRUUEJvZHkgPSBodHRwQm9keSgpOwotICAg IGJvb2wgaXNIaWRkZW5Gcm9tSW5zcGVjdG9yID0gaGlkZGVuRnJvbUluc3BlY3RvcigpOwotCi0g ICAgKnRoaXMgPSBkZWxlZ2F0ZVByb3ZpZGVkUmVxdWVzdDsKLQotICAgIHNldFByaW9yaXR5KG9s ZFByaW9yaXR5KTsKLSAgICBzZXRIVFRQQm9keShvbGRIVFRQQm9keS5yZWxlYXNlKCkpOwotICAg IHNldEhpZGRlbkZyb21JbnNwZWN0b3IoaXNIaWRkZW5Gcm9tSW5zcGVjdG9yKTsKLX0KLQogdm9p ZCBSZXNvdXJjZVJlcXVlc3Q6OmRvVXBkYXRlUmVzb3VyY2VSZXF1ZXN0KCkKIHsKICAgICBpZiAo IW1fY2ZSZXF1ZXN0KSB7CkBAIC0zMzksNiArMzI2LDIxIEBAIHZvaWQgUmVzb3VyY2VSZXF1ZXN0 OjpzZXRTdG9yYWdlU2Vzc2lvbigKIAogI2VuZGlmIC8vIFVTRShDRk5FVFdPUkspCiAKK3ZvaWQg UmVzb3VyY2VSZXF1ZXN0Ojp1cGRhdGVGcm9tRGVsZWdhdGVQcmVzZXJ2aW5nT2xkUHJvcGVydGll cyhjb25zdCBSZXNvdXJjZVJlcXVlc3QmIGRlbGVnYXRlUHJvdmlkZWRSZXF1ZXN0KQoreworICAg IFJlc291cmNlTG9hZFByaW9yaXR5IG9sZFByaW9yaXR5ID0gcHJpb3JpdHkoKTsKKyAgICBSZWZQ dHI8Rm9ybURhdGE+IG9sZEhUVFBCb2R5ID0gaHR0cEJvZHkoKTsKKyAgICBib29sIGlzSGlkZGVu RnJvbUluc3BlY3RvciA9IGhpZGRlbkZyb21JbnNwZWN0b3IoKTsKKyAgICBhdXRvIG9sZFJlcXVl c3RlciA9IHJlcXVlc3RlcigpOworCisgICAgKnRoaXMgPSBkZWxlZ2F0ZVByb3ZpZGVkUmVxdWVz dDsKKworICAgIHNldFByaW9yaXR5KG9sZFByaW9yaXR5KTsKKyAgICBzZXRIVFRQQm9keShvbGRI VFRQQm9keS5yZWxlYXNlKCkpOworICAgIHNldEhpZGRlbkZyb21JbnNwZWN0b3IoaXNIaWRkZW5G cm9tSW5zcGVjdG9yKTsKKyAgICBzZXRSZXF1ZXN0ZXIob2xkUmVxdWVzdGVyKTsKK30KKwogYm9v bCBSZXNvdXJjZVJlcXVlc3Q6Omh0dHBQaXBlbGluaW5nRW5hYmxlZCgpCiB7CiAgICAgcmV0dXJu IHNfaHR0cFBpcGVsaW5pbmdFbmFibGVkOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jb2NvYS9SZXNvdXJjZVJlcXVlc3RDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL1Jlc291cmNlUmVxdWVzdENvY29hLm1t CShyZXZpc2lvbiAxODM4NjUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nv Y29hL1Jlc291cmNlUmVxdWVzdENvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMDUsMTkgKzIw NSw2IEBAIHZvaWQgUmVzb3VyY2VSZXF1ZXN0Ojpkb1VwZGF0ZVBsYXRmb3JtSFQKICAgICB9CiB9 CiAKLXZvaWQgUmVzb3VyY2VSZXF1ZXN0Ojp1cGRhdGVGcm9tRGVsZWdhdGVQcmVzZXJ2aW5nT2xk UHJvcGVydGllcyhjb25zdCBSZXNvdXJjZVJlcXVlc3QmIGRlbGVnYXRlUHJvdmlkZWRSZXF1ZXN0 KQotewotICAgIFJlc291cmNlTG9hZFByaW9yaXR5IG9sZFByaW9yaXR5ID0gcHJpb3JpdHkoKTsK LSAgICBSZWZQdHI8Rm9ybURhdGE+IG9sZEhUVFBCb2R5ID0gaHR0cEJvZHkoKTsKLSAgICBib29s IGlzSGlkZGVuRnJvbUluc3BlY3RvciA9IGhpZGRlbkZyb21JbnNwZWN0b3IoKTsKLQotICAgICp0 aGlzID0gZGVsZWdhdGVQcm92aWRlZFJlcXVlc3Q7Ci0KLSAgICBzZXRQcmlvcml0eShvbGRQcmlv cml0eSk7Ci0gICAgc2V0SFRUUEJvZHkob2xkSFRUUEJvZHkucmVsZWFzZSgpKTsKLSAgICBzZXRI aWRkZW5Gcm9tSW5zcGVjdG9yKGlzSGlkZGVuRnJvbUluc3BlY3Rvcik7Ci19Ci0KICNpZiAhUExB VEZPUk0oSU9TKQogdm9pZCBSZXNvdXJjZVJlcXVlc3Q6OmFwcGx5V2ViQXJjaGl2ZUhhY2tGb3JN YWlsKCkKIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzg2NykKKysrIFNvdXJj ZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisy MDE1LTA1LTA2ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBS RUdSRVNTSU9OIChyMTgzNDY3KTogVW5hYmxlIHRvIHN0YXJ0IGRvd25sb2FkcyBpbiBwcml2YXRl IGJyb3dzaW5nIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDUzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQubW06CisgICAgICAg IChXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlc3QpOgorCisgICAg ICAgICAgICBVc2UgdXBkYXRlRnJvbURlbGVnYXRlUHJlc2VydmluZ09sZFByb3BlcnRpZXMgKGxp a2UgV0syKSBpbnN0ZWFkIG9mIGRvaW5nIHRoZSBzYW1lIHRoaW5nIG1hbnVhbGx5LgorCiAyMDE1 LTA1LTA0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFRvZ2ds aW5nIHVuZGVybGluZSBvciBzdHJpa2UgdGhyb3VnaCBhZmZlY3RzIGVhY2ggb3RoZXIKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1l TG9hZGVyQ2xpZW50Lm1tCShyZXZpc2lvbiAxODM4NjUpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9X ZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5tbQkod29ya2luZyBjb3B5KQpAQCAt MzYxLDkgKzM2MSw2IEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoV2lsbFMK IAogICAgIE5TVVJMUmVxdWVzdCAqY3VycmVudFVSTFJlcXVlc3QgPSByZXF1ZXN0Lm5zVVJMUmVx dWVzdChVcGRhdGVIVFRQQm9keSk7CiAgICAgTlNVUkxSZXF1ZXN0ICpuZXdVUkxSZXF1ZXN0ID0g Y3VycmVudFVSTFJlcXVlc3Q7Ci0gICAgUmVzb3VyY2VMb2FkUHJpb3JpdHkgcHJpb3JpdHkgPSBy ZXF1ZXN0LnByaW9yaXR5KCk7Ci0gICAgYm9vbCBpc0hpZGRlbkZyb21JbnNwZWN0b3IgPSByZXF1 ZXN0LmhpZGRlbkZyb21JbnNwZWN0b3IoKTsKLSAgICBhdXRvIHJlcXVlc3RlciA9IHJlcXVlc3Qu cmVxdWVzdGVyKCk7CiAjaWYgUExBVEZPUk0oSU9TKQogICAgIGlmIChpbXBsZW1lbnRhdGlvbnMt PndlYlRocmVhZFdpbGxTZW5kUmVxdWVzdEZ1bmMpIHsKICAgICAgICAgbmV3VVJMUmVxdWVzdCA9 IChOU1VSTFJlcXVlc3QgKilDYWxsUmVzb3VyY2VMb2FkRGVsZWdhdGVJbldlYlRocmVhZChpbXBs ZW1lbnRhdGlvbnMtPndlYlRocmVhZFdpbGxTZW5kUmVxdWVzdEZ1bmMsIHdlYlZpZXcsIEBzZWxl Y3Rvcih3ZWJUaHJlYWRXZWJWaWV3OnJlc291cmNlOndpbGxTZW5kUmVxdWVzdDpyZWRpcmVjdFJl c3BvbnNlOmZyb21EYXRhU291cmNlOiksIFt3ZWJWaWV3IF9vYmplY3RGb3JJZGVudGlmaWVyOmlk ZW50aWZpZXJdLCBjdXJyZW50VVJMUmVxdWVzdCwgcmVkaXJlY3RSZXNwb25zZS5uc1VSTFJlc3Bv bnNlKCksIGRhdGFTb3VyY2UobG9hZGVyKSk7CkBAIC0zNzMsMTAgKzM3MCw3IEBAIHZvaWQgV2Vi RnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoV2lsbFMKICAgICAgICAgbmV3VVJMUmVxdWVzdCA9 IChOU1VSTFJlcXVlc3QgKilDYWxsUmVzb3VyY2VMb2FkRGVsZWdhdGUoaW1wbGVtZW50YXRpb25z LT53aWxsU2VuZFJlcXVlc3RGdW5jLCB3ZWJWaWV3LCBAc2VsZWN0b3Iod2ViVmlldzpyZXNvdXJj ZTp3aWxsU2VuZFJlcXVlc3Q6cmVkaXJlY3RSZXNwb25zZTpmcm9tRGF0YVNvdXJjZTopLCBbd2Vi VmlldyBfb2JqZWN0Rm9ySWRlbnRpZmllcjppZGVudGlmaWVyXSwgY3VycmVudFVSTFJlcXVlc3Qs IHJlZGlyZWN0UmVzcG9uc2UubnNVUkxSZXNwb25zZSgpLCBkYXRhU291cmNlKGxvYWRlcikpOwog CiAgICAgaWYgKG5ld1VSTFJlcXVlc3QgIT0gY3VycmVudFVSTFJlcXVlc3QpCi0gICAgICAgIHJl cXVlc3QgPSBuZXdVUkxSZXF1ZXN0OwotICAgIHJlcXVlc3Quc2V0SGlkZGVuRnJvbUluc3BlY3Rv cihpc0hpZGRlbkZyb21JbnNwZWN0b3IpOwotICAgIHJlcXVlc3Quc2V0UHJpb3JpdHkocHJpb3Jp dHkpOwotICAgIHJlcXVlc3Quc2V0UmVxdWVzdGVyKHJlcXVlc3Rlcik7CisgICAgICAgIHJlcXVl c3QudXBkYXRlRnJvbURlbGVnYXRlUHJlc2VydmluZ09sZFByb3BlcnRpZXMoUmVzb3VyY2VSZXF1 ZXN0KG5ld1VSTFJlcXVlc3QpKTsKIH0KIAogYm9vbCBXZWJGcmFtZUxvYWRlckNsaWVudDo6c2hv dWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UoRG9jdW1lbnRMb2FkZXIqIGxvYWRlciwgdW5zaWduZWQg bG9uZyBpZGVudGlmaWVyKQo=