144531 2015-05-02 15:09:26 -0700 Web Inspector: Fix some issues with Search tabs 2015-05-05 10:46:35 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1091145 0 timothy 2015-05-02 15:09:26 -0700 * Script results open in the Resources tab. * Restoring the cookie state fails to select a result. 1091147 1 252251 timothy 2015-05-02 15:13:05 -0700 Created attachment 252251 Patch 1091799 2 252251 commit-queue 2015-05-05 10:00:51 -0700 Comment on attachment 252251 Patch Clearing flags on attachment: 252251 Committed r183816: <http://trac.webkit.org/changeset/183816> 1091800 3 commit-queue 2015-05-05 10:00:55 -0700 All reviewed patches have been landed. Closing bug. 1091811 4 252251 burg 2015-05-05 10:46:35 -0700 Comment on attachment 252251 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252251&action=review (oops, forgot to hit "Publish") > Source/WebInspectorUI/ChangeLog:7 > + You should describe the 'issues' here. I think one is cookie restoration- is that affected by reloads or reopens or both? > Source/WebInspectorUI/ChangeLog:19 > + Don't allow restoring the previous selected node when another not has already been selected. not > node 252251 2015-05-02 15:13:05 -0700 2015-05-05 10:00:51 -0700 Patch bug-144531-20150502151152.patch text/plain 6901 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ZjM3MTkxMWFmODEzNGY0ZTBiMGM4Y2EzMWY1NjcxMzYwMTIzMjZlLi44NDMxM2I4ODQyMTNkYzgx Y2Q4YmJkMzI4YmRmMmQzYjg2ZGFhNDRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyOSBAQAogMjAxNS0wNS0wMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IHNvbWUgaXNzdWVzIHdpdGggU2VhcmNo IHRhYnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NDUzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5Db250ZW50Vmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29udGVudFZpZXcuaXNWaWV3 YWJsZSk6CisgICAgICAgIFN1cHBvcnQgRE9NU2VhcmNoTWF0Y2hPYmplY3QgYW5kIFNvdXJjZUNv ZGVTZWFyY2hNYXRjaE9iamVjdCByZXByZXNlbnRlZE9iamVjdHMuIFRoZXNlIGFyZSB1c3VhbGx5 CisgICAgICAgIGhhbmRsZWQgYXQgYSBoaWdoZXIgbGV2ZWwsIGJ1dCBjb29raWUgcmVzdG9yaW5n IHJlcXVpcmVzIENvbnRlbnRWaWV3IHRvIGhhbmRsZSB0aGVtLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRE9NVHJlZUNvbnRlbnRWaWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlQ29u dGVudFZpZXcucHJvdG90eXBlLnNlbGVjdEFuZFJldmVhbERPTU5vZGUpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkRPTVRyZWVDb250ZW50Vmlldy5wcm90b3R5cGUuc2VsZWN0TGFzdFNlbGVjdGVk Tm9kZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZUNvbnRlbnRWaWV3LnByb3RvdHlw ZS5fcmVzdG9yZVNlbGVjdGVkTm9kZUFmdGVyVXBkYXRlKToKKyAgICAgICAgRG9uJ3QgYWxsb3cg cmVzdG9yaW5nIHRoZSBwcmV2aW91cyBzZWxlY3RlZCBub2RlIHdoZW4gYW5vdGhlciBub3QgaGFz IGFscmVhZHkgYmVlbiBzZWxlY3RlZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv U2VhcmNoVGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2VhcmNoVGFi Q29udGVudFZpZXcucHJvdG90eXBlLmNhblNob3dSZXByZXNlbnRlZE9iamVjdCk6CisgICAgICAg IEFsbG93IFNjcmlwdCBvYmplY3RzIHRvIGJlIHNob3duIGluIHRoZSBTZWFyY2ggdGFiLgorCisy MDE1LTA1LTAyICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBOYXZpZ2F0aW9uU2lkZWJhclBhbmVsIGxlYWtzIHNvbWUgZXZlbnQg bGlzdGVuZXJzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDQ1MjMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qcwppbmRleCBmMjM3MzU2NzAxZThlNzUyNWNjM2Y1ZDFh NjY1MGJhOGRhNWY3YTY1Li41OTkzYmZjZDgwODIzOTcxNmZkNzI5MmIyNzExOWI5NWFmMDJkYTAw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D b250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Db250ZW50Vmlldy5qcwpAQCAtODEsNiArODEsMjggQEAgV2ViSW5zcGVjdG9yLkNvbnRl bnRWaWV3ID0gZnVuY3Rpb24ocmVwcmVzZW50ZWRPYmplY3QsIGV4dHJhQXJndW1lbnRzKQogICAg ICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuRE9NVHJl ZSkKICAgICAgICAgICAgIHJldHVybiBuZXcgV2ViSW5zcGVjdG9yLkZyYW1lRE9NVHJlZUNvbnRl bnRWaWV3KHJlcHJlc2VudGVkT2JqZWN0LCBleHRyYUFyZ3VtZW50cyk7CiAKKyAgICAgICAgaWYg KHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkRPTVNlYXJjaE1hdGNo T2JqZWN0KSB7CisgICAgICAgICAgICB2YXIgcmVzdWx0VmlldyA9IG5ldyBXZWJJbnNwZWN0b3Iu RnJhbWVET01UcmVlQ29udGVudFZpZXcoV2ViSW5zcGVjdG9yLmZyYW1lUmVzb3VyY2VNYW5hZ2Vy Lm1haW5GcmFtZS5kb21UcmVlLCBleHRyYUFyZ3VtZW50cyk7CisgICAgICAgICAgICByZXN1bHRW aWV3LnJlc3RvcmVGcm9tQ29va2llKHtub2RlVG9TZWxlY3Q6IHJlcHJlc2VudGVkT2JqZWN0LmRv bU5vZGV9KTsKKyAgICAgICAgICAgIHJldHVybiByZXN1bHRWaWV3OworICAgICAgICB9CisKKyAg ICAgICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlNvdXJj ZUNvZGVTZWFyY2hNYXRjaE9iamVjdCkgeworICAgICAgICAgICAgdmFyIHJlc3VsdFZpZXc7Cisg ICAgICAgICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3Quc291cmNlQ29kZSBpbnN0YW5jZW9mIFdl Ykluc3BlY3Rvci5SZXNvdXJjZSkKKyAgICAgICAgICAgICAgICByZXN1bHRWaWV3ID0gbmV3IFdl Ykluc3BlY3Rvci5SZXNvdXJjZUNsdXN0ZXJDb250ZW50VmlldyhyZXByZXNlbnRlZE9iamVjdC5z b3VyY2VDb2RlLCBleHRyYUFyZ3VtZW50cyk7CisgICAgICAgICAgICBlbHNlIGlmIChyZXByZXNl bnRlZE9iamVjdC5zb3VyY2VDb2RlIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlNjcmlwdCkKKyAg ICAgICAgICAgICAgICByZXN1bHRWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5TY3JpcHRDb250ZW50 VmlldyhyZXByZXNlbnRlZE9iamVjdC5zb3VyY2VDb2RlLCBleHRyYUFyZ3VtZW50cyk7CisgICAg ICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgY29uc29sZS5lcnJvcigiVW5rbm93biBTb3Vy Y2VDb2RlIiwgcmVwcmVzZW50ZWRPYmplY3Quc291cmNlQ29kZSk7CisKKyAgICAgICAgICAgIHZh ciB0ZXh0UmFuZ2VUb1NlbGVjdCA9IHJlcHJlc2VudGVkT2JqZWN0LnNvdXJjZUNvZGVUZXh0UmFu Z2UuZm9ybWF0dGVkVGV4dFJhbmdlOworICAgICAgICAgICAgdmFyIHN0YXJ0UG9zaXRpb24gPSB0 ZXh0UmFuZ2VUb1NlbGVjdC5zdGFydFBvc2l0aW9uKCk7CisgICAgICAgICAgICByZXN1bHRWaWV3 LnJlc3RvcmVGcm9tQ29va2llKHtsaW5lTnVtYmVyOiBzdGFydFBvc2l0aW9uLmxpbmVOdW1iZXIs IGNvbHVtbk51bWJlcjogc3RhcnRQb3NpdGlvbi5jb2x1bW5OdW1iZXJ9KTsKKworICAgICAgICAg ICAgcmV0dXJuIHJlc3VsdFZpZXc7CisgICAgICAgIH0KKwogICAgICAgICBpZiAocmVwcmVzZW50 ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuTG9nT2JqZWN0KQogICAgICAgICAgICAg cmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcocmVwcmVzZW50ZWRPYmplY3Qs IGV4dHJhQXJndW1lbnRzKTsKIApAQCAtMTQxLDYgKzE2MywxMCBAQCBXZWJJbnNwZWN0b3IuQ29u dGVudFZpZXcuaXNWaWV3YWJsZSA9IGZ1bmN0aW9uKHJlcHJlc2VudGVkT2JqZWN0KQogICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJ bnNwZWN0b3IuRE9NVHJlZSkKICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgaWYgKHJlcHJlc2Vu dGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkRPTVNlYXJjaE1hdGNoT2JqZWN0KQor ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2Vv ZiBXZWJJbnNwZWN0b3IuU291cmNlQ29kZVNlYXJjaE1hdGNoT2JqZWN0KQorICAgICAgICByZXR1 cm4gdHJ1ZTsKICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0 b3IuTG9nT2JqZWN0KQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAocmVwcmVzZW50ZWRP YmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuQ29udGVudEZsb3cpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZp ZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVl Q29udGVudFZpZXcuanMKaW5kZXggMGFmYmNhZmMzODdiMmY3OWUyMjdlNDAxN2E4MThiNTQ2ZDk3 MGZhNy4uNTkwOTBjNWY3ZTFlZDE5ODBiNDg4OWU1ZWQ4YmRjMzRmYWZmMGM3OCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUNvbnRl bnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0RPTVRyZWVDb250ZW50Vmlldy5qcwpAQCAtNTksNiArNTksNyBAQCBXZWJJbnNwZWN0b3IuRE9N VHJlZUNvbnRlbnRWaWV3ID0gZnVuY3Rpb24ocmVwcmVzZW50ZWRPYmplY3QpCiAKICAgICB0aGlz Ll9sYXN0U2VsZWN0ZWROb2RlUGF0aFNldHRpbmcgPSBuZXcgV2ViSW5zcGVjdG9yLlNldHRpbmco Imxhc3Qtc2VsZWN0ZWQtbm9kZS1wYXRoIiwgbnVsbCk7CiAKKyAgICB0aGlzLl9yZXN0b3JlU2Vs ZWN0ZWROb2RlSXNBbGxvd2VkID0gdHJ1ZTsKICAgICB0aGlzLl9udW1iZXJPZlNlYXJjaFJlc3Vs dHMgPSBudWxsOwogfTsKIApAQCAtMTQ1LDYgKzE0Niw3IEBAIFdlYkluc3BlY3Rvci5ET01UcmVl Q29udGVudFZpZXcucHJvdG90eXBlID0gewogCiAgICAgc2VsZWN0QW5kUmV2ZWFsRE9NTm9kZTog ZnVuY3Rpb24oZG9tTm9kZSwgcHJldmVudEZvY3VzQ2hhbmdlKQogICAgIHsKKyAgICAgICAgdGhp cy5fcmVzdG9yZVNlbGVjdGVkTm9kZUlzQWxsb3dlZCA9IGZhbHNlOwogICAgICAgICB0aGlzLl9k b21UcmVlT3V0bGluZS5zZWxlY3RET01Ob2RlKGRvbU5vZGUsICFwcmV2ZW50Rm9jdXNDaGFuZ2Up OwogICAgIH0sCiAKQEAgLTMyMiw3ICszMjQsNyBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZUNvbnRl bnRWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgIF9yZXN0b3JlU2VsZWN0ZWROb2RlQWZ0ZXJVcGRh dGU6IGZ1bmN0aW9uKGRvY3VtZW50VVJMLCBkZWZhdWx0Tm9kZSkKICAgICB7Ci0gICAgICAgIGlm ICghV2ViSW5zcGVjdG9yLmRvbVRyZWVNYW5hZ2VyLnJlc3RvcmVTZWxlY3RlZE5vZGVJc0FsbG93 ZWQpCisgICAgICAgIGlmICghdGhpcy5fcmVzdG9yZVNlbGVjdGVkTm9kZUlzQWxsb3dlZCB8fCAh V2ViSW5zcGVjdG9yLmRvbVRyZWVNYW5hZ2VyLnJlc3RvcmVTZWxlY3RlZE5vZGVJc0FsbG93ZWQp CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgZnVuY3Rpb24gc2VsZWN0Tm9kZShsYXN0 U2VsZWN0ZWROb2RlKQpAQCAtMzQ1LDggKzM0Nyw5IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlQ29u dGVudFZpZXcucHJvdG90eXBlID0gewogCiAgICAgICAgIGZ1bmN0aW9uIHNlbGVjdExhc3RTZWxl Y3RlZE5vZGUobm9kZUlkKQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIVdlYkluc3BlY3Rv ci5kb21UcmVlTWFuYWdlci5yZXN0b3JlU2VsZWN0ZWROb2RlSXNBbGxvd2VkKQorICAgICAgICAg ICAgaWYgKCF0aGlzLl9yZXN0b3JlU2VsZWN0ZWROb2RlSXNBbGxvd2VkIHx8ICFXZWJJbnNwZWN0 b3IuZG9tVHJlZU1hbmFnZXIucmVzdG9yZVNlbGVjdGVkTm9kZUlzQWxsb3dlZCkKICAgICAgICAg ICAgICAgICByZXR1cm47CisKICAgICAgICAgICAgIHNlbGVjdE5vZGUuY2FsbCh0aGlzLCBXZWJJ bnNwZWN0b3IuZG9tVHJlZU1hbmFnZXIubm9kZUZvcklkKG5vZGVJZCkpOwogICAgICAgICB9CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Nl YXJjaFRhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvU2VhcmNoVGFiQ29udGVudFZpZXcuanMKaW5kZXggOTg1ZWY5NmMwOThkYjgyMzIx MmY1YmFiNGE4NDRhNDlkODlhMmRhYi4uNjYyYjBlYTNmMjJkNmRmODc2YzgyOTk5NTU4NDU4NmMz ODQ4YzExYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvU2VhcmNoVGFiQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoVGFiQ29udGVudFZpZXcuanMKQEAgLTU2LDcgKzU2 LDcgQEAgV2ViSW5zcGVjdG9yLlNlYXJjaFRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKIAog ICAgIGNhblNob3dSZXByZXNlbnRlZE9iamVjdDogZnVuY3Rpb24ocmVwcmVzZW50ZWRPYmplY3Qp CiAgICAgewotICAgICAgICByZXR1cm4gcmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJ bnNwZWN0b3IuUmVzb3VyY2UgfHwgcmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNw ZWN0b3IuRE9NVHJlZTsKKyAgICAgICAgcmV0dXJuIHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNl b2YgV2ViSW5zcGVjdG9yLlJlc291cmNlIHx8IHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2Yg V2ViSW5zcGVjdG9yLlNjcmlwdCB8fCByZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9mIFdlYklu c3BlY3Rvci5ET01UcmVlOwogICAgIH0sCiAKICAgICBmb2N1c1NlYXJjaEZpZWxkOiBmdW5jdGlv bigpCg==