144523 2015-05-02 09:12:10 -0700 Web Inspector: NavigationSidebarPanel leaks some event listeners 2015-05-11 12:52:29 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1091097 0 timothy 2015-05-02 09:12:10 -0700 Need to remove them in closed(). 1091099 1 252233 timothy 2015-05-02 09:12:49 -0700 Created attachment 252233 Patch 1091484 2 252233 joepeck 2015-05-04 12:36:50 -0700 Comment on attachment 252233 Patch r=me. Looks like cq might not be able to handle this. 1091485 3 252233 commit-queue 2015-05-04 12:38:49 -0700 Comment on attachment 252233 Patch Rejecting attachment 252233 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 252233, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: erInterface/Views/SearchSidebarPanel.js patching file Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js patching file Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js Hunk #1 FAILED at 156. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6374829829652480 1093801 4 252233 timothy 2015-05-11 10:52:42 -0700 Comment on attachment 252233 Patch https://trac.webkit.org/r184108 1093860 5 timothy 2015-05-11 12:52:01 -0700 Landed manually. 1093861 6 webkit-bug-importer 2015-05-11 12:52:29 -0700 <rdar://problem/20903134> 252233 2015-05-02 09:12:49 -0700 2015-05-04 12:38:49 -0700 Patch bug-144523-20150502091137.patch text/plain 5629 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YjgyMDY4ZTc5MzJiMjNhNzRhMjU2MTY3YmVjNDdjNDAyOGY5MTU2Li5mZjM3MTkxMWFmODEzNGY0 ZTBiMGM4Y2EzMWY1NjcxMzYwMTIzMjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNCBAQAogMjAxNS0wNS0wMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmF2aWdhdGlvblNpZGViYXJQYW5lbCBsZWFr cyBzb21lIGV2ZW50IGxpc3RlbmVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ0NTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFu ZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQYW5lbCk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQYW5lbC5wcm90b3R5cGUuY2xv c2VkKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVs LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclBhbmVsLnByb3RvdHlw ZS5jbG9zZWQpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBh bmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNlYXJjaFNpZGViYXJQYW5lbC5wcm90b3R5 cGUuY2xvc2VkKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1N0b3JhZ2VTaWRlYmFy UGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3RvcmFnZVNpZGViYXJQYW5lbC5wcm90 b3R5cGUuY2xvc2VkKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lU2lk ZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVs LnByb3RvdHlwZS5jbG9zZWQpOgorCisyMDE1LTA1LTAyICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1v dGh5QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBbGxvdyBjbG9zaW5nIGFu ZCByZW9wZW5pbmcgdGhlIFRpbWVsaW5lcyB0YWIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDUyMAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGVi YXJQYW5lbC5qcwppbmRleCAwYWI0Mzc3NjhjNmRlNjg3ZWUyMDk4Y2MzMWFkYjljOWQzNGJlZjUy Li5iMzNjYzU1ZjZhOThhZWFlZmEzNTM3MTNlYTExMWQzMzM4OTQ1NWRlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJh clBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMKQEAgLTUyLDcgKzUyLDggQEAgV2ViSW5zcGVjdG9y Lk5hdmlnYXRpb25TaWRlYmFyUGFuZWwgPSBjbGFzcyBOYXZpZ2F0aW9uU2lkZWJhclBhbmVsIGV4 dGVuZHMgV2ViSW4KICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl90 b3BPdmVyZmxvd1NoYWRvd0VsZW1lbnQpOwogICAgICAgICB9CiAKLSAgICAgICAgd2luZG93LmFk ZEV2ZW50TGlzdGVuZXIoInJlc2l6ZSIsIHRoaXMuX3VwZGF0ZUNvbnRlbnRPdmVyZmxvd1NoYWRv d1Zpc2liaWxpdHkuYmluZCh0aGlzKSk7CisgICAgICAgIHRoaXMuX2JvdW5kVXBkYXRlQ29udGVu dE92ZXJmbG93U2hhZG93VmlzaWJpbGl0eSA9IHRoaXMuX3VwZGF0ZUNvbnRlbnRPdmVyZmxvd1No YWRvd1Zpc2liaWxpdHkuYmluZCh0aGlzKTsKKyAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVu ZXIoInJlc2l6ZSIsIHRoaXMuX2JvdW5kVXBkYXRlQ29udGVudE92ZXJmbG93U2hhZG93VmlzaWJp bGl0eSk7CiAKICAgICAgICAgdGhpcy5fZmlsdGVyc1NldHRpbmcgPSBuZXcgV2ViSW5zcGVjdG9y LlNldHRpbmcoaWRlbnRpZmllciArICItbmF2aWdhdGlvbi1zaWRlYmFyLWZpbHRlcnMiLCB7fSk7 CiAgICAgICAgIHRoaXMuX2ZpbHRlckJhci5maWx0ZXJzID0gdGhpcy5fZmlsdGVyc1NldHRpbmcu dmFsdWU7CkBAIC03Niw2ICs3NywxMiBAQCBXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQ YW5lbCA9IGNsYXNzIE5hdmlnYXRpb25TaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbgogCiAgICAg Ly8gUHVibGljCiAKKyAgICBjbG9zZWQoKQorICAgIHsKKyAgICAgICAgd2luZG93LnJlbW92ZUV2 ZW50TGlzdGVuZXIoInJlc2l6ZSIsIHRoaXMuX2JvdW5kVXBkYXRlQ29udGVudE92ZXJmbG93U2hh ZG93VmlzaWJpbGl0eSk7CisgICAgICAgIFdlYkluc3BlY3Rvci5GcmFtZS5yZW1vdmVFdmVudExp c3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOworICAgIH0KKwogICAgIGdldCBjb250ZW50QnJvd3Nl cigpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fY29udGVudEJyb3dzZXI7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVNp ZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCmluZGV4IDI5YjQ3MzkyNTRjZTkwN2UzOGFlMGVmYWRk NmMzYzU5NmM0MTcyODIuLmNhZjNiYzBkZTI0ZmY0Mzg5OTZkNzA0NzgxN2Y1YmU1N2MxOGU1YWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jl c291cmNlU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCkBAIC01Niw2ICs1Niw4IEBAIFdl Ykluc3BlY3Rvci5SZXNvdXJjZVNpZGViYXJQYW5lbCA9IGNsYXNzIFJlc291cmNlU2lkZWJhclBh bmVsIGV4dGVuZHMgV2ViSW5zcGVjCiAKICAgICBjbG9zZWQoKQogICAgIHsKKyAgICAgICAgc3Vw ZXIuY2xvc2VkKCk7CisKICAgICAgICAgV2ViSW5zcGVjdG9yLkZyYW1lLnJlbW92ZUV2ZW50TGlz dGVuZXIobnVsbCwgbnVsbCwgdGhpcyk7CiAgICAgICAgIFdlYkluc3BlY3Rvci5mcmFtZVJlc291 cmNlTWFuYWdlci5yZW1vdmVFdmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOwogICAgICAg ICBXZWJJbnNwZWN0b3IuZGVidWdnZXJNYW5hZ2VyLnJlbW92ZUV2ZW50TGlzdGVuZXIobnVsbCwg bnVsbCwgdGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9TZWFyY2hTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hTaWRlYmFyUGFuZWwuanMKaW5kZXggZTE0Njc1MWJl YTBlN2EzZTI4NjI3ZmE0Yjc3MTVmMGU3NTU1MmVjYS4uN2ZkNjJhYWFmYWFjN2UxOTMzZjQ5MmE4 YzFjNGNhOGNiNDViMThiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFNpZGViYXJQYW5lbC5qcwpAQCAtNjQs NiArNjQsOCBAQCBXZWJJbnNwZWN0b3IuU2VhcmNoU2lkZWJhclBhbmVsID0gY2xhc3MgU2VhcmNo U2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjdG9yLgogCiAgICAgY2xvc2VkKCkKICAgICB7 CisgICAgICAgIHN1cGVyLmNsb3NlZCgpOworCiAgICAgICAgIFdlYkluc3BlY3Rvci5GcmFtZS5y ZW1vdmVFdmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOwogICAgIH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFnZVNpZGVi YXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N0 b3JhZ2VTaWRlYmFyUGFuZWwuanMKaW5kZXggNzM4ZTc3NWUwMTE3MGUxZGQzOTMzMGU1YWE5Zjlk OGQwOTAyMzdkOS4uMWFjNmU3MzNiMmZjN2E3NDFjNTBjYjIyZGQ1MWNiZDgxOTE3ZjE0NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFn ZVNpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9TdG9yYWdlU2lkZWJhclBhbmVsLmpzCkBAIC04NSw2ICs4NSw4IEBAIFdlYkluc3Bl Y3Rvci5TdG9yYWdlU2lkZWJhclBhbmVsID0gY2xhc3MgU3RvcmFnZVNpZGViYXJQYW5lbCBleHRl bmRzIFdlYkluc3BlY3RvCiAKICAgICBjbG9zZWQoKQogICAgIHsKKyAgICAgICAgc3VwZXIuY2xv c2VkKCk7CisKICAgICAgICAgV2ViSW5zcGVjdG9yLnN0b3JhZ2VNYW5hZ2VyLnJlbW92ZUV2ZW50 TGlzdGVuZXIobnVsbCwgbnVsbCwgdGhpcyk7CiAgICAgICAgIFdlYkluc3BlY3Rvci5hcHBsaWNh dGlvbkNhY2hlTWFuYWdlci5yZW1vdmVFdmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOwog ICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKaW5kZXggNzhiMzZiZDI4OWMy OGI2M2IxZmFlZjg5YzUwYmNkNTQ1Y2VkZDU0ZS4uOTAxNWM0ZWM2N2E1ZWQzMTViMTlhNTZiNmE3 NWU2ODhkNDRmZmMxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKQEAgLTE1 Niw2ICsxNTYsOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwgPSBjbGFzcyBU aW1lbGluZVNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogCiAgICAgY2xvc2VkKCkKICAg ICB7CisgICAgICAgIHN1cGVyLmNsb3NlZCgpOworCiAgICAgICAgIFdlYkluc3BlY3Rvci5zaG93 UmVwbGF5SW50ZXJmYWNlU2V0dGluZy5yZW1vdmVFdmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRo aXMpOwogICAgICAgICBXZWJJbnNwZWN0b3IucmVwbGF5TWFuYWdlci5yZW1vdmVFdmVudExpc3Rl bmVyKG51bGwsIG51bGwsIHRoaXMpOwogICAgICAgICBXZWJJbnNwZWN0b3IudGltZWxpbmVNYW5h Z2VyLnJlbW92ZUV2ZW50TGlzdGVuZXIobnVsbCwgbnVsbCwgdGhpcyk7Cg==