144516 2015-05-02 00:54:42 -0700 Generated static StringImpls should have static flag set. 2015-05-02 15:58:09 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified REOPENED Performance P2 Normal --- 144534 1 kling kling benjamin cmarcelo commit-queue oldest_to_newest 1091055 0 kling 2015-05-02 00:54:42 -0700 Looks like strings generated by StaticString.pm don't actually get the static flag set on them. 1091056 1 252222 kling 2015-05-02 00:55:17 -0700 Created attachment 252222 Patch 1091134 2 252222 commit-queue 2015-05-02 13:57:16 -0700 Comment on attachment 252222 Patch Clearing flags on attachment: 252222 Committed r183722: <http://trac.webkit.org/changeset/183722> 1091135 3 commit-queue 2015-05-02 13:57:22 -0700 All reviewed patches have been landed. Closing bug. 1091152 4 ap 2015-05-02 15:54:21 -0700 This made all the tests assert: https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r183722%20(12448)/results.html 1091154 5 commit-queue 2015-05-02 15:58:09 -0700 Re-opened since this is blocked by bug 144534 252222 2015-05-02 00:55:17 -0700 2015-05-02 13:57:16 -0700 Patch bug-144516.diff text/plain 1489 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYTVkNDM5NC4uNWM5Y2QzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNS0wNS0wMiAg QW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKKyAgICAgICAgR2VuZXJhdGVkIHN0 YXRpYyBTdHJpbmdJbXBscyBzaG91bGQgaGF2ZSBzdGF0aWMgZmxhZyBzZXQuCisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xNDQ1MTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRGlzY292ZXJlZCB0aGlzIHdoaWxlIHRyYWNraW5nIGRvd24g YSBzdHJpbmcgcmVmIGxlYWsuIFR1cm5zIG91dCB0aGF0IHRoZSBzdHJpbmdzCisgICAgICAgIGdl bmVyYXRlZCBieSBTdGF0aWNTdHJpbmcucG0gd2VyZSBub3QgZ2V0dGluZyB0aGUgc3RhdGljIGZs YWcgc2V0IG9uIHRoZW0uCisKKyAgICAgICAgVGhlIG9ubHkgcHJhY3RpY2FsIGRpZmZlcmVuY2Ug ZnJvbSB0aGlzIEFGQUlDVCBpcyB0aGF0IG5vdyB0aGUgZ2FyYmFnZSBjb2xsZWN0b3IKKyAgICAg ICAgd2lsbCBjb3JyZWN0bHkgc2VlIHRoYXQgdGhlc2Ugc3RyaW5ncyBoYXZlIG5vIGV4dHJhIG1l bW9yeSBjb3N0IHRvIHdvcnJ5IGFib3V0LgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nSW1w bC5oOgorCiAyMDE1LTA1LTAxICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNv bT4KIAogICAgICAgICBVU0UoLi4uKSBtYWNybyBzaG91bGQgZXhwZWN0IHVucHJlZml4ZWQgdmFy aWFibGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaCBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCmluZGV4IGRjMjJiZDAuLjA2MjgzMzcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCkBAIC04OTIsNyArODkyLDcgQEAgcHVibGljOgogICAg ICAgICB1bnNpZ25lZCBtX2hhc2hBbmRGbGFnczsKIAogICAgICAgICAvLyBUaGVzZSB2YWx1ZXMg bWltaWMgQ29uc3RydWN0RnJvbUxpdGVyYWwuCi0gICAgICAgIHN0YXRpYyBjb25zdCB1bnNpZ25l ZCBzX2luaXRpYWxSZWZDb3VudCA9IHNfcmVmQ291bnRJbmNyZW1lbnQ7CisgICAgICAgIHN0YXRp YyBjb25zdCB1bnNpZ25lZCBzX2luaXRpYWxSZWZDb3VudCA9IHNfcmVmQ291bnRGbGFnSXNTdGF0 aWNTdHJpbmc7CiAgICAgICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBzX2luaXRpYWxGbGFncyA9 IHNfaGFzaEZsYWc4Qml0QnVmZmVyIHwgU3RyaW5nTm9ybWFsIHwgQnVmZmVySW50ZXJuYWw7CiAg ICAgICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBzX2hhc2hTaGlmdCA9IHNfZmxhZ0NvdW50Owog ICAgIH07Cg==