144510 2015-05-01 17:30:14 -0700 Expose API in WKBackForwardListRef for removing a back forward list item 2015-05-04 16:18:11 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 adachan adachan andersca ap beidson commit-queue mitz sam thorton oldest_to_newest 1090996 0 adachan 2015-05-01 17:30:14 -0700 There's currently no method to remove an item in WebBackForwardList, so we'll have to add one. This is needed for <rdar://problem/20681226> 1091537 1 252336 adachan 2015-05-04 15:02:15 -0700 Created attachment 252336 Patch 1091540 2 commit-queue 2015-05-04 15:05:55 -0700 Attachment 252336 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebBackForwardList.cpp:328: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1091554 3 252336 beidson 2015-05-04 15:31:46 -0700 Comment on attachment 252336 Patch We feel that the WebBackForwardList in WK1 being mutable by the client was a mistake and therefore we've willfully *not* added any mutability to the WK2 list. It's been asked multiple times, but we've always found a different solution for whoever has needed it. Can you describe more why we *have* to do this? 1091586 4 adachan 2015-05-04 16:18:11 -0700 We'll try to accomplish what we need without this change. Closing the bug. 252336 2015-05-04 15:02:15 -0700 2015-05-04 15:31:46 -0700 Patch 0001-Add-C-API-for-removing-a-back-forward-list-item.patch text/plain 5700 adachan RnJvbSBmY2U4ZGExOWU1YjkyYjliZTg4NzQ1M2E5YzdiMGUxMzkyOTM1M2EyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IE1v biwgNCBNYXkgMjAxNSAxNDo1Nzo0OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBDIEFQSSBm b3IgcmVtb3ZpbmcgYSBiYWNrIGZvcndhcmQgbGlzdCBpdGVtLgogaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDUxMAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgpUaGUgaW1wbGVtZW50YXRpb24gaXMgbW9kZWxlZCBhZnRlciB0aGUgV2ViQ29yZSdzIEJhY2tG b3J3YXJkTGlzdDo6cmVtb3ZlSXRlbSgpLgoKKiBVSVByb2Nlc3MvQVBJL0MvV0tCYWNrRm9yd2Fy ZExpc3RSZWYuY3BwOgooV0tCYWNrRm9yd2FyZExpc3RSZW1vdmVJdGVtKToKKiBVSVByb2Nlc3Mv QVBJL0MvV0tCYWNrRm9yd2FyZExpc3RSZWYuaDoKKiBVSVByb2Nlc3MvV2ViQmFja0ZvcndhcmRM aXN0LmNwcDoKKFdlYktpdDo6V2ViQmFja0ZvcndhcmRMaXN0OjpyZW1vdmVJdGVtKToKQmFpbCBl YXJseSBpZiB0aGUgaXRlbSBpcyBudWxsLiBPdGhlcndpc2UsIGxvb2sgZm9yIGl0IGluIG1fZW50 cmllcy4gQmFpbCBpZiBpdCBjYW5ub3QKYmUgZm91bmQuIE90aGVyd2lzZSwgY2hlY2sgd2hldGhl ciB3ZSBuZWVkIHRvIHVwZGF0ZSBtX2N1cnJlbnRJbmRleCBhbmQgbV9oYXNDdXJyZW50SW5kZXgu CiogVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5oOgotLS0KIFNvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTggKysrKysrKysrKysrCiAuLi4v VUlQcm9jZXNzL0FQSS9DL1dLQmFja0ZvcndhcmRMaXN0UmVmLmNwcCAgICAgICB8ICA1ICsrKysK IC4uLi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0JhY2tGb3J3YXJkTGlzdFJlZi5oIHwgIDEg KwogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5jcHAgICAgfCAz NCArKysrKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQmFj a0ZvcndhcmRMaXN0LmggICAgICB8ICAxICsKIDUgZmlsZXMgY2hhbmdlZCwgNTkgaW5zZXJ0aW9u cygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwppbmRleCBjYzMzMjRkLi43M2JjNjdmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjEgQEAKKzIwMTUtMDUtMDQgIEFkYSBDaGFuICA8YWRhY2hhbkBhcHBsZS5jb20+CisKKyAg ICAgICAgQWRkIEMgQVBJIGZvciByZW1vdmluZyBhIGJhY2sgZm9yd2FyZCBsaXN0IGl0ZW0uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ1MTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgaW1wbGVt ZW50YXRpb24gaXMgbW9kZWxlZCBhZnRlciB0aGUgV2ViQ29yZSdzIEJhY2tGb3J3YXJkTGlzdDo6 cmVtb3ZlSXRlbSgpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQmFja0ZvcndhcmRM aXN0UmVmLmNwcDoKKyAgICAgICAgKFdLQmFja0ZvcndhcmRMaXN0UmVtb3ZlSXRlbSk6CisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQmFja0ZvcndhcmRMaXN0UmVmLmg6CisgICAgICAgICog VUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkJh Y2tGb3J3YXJkTGlzdDo6cmVtb3ZlSXRlbSk6CisgICAgICAgIEJhaWwgZWFybHkgaWYgdGhlIGl0 ZW0gaXMgbnVsbC4gT3RoZXJ3aXNlLCBsb29rIGZvciBpdCBpbiBtX2VudHJpZXMuIEJhaWwgaWYg aXQgY2Fubm90CisgICAgICAgIGJlIGZvdW5kLiBPdGhlcndpc2UsIGNoZWNrIHdoZXRoZXIgd2Ug bmVlZCB0byB1cGRhdGUgbV9jdXJyZW50SW5kZXggYW5kIG1faGFzQ3VycmVudEluZGV4LgorICAg ICAgICAqIFVJUHJvY2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuaDoKKwogMjAxNS0wNS0wNCAgQW50 dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgTmV0d29yayBDYWNoZTog U3VwcG9ydCB0aW1lIGJhc2VkIGNhY2hlIGNsZWFyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tCYWNrRm9yd2FyZExpc3RSZWYuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQmFja0ZvcndhcmRMaXN0UmVmLmNwcAppbmRleCA0YmU3 ZmMzLi42YWMxMjkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mv V0tCYWNrRm9yd2FyZExpc3RSZWYuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQy9XS0JhY2tGb3J3YXJkTGlzdFJlZi5jcHAKQEAgLTU3LDYgKzU3LDExIEBAIFdLQmFja0Zv cndhcmRMaXN0SXRlbVJlZiBXS0JhY2tGb3J3YXJkTGlzdEdldEl0ZW1BdEluZGV4KFdLQmFja0Zv cndhcmRMaXN0UmVmIGxpCiAgICAgcmV0dXJuIHRvQVBJKHRvSW1wbChsaXN0UmVmKS0+aXRlbUF0 SW5kZXgoaW5kZXgpKTsKIH0KIAordm9pZCBXS0JhY2tGb3J3YXJkTGlzdFJlbW92ZUl0ZW0oV0tC YWNrRm9yd2FyZExpc3RSZWYgbGlzdFJlZiwgV0tCYWNrRm9yd2FyZExpc3RJdGVtUmVmIGl0ZW1S ZWYpCit7CisgICAgdG9JbXBsKGxpc3RSZWYpLT5yZW1vdmVJdGVtKHRvSW1wbChpdGVtUmVmKSk7 Cit9CisKIHZvaWQgV0tCYWNrRm9yd2FyZExpc3RDbGVhcihXS0JhY2tGb3J3YXJkTGlzdFJlZiBs aXN0UmVmKQogewogICAgIHRvSW1wbChsaXN0UmVmKS0+Y2xlYXIoKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0JhY2tGb3J3YXJkTGlzdFJlZi5oIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQmFja0ZvcndhcmRMaXN0UmVmLmgKaW5kZXgg OTdiMjIwOS4uMGQ3MjFlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9DL1dLQmFja0ZvcndhcmRMaXN0UmVmLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9DL1dLQmFja0ZvcndhcmRMaXN0UmVmLmgKQEAgLTM5LDYgKzM5LDcgQEAgV0tfRVhQT1JU IFdLQmFja0ZvcndhcmRMaXN0SXRlbVJlZiBXS0JhY2tGb3J3YXJkTGlzdEdldEJhY2tJdGVtKFdL QmFja0ZvcndhcmRMaXMKIFdLX0VYUE9SVCBXS0JhY2tGb3J3YXJkTGlzdEl0ZW1SZWYgV0tCYWNr Rm9yd2FyZExpc3RHZXRGb3J3YXJkSXRlbShXS0JhY2tGb3J3YXJkTGlzdFJlZiBsaXN0KTsKIFdL X0VYUE9SVCBXS0JhY2tGb3J3YXJkTGlzdEl0ZW1SZWYgV0tCYWNrRm9yd2FyZExpc3RHZXRJdGVt QXRJbmRleChXS0JhY2tGb3J3YXJkTGlzdFJlZiBsaXN0LCBpbnQgaW5kZXgpOwogCitXS19FWFBP UlQgdm9pZCBXS0JhY2tGb3J3YXJkTGlzdFJlbW92ZUl0ZW0oV0tCYWNrRm9yd2FyZExpc3RSZWYg bGlzdCwgV0tCYWNrRm9yd2FyZExpc3RJdGVtUmVmIGl0ZW0pOwogV0tfRVhQT1JUIHZvaWQgV0tC YWNrRm9yd2FyZExpc3RDbGVhcihXS0JhY2tGb3J3YXJkTGlzdFJlZiBsaXN0KTsKIAogV0tfRVhQ T1JUIHVuc2lnbmVkIFdLQmFja0ZvcndhcmRMaXN0R2V0QmFja0xpc3RDb3VudChXS0JhY2tGb3J3 YXJkTGlzdFJlZiBsaXN0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJCYWNrRm9yd2FyZExpc3QuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkJhY2tG b3J3YXJkTGlzdC5jcHAKaW5kZXggZGUyODIxMi4uZDM1NjM5ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5jcHAKQEAgLTMwOCw2ICszMDgsNDAg QEAgUmVmPEFQSTo6QXJyYXk+IFdlYkJhY2tGb3J3YXJkTGlzdDo6Zm9yd2FyZExpc3RBc0FQSUFy cmF5V2l0aExpbWl0KHVuc2lnbmVkIGxpbWkKICAgICByZXR1cm4gQVBJOjpBcnJheTo6Y3JlYXRl KFdURjo6bW92ZSh2ZWN0b3IpKTsKIH0KIAordm9pZCBXZWJCYWNrRm9yd2FyZExpc3Q6OnJlbW92 ZUl0ZW0oV2ViQmFja0ZvcndhcmRMaXN0SXRlbSogYmFja0ZvcndhcmRMaXN0SXRlbSkKK3sKKyAg ICBpZiAoIWJhY2tGb3J3YXJkTGlzdEl0ZW0pCisgICAgICAgIHJldHVybjsKKworICAgIHNpemVf dCBpbmRleCA9IG1fZW50cmllcy5maW5kKGJhY2tGb3J3YXJkTGlzdEl0ZW0pOworICAgIGlmIChp bmRleCA9PSBub3RGb3VuZCkKKyAgICAgICAgcmV0dXJuOworCisgICAgVmVjdG9yPFJlZlB0cjxX ZWJCYWNrRm9yd2FyZExpc3RJdGVtPj4gcmVtb3ZlZEl0ZW1zOworICAgIHJlbW92ZWRJdGVtcy5h cHBlbmQoYmFja0ZvcndhcmRMaXN0SXRlbSk7CisKKyAgICBtX2VudHJpZXMucmVtb3ZlKGluZGV4 KTsKKworICAgIGlmIChtX2hhc0N1cnJlbnRJbmRleCkgeworICAgICAgICBpZiAobV9jdXJyZW50 SW5kZXggPiBpbmRleCkKKyAgICAgICAgICAgIG1fY3VycmVudEluZGV4LS07CisgICAgICAgIGVs c2UgaWYgKG1fY3VycmVudEluZGV4ID09IGluZGV4KXsKKyAgICAgICAgICAgIHNpemVfdCBjb3Vu dCA9IG1fZW50cmllcy5zaXplKCk7CisgICAgICAgICAgICBpZiAobV9jdXJyZW50SW5kZXggPj0g Y291bnQpIHsKKyAgICAgICAgICAgICAgICBpZiAoY291bnQpCisgICAgICAgICAgICAgICAgICAg IG1fY3VycmVudEluZGV4ID0gY291bnQgLSAxOworICAgICAgICAgICAgICAgIGVsc2UgeworICAg ICAgICAgICAgICAgICAgICBtX2hhc0N1cnJlbnRJbmRleCA9IGZhbHNlOworICAgICAgICAgICAg ICAgICAgICBtX2N1cnJlbnRJbmRleCA9IDA7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAg ICAgfQorICAgICAgICB9CisgICAgfQorCisgICAgZGlkUmVtb3ZlSXRlbSgqYmFja0ZvcndhcmRM aXN0SXRlbSk7CisgICAgbV9wYWdlLT5kaWRDaGFuZ2VCYWNrRm9yd2FyZExpc3QobnVsbHB0ciwg V1RGOjptb3ZlKHJlbW92ZWRJdGVtcykpOworfQorCiB2b2lkIFdlYkJhY2tGb3J3YXJkTGlzdDo6 cmVtb3ZlQWxsSXRlbXMoKQogewogICAgIEFTU0VSVCghbV9oYXNDdXJyZW50SW5kZXggfHwgbV9j dXJyZW50SW5kZXggPCBtX2VudHJpZXMuc2l6ZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuaAppbmRleCAxNzhmMDdlLi5lNmZlMzBmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQmFja0ZvcndhcmRMaXN0LmgKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5oCkBAIC01Miw2ICs1 Miw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgYWRkSXRlbShXZWJCYWNrRm9yd2FyZExpc3RJdGVt Kik7CiAgICAgdm9pZCBnb1RvSXRlbShXZWJCYWNrRm9yd2FyZExpc3RJdGVtKik7CisgICAgdm9p ZCByZW1vdmVJdGVtKFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qKTsKICAgICB2b2lkIHJlbW92ZUFs bEl0ZW1zKCk7CiAgICAgdm9pZCBjbGVhcigpOwogCi0tIAoyLjMuMiAoQXBwbGUgR2l0LTU1KQoK