144498 2015-05-01 13:07:03 -0700 Inline some small methods instead of them being EXPORT'd and out of line 2015-05-01 17:01:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue darin oldest_to_newest 1090867 0 joepeck 2015-05-01 13:07:03 -0700 * SUMMARY Inline some small methods instead of them being EXPORT'd and out of line. The EXPORT should not be needed if the methods are inlined. 1090868 1 252167 joepeck 2015-05-01 13:07:52 -0700 Created attachment 252167 [PATCH] Proposed Fix 1090946 2 252167 darin 2015-05-01 16:12:01 -0700 Comment on attachment 252167 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=252167&action=review > Source/WebCore/page/Page.h:443 > + RefPtr<WheelEventTestTrigger> testTrigger() const { return m_testTrigger; } Reading this I realize that this accessor should return a raw pointer, not a RefPtr. 1090984 3 252167 commit-queue 2015-05-01 17:01:16 -0700 Comment on attachment 252167 [PATCH] Proposed Fix Clearing flags on attachment: 252167 Committed r183700: <http://trac.webkit.org/changeset/183700> 1090985 4 commit-queue 2015-05-01 17:01:20 -0700 All reviewed patches have been landed. Closing bug. 252167 2015-05-01 13:07:52 -0700 2015-05-01 17:01:16 -0700 [PATCH] Proposed Fix inline.patch text/plain 2345 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YTUxODIyLi41Zjg4NWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTUtMDUtMDEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBJbmxpbmUgc29tZSBzbWFsbCBtZXRob2RzIGluc3RlYWQgb2YgdGhlbSBiZWluZyBF WFBPUlQnZCBhbmQgb3V0IG9mIGxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NDQ5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6 OnRlc3RUcmlnZ2VyKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OmNsZWFyVHJp Z2dlcik6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpleHBlY3RzV2hlZWxFdmVu dFRyaWdnZXJzKTogRGVsZXRlZC4KKyAgICAgICAgKiBwYWdlL1BhZ2UuaDoKKyAgICAgICAgKFdl YkNvcmU6OlBhZ2U6OnRlc3RUcmlnZ2VyKToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OmNsZWFy VHJpZ2dlcik6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpleHBlY3RzV2hlZWxFdmVudFRyaWdn ZXJzKToKKwogMjAxNS0wNS0wMSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIEFQSSB0byBkaXNhYmxlIG1ldGEgcmVmcmVzaGVzLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5j cHAKaW5kZXggODQ5YjhhMC4uMTRkOTJkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9QYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC0xNzI1LDEx ICsxNzI1LDYgQEAgdm9pZCBQYWdlOjpzZXRTaG91bGRQbGF5VG9QbGF5YmFja1RhcmdldCh1aW50 NjRfdCBjbGllbnRJZCwgYm9vbCBzaG91bGRQbGF5KQogfQogI2VuZGlmCiAKLVJlZlB0cjxXaGVl bEV2ZW50VGVzdFRyaWdnZXI+IFBhZ2U6OnRlc3RUcmlnZ2VyKCkgY29uc3QKLXsKLSAgICByZXR1 cm4gbV90ZXN0VHJpZ2dlcjsKLX0KLQogV2hlZWxFdmVudFRlc3RUcmlnZ2VyJiBQYWdlOjplbnN1 cmVUZXN0VHJpZ2dlcigpCiB7CiAgICAgaWYgKCFtX3Rlc3RUcmlnZ2VyKQpAQCAtMTczOCwxNCAr MTczMyw0IEBAIFdoZWVsRXZlbnRUZXN0VHJpZ2dlciYgUGFnZTo6ZW5zdXJlVGVzdFRyaWdnZXIo KQogICAgIHJldHVybiAqbV90ZXN0VHJpZ2dlcjsKIH0KIAotdm9pZCBQYWdlOjpjbGVhclRyaWdn ZXIoKQotewotICAgIG1fdGVzdFRyaWdnZXIgPSBudWxscHRyOwotfQotCi1ib29sIFBhZ2U6OmV4 cGVjdHNXaGVlbEV2ZW50VHJpZ2dlcnMoKSBjb25zdAotewotICAgIHJldHVybiAhIW1fdGVzdFRy aWdnZXI7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUGFnZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKaW5kZXggNGEw N2EwYS4uZDAzMGI0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKQEAgLTQ0MCwxMCArNDQwLDEwIEBAIHB1Ymxp YzoKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHNldFNob3VsZFBsYXlUb1BsYXliYWNrVGFyZ2V0 KHVpbnQ2NF90LCBib29sKTsKICNlbmRpZgogCi0gICAgV0VCQ09SRV9FWFBPUlQgUmVmUHRyPFdo ZWVsRXZlbnRUZXN0VHJpZ2dlcj4gdGVzdFRyaWdnZXIoKSBjb25zdDsKKyAgICBSZWZQdHI8V2hl ZWxFdmVudFRlc3RUcmlnZ2VyPiB0ZXN0VHJpZ2dlcigpIGNvbnN0IHsgcmV0dXJuIG1fdGVzdFRy aWdnZXI7IH0KICAgICBXRUJDT1JFX0VYUE9SVCBXaGVlbEV2ZW50VGVzdFRyaWdnZXImIGVuc3Vy ZVRlc3RUcmlnZ2VyKCk7Ci0gICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBjbGVhclRyaWdnZXIoKTsK LSAgICBXRUJDT1JFX0VYUE9SVCBib29sIGV4cGVjdHNXaGVlbEV2ZW50VHJpZ2dlcnMoKSBjb25z dDsKKyAgICB2b2lkIGNsZWFyVHJpZ2dlcigpIHsgbV90ZXN0VHJpZ2dlciA9IG51bGxwdHI7IH0K KyAgICBib29sIGV4cGVjdHNXaGVlbEV2ZW50VHJpZ2dlcnMoKSBjb25zdCB7IHJldHVybiAhIW1f dGVzdFRyaWdnZXI7IH0KIAogcHJpdmF0ZToKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGluaXRH cm91cCgpOwo=