144493 2015-05-01 10:38:29 -0700 Stop using deprecated AVKit SPI for enter and exit fullscreen. 2015-05-01 14:19:25 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue eric.carlson jer.noble oldest_to_newest 1090821 0 jeremyj-wk 2015-05-01 10:38:29 -0700 Stop using deprecated AVKit SPI for enter and exit fullscreen. 1090822 1 jeremyj-wk 2015-05-01 10:41:06 -0700 rdar://problem/20733676 1090823 2 252157 jeremyj-wk 2015-05-01 10:42:20 -0700 Created attachment 252157 Patch 1090824 3 commit-queue 2015-05-01 10:44:17 -0700 Attachment 252157 did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1043: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1098: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1090879 4 252157 commit-queue 2015-05-01 14:19:22 -0700 Comment on attachment 252157 Patch Clearing flags on attachment: 252157 Committed r183690: <http://trac.webkit.org/changeset/183690> 1090880 5 commit-queue 2015-05-01 14:19:25 -0700 All reviewed patches have been landed. Closing bug. 252157 2015-05-01 10:42:20 -0700 2015-05-01 14:19:22 -0700 Patch bug-144493-20150501104109.patch text/plain 3981 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWRhZjBkY2VhZjYzYWNj MzE5NWVhODVhNGRhYjNkNDc2ZDc1NGIxMC4uNjAyYzQ5MjdiYzI0YjA3M2QxOTI4MTFhYWExOTRl OGMwNWYxNDVjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA1LTAxICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBTdG9wIHVzaW5nIGRlcHJl Y2F0ZWQgQVZLaXQgU1BJIGZvciBlbnRlciBhbmQgZXhpdCBmdWxsc2NyZWVuLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NDkzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSAKKyAgICAgICAg ICAgIC1lbnRlckZ1bGxTY3JlZW5XaXRoQ29tcGxldGlvbkhhbmRsZXI6CisgICAgICAgICAgICAt ZXhpdEZ1bGxTY3JlZW5XaXRoQ29tcGxldGlvbkhhbmRsZXI6CisgICAgICAgIHdpdGgKKyAgICAg ICAgICAgIC1lbnRlckZ1bGxTY3JlZW5BbmltYXRlZDpjb21wbGV0aW9uSGFuZGxlcjoKKyAgICAg ICAgICAgIC1leGl0RnVsbFNjcmVlbkFuaW1hdGVkOmNvbXBsZXRpb25IYW5kbGVyOgorICAgICAg ICAKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZL aXQubW06CisgICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZW50ZXJG dWxsc2NyZWVuU3RhbmRhcmQpOgorICAgICAgICAoV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNl QVZLaXQ6OmV4aXRGdWxsc2NyZWVuSW50ZXJuYWwpOgorICAgICAgICAqIHBsYXRmb3JtL3NwaS9j b2NvYS9BVktpdFNQSS5oOgorCiAyMDE1LTA1LTAxICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5z b25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbRnJlZXR5cGVdIEFkZCBzdXBwb3J0IGZvciB0aGUg Zm9udC1zeW50aGVzaXMgcHJvcGVydHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQppbmRl eCA5MDMwODllN2MwOTU3ZDU3MDFkOTNmOTIzNjRjZjNmYmMwZjUxODY4Li40NTg0MTMzMmZhZTFk YzEyOTJlNjVlNWI4OGI5OTQ4YTE4MjVmNmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0 Lm1tCkBAIC0xMDQwLDcgKzEwNDAsNyBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFj ZUFWS2l0OjplbnRlckZ1bGxzY3JlZW5TdGFuZGFyZCgpCiB7CiAgICAgTE9HKEZ1bGxzY3JlZW4s ICJXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZW50ZXJGdWxsc2NyZWVuU3RhbmRh cmQoJXApIiwgdGhpcyk7CiAgICAgUmVmUHRyPFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFW S2l0PiBzdHJvbmdUaGlzKHRoaXMpOwotICAgIFttX3BsYXllclZpZXdDb250cm9sbGVyIGVudGVy RnVsbFNjcmVlbldpdGhDb21wbGV0aW9uSGFuZGxlcjpbdGhpcywgc3Ryb25nVGhpc10gKEJPT0wg c3VjY2VlZGVkLCBOU0Vycm9yKikgeworICAgIFttX3BsYXllclZpZXdDb250cm9sbGVyIGVudGVy RnVsbFNjcmVlbkFuaW1hdGVkOllFUyBjb21wbGV0aW9uSGFuZGxlcjpbdGhpcywgc3Ryb25nVGhp c10gKEJPT0wgc3VjY2VlZGVkLCBOU0Vycm9yKikgewogICAgICAgICBVTlVTRURfUEFSQU0oc3Vj Y2VlZGVkKTsKICAgICAgICAgTE9HKEZ1bGxzY3JlZW4sICJXZWJWaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VBVktpdDo6ZW50ZXJGdWxsc2NyZWVuU3RhbmRhcmQgLSBsYW1iZGEoJXApIC0gc3VjY2Vl ZGVkKCVzKSIsIHRoaXMsIGJvb2xTdHJpbmcoc3VjY2VlZGVkKSk7CiAgICAgICAgIFttX3BsYXll clZpZXdDb250cm9sbGVyIHNldFNob3dzUGxheWJhY2tDb250cm9sczpZRVNdOwpAQCAtMTA5NSw3 ICsxMDk1LDcgQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZXhpdEZ1 bGxzY3JlZW5JbnRlcm5hbChjb25zdCBXZWJDb3JlOjpJbnQKICAgICAgICAgfV07CiAgICAgfSBl bHNlIGlmIChpc01vZGUoSFRNTE1lZGlhRWxlbWVudDo6VmlkZW9GdWxsc2NyZWVuTW9kZVN0YW5k YXJkKSkgewogICAgICAgICBSZWZQdHI8V2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ+ IHN0cm9uZ1RoaXModGhpcyk7Ci0gICAgICAgIFttX3BsYXllclZpZXdDb250cm9sbGVyIGV4aXRG dWxsU2NyZWVuV2l0aENvbXBsZXRpb25IYW5kbGVyOltzdHJvbmdUaGlzXSAoQk9PTCwgTlNFcnJv ciopIHsKKyAgICAgICAgW21fcGxheWVyVmlld0NvbnRyb2xsZXIgZXhpdEZ1bGxTY3JlZW5Bbmlt YXRlZDpZRVMgY29tcGxldGlvbkhhbmRsZXI6W3N0cm9uZ1RoaXNdIChCT09MLCBOU0Vycm9yKikg ewogICAgICAgICAgICAgc3Ryb25nVGhpcy0+bV9leGl0Q29tcGxldGVkID0gdHJ1ZTsKIAogICAg ICAgICAgICAgW0NBVHJhbnNhY3Rpb24gYmVnaW5dOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vc3BpL2NvY29hL0FWS2l0U1BJLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9zcGkvY29jb2EvQVZLaXRTUEkuaAppbmRleCA5ZmNhNDg1NDZhOTMzZGVlNjhiNDc2NjEwOTQ4 NmFjY2M4ZGFlMTQzLi4wYzUxYWViZGQ2MjQ4ZmViYmIyN2YwYTlkMWE1Y2QzZTMxODBmZmE4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvQVZLaXRTUEkuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvQVZLaXRTUEkuaApAQCAtODUs OSArODUsOCBAQCB0eXBlZGVmIE5TSW50ZWdlciBBVlBsYXllclZpZXdDb250cm9sbGVyT3B0aW1p emVkRnVsbHNjcmVlblN0b3BSZWFzb247CiAKIEBpbnRlcmZhY2UgQVZQbGF5ZXJWaWV3Q29udHJv bGxlciAoRGV0YWlscykKIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aFZpZGVvTGF5ZXI6KENBTGF5 ZXIgPEFWVmlkZW9MYXllcj4gKil2aWRlb0xheWVyOwotLSAodm9pZCllbnRlckZ1bGxTY3JlZW5X aXRoQ29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKEJPT0wgc3VjY2VzcywgTlNFcnJvciAqKSlj b21wbGV0aW9uSGFuZGxlcjsKKy0gKHZvaWQpZW50ZXJGdWxsU2NyZWVuQW5pbWF0ZWQ6KEJPT0wp YW5pbWF0ZWQgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKEJPT0wgc3VjY2VzcywgTlNFcnJv ciAqKSljb21wbGV0aW9uSGFuZGxlcjsKIC0gKHZvaWQpZXhpdEZ1bGxTY3JlZW5BbmltYXRlZDoo Qk9PTClhbmltYXRlZCBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoQk9PTCBzdWNjZXNzLCBO U0Vycm9yICopKWNvbXBsZXRpb25IYW5kbGVyOwotLSAodm9pZClleGl0RnVsbFNjcmVlbldpdGhD b21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoQk9PTCBzdWNjZXNzLCBOU0Vycm9yICopKWNvbXBs ZXRpb25IYW5kbGVyOwogCiAtICh2b2lkKXN0YXJ0T3B0aW1pemVkRnVsbHNjcmVlbjsKIC0gKHZv aWQpc3RhcnRPcHRpbWl6ZWRGdWxsc2NyZWVuV2l0aFN0YXJ0Q29tcGxldGlvbkhhbmRsZXI6KHZv aWQgKF4pKEJPT0wgc3VjY2VzcywgTlNFcnJvciopKXN0YXJ0Q29tcGxldGlvbkhhbmRsZXIgc3Rv cENvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShBVlBsYXllclZpZXdDb250cm9sbGVyT3B0aW1p emVkRnVsbHNjcmVlblN0b3BSZWFzb24pKXN0b3BDb21wbGV0aW9uSGFuZGxlcjsK