144481 2015-04-30 17:57:04 -0700 AX: [ATK] REGRESSION: accessibility/canvas-fallback-content.html now crashes 2015-05-01 10:07:13 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig mario samuel_white webkit-bug-importer oldest_to_newest 1090681 0 jdiggs 2015-04-30 17:57:04 -0700 See bug 142719 comment 139. STDERR: ASSERTION FAILED: !needsStyleRecalc() || !document().childNeedsStyleRecalc() STDERR: ../../Source/WebCore/dom/Element.cpp(483) : virtual bool WebCore::Element::isFocusable() const STDERR: 1 0x7f7200253b8e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7f7200253b8e] STDERR: 2 0x7f7205e48abd /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Element::isFocusable() const+0xbf) [0x7f7205e48abd] STDERR: 3 0x7f7205a97754 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AccessibilityNodeObject::determineAccessibilityRole()+0x456) [0x7f7205a97754] STDERR: 4 0x7f7205a96abf /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AccessibilityNodeObject::init()+0x5d) [0x7f7205a96abf] STDERR: 5 0x7f7205a73b50 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AXObjectCache::getOrCreate(WebCore::Node*)+0x2b4) [0x7f7205a73b50] STDERR: 6 0x7f7206c26681 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged(WebCore::Node*, WebCore::Node*)+0xb7) [0x7f7206c26681] STDERR: 7 0x7f7205a756c6 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AXObjectCache::handleFocusedUIElementChanged(WebCore::Node*, WebCore::Node*)+0x3e) [0x7f7205a756c6] STDERR: 8 0x7f7205deb6cc /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Document::setFocusedElement(WTF::PassRefPtr<WebCore::Element>, WebCore::FocusDirection)+0x80e) [0x7f7205deb6cc] STDERR: 9 0x7f7206431844 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::FocusController::setFocusedElement(WebCore::Element*, WTF::PassRefPtr<WebCore::Frame>, WebCore::FocusDirection)+0x43e) [0x7f7206431844] STDERR: 10 0x7f7205e4fa9d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Element::focus(bool, WebCore::FocusDirection)+0x14f) [0x7f7205e4fa9d] STDERR: 11 0x7f7206e7c3d7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::jsElementPrototypeFunctionFocus(JSC::ExecState*)+0x158) [0x7f7206e7c3d7] STDERR: 12 0x7f71a9fff0a8 [0x7f71a9fff0a8] 1090682 1 webkit-bug-importer 2015-04-30 17:57:17 -0700 <rdar://problem/20774263> 1090710 2 jdiggs 2015-04-30 19:11:48 -0700 Removing the associated commit. I just took a look at earlier builds and it seems this was crashing at least as far back r172891 (1488) -- the earliest one in the list of results. So it's hard to say when this broke. 1090730 3 252135 jdiggs 2015-05-01 00:09:05 -0700 Created attachment 252135 Patch 1090767 4 jdiggs 2015-05-01 06:34:20 -0700 Chris or Mario: If you have time for a review, it would be great. Thanks! (It's a tiny patch.) 1090811 5 252135 commit-queue 2015-05-01 10:07:08 -0700 Comment on attachment 252135 Patch Clearing flags on attachment: 252135 Committed r183678: <http://trac.webkit.org/changeset/183678> 1090813 6 commit-queue 2015-05-01 10:07:13 -0700 All reviewed patches have been landed. Closing bug. 252135 2015-05-01 00:09:05 -0700 2015-05-01 10:07:08 -0700 Patch bug-144481-20150501030753.patch text/plain 1894 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODlkOThiNDQ2ZGE0MWJl Njc4ZjkwYmFlODFiMWEzNTZhNmE0NDYzZS4uMmFjMTUyZDFjODJiY2Y4M2VlZTY0NzkzYzUzOTQ4 YzI4ZmM3Nzc2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA0LTMwICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogW0FUS10gUkVH UkVTU0lPTjogYWNjZXNzaWJpbGl0eS9jYW52YXMtZmFsbGJhY2stY29udGVudC5odG1sIG5vdyBj cmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDQ0ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD YW52YXMgZmFsbGJhY2sgY29udGVudCBpcyBhbGxvd2VkIHRvIGJlIGZvY3VzYWJsZSBpZiB0aGUg Y2FudmFzIGlzIGRpc3BsYXllZAorICAgICAgICBhbmQgdmlzaWJsZS4gVXBkYXRlIHRoZSBzdHls ZSB3aGVuIGNyZWF0aW5nIGFuIGFjY2Vzc2libGUgb2JqZWN0IGZvciBhIG5vZGUgaW4KKyAgICAg ICAgYSBjYW52YXMgc3VidHJlZSBhbmQgYmVmb3JlIEVsZW1lbnQ6OmlzRm9jdXNhYmxlKCkgZ2V0 cyBjYWxsZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGUgZXhpc3RpbmcsIGNyYXNoaW5n IHRlc3Qgbm8gbG9uZ2VyIGNyYXNoZXMuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FYT2Jq ZWN0Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Z2V0T3JDcmVh dGUpOgorCiAyMDE1LTA0LTMwICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAog ICAgICAgICBDbGVhbiB1cDogUmVtb3ZlIHVubmVjZXNzYXJ5IHJ1bnRpbWUgY29tcHV0YXRpb24g b2Ygc3RyaW5nIGxlbmd0aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BWE9iamVjdENhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmpl Y3RDYWNoZS5jcHAKaW5kZXggNDNkNTg5MmZlM2YyYjE2MmEyNDlmNmZhYmIyYjdiODhjMGU0YzU5 NC4uN2NmODJlYmQwMDQyZGY1NDM0NWJhOWE5ODJlYmFhMmZjNWFhZjlhZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCkBAIC0zOTcsNiArMzk3 LDExIEBAIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFYT2JqZWN0Q2FjaGU6OmdldE9yQ3JlYXRlKE5v ZGUqIG5vZGUpCiAgICAgaWYgKCFpbkNhbnZhc1N1YnRyZWUgJiYgIWlzSGlkZGVuICYmICFpbnNp ZGVNZXRlckVsZW1lbnQpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCisgICAgLy8gRmFsbGJh Y2sgY29udGVudCBpcyBvbmx5IGZvY3VzYWJsZSBhcyBsb25nIGFzIHRoZSBjYW52YXMgaXMgZGlz cGxheWVkIGFuZCB2aXNpYmxlLgorICAgIC8vIFVwZGF0ZSB0aGUgc3R5bGUgYmVmb3JlIEVsZW1l bnQ6OmlzRm9jdXNhYmxlKCkgZ2V0cyBjYWxsZWQuCisgICAgaWYgKGluQ2FudmFzU3VidHJlZSkK KyAgICAgICAgbm9kZS0+ZG9jdW1lbnQoKS51cGRhdGVTdHlsZUlmTmVlZGVkKCk7CisKICAgICBS ZWZQdHI8QWNjZXNzaWJpbGl0eU9iamVjdD4gbmV3T2JqID0gY3JlYXRlRnJvbU5vZGUobm9kZSk7 CiAKICAgICAvLyBXaWxsIGNyYXNoIGxhdGVyIGlmIHdlIGhhdmUgdHdvIG9iamVjdHMgZm9yIHRo ZSBzYW1lIG5vZGUuCg==