14448 2007-06-28 13:45:49 -0700 HTMLObjectElement::data should return an absolute URL 2008-02-05 08:53:04 -0800 1 1 1 Unclassified WebKit DOM 523.x (Safari 3) All All RESOLVED DUPLICATE 16799 P3 Normal --- 1 fishd fishd oldest_to_newest 5969 0 fishd 2007-06-28 13:45:49 -0700 HTMLObjectElement::data should return an absolute URL The spec says to return an abs URL, Firefox returns an abs URL, but WebKit and IE both return a relative URL when this property is accessed. Based on discussions on #webkit, it sounds like webkit should be changed to return an abs URL. 5954 1 fishd 2007-06-28 16:47:50 -0700 patch w/ testcase coming up... 5949 2 15302 fishd 2007-06-28 19:40:57 -0700 Created attachment 15302 simple patch + testcase This patch is modelled after the code for HTMLImageElement::src(). I changed the FrameLoader::completeURL call to a Document::completeURL as a minor simplification since HTMLObjectElement already has direct access to its Document. 5837 3 15302 darin 2007-06-30 11:42:53 -0700 Comment on attachment 15302 simple patch + testcase Looks good. r=me What about the usemap attribute? 5817 4 fishd 2007-06-30 15:24:58 -0700 Yes, good question. I'll investigate and file a new bug if there are similar changed needed for that. 5820 5 fishd 2007-06-30 15:41:09 -0700 It looks like FF and IE do not return an absolute URL for the DOM useMap property; however, Opera does. 5795 6 mrowe 2007-07-01 07:21:25 -0700 Landed in r23911. 5788 7 mrowe 2007-07-01 08:48:52 -0700 This introduced two test failures: <http://build.webkit.org/results/post-commit-powerpc-mac-os-x/7125/results.html>. I will be rolling it out in a moment as we can't have regressions in the tree. 5789 8 mrowe 2007-07-01 08:54:37 -0700 Rolled out in r23913. Please be sure to run the entire layout test suite when resubmitting an updated patch. 5790 9 fishd 2007-07-01 09:55:25 -0700 It looks like fast/loader/xmlhttprequest-bad-mimetype is still failing even after this patch was rolled back. That just leaves the two instances of object06.html (one for html and one for xhtml). It turns out that both of those tests are actually asserting the opposite of this bug report. They are testing that indeed the HTMLObjectElement's data accessor returns a relative URL instead of an absolute URL! The object06.html test seems to originate from some w3.org test suite. So, does that make this bug invalid?? 5786 10 15302 mrowe 2007-07-01 10:04:35 -0700 Comment on attachment 15302 simple patch + testcase Changing to r- to get this out of the commit queue. 69477 11 fishd 2008-02-05 08:53:04 -0800 *** This bug has been marked as a duplicate of 16799 *** 15302 2007-06-28 19:40:57 -0700 2007-07-01 10:04:35 -0700 simple patch + testcase obj-1.diff text/plain 3862 fishd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzg2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDYtMjggIE1vcmdhbkwgIDxtb3JnYW5sLndlYmtpdEB5YWhv by5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4IGZvciBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ0OAorICAg ICAgICBIVE1MT2JqZWN0RWxlbWVudDo6ZGF0YSBzaG91bGQgcmV0dXJuIGFuIGFic29sdXRlIFVS TAorCisgICAgICAgICogaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpIVE1MT2JqZWN0RWxlbWVudDo6aXNJbWFnZVR5cGUpOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTE9iamVjdEVsZW1lbnQ6OmRhdGEpOgorCiAyMDA3LTA2LTI4ICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVyc3RhbXBlZCBieSBBZGFtIFJvYmVuLgpJbmRl eDogV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2h0bWwvSFRNTE9iamVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiAyMzg2MCkKKysrIFdlYkNv cmUvaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4Nyw3ICsy ODcsNyBAQCBib29sIEhUTUxPYmplY3RFbGVtZW50Ojppc0ltYWdlVHlwZSgpCiAgICAgICAgIH0K ICAgICB9CiAgICAgaWYgKEZyYW1lKiBmcmFtZSA9IGRvY3VtZW50KCktPmZyYW1lKCkpIHsKLSAg ICAgICAgS1VSTCBjb21wbGV0ZWRVUkwoZnJhbWUtPmxvYWRlcigpLT5jb21wbGV0ZVVSTChtX3Vy bCkpOworICAgICAgICBLVVJMIGNvbXBsZXRlZFVSTChkb2N1bWVudCgpLT5jb21wbGV0ZVVSTCht X3VybCkuZGVwcmVjYXRlZFN0cmluZygpKTsKICAgICAgICAgcmV0dXJuIGZyYW1lLT5sb2FkZXIo KS0+Y2xpZW50KCktPm9iamVjdENvbnRlbnRUeXBlKGNvbXBsZXRlZFVSTCwgbV9zZXJ2aWNlVHlw ZSkgPT0gT2JqZWN0Q29udGVudEltYWdlOwogICAgIH0KIApAQCAtMzkyLDcgKzM5Miw3IEBAIHZv aWQgSFRNTE9iamVjdEVsZW1lbnQ6OnNldENvZGVUeXBlKGNvbnMKIAogU3RyaW5nIEhUTUxPYmpl Y3RFbGVtZW50OjpkYXRhKCkgY29uc3QKIHsKLSAgICByZXR1cm4gZ2V0QXR0cmlidXRlKGRhdGFB dHRyKTsKKyAgICByZXR1cm4gZG9jdW1lbnQoKS0+Y29tcGxldGVVUkwoZ2V0QXR0cmlidXRlKGRh dGFBdHRyKSk7CiB9CiAKIHZvaWQgSFRNTE9iamVjdEVsZW1lbnQ6OnNldERhdGEoY29uc3QgU3Ry aW5nJiB2YWx1ZSkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODY0KQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDYtMjggIE1vcmdh bkwgIDxtb3JnYW5sLndlYmtpdEB5YWhvby5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHMgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NDQ4CisgICAgICAgIEhUTUxPYmplY3RFbGVtZW50OjpkYXRhIHNo b3VsZCByZXR1cm4gYW4gYWJzb2x1dGUgVVJMCisKKyAgICAgICAgKiBmYXN0L2RvbS9vYmplY3Qt ZGF0YS1hYnN1cmwtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9vYmpl Y3QtZGF0YS1hYnN1cmwuaHRtbDogQWRkZWQuCisKIDIwMDctMDYtMjggIFNhbSBXZWluaWcgIDxz YW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXJzdGFtcGVkIGJ5IEFkYW0gUm9iZW4uCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9vYmplY3QtZGF0YS1hYnN1cmwtZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL29iamVjdC1kYXRhLWFic3VybC1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9vYmplY3Qt ZGF0YS1hYnN1cmwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYgQEAKK1Ro aXMgdGVzdCBjaGVja3MgdGhhdCB0aGUgZGF0YSBwcm9wZXJ0eSBvZiBhbiBIVE1MT2JqZWN0RWxl bWVudCByZXR1cm5zIGFuIGFic29sdXRlIFVSTC4gU2VlIGJ1ZyAxNDQ0OCBmb3IgcmVmZXJlbmNl LgorCitJZiB0aGUgdGVzdCBwYXNzZXMsIHlvdSBzaG91bGQgc2VlIHRoZSB0ZXh0IFBBU1MgYmVs b3cgdGhlIEFwcGxlIGxvZ28uCisKKworUEFTUwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20v b2JqZWN0LWRhdGEtYWJzdXJsLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9k b20vb2JqZWN0LWRhdGEtYWJzdXJsLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2RvbS9vYmplY3QtZGF0YS1hYnN1cmwuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwz NCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK2Z1bmN0aW9u IGdldEJhc2VVUkwoKSB7CisgICAgdmFyIGhyZWYgPSBkb2N1bWVudC5sb2NhdGlvbi5ocmVmOwor ICAgIHZhciBsYXN0U2xhc2ggPSBocmVmLmxhc3RJbmRleE9mKCIvIik7CisgICAgcmV0dXJuIGhy ZWYuc3Vic3RyaW5nKDAsIGxhc3RTbGFzaCk7Cit9CitmdW5jdGlvbiB0ZXN0KCkgeworICAgIHZh ciByZXN1bHQ7CisgICAgdmFyIHVybCA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJv YmplY3QiKVswXS5kYXRhOworICAgIGlmICh1cmwgPT0gInJlc291cmNlcy9hcHBsZS5naWYiIHx8 IHVybC5pbmRleE9mKGdldEJhc2VVUkwoKSkgIT0gMCkgeworICAgICAgICByZXN1bHQgPSAiRkFJ TCI7CisgICAgfSBlbHNlIHsKKyAgICAgICAgcmVzdWx0ID0gIlBBU1MiOworICAgIH0KKyAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNy ZWF0ZVRleHROb2RlKHJlc3VsdCkpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxv YWQ9InRlc3QoKSI+Cis8cD4KK1RoaXMgdGVzdCBjaGVja3MgdGhhdCB0aGUgPHR0PmRhdGE8L3R0 PiBwcm9wZXJ0eSBvZiBhbiBIVE1MT2JqZWN0RWxlbWVudCByZXR1cm5zIGFuIGFic29sdXRlIFVS TC4KK1NlZSA8YSBocmVmPSJodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDQ0OCI+YnVnIDE0NDQ4PC9hPiBmb3IgcmVmZXJlbmNlLgorPC9wPgorPHA+CitJZiB0aGUgdGVz dCBwYXNzZXMsIHlvdSBzaG91bGQgc2VlIHRoZSB0ZXh0IFBBU1MgYmVsb3cgdGhlIEFwcGxlIGxv Z28uCis8L3A+Cis8b2JqZWN0IGRhdGE9InJlc291cmNlcy9hcHBsZS5naWYiPjwvb2JqZWN0Pgor PGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==