144473 2015-04-30 14:42:03 -0700 Should choose UIScrollView indicatorStyle based on the document background color 2015-04-30 15:08:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue mitz sam simon.fraser thorton oldest_to_newest 1090582 0 bdakin 2015-04-30 14:42:03 -0700 Should choose UIScrollView indicatorStyle based on the document background color rdar://problem/19897699 1090586 1 252092 bdakin 2015-04-30 14:45:45 -0700 Created attachment 252092 Patch 1090589 2 commit-queue 2015-04-30 14:48:38 -0700 Attachment 252092 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/Color.h:119: The parameter name "l" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1090592 3 bdakin 2015-04-30 15:08:17 -0700 Thanks Simon! http://trac.webkit.org/changeset/183645 252092 2015-04-30 14:45:45 -0700 2015-04-30 14:52:22 -0700 Patch for-review.txt text/plain 3136 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzY0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTMwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTaG91bGQgY2hvb3NlIFVJU2Nyb2xs VmlldyBpbmRpY2F0b3JTdHlsZSBiYXNlZCBvbiB0aGUgZG9jdW1lbnQgYmFja2dyb3VuZCBjb2xv cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NDcz CisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTk4 OTc2OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF eHBvcnQgdGhpcyBmdW5jdGlvbi4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Db2xvci5o OgorCiAyMDE1LTA0LTMwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIFtXaW5dIEFsbG93IFdlYktpdCB0byBidWlsZCB3aXRob3V0IEFOR0xFIHN1cHBvcnQK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3IuaAkocmV2aXNpb24g MTgzNTk3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3IuaAkod29y a2luZyBjb3B5KQpAQCAtMTE2LDcgKzExNiw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldFJHQihS R0JBMzIgcmdiKSB7IG1fY29sb3IgPSByZ2I7IG1fdmFsaWQgPSB0cnVlOyB9CiAgICAgV0VCQ09S RV9FWFBPUlQgdm9pZCBnZXRSR0JBKGZsb2F0JiByLCBmbG9hdCYgZywgZmxvYXQmIGIsIGZsb2F0 JiBhKSBjb25zdDsKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGdldFJHQkEoZG91YmxlJiByLCBk b3VibGUmIGcsIGRvdWJsZSYgYiwgZG91YmxlJiBhKSBjb25zdDsKLSAgICB2b2lkIGdldEhTTChk b3VibGUmIGgsIGRvdWJsZSYgcywgZG91YmxlJiBsKSBjb25zdDsKKyAgICBXRUJDT1JFX0VYUE9S VCB2b2lkIGdldEhTTChkb3VibGUmIGgsIGRvdWJsZSYgcywgZG91YmxlJiBsKSBjb25zdDsKIAog ICAgIENvbG9yIGxpZ2h0KCkgY29uc3Q7CiAgICAgQ29sb3IgZGFyaygpIGNvbnN0OwpJbmRleDog U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwkocmV2aXNpb24gMTgzNjQ0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMDQtMzAgIEJldGggRGFraW4gIDxi ZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFNob3VsZCBjaG9vc2UgVUlTY3JvbGxWaWV3IGlu ZGljYXRvclN0eWxlIGJhc2VkIG9uIHRoZSBkb2N1bWVudCBiYWNrZ3JvdW5kIGNvbG9yCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ0NzMKKyAgICAg ICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xOTg5NzY5OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0 aGUgaW5kaWNhdG9yIHN0eWxlIHdoZW5ldmVyIHRoZSBiYWNrZ3JvdW5kIGNvbG9yIGNoYW5nZXMu ICAKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAg KC1bV0tXZWJWaWV3IF91cGRhdGVTY3JvbGxWaWV3QmFja2dyb3VuZF0pOgorCiAyMDE1LTA0LTMw ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gdGFw cGluZyBpbiB0aGUgbWlkZGxlIG9mIGEgd29yZCBpbiBlZGl0YWJsZSBjb250ZW50IHNob3VsZCBu b3Qgc2VsZWN0IHRoZSB3b3JkLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHJldmlzaW9uIDE4MzU5NykKKysrIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC03 OTUsNiArNzk1LDE0IEBAIC0gKHZvaWQpX3VwZGF0ZVNjcm9sbFZpZXdCYWNrZ3JvdW5kCiAKICAg ICBhdXRvIHVpQmFja2dyb3VuZENvbG9yID0gYWRvcHROUyhbW1VJQ29sb3IgYWxsb2NdIGluaXRX aXRoQ0dDb2xvcjpjYWNoZWRDR0NvbG9yKGNvbG9yLCBXZWJDb3JlOjpDb2xvclNwYWNlRGV2aWNl UkdCKV0pOwogICAgIFtfc2Nyb2xsVmlldyBzZXRCYWNrZ3JvdW5kQ29sb3I6dWlCYWNrZ3JvdW5k Q29sb3IuZ2V0KCldOworCisgICAgLy8gVXBkYXRlIHRoZSBpbmRpY2F0b3Igc3R5bGUgYmFzZWQg b24gdGhlIGxpZ2h0bmVzcy9kYXJrbmVzcyBvZiB0aGUgYmFja2dyb3VuZCBjb2xvci4KKyAgICBk b3VibGUgaHVlLCBzYXR1cmF0aW9uLCBsaWdodG5lc3M7CisgICAgY29sb3IuZ2V0SFNMKGh1ZSwg c2F0dXJhdGlvbiwgbGlnaHRuZXNzKTsKKyAgICBpZiAobGlnaHRuZXNzIDw9IC41ICYmIGNvbG9y LmFscGhhKCkgPiAwKQorICAgICAgICBbX3Njcm9sbFZpZXcgc2V0SW5kaWNhdG9yU3R5bGU6VUlT Y3JvbGxWaWV3SW5kaWNhdG9yU3R5bGVXaGl0ZV07CisgICAgZWxzZQorICAgICAgICBbX3Njcm9s bFZpZXcgc2V0SW5kaWNhdG9yU3R5bGU6VUlTY3JvbGxWaWV3SW5kaWNhdG9yU3R5bGVEZWZhdWx0 XTsKIH0KIAogLSAoQ0dQb2ludClfYWRqdXN0ZWRDb250ZW50T2Zmc2V0OihDR1BvaW50KXBvaW50 Cg==