144472 2015-04-30 14:41:59 -0700 [Freetype] Add support for the font-synthesis property 2015-05-01 09:01:53 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson commit-queue mmaxfield oldest_to_newest 1090581 0 mrobinson 2015-04-30 14:41:59 -0700 r183494 added support for the font-synthesis property for the iOS and Mac ports, but we need this for Freetype ports as well. 1090584 1 252090 mrobinson 2015-04-30 14:43:53 -0700 Created attachment 252090 Patch 1090694 2 252090 mmaxfield 2015-04-30 18:21:23 -0700 Comment on attachment 252090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252090&action=review > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:331 > + if (fontDescription.italic() && fontDescription.fontSynthesis() & FontSynthesisStyle Why the difference in order between weight and italic? 1090723 3 252090 mrobinson 2015-04-30 22:26:12 -0700 Comment on attachment 252090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252090&action=review >> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:331 >> + if (fontDescription.italic() && fontDescription.fontSynthesis() & FontSynthesisStyle > > Why the difference in order between weight and italic? No reason. I think I just did that for some intuitive sense of readability. I'm happy to make it consistent. :) 1090777 4 252150 mrobinson 2015-05-01 07:56:05 -0700 Created attachment 252150 Patch 1090782 5 252150 svillar 2015-05-01 08:04:03 -0700 Comment on attachment 252150 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252150&action=review > Source/WebCore/ChangeLog:3 > + [Freetype] Add support for the font-synthesis property Nit: extra space here > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:165 > + if (descriptionAllowsSyntheticBold && fontDescription.weight() >= FontWeightBold) { We're doing an extra check for < FontWeightBold here but I guess it's so simple that we can leave with it. 1090784 6 mrobinson 2015-05-01 08:09:02 -0700 (In reply to comment #5) > Comment on attachment 252150 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252150&action=review > > > Source/WebCore/ChangeLog:3 > > + [Freetype] Add support for the font-synthesis property > > Nit: extra space here > > > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:165 > > + if (descriptionAllowsSyntheticBold && fontDescription.weight() >= FontWeightBold) { > > We're doing an extra check for < FontWeightBold here but I guess it's so > simple that we can leave with it. I think in this case we have to check whether the font needs the synthetic bold and also whether the font-synthesis property allows it. 1090793 7 mrobinson 2015-05-01 09:01:30 -0700 Committed r183673: <http://trac.webkit.org/changeset/183673> 252090 2015-04-30 14:43:53 -0700 2015-05-01 07:56:02 -0700 Patch bug-144472-20150430144242.patch text/plain 2825 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTViZjA0ZDQxODYyYWVm MTE0ZTI1ZTZhZTEwMjEzZmYwZDk1NWY3NC4uZjhhZjRmOGNmNjhkZTNiNmQ3NzExMzdkMzUyYjI0 M2YyZWUxYjQ2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTMwICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbRnJlZXR5cGVd IEFkZCBzdXBwb3J0IGZvciB0aGUgIGZvbnQtc3ludGhlc2lzIHByb3BlcnR5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ0NzIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMg Y2F1c2VzIGZhc3QvY3NzMy10ZXh0L2ZvbnQtc3ludGhlc2lzLmh0bWwgdG8gcGFzcworICAgICAg ICBmb3IgV2ViS2l0R1RLKy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBl L0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxh dGZvcm1EYXRhOjpGb250UGxhdGZvcm1EYXRhKTogT25seSB1c2Ugc3ludGhldGljIGJvbGQgd2hl biB0aGUgZm9udCBkZXNjcmlwdGlvbiBhbGxvd3MgaXQuCisgICAgICAgIChXZWJDb3JlOjpGb250 UGxhdGZvcm1EYXRhOjppbml0aWFsaXplV2l0aEZvbnRGYWNlKTogRGl0dG8gZm9yIHN5bnRoZXRp YyBvYmxpcXVlLgorCiAyMDE1LTA0LTMwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIFtXaW5dIEFsbG93IFdlYktpdCB0byBidWlsZCB3aXRob3V0IEFOR0xF IHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zy ZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCmluZGV4 IGU5YzVmMjhmNTE5OWViNDQyM2NmNDQ4Nzg5N2MzMmYzZGY4YTBlNzQuLjIyZjhiYTgyMDU5YTBh YTRkODkwOThkZGQ3NTY5NjI2MGE0YjlhMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3Jt RGF0YUZyZWVUeXBlLmNwcApAQCAtMTYxLDcgKzE2MSw4IEBAIEZvbnRQbGF0Zm9ybURhdGE6OkZv bnRQbGF0Zm9ybURhdGEoRmNQYXR0ZXJuKiBwYXR0ZXJuLCBjb25zdCBGb250RGVzY3JpcHRpb24m IGZvCiAgICAgaWYgKEZjUGF0dGVybkdldEludGVnZXIocGF0dGVybiwgRkNfU1BBQ0lORywgMCwg JnNwYWNpbmcpID09IEZjUmVzdWx0TWF0Y2ggJiYgc3BhY2luZyA9PSBGQ19NT05PKQogICAgICAg ICBtX2ZpeGVkV2lkdGggPSB0cnVlOwogCi0gICAgaWYgKGZvbnREZXNjcmlwdGlvbi53ZWlnaHQo KSA+PSBGb250V2VpZ2h0Qm9sZCkgeworICAgIGJvb2wgZGVzY3JpcHRpb25BbGxvd3NTeW50aGV0 aWNCb2xkID0gZm9udERlc2NyaXB0aW9uLmZvbnRTeW50aGVzaXMoKSAmIEZvbnRTeW50aGVzaXNX ZWlnaHQ7CisgICAgaWYgKGRlc2NyaXB0aW9uQWxsb3dzU3ludGhldGljQm9sZCAmJiBmb250RGVz Y3JpcHRpb24ud2VpZ2h0KCkgPj0gRm9udFdlaWdodEJvbGQpIHsKICAgICAgICAgLy8gVGhlIEZD X0VNQk9MREVOIHByb3BlcnR5IGluc3RydWN0cyB1cyB0byBmYWtlIHRoZSBib2xkbmVzcyBvZiB0 aGUgZm9udC4KICAgICAgICAgRmNCb29sIGZvbnRDb25maWdFbWJvbGRlbiA9IEZjRmFsc2U7CiAg ICAgICAgIGlmIChGY1BhdHRlcm5HZXRCb29sKHBhdHRlcm4sIEZDX0VNQk9MREVOLCAwLCAmZm9u dENvbmZpZ0VtYm9sZGVuKSA9PSBGY1Jlc3VsdE1hdGNoKQpAQCAtMzI3LDggKzMyOCwxMCBAQCB2 b2lkIEZvbnRQbGF0Zm9ybURhdGE6OmluaXRpYWxpemVXaXRoRm9udEZhY2UoY2Fpcm9fZm9udF9m YWNlX3QqIGZvbnRGYWNlLCBjb25zdAogCiAgICAgLy8gV2UgcmVxdWVzdGVkIGFuIGl0YWxpYyBm b250LCBidXQgRm9udGNvbmZpZyBnYXZlIHVzIG9uZSB0aGF0IHdhcyBuZWl0aGVyIG9ibGlxdWUg bm9yIGl0YWxpYy4KICAgICBpbnQgYWN0dWFsRm9udFNsYW50OwotICAgIGlmIChmb250RGVzY3Jp cHRpb24uaXRhbGljKCkgJiYgRmNQYXR0ZXJuR2V0SW50ZWdlcihvcHRpb25zUGF0dGVybiwgRkNf U0xBTlQsIDAsICZhY3R1YWxGb250U2xhbnQpID09IEZjUmVzdWx0TWF0Y2gpCisgICAgaWYgKGZv bnREZXNjcmlwdGlvbi5pdGFsaWMoKSAmJiBmb250RGVzY3JpcHRpb24uZm9udFN5bnRoZXNpcygp ICYgRm9udFN5bnRoZXNpc1N0eWxlCisgICAgICAgICYmIEZjUGF0dGVybkdldEludGVnZXIob3B0 aW9uc1BhdHRlcm4sIEZDX1NMQU5ULCAwLCAmYWN0dWFsRm9udFNsYW50KSA9PSBGY1Jlc3VsdE1h dGNoKSB7CiAgICAgICAgIG1fc3ludGhldGljT2JsaXF1ZSA9IGFjdHVhbEZvbnRTbGFudCA9PSBG Q19TTEFOVF9ST01BTjsKKyAgICB9CiAKICAgICAvLyBUaGUgbWF0cml4IGZyb20gRm9udENvbmZp ZyBkb2VzIG5vdCBpbmNsdWRlIHRoZSBzY2FsZS4gCiAgICAgY2Fpcm9fbWF0cml4X3NjYWxlKCZm b250TWF0cml4LCByZWFsU2l6ZSwgcmVhbFNpemUpOwo= 252150 2015-05-01 07:56:05 -0700 2015-05-01 09:01:53 -0700 Patch bug-144472-20150501075454.patch text/plain 2906 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTViZjA0ZDQxODYyYWVm MTE0ZTI1ZTZhZTEwMjEzZmYwZDk1NWY3NC4uZjhhZjRmOGNmNjhkZTNiNmQ3NzExMzdkMzUyYjI0 M2YyZWUxYjQ2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTMwICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbRnJlZXR5cGVd IEFkZCBzdXBwb3J0IGZvciB0aGUgIGZvbnQtc3ludGhlc2lzIHByb3BlcnR5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ0NzIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMg Y2F1c2VzIGZhc3QvY3NzMy10ZXh0L2ZvbnQtc3ludGhlc2lzLmh0bWwgdG8gcGFzcworICAgICAg ICBmb3IgV2ViS2l0R1RLKy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBl L0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxh dGZvcm1EYXRhOjpGb250UGxhdGZvcm1EYXRhKTogT25seSB1c2Ugc3ludGhldGljIGJvbGQgd2hl biB0aGUgZm9udCBkZXNjcmlwdGlvbiBhbGxvd3MgaXQuCisgICAgICAgIChXZWJDb3JlOjpGb250 UGxhdGZvcm1EYXRhOjppbml0aWFsaXplV2l0aEZvbnRGYWNlKTogRGl0dG8gZm9yIHN5bnRoZXRp YyBvYmxpcXVlLgorCiAyMDE1LTA0LTMwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIFtXaW5dIEFsbG93IFdlYktpdCB0byBidWlsZCB3aXRob3V0IEFOR0xF IHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zy ZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCmluZGV4 IGU5YzVmMjhmNTE5OWViNDQyM2NmNDQ4Nzg5N2MzMmYzZGY4YTBlNzQuLjc5Zjg3ZDNkODg1M2I2 ZDlhYTI0MzYzMTg2MzA3NTA3N2M3YWMxMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3Jt RGF0YUZyZWVUeXBlLmNwcApAQCAtMTYxLDcgKzE2MSw4IEBAIEZvbnRQbGF0Zm9ybURhdGE6OkZv bnRQbGF0Zm9ybURhdGEoRmNQYXR0ZXJuKiBwYXR0ZXJuLCBjb25zdCBGb250RGVzY3JpcHRpb24m IGZvCiAgICAgaWYgKEZjUGF0dGVybkdldEludGVnZXIocGF0dGVybiwgRkNfU1BBQ0lORywgMCwg JnNwYWNpbmcpID09IEZjUmVzdWx0TWF0Y2ggJiYgc3BhY2luZyA9PSBGQ19NT05PKQogICAgICAg ICBtX2ZpeGVkV2lkdGggPSB0cnVlOwogCi0gICAgaWYgKGZvbnREZXNjcmlwdGlvbi53ZWlnaHQo KSA+PSBGb250V2VpZ2h0Qm9sZCkgeworICAgIGJvb2wgZGVzY3JpcHRpb25BbGxvd3NTeW50aGV0 aWNCb2xkID0gZm9udERlc2NyaXB0aW9uLmZvbnRTeW50aGVzaXMoKSAmIEZvbnRTeW50aGVzaXNX ZWlnaHQ7CisgICAgaWYgKGRlc2NyaXB0aW9uQWxsb3dzU3ludGhldGljQm9sZCAmJiBmb250RGVz Y3JpcHRpb24ud2VpZ2h0KCkgPj0gRm9udFdlaWdodEJvbGQpIHsKICAgICAgICAgLy8gVGhlIEZD X0VNQk9MREVOIHByb3BlcnR5IGluc3RydWN0cyB1cyB0byBmYWtlIHRoZSBib2xkbmVzcyBvZiB0 aGUgZm9udC4KICAgICAgICAgRmNCb29sIGZvbnRDb25maWdFbWJvbGRlbiA9IEZjRmFsc2U7CiAg ICAgICAgIGlmIChGY1BhdHRlcm5HZXRCb29sKHBhdHRlcm4sIEZDX0VNQk9MREVOLCAwLCAmZm9u dENvbmZpZ0VtYm9sZGVuKSA9PSBGY1Jlc3VsdE1hdGNoKQpAQCAtMzI3LDggKzMyOCwxMSBAQCB2 b2lkIEZvbnRQbGF0Zm9ybURhdGE6OmluaXRpYWxpemVXaXRoRm9udEZhY2UoY2Fpcm9fZm9udF9m YWNlX3QqIGZvbnRGYWNlLCBjb25zdAogCiAgICAgLy8gV2UgcmVxdWVzdGVkIGFuIGl0YWxpYyBm b250LCBidXQgRm9udGNvbmZpZyBnYXZlIHVzIG9uZSB0aGF0IHdhcyBuZWl0aGVyIG9ibGlxdWUg bm9yIGl0YWxpYy4KICAgICBpbnQgYWN0dWFsRm9udFNsYW50OwotICAgIGlmIChmb250RGVzY3Jp cHRpb24uaXRhbGljKCkgJiYgRmNQYXR0ZXJuR2V0SW50ZWdlcihvcHRpb25zUGF0dGVybiwgRkNf U0xBTlQsIDAsICZhY3R1YWxGb250U2xhbnQpID09IEZjUmVzdWx0TWF0Y2gpCisgICAgYm9vbCBk ZXNjcmlwdGlvbkFsbG93c1N5bnRoZXRpY09ibGlxdWUgPSBmb250RGVzY3JpcHRpb24uZm9udFN5 bnRoZXNpcygpICYgRm9udFN5bnRoZXNpc1N0eWxlOworICAgIGlmIChkZXNjcmlwdGlvbkFsbG93 c1N5bnRoZXRpY09ibGlxdWUgJiYgZm9udERlc2NyaXB0aW9uLml0YWxpYygpCisgICAgICAgICYm IEZjUGF0dGVybkdldEludGVnZXIob3B0aW9uc1BhdHRlcm4sIEZDX1NMQU5ULCAwLCAmYWN0dWFs Rm9udFNsYW50KSA9PSBGY1Jlc3VsdE1hdGNoKSB7CiAgICAgICAgIG1fc3ludGhldGljT2JsaXF1 ZSA9IGFjdHVhbEZvbnRTbGFudCA9PSBGQ19TTEFOVF9ST01BTjsKKyAgICB9CiAKICAgICAvLyBU aGUgbWF0cml4IGZyb20gRm9udENvbmZpZyBkb2VzIG5vdCBpbmNsdWRlIHRoZSBzY2FsZS4gCiAg ICAgY2Fpcm9fbWF0cml4X3NjYWxlKCZmb250TWF0cml4LCByZWFsU2l6ZSwgcmVhbFNpemUpOwo=