144452 2015-04-30 10:04:01 -0700 [GTK] Add libhyphen-dev to the build dependencies 2015-05-01 02:05:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 calvaris calvaris cgarcia commit-queue mcatanzaro mrobinson pnormand zan oldest_to_newest 1090460 0 calvaris 2015-04-30 10:04:01 -0700 [GTK] Add libhyphen-dev to the build dependencies 1090462 1 252064 calvaris 2015-04-30 10:05:03 -0700 Created attachment 252064 Patch libhyphen-dev seems to be needed now, otherwise compilation fails. 1090496 2 252064 commit-queue 2015-04-30 11:22:03 -0700 Comment on attachment 252064 Patch Clearing flags on attachment: 252064 Committed r183634: <http://trac.webkit.org/changeset/183634> 1090497 3 commit-queue 2015-04-30 11:22:06 -0700 All reviewed patches have been landed. Closing bug. 1090523 4 mcatanzaro 2015-04-30 12:00:37 -0700 When touching this file please be sure to add the Fedora (hyphen-devel) and Arch (hyphen) packages too. 1090535 5 calvaris 2015-04-30 12:25:08 -0700 (In reply to comment #4) > When touching this file please be sure to add the Fedora (hyphen-devel) and > Arch (hyphen) packages too. I wish this could have done with a follow up patch rather than with a rollout ;) 1090536 6 calvaris 2015-04-30 12:26:36 -0700 (In reply to comment #5) > (In reply to comment #4) > > When touching this file please be sure to add the Fedora (hyphen-devel) and > > Arch (hyphen) packages too. > > I wish this could have done with a follow up patch rather than with a > rollout ;) Actually, it seems it is not, my bad. I thought it was an automatic rollout :D 1090537 7 calvaris 2015-04-30 12:27:44 -0700 (In reply to comment #4) > When touching this file please be sure to add the Fedora (hyphen-devel) and > Arch (hyphen) packages too. Btw, how do you test the different possibilities, just trust it? 1090599 8 mcatanzaro 2015-04-30 15:24:23 -0700 (In reply to comment #7) > (In reply to comment #4) > > When touching this file please be sure to add the Fedora (hyphen-devel) and > > Arch (hyphen) packages too. > > Btw, how do you test the different possibilities, just trust it? I just check online: https://www.archlinux.org/packages/extra/x86_64/hyphen/ ^ View file list (at the bottom of the page) shows it has /usr/lib/libhyphen.so https://apps.fedoraproject.org/packages/hyphen-devel/ ^ The Contents tab shows it contains /usr/lib64/libhyphen.so 1090608 9 252097 calvaris 2015-04-30 15:53:55 -0700 Created attachment 252097 Patch Added hyphen as Arch and Fedora deps as well. 1090617 10 252097 mrobinson 2015-04-30 16:08:54 -0700 Comment on attachment 252097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252097&action=review > Tools/ChangeLog:15 > + Reviewed by NOBODY (OOPS!). > + > + * gtk/install-dependencies: Added hyphen as Fedora and Arch > + dependencies. > + > +2015-04-30 Xabier Rodriguez Calvar <calvaris@igalia.com> > + > + [GTK] Add libhyphen-dev to the build dependencies > + https://bugs.webkit.org/show_bug.cgi?id=144452 > + Your changelog has issues here, I think. Be careful when landing this that you don't insert the ChangeLog entry into the middle of the file. 1090734 11 252137 calvaris 2015-05-01 01:13:18 -0700 Created attachment 252137 Patch for landing 1090748 12 252137 commit-queue 2015-05-01 02:05:28 -0700 Comment on attachment 252137 Patch for landing Clearing flags on attachment: 252137 Committed r183669: <http://trac.webkit.org/changeset/183669> 1090749 13 commit-queue 2015-05-01 02:05:34 -0700 All reviewed patches have been landed. Closing bug. 252064 2015-04-30 10:05:03 -0700 2015-04-30 15:53:05 -0700 Patch bug-144452-20150430190352.patch text/plain 1173 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODI2MmVhOTk1ZTgxOTNmYjJkYzEwMDg3ZjIyYmE3MjBi ZWMzNDI5My4uYzc2YmI2ZjlhNWVjMjA1NDU0MWE2OWRkMTM5ZjJhNGU0NGQzOGU3MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA0LTMwICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dUS10gQWRkIGxpYmh5cGhlbi1kZXYgdG8gdGhlIGJ1aWxkIGRl cGVuZGVuY2llcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ0NDUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXM6IEFkZGVkIGxpYmh5cGhlbi1kZXYgdG8gdGhl IFdlYktpdEdUSysKKyAgICAgICAgYnVpbGQgZGVwZW5kZW5jaWVzLgorCiAyMDE1LTA0LTMwICBE ZXdlaSBaaHUgIDxkZXdlaV96aHVAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCByZXR1cm4gY29k ZSBpc3N1ZSwgY2hlY2sgcmV0dXJuIGNvZGUgb2Ygc2FmYXJpIHByb2Nlc3MgYW5kIGR1bXAgcmVz dWx0cyB0byBsb2cKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcyBi L1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcwppbmRleCBjZjJmMTlmMmIwZTg5YWM3OGEw NzgzMDFjMmY3Y2MwMjVjMjZkNWQ4Li42ZDJkOTg0ZDNlMjJlYjJiYzFiYmEzNTFkNmRhYzVjMjg4 YjUwN2VlIDEwMDc1NQotLS0gYS9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKKysrIGIv VG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCkBAIC03NSw2ICs3NSw3IEBAIGZ1bmN0aW9u IGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0IHsKICAgICAgICAgbGliZ3RrLTMtZGV2IFwKICAg ICAgICAgbGliZ3VkZXYtMS4wLWRldiBcCiAgICAgICAgIGxpYmhhcmZidXp6LWRldiBcCisgICAg ICAgIGxpYmh5cGhlbi1kZXYgXAogICAgICAgICBsaWJpY3UtZGV2IFwKICAgICAgICAgbGlianBl Zy1kZXYgXAogICAgICAgICBsaWJtcGcxMjMtZGV2IFwK 252097 2015-04-30 15:53:55 -0700 2015-05-01 01:13:07 -0700 Patch bug-144452-20150501005244.patch text/plain 1419 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzAwNGQ3Njg4N2ZmYjYxZDk0YTAxYjg0ODM3YWY4ZjIw YTkyMTJlOS4uNmNjZmI2MmJhODM5ZmYyODI2NTc0OTlhZjRjMDZiOWY5NThmOGY0ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMyw2ICszLDE2 IEBACiAgICAgICAgIFtHVEtdIEFkZCBsaWJoeXBoZW4tZGV2IHRvIHRoZSBidWlsZCBkZXBlbmRl bmNpZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NDQ1MgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog Z3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzOiBBZGRlZCBoeXBoZW4gYXMgRmVkb3JhIGFuZCBBcmNo CisgICAgICAgIGRlcGVuZGVuY2llcy4KKworMjAxNS0wNC0zMCAgWGFiaWVyIFJvZHJpZ3VleiBD YWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFkZCBsaWJoeXBo ZW4tZGV2IHRvIHRoZSBidWlsZCBkZXBlbmRlbmNpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDQ1MgorCiAgICAgICAgIFJldmlld2VkIGJ5IE1h cnRpbiBSb2JpbnNvbi4KIAogICAgICAgICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczogQWRk ZWQgbGliaHlwaGVuLWRldiB0byB0aGUgV2ViS2l0R1RLKwpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3Rr L2luc3RhbGwtZGVwZW5kZW5jaWVzIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmlu ZGV4IDZkMmQ5ODRkM2UyMmViMmJjMWJiYTM1MWQ2ZGFjNWMyODhiNTA3ZWUuLmI1YzQzNmVjNjdm MzU0MTFmMTdmZWM2YWU1NGIxNjgxZWZhZTMyNTggMTAwNzU1Ci0tLSBhL1Rvb2xzL2d0ay9pbnN0 YWxsLWRlcGVuZGVuY2llcworKysgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAg LTE4MCw2ICsxODAsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aFBhY21hbiB7 CiAgICAgICAgIGdyZXAgXAogICAgICAgICBncm9mZiBcCiAgICAgICAgIGd6aXAgXAorICAgICAg ICBoeXBoZW4gXAogICAgICAgICBsaWJ0b29sIFwKICAgICAgICAgbTQgXAogICAgICAgICBtYWtl IFwKQEAgLTMxMyw2ICszMTQsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRmVkb3JhRGVwZW5kZW5jaWVz IHsKICAgICAgICAgZ3RrMi1kZXZlbCBcCiAgICAgICAgIGd0azMtZGV2ZWwgXAogICAgICAgICBo YXJmYnV6ei1kZXZlbCBcCisgICAgICAgIGh5cGhlbi1kZXZlbCBcCiAJanNvbi1nbGliLWRldmVs IFwKICAgICAgICAgbGliWHQtZGV2ZWwgXAogICAgICAgICBsaWJYdHN0LWRldmVsIFwK 252137 2015-05-01 01:13:18 -0700 2015-05-01 02:05:28 -0700 Patch for landing bug-144452-20150501101206.patch text/plain 1316 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDI3Zjc1MDMwYmQ0YTM0ZDBiMTkxZGNhM2EzNzczYTM4 MWQ2MTk3Yi4uNzgwODhkODE3NWNkZDVjMjc4YzAxNGU0MzJiMmFmODgwZmZmZDk0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA1LTAxICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dUS10gQWRkIGxpYmh5cGhlbi1kZXYgdG8gdGhlIGJ1aWxkIGRl cGVuZGVuY2llcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ0NDUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgorCisgICAg ICAgICogZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzOiBBZGRlZCBoeXBoZW4gYXMgRmVkb3JhIGFu ZCBBcmNoCisgICAgICAgIGRlcGVuZGVuY2llcy4KKwogMjAxNS0wNC0zMCAgQnJlbnQgRnVsZ2hh bSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm92aWRlIGEgcnVudGltZSBmbGFn IHRvIHJ1bi13ZWJraXQtdGVzdHMgdGhhdCBzaG93cyB0aGUgdGVzdCB2aWV3CmRpZmYgLS1naXQg YS9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBl bmRlbmNpZXMKaW5kZXggNmQyZDk4NGQzZTIyZWIyYmMxYmJhMzUxZDZkYWM1YzI4OGI1MDdlZS4u YjVjNDM2ZWM2N2YzNTQxMWYxN2ZlYzZhZTU0YjE2ODFlZmFlMzI1OCAxMDA3NTUKLS0tIGEvVG9v bHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCisrKyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVu ZGVuY2llcwpAQCAtMTgwLDYgKzE4MCw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNX aXRoUGFjbWFuIHsKICAgICAgICAgZ3JlcCBcCiAgICAgICAgIGdyb2ZmIFwKICAgICAgICAgZ3pp cCBcCisgICAgICAgIGh5cGhlbiBcCiAgICAgICAgIGxpYnRvb2wgXAogICAgICAgICBtNCBcCiAg ICAgICAgIG1ha2UgXApAQCAtMzEzLDYgKzMxNCw3IEBAIGZ1bmN0aW9uIGluc3RhbGxGZWRvcmFE ZXBlbmRlbmNpZXMgewogICAgICAgICBndGsyLWRldmVsIFwKICAgICAgICAgZ3RrMy1kZXZlbCBc CiAgICAgICAgIGhhcmZidXp6LWRldmVsIFwKKyAgICAgICAgaHlwaGVuLWRldmVsIFwKIAlqc29u LWdsaWItZGV2ZWwgXAogICAgICAgICBsaWJYdC1kZXZlbCBcCiAgICAgICAgIGxpYlh0c3QtZGV2 ZWwgXAo=