144439 2015-04-30 02:21:50 -0700 [ARM] Don't compare unsigned chars to EOF (-1) 2015-05-11 02:18:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 ossy ossy changseok jungjik.lee kenneth laszlo.gombos ossy svillar oldest_to_newest 1090397 0 ossy 2015-04-30 02:21:50 -0700 build error no1: ----------------- ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp: In function 'WTF::String WebCore::nextToken(FILE*)': ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:69:16: error: comparison is always false due to limited range of data type [-Werror=type-limits] if (ch == EOF || (isASCIISpace(ch) && index)) // Break on non-initial ASCII space. ^ cc1plus: all warnings being treated as errors build error no2: ----------------- ../../Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp: In function 'WTF::String WebKit::nextToken(FILE*)': ../../Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp:70:16: error: comparison is always false due to limited range of data type [-Werror=type-limits] if (ch == EOF || (isASCIISpace(ch) && index)) // Break on non-initial ASCII space. ^ cc1plus: all warnings being treated as errors ---- char ch = fgetc(file); ----> fgetc returns an int which is casted to char (signed char on X86_64 and unsigned char on ARM). EOF is defined as -1. (int) If fgetc returns with EOF, it will be 255 after casting unsigned char. When comparing the unsigned char 255 and the int -1, the unsigned char 255 will be casted to int 255 which will never be equal to -1. $ man fgetc [snip] fgetc() reads the next character from stream and returns it as an unsigned char cast to an int, or EOF on end of file or error. [snip] The correct fix is to avoid casting the return value of fgetc. 1090400 1 ossy 2015-04-30 02:36:56 -0700 Just to document, http://trac.webkit.org/changeset/127195 added the Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp change and http://trac.webkit.org/changeset/177216 added (copied) this bug into Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp. 1090401 2 252048 ossy 2015-04-30 02:39:58 -0700 Created attachment 252048 Patch 1090477 3 252048 ggaren 2015-04-30 10:41:36 -0700 Comment on attachment 252048 Patch r=me 1091330 4 252048 ossy 2015-05-04 01:43:49 -0700 Comment on attachment 252048 Patch Clearing flags on attachment: 252048 Committed r183740: <http://trac.webkit.org/changeset/183740> 1091331 5 ossy 2015-05-04 01:43:57 -0700 All reviewed patches have been landed. Closing bug. 1093703 6 ossy 2015-05-11 02:18:47 -0700 *** Bug 104613 has been marked as a duplicate of this bug. *** 252048 2015-04-30 02:39:58 -0700 2015-05-04 01:43:49 -0700 Patch bug-144439-20150430023847.patch text/plain 2846 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDMwOWUwZjJmYTRmOWQy MmQxZDNjOGYwMzYzNmI1NWEwMzdhZjVhNC4uODA1M2I0OWI4ZGY4MGRhYzkxMTM3NGUxOWIwMTVk MzZiMTEwZDFhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA0LTMwICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0FSTV0gRG9uJ3Qg Y29tcGFyZSB1bnNpZ25lZCBjaGFycyB0byBFT0YgKC0xKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NDM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9saW51eC9NZW1vcnlQcmVzc3Vy ZUhhbmRsZXJMaW51eC5jcHA6CisgICAgICAgIChXZWJLaXQ6Om5leHRUb2tlbik6IERvbid0IGNh c3QgcmV0dXJuIHZhbHVlIG9mIGZnZXRjKCkgdG8gY2hhci4KKwogMjAxNS0wNC0yOSAgSmVyIE5v YmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIEdlbmVyaWNUYXNrUXVl dWUgZXZlbiBtb3JlIGdlbmVyaWMgKGFuZCB1c2FibGUgaW5zaWRlIHBsYXRmb3JtLykKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwppbmRleCA1MmI5ZTljYzAyYWMwOTY5NWQ0NjZjMTYyZTFjMjk2MWIyMzEwODUzLi4yMTU5NGE5 MTZkOThmZTUxYTAyMzEyOTgyZDc0NTUwY2VhODM4MWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMTUtMDQtMzAgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4K KworICAgICAgICBbQVJNXSBEb24ndCBjb21wYXJlIHVuc2lnbmVkIGNoYXJzIHRvIEVPRiAoLTEp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ0MzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJl ZC9saW51eC9XZWJNZW1vcnlTYW1wbGVyTGludXguY3BwOgorICAgICAgICAoV2ViS2l0OjpuZXh0 VG9rZW4pOiBEb24ndCBjYXN0IHJldHVybiB2YWx1ZSBvZiBmZ2V0YygpIHRvIGNoYXIuCisKIDIw MTUtMDQtMjkgIEh1bnNlb3AgSmVvbmcgIDxoczg1Lmplb25nQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIEZpeCB0aGUgRUZMIGJ1aWxkIGFmdGVyIHIxODM1OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2xpbnV4L01lbW9yeVByZXNzdXJlSGFuZGxlckxpbnV4LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2xpbnV4L01lbW9yeVByZXNzdXJlSGFuZGxlckxpbnV4LmNw cAppbmRleCAyZTQ4Njk5OTBjNTE4ZmZlYmQyNTE0YTYwNzljZTY1NjRmZmRiZDliLi4yYTFlYmU3 ZWY5NWEzNDQxZGU1MGUxZGFlZDA1YzIwZWQyN2NiZmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9saW51eC9NZW1vcnlQcmVzc3VyZUhhbmRsZXJMaW51eC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbGludXgvTWVtb3J5UHJlc3N1cmVIYW5kbGVyTGludXgu Y3BwCkBAIC02NSw3ICs2NSw3IEBAIHN0YXRpYyBpbmxpbmUgU3RyaW5nIG5leHRUb2tlbihGSUxF KiBmaWxlKQogICAgIGNoYXIgYnVmZmVyW2J1ZmZlclNpemVdID0gezAsIH07CiAgICAgdW5zaWdu ZWQgaW5kZXggPSAwOwogICAgIHdoaWxlIChpbmRleCA8IGJ1ZmZlclNpemUpIHsKLSAgICAgICAg Y2hhciBjaCA9IGZnZXRjKGZpbGUpOworICAgICAgICBpbnQgY2ggPSBmZ2V0YyhmaWxlKTsKICAg ICAgICAgaWYgKGNoID09IEVPRiB8fCAoaXNBU0NJSVNwYWNlKGNoKSAmJiBpbmRleCkpIC8vIEJy ZWFrIG9uIG5vbi1pbml0aWFsIEFTQ0lJIHNwYWNlLgogICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgIGlmICghaXNBU0NJSVNwYWNlKGNoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv U2hhcmVkL2xpbnV4L1dlYk1lbW9yeVNhbXBsZXJMaW51eC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvbGludXgvV2ViTWVtb3J5U2FtcGxlckxpbnV4LmNwcAppbmRleCAzYmYwMDMxNTFlZGEw ODM1ZmUyNzgxYmU3YzhiYmM3MGU1NTMwMDdhLi4zNmM5YTQwOGE0M2M5ZGI2N2VjMGM3OWZmZGEy NmVjMGNlYTYxYzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbGludXgvV2Vi TWVtb3J5U2FtcGxlckxpbnV4LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbGludXgv V2ViTWVtb3J5U2FtcGxlckxpbnV4LmNwcApAQCAtNjYsNyArNjYsNyBAQCBzdGF0aWMgaW5saW5l IFN0cmluZyBuZXh0VG9rZW4oRklMRSogZmlsZSkKICAgICBjaGFyIGJ1ZmZlclttYXhCdWZmZXJd ID0gezAsIH07CiAgICAgdW5zaWduZWQgaW50IGluZGV4ID0gMDsKICAgICB3aGlsZSAoaW5kZXgg PCBtYXhCdWZmZXIpIHsKLSAgICAgICAgY2hhciBjaCA9IGZnZXRjKGZpbGUpOworICAgICAgICBp bnQgY2ggPSBmZ2V0YyhmaWxlKTsKICAgICAgICAgaWYgKGNoID09IEVPRiB8fCAoaXNBU0NJSVNw YWNlKGNoKSAmJiBpbmRleCkpIC8vIEJyZWFrIG9uIG5vbi1pbml0aWFsIEFTQ0lJIHNwYWNlLgog ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGlmICghaXNBU0NJSVNwYWNlKGNoKSkgewo=