144435 2015-04-29 21:57:45 -0700 [EFL] CMake should be failed if openwebrtc package does not exist but ENABLE_MEDIA_STREAM is ON 2015-04-29 23:38:55 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi lucas.de.marchi oldest_to_newest 1090355 0 ryuan.choi 2015-04-29 21:57:45 -0700 ewebkit should include openwebrtc if ENABLE_MEDIA_STREAM is ON. If not, linker will complain at the almost end of build. In order to catch it earilier, we'd better to add REQUIRED field in find_package or raise FATAL_ERROR with some message like GTK port did. 1090358 1 252039 ryuan.choi 2015-04-29 22:06:45 -0700 Created attachment 252039 Patch 1090365 2 252039 gyuyoung.kim 2015-04-29 22:58:16 -0700 Comment on attachment 252039 Patch Oh, right. When we failed to build openwebrtc via jhbuild, it was hard to find what is problem. 1090369 3 252044 ryuan.choi 2015-04-29 23:28:21 -0700 Created attachment 252044 Patch 1090371 4 252044 ryuan.choi 2015-04-29 23:38:39 -0700 Comment on attachment 252044 Patch Clearing flags on attachment: 252044 Committed r183619: <http://trac.webkit.org/changeset/183619> 1090372 5 ryuan.choi 2015-04-29 23:38:55 -0700 All reviewed patches have been landed. Closing bug. 252039 2015-04-29 22:06:45 -0700 2015-04-29 23:27:47 -0700 Patch bug-144435-20150430140520.patch text/plain 1950 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDA1Njk1 MThjM2JjYTkzNjhiZTJiMWY3OTliZGIyYjFiZGJjY2ZhOTkuLmY5ZWI1OTVlZTFhYzA0NWQ0MDk5 NDM0MDg4NWM3NmJlNWMyODVjNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC05Niw2ICs5Niw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9MSU5LX1BSRUZFVENI IFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRURJ QV9DQVBUVVJFIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9NRURJQV9DT05UUk9MU19TQ1JJUFQgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZB VUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FRElBX1NPVVJDRSBQVUJMSUMgT04pCitXRUJLSVRfT1BU SU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUVESUFfU1RSRUFNIFBVQkxJQyBPTikKIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRU1PUllfU0FNUExFUiBQVUJM SUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUhUTUwgUFVC TElDIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9N T1VTRV9DVVJTT1JfU0NBTEUgUFVCTElDIE9OKQpAQCAtMTkwLDEwICsxOTEsOCBAQCBpZiAoRU5B QkxFX0JBVFRFUllfU1RBVFVTKQogZW5kaWYgKCkKIAogaWYgKEVOQUJMRV9NRURJQV9TVFJFQU0p Ci0gICAgZmluZF9wYWNrYWdlKE9wZW5XZWJSVEMpCi0gICAgaWYgKE9QRU5XRUJSVENfRk9VTkQp Ci0gICAgICAgIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfT1BFTldFQlJUQykKLSAgICBlbmRp ZiAoKQorICAgIGZpbmRfcGFja2FnZShPcGVuV2ViUlRDIFJFUVVJUkVEKQorICAgIGFkZF9kZWZp bml0aW9ucygtRFdURl9VU0VfT1BFTldFQlJUQykKIGVuZGlmICgpCiAKIGlmIChFTkFCTEVfTkVU U0NBUEVfUExVR0lOX0FQSSkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRl eCA5MGM0ZDZhZDlmY2FmNDE4ZTdlZmViYWUwNjg2ZGI0NTI2YjQ2MjA3Li5kN2Y4YzgyYjI3MTUw YWE1ZTBkNDExNWM4ZmVjYWU5NTc5ZTMxMTJmIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDQtMjkgIFJ5dWFuIENob2kgIDxyeXVh bi5jaG9pQG5hdmVyY29ycC5jb20+CisKKyAgICAgICAgW0VGTF0gQ01ha2Ugc2hvdWxkIGJlIGZh aWxlZCBpZiBvcGVud2VicnRjIHBhY2thZ2UgaXMgbm90IGV4aXN0IGJ1dCBFTkFCTEVfTUVESUFf U1RSRUFNIGlzIE9OCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDQ0MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIHBhdGNoIGFkZHMgUkVRVUlSRUQgb3B0aW9uIGZvciBPcGVuV2ViUlRDIHdoZW4g RU5BQkxFX01FRElBX1NUUkVBTSBpcyBPTi4KKyAgICAgICAgSW4gYWRkaXRpb24sIHRoaXMgYWRk cyBERUZBVUxUX1BPUlRfVkFMVUUgZm9yIEVOQUJMRV9NRURJQV9TVFJFQU0gdG8gbWF0Y2ggd2l0 aCBGZWF0dXJlTGlzdC5wbQorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21h a2U6CisKIDIwMTUtMDQtMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OKDE4MzU4Myk6IFtNYWNdIG1ha2Ugd2l0aG91dCBTREtST09U IGhhcyBpc3N1ZXMK 252044 2015-04-29 23:28:21 -0700 2015-04-29 23:38:39 -0700 Patch bug-144435-20150430152659.patch text/plain 1950 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDA1Njk1 MThjM2JjYTkzNjhiZTJiMWY3OTliZGIyYjFiZGJjY2ZhOTkuLmY5ZWI1OTVlZTFhYzA0NWQ0MDk5 NDM0MDg4NWM3NmJlNWMyODVjNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC05Niw2ICs5Niw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9MSU5LX1BSRUZFVENI IFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRURJ QV9DQVBUVVJFIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9NRURJQV9DT05UUk9MU19TQ1JJUFQgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZB VUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FRElBX1NPVVJDRSBQVUJMSUMgT04pCitXRUJLSVRfT1BU SU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUVESUFfU1RSRUFNIFBVQkxJQyBPTikKIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRU1PUllfU0FNUExFUiBQVUJM SUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUhUTUwgUFVC TElDIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9N T1VTRV9DVVJTT1JfU0NBTEUgUFVCTElDIE9OKQpAQCAtMTkwLDEwICsxOTEsOCBAQCBpZiAoRU5B QkxFX0JBVFRFUllfU1RBVFVTKQogZW5kaWYgKCkKIAogaWYgKEVOQUJMRV9NRURJQV9TVFJFQU0p Ci0gICAgZmluZF9wYWNrYWdlKE9wZW5XZWJSVEMpCi0gICAgaWYgKE9QRU5XRUJSVENfRk9VTkQp Ci0gICAgICAgIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfT1BFTldFQlJUQykKLSAgICBlbmRp ZiAoKQorICAgIGZpbmRfcGFja2FnZShPcGVuV2ViUlRDIFJFUVVJUkVEKQorICAgIGFkZF9kZWZp bml0aW9ucygtRFdURl9VU0VfT1BFTldFQlJUQykKIGVuZGlmICgpCiAKIGlmIChFTkFCTEVfTkVU U0NBUEVfUExVR0lOX0FQSSkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRl eCA5MGM0ZDZhZDlmY2FmNDE4ZTdlZmViYWUwNjg2ZGI0NTI2YjQ2MjA3Li43MWFjMGNiMjg5NzYy ZTVlNTQwOTBhMmYwOGZiMGYwZTNhYmVjOTZmIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDQtMjkgIFJ5dWFuIENob2kgIDxyeXVh bi5jaG9pQG5hdmVyY29ycC5jb20+CisKKyAgICAgICAgW0VGTF0gQ01ha2Ugc2hvdWxkIGJlIGZh aWxlZCBpZiBvcGVud2VicnRjIHBhY2thZ2UgZG9lcyBub3QgZXhpc3QgYnV0IEVOQUJMRV9NRURJ QV9TVFJFQU0gaXMgT04KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDQzNQorCisgICAgICAgIFJldmlld2VkIGJ5IEd5dXlvdW5nIEtpbS4KKworICAg ICAgICBUaGlzIHBhdGNoIGFkZHMgUkVRVUlSRUQgb3B0aW9uIGZvciBPcGVuV2ViUlRDIHdoZW4g RU5BQkxFX01FRElBX1NUUkVBTSBpcyBPTi4KKyAgICAgICAgSW4gYWRkaXRpb24sIHRoaXMgYWRk cyBERUZBVUxUX1BPUlRfVkFMVUUgZm9yIEVOQUJMRV9NRURJQV9TVFJFQU0gdG8gbWF0Y2ggd2l0 aCBGZWF0dXJlTGlzdC5wbQorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21h a2U6CisKIDIwMTUtMDQtMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OKDE4MzU4Myk6IFtNYWNdIG1ha2Ugd2l0aG91dCBTREtST09U IGhhcyBpc3N1ZXMK