144430 2015-04-29 19:19:53 -0700 Not all videos should automatically play to playback target 2015-04-29 20:43:38 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson webkit-bug-importer oldest_to_newest 1090296 0 eric.carlson 2015-04-29 19:19:53 -0700 Refine the selection criteria. 1090297 1 eric.carlson 2015-04-29 19:20:20 -0700 <rdar://problem/20718523> 1090300 2 252026 eric.carlson 2015-04-29 19:25:19 -0700 Created attachment 252026 Proposed patch. 1090340 3 252026 eric.carlson 2015-04-29 20:43:28 -0700 Comment on attachment 252026 Proposed patch. Committed r183613: https://trac.webkit.org/r183613 252026 2015-04-29 19:25:19 -0700 2015-04-29 20:43:28 -0700 Proposed patch. auto_throw_patch_1.txt text/plain 4502 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzYwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA0LTI5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE5vdCBhbGwgdmlkZW9z IHNob3VsZCBhdXRvbWF0aWNhbGx5IHBsYXkgdG8gcGxheWJhY2sgdGFyZ2V0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ0MzAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzZXNz aW9uL1dlYk1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViTWVk aWFTZXNzaW9uTWFuYWdlcjo6Y2xpZW50U3RhdGVEaWRDaGFuZ2UpOiBDb25zaWRlciBFeHRlcm5h bERldmljZUF1dG9QbGF5Q2FuZGlkYXRlLgorICAgICAgICBNaW5vciBjbGVhbnVwLgorCisgICAg ICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxN ZWRpYUVsZW1lbnQ6Om1lZGlhU3RhdGUpOiBTZXQgRXh0ZXJuYWxEZXZpY2VBdXRvUGxheUNhbmRp ZGF0ZSB3aGVuIGEgPHZpZGVvPgorICAgICAgICBoYXMgYSBmaWxlIHdpdGggYW4gYXVkaW8gdHJh Y2sgdGhhdCBkb2VzIG5vdCBsb29wLgorCisgICAgICAgICogcGFnZS9NZWRpYVByb2R1Y2VyLmg6 IEFkZCBFeHRlcm5hbERldmljZUF1dG9QbGF5Q2FuZGlkYXRlLgorCiAyMDE1LTA0LTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIGF0IFdl YkNvcmU6OkRvY3VtZW50OjphYnNvbHV0ZVJlZ2lvbkZvckV2ZW50VGFyZ2V0cyAKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL1dlYk1lZGlhU2Vzc2lvbk1hbmFnZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL1dl Yk1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCShyZXZpc2lvbiAxODM1ODcpCisrKyBTb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9XZWJNZWRpYVNlc3Npb25NYW5hZ2VyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTQ0LDcgKzE0NCwxMCBAQCB2b2lkIFdlYk1lZGlhU2Vzc2lvbk1hbmFn ZXI6OmNsaWVudFN0YXRlCiAgICAgaWYgKCFmbGFnc0FyZVNldChvbGRGbGFncywgTWVkaWFQcm9k dWNlcjo6UmVxdWlyZXNQbGF5YmFja1RhcmdldE1vbml0b3JpbmcpICYmIGZsYWdzQXJlU2V0KG5l d0ZsYWdzLCBNZWRpYVByb2R1Y2VyOjpSZXF1aXJlc1BsYXliYWNrVGFyZ2V0TW9uaXRvcmluZykp CiAgICAgICAgIGNvbmZpZ3VyZVBsYXliYWNrVGFyZ2V0TW9uaXRvcmluZygpOwogCi0gICAgaWYg KCFmbGFnc0FyZVNldChuZXdGbGFncywgTWVkaWFQcm9kdWNlcjo6SXNQbGF5aW5nVmlkZW8pKQor ICAgIGlmICghZmxhZ3NBcmVTZXQobmV3RmxhZ3MsIE1lZGlhUHJvZHVjZXI6OklzUGxheWluZ1Zp ZGVvKSB8fCAhZmxhZ3NBcmVTZXQobmV3RmxhZ3MsIE1lZGlhUHJvZHVjZXI6OkV4dGVybmFsRGV2 aWNlQXV0b1BsYXlDYW5kaWRhdGUpKQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAoIW1fcGxh eWJhY2tUYXJnZXQgfHwgIW1fcGxheWJhY2tUYXJnZXQtPmhhc0FjdGl2ZVJvdXRlKCkpCiAgICAg ICAgIHJldHVybjsKIAogICAgIC8vIERvIG5vdCBpbnRlcnJ1cHQgYW5vdGhlciBlbGVtZW50IGFs cmVhZHkgcGxheWluZyB0byBhIGRldmljZS4KQEAgLTE1NiwxNyArMTU5LDE0IEBAIHZvaWQgV2Vi TWVkaWFTZXNzaW9uTWFuYWdlcjo6Y2xpZW50U3RhdGUKICAgICAgICAgICAgIHJldHVybjsKICAg ICB9CiAKLSAgICBpZiAobV9wbGF5YmFja1RhcmdldCAmJiBtX3BsYXliYWNrVGFyZ2V0LT5oYXNB Y3RpdmVSb3V0ZSgpKSB7Ci0KLSAgICAgICAgZm9yIChhdXRvJiBzdGF0ZSA6IG1fY2xpZW50U3Rh dGUpIHsKLSAgICAgICAgICAgIGlmIChzdGF0ZS0+Y29udGV4dElkID09IGNvbnRleHRJZCAmJiBz dGF0ZS0+Y2xpZW50ID09ICZjbGllbnQpCi0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAg ICAgICAgICBzdGF0ZS0+Y2xpZW50LT5zZXRTaG91bGRQbGF5VG9QbGF5YmFja1RhcmdldChzdGF0 ZS0+Y29udGV4dElkLCBmYWxzZSk7Ci0gICAgICAgIH0KLQotICAgICAgICBjaGFuZ2VkQ2xpZW50 U3RhdGUtPmNsaWVudC0+c2V0U2hvdWxkUGxheVRvUGxheWJhY2tUYXJnZXQoY2hhbmdlZENsaWVu dFN0YXRlLT5jb250ZXh0SWQsIHRydWUpOworICAgIGZvciAoYXV0byYgc3RhdGUgOiBtX2NsaWVu dFN0YXRlKSB7CisgICAgICAgIGlmIChzdGF0ZS0+Y29udGV4dElkID09IGNvbnRleHRJZCAmJiBz dGF0ZS0+Y2xpZW50ID09ICZjbGllbnQpCisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAg c3RhdGUtPmNsaWVudC0+c2V0U2hvdWxkUGxheVRvUGxheWJhY2tUYXJnZXQoc3RhdGUtPmNvbnRl eHRJZCwgZmFsc2UpOwogICAgIH0KIAorICAgIGNoYW5nZWRDbGllbnRTdGF0ZS0+Y2xpZW50LT5z ZXRTaG91bGRQbGF5VG9QbGF5YmFja1RhcmdldChjaGFuZ2VkQ2xpZW50U3RhdGUtPmNvbnRleHRJ ZCwgdHJ1ZSk7CisKICAgICBpZiAoaW5kZXggJiYgbV9jbGllbnRTdGF0ZS5zaXplKCkgPiAxKQog ICAgICAgICBzdGQ6OnN3YXAobV9jbGllbnRTdGF0ZS5hdChpbmRleCksIG1fY2xpZW50U3RhdGUu YXQoMCkpOwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CShyZXZpc2lvbiAxODM1ODcpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MTg5LDYgKzYxODksNyBAQCBNZWRpYVByb2R1Y2Vy OjpNZWRpYVN0YXRlRmxhZ3MgSFRNTE1lZGlhCiAgICAgTWVkaWFTdGF0ZUZsYWdzIHN0YXRlID0g SXNOb3RQbGF5aW5nOwogCiAgICAgYm9vbCBoYXNBY3RpdmVWaWRlbyA9IGlzVmlkZW8oKSAmJiBo YXNWaWRlbygpOworICAgIGJvb2wgaGFzQXVkaW8gPSB0aGlzLT5oYXNBdWRpbygpOwogI2lmIEVO QUJMRShXSVJFTEVTU19QTEFZQkFDS19UQVJHRVQpCiAgICAgaWYgKGlzUGxheWluZ1RvV2lyZWxl c3NQbGF5YmFja1RhcmdldCgpKQogICAgICAgICBzdGF0ZSB8PSBJc1BsYXlpbmdUb0V4dGVybmFs RGV2aWNlOwpAQCAtNjE5NywxMiArNjE5OCwxNiBAQCBNZWRpYVByb2R1Y2VyOjpNZWRpYVN0YXRl RmxhZ3MgSFRNTE1lZGlhCiAgICAgICAgIGlmICgobV9oYXNQbGF5YmFja1RhcmdldEF2YWlsYWJp bGl0eUxpc3RlbmVycyB8fCBoYXNBY3RpdmVWaWRlbykgJiYgbV9wbGF5ZXItPmNhblBsYXlUb1dp cmVsZXNzUGxheWJhY2tUYXJnZXQoKSkKICAgICAgICAgICAgIHN0YXRlIHw9IFJlcXVpcmVzUGxh eWJhY2tUYXJnZXRNb25pdG9yaW5nOwogICAgIH0KKworICAgIGlmIChoYXNBY3RpdmVWaWRlbyAm JiBoYXNBdWRpbyAmJiAhbG9vcCgpKQorICAgICAgICBzdGF0ZSB8PSBFeHRlcm5hbERldmljZUF1 dG9QbGF5Q2FuZGlkYXRlOworCiAjZW5kaWYKIAogICAgIGlmICghaXNQbGF5aW5nKCkpCiAgICAg ICAgIHJldHVybiBzdGF0ZTsKIAotICAgIGlmIChoYXNBdWRpbygpICYmICFtdXRlZCgpKQorICAg IGlmIChoYXNBdWRpbyAmJiAhbXV0ZWQoKSkKICAgICAgICAgc3RhdGUgfD0gSXNQbGF5aW5nQXVk aW87CiAKICAgICBpZiAoaGFzQWN0aXZlVmlkZW8pCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdl L01lZGlhUHJvZHVjZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL01lZGlh UHJvZHVjZXIuaAkocmV2aXNpb24gMTgzNTU0KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9NZWRp YVByb2R1Y2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDYgKzM2LDcgQEAgcHVibGljOgogICAg ICAgICBJc1BsYXlpbmdWaWRlbyA9IDEgPDwgMSwKICAgICAgICAgSXNQbGF5aW5nVG9FeHRlcm5h bERldmljZSA9IDEgPDwgMiwKICAgICAgICAgUmVxdWlyZXNQbGF5YmFja1RhcmdldE1vbml0b3Jp bmcgPSAxIDw8IDMsCisgICAgICAgIEV4dGVybmFsRGV2aWNlQXV0b1BsYXlDYW5kaWRhdGUgPSAx IDw8IDQsCiAgICAgfTsKICAgICB0eXBlZGVmIHVuc2lnbmVkIE1lZGlhU3RhdGVGbGFnczsKIAo=