144429 2015-04-29 19:08:45 -0700 LiveNodeList may unexpectedly return an element for empty string 2015-04-29 20:29:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue darin esprehn+autocc joepeck kangil.han oldest_to_newest 1090291 0 joepeck 2015-04-29 19:08:45 -0700 * SUMMARY LiveNodeList may unexpectedly return an element for empty string. * TEST <body> <script> var container = document.createElement("div"); var div = document.createElement("div"); div.id = ""; container.appendChild(div); var div2 = document.createElement("div"); div2.id = "foo"; container.appendChild(div2); var list = container.getElementsByTagName("div"); alert(list[""]); // expected: undefined, actual: div#foo alert(list["foo"]); // expected: div#foo, actual: div#foo </script> * NOTES - Firefox and Chrome both produce the expected results. 1090309 1 252029 joepeck 2015-04-29 19:38:21 -0700 Created attachment 252029 [PATCH] Proposed Fix 1090311 2 252029 darin 2015-04-29 19:41:52 -0700 Comment on attachment 252029 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=252029&action=review > Source/WebCore/dom/LiveNodeList.cpp:57 > + if (elementId.isEmpty()) > + return nullptr; You could put this check after the rootNode.inDocument() block; no need to do even this small amount of extra work in the common case. 1090337 3 joepeck 2015-04-29 20:29:44 -0700 http://trac.webkit.org/changeset/183612 252029 2015-04-29 19:38:21 -0700 2015-04-29 19:55:40 -0700 [PATCH] Proposed Fix livenodelist.patch text/plain 3642 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyM2I0MGY4Li45OWJhZjcwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTUtMDQt MjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBMaXZl Tm9kZUxpc3QgbWF5IHVuZXhwZWN0ZWRseSByZXR1cm4gYW4gZWxlbWVudCBmb3IgZW1wdHkgc3Ry aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ0 MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZh c3QvZG9tL25hbWVkLWl0ZW1zLXdpdGgtZW1wdHktbmFtZS1leHBlY3RlZC50eHQ6CisgICAgICAg ICogZmFzdC9kb20vbmFtZWQtaXRlbXMtd2l0aC1lbXB0eS1uYW1lLmh0bWw6CisKKzIwMTUtMDQt MjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBOb2Rl TGlzdCBoYXMgaXNzdWVzIHdpdGggU3ltYm9sIGFuZCBlbXB0eSBzdHJpbmcKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDMxMAogCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9uYW1lZC1pdGVtcy13aXRoLWVtcHR5LW5hbWUtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vbmFtZWQtaXRlbXMtd2l0aC1lbXB0eS1uYW1l LWV4cGVjdGVkLnR4dAppbmRleCBmNzAyYmUzLi4zZDM0NzA1IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9uYW1lZC1pdGVtcy13aXRoLWVtcHR5LW5hbWUtZXhwZWN0ZWQudHh0Cisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25hbWVkLWl0ZW1zLXdpdGgtZW1wdHktbmFtZS1leHBl Y3RlZC50eHQKQEAgLTcsNCArNyw3IEBAIFBBU1MgZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgn ZGl2JylbJyddID09PSB1bmRlZmluZWQgaXMgdHJ1ZQogUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50 c0J5VGFnTmFtZSgnZGl2JylbJyddID09PSB1bmRlZmluZWQgaXMgdHJ1ZQogUEFTUyBkb2N1bWVu dC5ib2R5LmNoaWxkcmVuWycnXSA9PT0gdW5kZWZpbmVkIGlzIHRydWUKIFBBU1MgZG9jdW1lbnQu YWxsWycnXSA9PT0gdW5kZWZpbmVkIGlzIHRydWUKK1BBU1MgY29udGFpbmVyLnF1ZXJ5U2VsZWN0 b3JBbGwoJ2RpdicpWycnXSA9PT0gdW5kZWZpbmVkIGlzIHRydWUKK1BBU1MgY29udGFpbmVyLmdl dEVsZW1lbnRzQnlUYWdOYW1lKCdkaXYnKVsnJ10gPT09IHVuZGVmaW5lZCBpcyB0cnVlCitQQVNT IGNvbnRhaW5lci5jaGlsZHJlblsnJ10gPT09IHVuZGVmaW5lZCBpcyB0cnVlCiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL25hbWVkLWl0ZW1zLXdpdGgtZW1wdHktbmFtZS5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vbmFtZWQtaXRlbXMtd2l0aC1lbXB0eS1uYW1lLmh0bWwK aW5kZXggZTE3NDkwZi4uNjlkMTYxOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20v bmFtZWQtaXRlbXMtd2l0aC1lbXB0eS1uYW1lLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9k b20vbmFtZWQtaXRlbXMtd2l0aC1lbXB0eS1uYW1lLmh0bWwKQEAgLTE0LDYgKzE0LDE1IEBAIHNo b3VsZEJlVHJ1ZSgiZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgnZGl2JylbJyddID09PSB1bmRl ZmluZWQiKTsKIHNob3VsZEJlVHJ1ZSgiZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2Rp dicpWycnXSA9PT0gdW5kZWZpbmVkIik7CiBzaG91bGRCZVRydWUoImRvY3VtZW50LmJvZHkuY2hp bGRyZW5bJyddID09PSB1bmRlZmluZWQiKTsKIHNob3VsZEJlVHJ1ZSgiZG9jdW1lbnQuYWxsWycn XSA9PT0gdW5kZWZpbmVkIik7CisKKy8vIENvbGxlY3Rpb25zIG5vdCBpbiB0aGUgZG9jdW1lbnQu Cit2YXIgY29udGFpbmVyID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7Cit2YXIgZGl2 ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CitkaXYuaWQgPSAiIjsKK2NvbnRhaW5l ci5hcHBlbmRDaGlsZChkaXYpOworc2hvdWxkQmVUcnVlKCJjb250YWluZXIucXVlcnlTZWxlY3Rv ckFsbCgnZGl2JylbJyddID09PSB1bmRlZmluZWQiKTsKK3Nob3VsZEJlVHJ1ZSgiY29udGFpbmVy LmdldEVsZW1lbnRzQnlUYWdOYW1lKCdkaXYnKVsnJ10gPT09IHVuZGVmaW5lZCIpOworc2hvdWxk QmVUcnVlKCJjb250YWluZXIuY2hpbGRyZW5bJyddID09PSB1bmRlZmluZWQiKTsKIDwvc2NyaXB0 PgogPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2Ny aXB0PgogPC9ib2R5PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdiNWE4MWQuLjg5NmYzNDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsNSArMSwxNiBAQAogMjAxNS0wNC0yOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCisgICAgICAgIExpdmVOb2RlTGlzdCBtYXkgdW5leHBlY3RlZGx5IHJldHVy biBhbiBlbGVtZW50IGZvciBlbXB0eSBzdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDQyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0xpdmVOb2RlTGlzdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpMaXZlTm9kZUxpc3Q6Om5hbWVkSXRlbSk6CisgICAgICAgIE5ldmVyIHJldHVybiBh IHJlc3VsdCBmb3IgYW4gZW1wdHkgc3RyaW5nLgorCisyMDE1LTA0LTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgTm9kZUxpc3QgaGFzIGlzc3VlcyB3 aXRoIFN5bWJvbCBhbmQgZW1wdHkgc3RyaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQzMTAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0xpdmVOb2RlTGlzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTGl2ZU5vZGVMaXN0LmNw cAppbmRleCA0YmJhZmRmLi4zODEyNDRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v TGl2ZU5vZGVMaXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTGl2ZU5vZGVMaXN0LmNw cApAQCAtNTMsNiArNTMsOSBAQCBDb250YWluZXJOb2RlJiBMaXZlTm9kZUxpc3Q6OnJvb3ROb2Rl KCkgY29uc3QKIAogTm9kZSogTGl2ZU5vZGVMaXN0OjpuYW1lZEl0ZW0oY29uc3QgQXRvbWljU3Ry aW5nJiBlbGVtZW50SWQpIGNvbnN0CiB7CisgICAgaWYgKGVsZW1lbnRJZC5pc0VtcHR5KCkpCisg ICAgICAgIHJldHVybiBudWxscHRyOworCiAgICAgLy8gRklYTUU6IFdoeSBkb2Vzbid0IHRoaXMg bG9vayBpbnRvIHRoZSBuYW1lIGF0dHJpYnV0ZSBsaWtlIEhUTUxDb2xsZWN0aW9uOjpuYW1lZEl0 ZW0gZG9lcz8KICAgICBOb2RlJiByb290Tm9kZSA9IHRoaXMtPnJvb3ROb2RlKCk7CiAK