144427 2015-04-29 18:59:51 -0700 Fix the EFL build after r183595 2015-04-30 03:30:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143684 1 hs85.jeong hs85.jeong commit-queue gyuyoung.kim lucas.de.marchi ossy oldest_to_newest 1090286 0 hs85.jeong 2015-04-29 18:59:51 -0700 ../../Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:91:13: error: ‘void WebKit::updateWheelEventTestTriggersIfNeeded(uint64_t)’ defined but not used [-Werror=unused-function] static void updateWheelEventTestTriggersIfNeeded(uint64_t pageID) https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21547/steps/compile-webkit/logs/stdio 1090287 1 252022 hs85.jeong 2015-04-29 19:02:04 -0700 Created attachment 252022 Patch 1090303 2 252022 gyuyoung.kim 2015-04-29 19:27:50 -0700 Comment on attachment 252022 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252022&action=review > Source/WebKit2/ChangeLog:9 > + (WebKit::updateWheelEventTestTriggersIfNeeded): Deleted. Wrong description. updateWheelEventTestTriggersIfNeeded() is guarded by #if ENABLE(CSS_SCROLL_SNAP) || ENABLE(RUBBER_BANDING). 1090308 3 252028 hs85.jeong 2015-04-29 19:36:51 -0700 Created attachment 252028 Patch 1090313 4 hs85.jeong 2015-04-29 19:42:36 -0700 (In reply to comment #2) > Comment on attachment 252022 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252022&action=review > > > Source/WebKit2/ChangeLog:9 > > + (WebKit::updateWheelEventTestTriggersIfNeeded): Deleted. > > Wrong description. updateWheelEventTestTriggersIfNeeded() is guarded by #if > ENABLE(CSS_SCROLL_SNAP) || ENABLE(RUBBER_BANDING). Thanks for the review. I will try to practice the writing description. 1090314 5 252028 gyuyoung.kim 2015-04-29 19:45:38 -0700 Comment on attachment 252028 Patch Clearing flags on attachment: 252028 Committed r183605: <http://trac.webkit.org/changeset/183605> 1090315 6 gyuyoung.kim 2015-04-29 19:45:44 -0700 All reviewed patches have been landed. Closing bug. 252022 2015-04-29 19:02:04 -0700 2015-04-29 19:36:43 -0700 Patch bug-144427-20150430110053.patch text/plain 1898 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTI1MmRhZWZhZmY1MjFl NTFjM2ZhYjlkNWFkNTY4ZGU0NjlkODdkNy4uNWU2MWU0MjM5ZmVlMTlkYjMyYmYxMzBmN2E2MjQx ZTRiMzdiN2MxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA0LTI5ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggdGhlIEVG TCBidWlsZCBhZnRlciByMTgzNTk1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDQ0MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3BwOgor ICAgICAgICAoV2ViS2l0Ojp1cGRhdGVXaGVlbEV2ZW50VGVzdFRyaWdnZXJzSWZOZWVkZWQpOiBE ZWxldGVkLgorCiAyMDE1LTA0LTI5ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgogCiAgICAgICAgIEV4cGFuZCB0ZXN0IGluZnJhc3RydWN0dXJlIHRvIHN1cHBvcnQgc2Nyb2xs aW5nIHRlc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv RXZlbnREaXNwYXRjaGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9F dmVudERpc3BhdGNoZXIuY3BwCmluZGV4IGIyYzlkODk5ZmNiYWQxMDY5NTVjMTNjNDMyNWM5ODk2 MjAwNjlhMmQuLmY3YWE5MDJlMjg0YWJlNzZlMDM3ZmZiYjRmYzEyMDJmODVjMDliYjEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNo ZXIuY3BwCkBAIC04OCw2ICs4OCw3IEBAIHZvaWQgRXZlbnREaXNwYXRjaGVyOjppbml0aWFsaXpl Q29ubmVjdGlvbihJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24pCiAgICAgY29ubmVjdGlvbi0+ YWRkV29ya1F1ZXVlTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2VzOjpFdmVudERpc3BhdGNoZXI6Om1l c3NhZ2VSZWNlaXZlck5hbWUoKSwgJm1fcXVldWUuZ2V0KCksIHRoaXMpOwogfQogCisjaWYgRU5B QkxFKENTU19TQ1JPTExfU05BUCkgfHwgRU5BQkxFKFJVQkJFUl9CQU5ESU5HKQogc3RhdGljIHZv aWQgdXBkYXRlV2hlZWxFdmVudFRlc3RUcmlnZ2Vyc0lmTmVlZGVkKHVpbnQ2NF90IHBhZ2VJRCkK IHsKICAgICBXZWJQYWdlKiB3ZWJQYWdlID0gV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkud2ViUGFn ZShwYWdlSUQpOwpAQCAtOTgsNiArOTksNyBAQCBzdGF0aWMgdm9pZCB1cGRhdGVXaGVlbEV2ZW50 VGVzdFRyaWdnZXJzSWZOZWVkZWQodWludDY0X3QgcGFnZUlEKQogCiAgICAgcGFnZS0+dGVzdFRy aWdnZXIoKS0+ZGVmZXJUZXN0c0ZvclJlYXNvbihyZWludGVycHJldF9jYXN0PFdoZWVsRXZlbnRU ZXN0VHJpZ2dlcjo6U2Nyb2xsYWJsZUFyZWFJZGVudGlmaWVyPihwYWdlKSwgV2hlZWxFdmVudFRl c3RUcmlnZ2VyOjpTY3JvbGxpbmdUaHJlYWRTeW5jTmVlZGVkKTsKIH0KKyNlbmRpZgogCiB2b2lk IEV2ZW50RGlzcGF0Y2hlcjo6d2hlZWxFdmVudCh1aW50NjRfdCBwYWdlSUQsIGNvbnN0IFdlYldo ZWVsRXZlbnQmIHdoZWVsRXZlbnQsIGJvb2wgY2FuUnViYmVyQmFuZEF0TGVmdCwgYm9vbCBjYW5S dWJiZXJCYW5kQXRSaWdodCwgYm9vbCBjYW5SdWJiZXJCYW5kQXRUb3AsIGJvb2wgY2FuUnViYmVy QmFuZEF0Qm90dG9tKQogewo= 252028 2015-04-29 19:36:51 -0700 2015-04-29 19:45:38 -0700 Patch bug-144427-20150430113540.patch text/plain 2006 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTI1MmRhZWZhZmY1MjFl NTFjM2ZhYjlkNWFkNTY4ZGU0NjlkODdkNy4uNTJiOWU5Y2MwMmFjMDk2OTVkNDY2YzE2MmUxYzI5 NjFiMjMxMDg1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTI5ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggdGhlIEVG TCBidWlsZCBhZnRlciByMTgzNTk1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDQ0MjcKKworICAgICAgICBSZXZpZXdlZCBieSBHeXV5b3VuZyBLaW0u CisKKyAgICAgICAgdXBkYXRlV2hlZWxFdmVudFRlc3RUcmlnZ2Vyc0lmTmVlZGVkKCkgaXMgZ3Vh cmRlZCBieSAjaWYgRU5BQkxFKENTU19TQ1JPTExfU05BUCkgfHwgRU5BQkxFKFJVQkJFUl9CQU5E SU5HKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3Bw OgorICAgICAgICAoV2ViS2l0Ojp1cGRhdGVXaGVlbEV2ZW50VGVzdFRyaWdnZXJzSWZOZWVkZWQp OgorCiAyMDE1LTA0LTI5ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIEV4cGFuZCB0ZXN0IGluZnJhc3RydWN0dXJlIHRvIHN1cHBvcnQgc2Nyb2xsaW5nIHRl c3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRXZlbnRE aXNwYXRjaGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERp c3BhdGNoZXIuY3BwCmluZGV4IGIyYzlkODk5ZmNiYWQxMDY5NTVjMTNjNDMyNWM5ODk2MjAwNjlh MmQuLmY3YWE5MDJlMjg0YWJlNzZlMDM3ZmZiYjRmYzEyMDJmODVjMDliYjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3Bw CkBAIC04OCw2ICs4OCw3IEBAIHZvaWQgRXZlbnREaXNwYXRjaGVyOjppbml0aWFsaXplQ29ubmVj dGlvbihJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24pCiAgICAgY29ubmVjdGlvbi0+YWRkV29y a1F1ZXVlTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2VzOjpFdmVudERpc3BhdGNoZXI6Om1lc3NhZ2VS ZWNlaXZlck5hbWUoKSwgJm1fcXVldWUuZ2V0KCksIHRoaXMpOwogfQogCisjaWYgRU5BQkxFKENT U19TQ1JPTExfU05BUCkgfHwgRU5BQkxFKFJVQkJFUl9CQU5ESU5HKQogc3RhdGljIHZvaWQgdXBk YXRlV2hlZWxFdmVudFRlc3RUcmlnZ2Vyc0lmTmVlZGVkKHVpbnQ2NF90IHBhZ2VJRCkKIHsKICAg ICBXZWJQYWdlKiB3ZWJQYWdlID0gV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkud2ViUGFnZShwYWdl SUQpOwpAQCAtOTgsNiArOTksNyBAQCBzdGF0aWMgdm9pZCB1cGRhdGVXaGVlbEV2ZW50VGVzdFRy aWdnZXJzSWZOZWVkZWQodWludDY0X3QgcGFnZUlEKQogCiAgICAgcGFnZS0+dGVzdFRyaWdnZXIo KS0+ZGVmZXJUZXN0c0ZvclJlYXNvbihyZWludGVycHJldF9jYXN0PFdoZWVsRXZlbnRUZXN0VHJp Z2dlcjo6U2Nyb2xsYWJsZUFyZWFJZGVudGlmaWVyPihwYWdlKSwgV2hlZWxFdmVudFRlc3RUcmln Z2VyOjpTY3JvbGxpbmdUaHJlYWRTeW5jTmVlZGVkKTsKIH0KKyNlbmRpZgogCiB2b2lkIEV2ZW50 RGlzcGF0Y2hlcjo6d2hlZWxFdmVudCh1aW50NjRfdCBwYWdlSUQsIGNvbnN0IFdlYldoZWVsRXZl bnQmIHdoZWVsRXZlbnQsIGJvb2wgY2FuUnViYmVyQmFuZEF0TGVmdCwgYm9vbCBjYW5SdWJiZXJC YW5kQXRSaWdodCwgYm9vbCBjYW5SdWJiZXJCYW5kQXRUb3AsIGJvb2wgY2FuUnViYmVyQmFuZEF0 Qm90dG9tKQogewo=