144424 2015-04-29 17:51:26 -0700 AX: AccessibilityTable::isDataTable() should return false for non-<table> elements that use CSS table display values 2015-05-13 00:06:43 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED DUPLICATE 144804 InRadar P2 Normal --- 1 jcraig webkit-unassigned webkit-bug-importer oldest_to_newest 1090261 0 252015 jcraig 2015-04-29 17:51:26 -0700 Created attachment 252015 test case AccessibilityTable::isDataTable() needs an update that excludes elements from most of the heuristic considerations if the element is not a native <table> element. In other words, no matter its style properties, an element should never be exposed as AXTable unless the element is <table>, or explicitly uses "table", "grid", or "treegrid" as the value of the role attribute. The additional heuristics like border detection should only be applied to <table> elements that have no explicit role. Test case from Marco Ranon: <rdar://problem/19745053> 1090262 1 webkit-bug-importer 2015-04-29 17:52:10 -0700 <rdar://problem/20756519> 1090263 2 jcraig 2015-04-29 17:54:04 -0700 I think this will be as simple as: if (!this.hasTagName(tableTag)) return false; ...but WebKit is not building for me at the moment. Need to make sure that does not break, legitimate ARIA 1.0 grids/treegrids and ARIA 1.1 tables. 1090264 3 jcraig 2015-04-29 17:54:20 -0700 <rdar://problem/19745053> 1094428 4 jcraig 2015-05-13 00:06:43 -0700 Forward duping to bug 144804 *** This bug has been marked as a duplicate of bug 144804 *** 252015 2015-04-29 17:51:26 -0700 2015-04-29 17:51:26 -0700 test case VO-BUG-faux-table-hidden-content.html text/html 2757 jcraig PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+Cgk8bWV0YSBjaGFyc2V0PSJ1 dGYtOCIgLz4KCTx0aXRsZT5Wb2ljZU92ZXIgZXhwb3NlcyBhICZsdDtkaXYmZ3Q7IHdpdGggZGlz cGxheTp0YWJsZSBhbmQgb25seSB0aHJlZSBjaGlsZHJlbiBhcyBhIHRhYmxlIGlmIGl0IGhhcyBh IGJvcmRlciwgYnV0IGRvZXMgbm90IGFsbG93IHRvIGVudGVyIGl0PC90aXRsZT4KCQoJPHN0eWxl IHR5cGU9InRleHQvY3NzIj4KCQkqIHsJCgkJCWZvbnQtZmFtaWx5OiAiTXlyaWFkIFNldCBQcm8i LCAiTHVjaWRhIEdyYW5kZSIsIEhlbHZldGljYSwgQXJpYWwsIFZlcmRhbmEsIHNhbnMtc2VyaWY7 CgkJfQoJCQoJCS5hMTF5IHsgIAoJCQlwb3NpdGlvbjogYWJzb2x1dGUgIWltcG9ydGFudDsKCQkJ aGVpZ2h0OiAxcHg7CgkJCXdpZHRoOiAxcHg7IAoJCQlvdmVyZmxvdzogaGlkZGVuOwoJCQljbGlw OiByZWN0KDFweCwgMXB4LCAxcHgsIDFweCk7CgkJfQoKCQkubGF5b3V0LXRhYmxlIHsKCQkJZGlz cGxheTp0YWJsZTsKCQl9CgoJCS5sYXlvdXQtdGFibGUgLnNlY29uZC1jZWxsLCAubGF5b3V0LXRh YmxlIC50aGlyZC1jZWxsLCAubGF5b3V0LXRhYmxlIC50aGlyZC1jZWxsLW5vLWJvcmRlciB7CgkJ CWRpc3BsYXk6IHRhYmxlLWNlbGw7CgkJfQoKCQkubGF5b3V0LXRhYmxlIC50aGlyZC1jZWxsIHsK CQkJYm9yZGVyLWxlZnQ6IDVweCBzb2xpZCAjZjAwOwoJCX0KCgkJLm5vdGVzIHsKCQkJYm9yZGVy OiAxcHggc29saWQgIzAwMDsKCQkJcGFkZGluZzogMCAxMHB4OwoJCQl3aWR0aDogNDBlbTsKCQkJ YmFja2dyb3VuZC1jb2xvcjogI2ZmYTsKCQkJbWFyZ2luLXRvcDogMTBweDsKCQl9CgoJCS5wYXNz IHsKCQkJYmFja2dyb3VuZC1jb2xvcjogI2NmYzsKCQl9CgoJCS5mYWlsIHsKCQkJYmFja2dyb3Vu ZC1jb2xvcjogI2ZjYzsKCQl9CQkJCQoKCTwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+Cgk8aDE+Vm9p Y2VPdmVyIGV4cG9zZXMgYSAmbHQ7ZGl2Jmd0OyB3aXRoIGRpc3BsYXk6dGFibGUgYW5kIG9ubHkg dGhyZWUgY2hpbGRyZW4gYXMgYSB0YWJsZSBpZiBpdCBoYXMgYSBib3JkZXIsIGJ1dCBkb2VzIG5v dCBhbGxvdyB0byBlbnRlciBpdDwvaDE+Cgk8aDI+RmF1eCB0YWJsZSB3aXRoIHRocmVlIERJVnMg KGZpcnN0IHZpc3VhbGx5IGhpZGRlbiksIG5vIGJvcmRlcnM8L2gyPgoJPGRpdiBjbGFzcz0ibGF5 b3V0LXRhYmxlIj4KCQk8ZGl2IGNsYXNzPSJmaXJzdC1jZWxsIGExMXkiPlZpc3VhbGx5IGhpZGRl biBkaXY8L2Rpdj4KCQk8ZGl2IGNsYXNzPSJzZWNvbmQtY2VsbCI+TGVmdCBkaXY8L2Rpdj4KCQk8 ZGl2IGNsYXNzPSJ0aGlyZC1jZWxsLW5vLWJvcmRlciI+UmlnaHQgZGl2PC9kaXY+Cgk8L2Rpdj4J Cgk8ZGl2IGNsYXNzPSJub3RlcyBwYXNzIj4KCQk8aDM+T1MgWDwvaDM+CgkJPGRsPgoJCQk8ZHQ+ RXhwZWN0ZWQgYmVoYXZpb3VyOjwvZHQ+CgkJCTxkZD5WTyBuZXZlciBleHBvc2VzIHRoZSBtYXJr dXAgYXMgYSB0YWJsZS48L2RkPgoJCQk8ZHQ+QWN0dWFsIGJlaGF2aW91cjo8L2R0PgoJCQk8ZGQ+ Vk8gbmV2ZXIgZXhwb3NlcyB0aGUgbWFya3VwIGFzIGEgdGFibGUuPC9kZD4KCQk8L2RsPgoJPC9k aXY+Cgk8ZGl2IGNsYXNzPSJub3RlcyBwYXNzIj4KCQk8aDM+aU9TPC9oMz4KCQk8ZGw+CgkJCTxk dD5FeHBlY3RlZCBiZWhhdmlvdXI6PC9kdD4KCQkJPGRkPlZPIG5ldmVyIGV4cG9zZXMgdGhlIG1h cmt1cCBhcyBhIHRhYmxlLjwvZGQ+CgkJCTxkdD5BY3R1YWwgYmVoYXZpb3VyOjwvZHQ+CgkJCTxk ZD5WTyBuZXZlciBleHBvc2VzIHRoZSBtYXJrdXAgYXMgYSB0YWJsZS48L2RkPgoJCTwvZGw+Cgk8 L2Rpdj4KCgk8aDI+RmF1eCB0YWJsZSB3aXRoIHRocmVlIERJVnMgKGZpcnN0IHZpc3VhbGx5IGhp ZGRlbikgYW5kIGEgYm9yZGVyczwvaDI+Cgk8ZGl2IGNsYXNzPSJsYXlvdXQtdGFibGUiPgoJCTxk aXYgY2xhc3M9ImZpcnN0LWNlbGwgYTExeSI+VmlzdWFsbHkgaGlkZGVuIGRpdjwvZGl2PgoJCTxk aXYgY2xhc3M9InNlY29uZC1jZWxsIj5MZWZ0IGRpdjwvZGl2PgoJCTxkaXYgY2xhc3M9InRoaXJk LWNlbGwiPlJpZ2h0IGRpdjwvZGl2PgoJPC9kaXY+CQoJPGRpdiBjbGFzcz0ibm90ZXMgZmFpbCI+ CgkJPGgzPk9TIFg8L2gzPgoJCTxkbD4KCQkJPGR0PkV4cGVjdGVkIGJlaGF2aW91cjo8L2R0PgoJ CQk8ZGQ+Vk8gbmV2ZXIgZXhwb3NlcyB0aGUgbWFya3VwIGFzIGEgdGFibGUuPC9kZD4KCQkJPGR0 PkFjdHVhbCBiZWhhdmlvdXI6PC9kdD4KCQkJPGRkPgoJCQkJPHVsPgoJCQkJCTxsaT5GaXJzdCBs b2FkOiBWTyBleHBvc2VzIGEgdGFibGUgKDMgY29sIDEgcm93KSBhbmQgZG9lcyBub3QgYWxsb3cg dG8gZW50ZXIgdGhlIHRhYmxlLjwvbGk+CgkJCQkJPGxpPkFmdGVyIHJlbG9hZDogVk8gZXhwb3Nl cyBhIHRhYmxlICgzIGNvbCAxIHJvdykgYW5kIGRvZXMgYWxsb3cgdG8gZW50ZXIgdGhlIHRhYmxl LjwvbGk+CgkJCQk8L3VsPgoJCQk8L2RkPgoJCTwvZGw+Cgk8L2Rpdj4KCTxkaXYgY2xhc3M9Im5v dGVzIGZhaWwiPgoJCTxoMz5pT1M8L2gzPgoJCTxkbD4KCQkJPGR0PkV4cGVjdGVkIGJlaGF2aW91 cjo8L2R0PgoJCQk8ZGQ+Vk8gbmV2ZXIgZXhwb3NlcyB0aGUgbWFya3VwIGFzIGEgdGFibGUuPC9k ZD4KCQkJPGR0PkFjdHVhbCBiZWhhdmlvdXI6PC9kdD4KCQkJPGRkPlZPIGV4cG9zZXMgdGhlIG1h cmt1cCBhcyBhIHRhYmxlIGFuZCBhbGxvd3MgdG8gZW50ZXIgaXQuPC9kZD4KCQk8L2RsPgoJPC9k aXY+Cgo8L2JvZHk+CjwvaHRtbD4K