144418 2015-04-29 16:03:31 -0700 UI process sometimes crashes under _takeViewSnapshot when the window is off-screen 2015-04-29 16:21:24 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton webkit-unassigned ap commit-queue simon.fraser oldest_to_newest 1090201 0 252000 thorton 2015-04-29 16:03:31 -0700 Created attachment 252000 null-checks If the window is off-screen, we can't snapshot it. 1090202 1 thorton 2015-04-29 16:03:39 -0700 <rdar://problem/20740278> 1090206 2 commit-queue 2015-04-29 16:05:10 -0700 Attachment 252000 did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1090210 3 252000 ap 2015-04-29 16:09:39 -0700 Comment on attachment 252000 null-checks View in context: https://bugs.webkit.org/attachment.cgi?id=252000&action=review > Source/WebKit2/ChangeLog:4 > + Need the bug URL (OOPS!). No? 1090212 4 thorton 2015-04-29 16:21:24 -0700 http://trac.webkit.org/changeset/183588 252000 2015-04-29 16:03:31 -0700 2015-04-29 16:09:39 -0700 null-checks a.diff text/plain 2169 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwZGY1M2ZhLi5jMjg5MDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTUtMDQtMjkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgVUkgcHJvY2VzcyBzb21ldGltZXMgY3Jhc2hlcyB1bmRlciBfdGFrZVZpZXdTbmFw c2hvdCB3aGVuIHRoZSB3aW5kb3cgaXMgb2ZmLXNjcmVlbgorICAgICAgICBOZWVkIHRoZSBidWcg VVJMIChPT1BTISkuCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMDc0MDI3OD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv bWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IF90YWtlVmlld1NuYXBzaG90XSk6Cisg ICAgICAgIE51bGwtY2hlY2sgdGhlIGFycmF5IGJlZm9yZSBjaGVja2luZyBpZiBpdCBoYXMgYW55 IGl0ZW1zLgorICAgICAgICBJZiB0aGUgd2luZG93IGlzIG9mZi1zY3JlZW4sIHdlIGNhbid0IHNu YXBzaG90IGl0LgorCiAyMDE1LTA0LTI4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9A aWdhbGlhLmNvbT4KIAogICAgICAgICBGdWxseSByZXBsYWNlIEVOQUJMRV9MTElOVF9DX0xPT1Ag d2l0aCBFTkFCTEVfSklUCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L21hYy9XS1ZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcu bW0KaW5kZXggOTcxYmFmOS4uOWFlM2VlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL1dLVmlldy5tbQpAQCAtMzM3Miw3ICszMzcyLDcgQEAgc3RhdGljIHZvaWQqIGtleVZh bHVlT2JzZXJ2aW5nQ29udGV4dCA9ICZrZXlWYWx1ZU9ic2VydmluZ0NvbnRleHQ7CiAKICAgICBD R1NXaW5kb3dDYXB0dXJlT3B0aW9ucyBvcHRpb25zID0ga0NHU0NhcHR1cmVJZ25vcmVHbG9iYWxD bGlwU2hhcGU7CiAgICAgUmV0YWluUHRyPENGQXJyYXlSZWY+IHdpbmRvd1NuYXBzaG90SW1hZ2Vz ID0gYWRvcHRDRihDR1NIV0NhcHR1cmVXaW5kb3dMaXN0KENHU01haW5Db25uZWN0aW9uSUQoKSwg JndpbmRvd0lELCAxLCBvcHRpb25zKSk7Ci0gICAgaWYgKCFDRkFycmF5R2V0Q291bnQod2luZG93 U25hcHNob3RJbWFnZXMuZ2V0KCkpKQorICAgIGlmICghd2luZG93U25hcHNob3RJbWFnZXMgfHwg IUNGQXJyYXlHZXRDb3VudCh3aW5kb3dTbmFwc2hvdEltYWdlcy5nZXQoKSkpCiAgICAgICAgIHJl dHVybiBudWxscHRyOwogCiAgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IHdpbmRvd1NuYXBzaG90 SW1hZ2UgPSAoQ0dJbWFnZVJlZilDRkFycmF5R2V0VmFsdWVBdEluZGV4KHdpbmRvd1NuYXBzaG90 SW1hZ2VzLmdldCgpLCAwKTsKQEAgLTMzODIsNyArMzM4Miw3IEBAIHN0YXRpYyB2b2lkKiBrZXlW YWx1ZU9ic2VydmluZ0NvbnRleHQgPSAma2V5VmFsdWVPYnNlcnZpbmdDb250ZXh0OwogICAgIGlm IChDR0ltYWdlR2V0V2lkdGgod2luZG93U25hcHNob3RJbWFnZS5nZXQoKSkgIT0gZGVzaXJlZFNu YXBzaG90V2lkdGgpIHsKICAgICAgICAgb3B0aW9ucyB8PSBrQ0dTV2luZG93Q2FwdHVyZU5vbWlu YWxSZXNvbHV0aW9uOwogICAgICAgICB3aW5kb3dTbmFwc2hvdEltYWdlcyA9IGFkb3B0Q0YoQ0dT SFdDYXB0dXJlV2luZG93TGlzdChDR1NNYWluQ29ubmVjdGlvbklEKCksICZ3aW5kb3dJRCwgMSwg b3B0aW9ucykpOwotICAgICAgICBpZiAoIUNGQXJyYXlHZXRDb3VudCh3aW5kb3dTbmFwc2hvdElt YWdlcy5nZXQoKSkpCisgICAgICAgIGlmICghd2luZG93U25hcHNob3RJbWFnZXMgfHwgIUNGQXJy YXlHZXRDb3VudCh3aW5kb3dTbmFwc2hvdEltYWdlcy5nZXQoKSkpCiAgICAgICAgICAgICByZXR1 cm4gbnVsbHB0cjsKICAgICAgICAgd2luZG93U25hcHNob3RJbWFnZSA9IChDR0ltYWdlUmVmKUNG QXJyYXlHZXRWYWx1ZUF0SW5kZXgod2luZG93U25hcHNob3RJbWFnZXMuZ2V0KCksIDApOwogICAg IH0K