<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>144416</bug_id>
          
          <creation_ts>2015-04-29 15:58:13 -0700</creation_ts>
          <short_desc>http/tests/cache/main-resource-304-reload.html failing on Windows</short_desc>
          <delta_ts>2015-05-01 22:12:38 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Page Loading</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=144386</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>LayoutTestFailure, PlatformOnly</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jon Honeycutt">jhoneycutt</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>koivisto</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1090196</commentid>
    <comment_count>0</comment_count>
    <who name="Jon Honeycutt">jhoneycutt</who>
    <bug_when>2015-04-29 15:58:13 -0700</bug_when>
    <thetext>http/tests/cache/main-resource-304-reload.html is failing on Windows.

&lt;https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r183568%20(51454)/results.html&gt;

&lt;https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r183572%20(51455)/http/tests/cache/main-resource-304-reload-pretty-diff.html&gt;

It&apos;s not clear to me from the test whether this is an error that can be fixed by modifying the PHP script to use array_key_exists() or whether this is an Apache configuration issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090319</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2015-04-29 19:52:08 -0700</bug_when>
    <thetext>I&apos;m pretty sure that isset would do the trick:

if (isset($_SERVER[&quot;HTTP_IF_MODIFIED_SINCE&quot;])) {

&gt;     header(&quot;HTTP/1.0 304 Not Modified&quot;);

Why 1.0? Really weird to mix that with Cache-Control and ETags.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090381</commentid>
    <comment_count>2</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2015-04-30 00:33:53 -0700</bug_when>
    <thetext>I just copied and lightly modified the script from LayoutTests/http/tests/cache/resources/iframe304.php. That is indeed silly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090382</commentid>
    <comment_count>3</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2015-04-30 00:43:40 -0700</bug_when>
    <thetext>Switched both scripts to say HTTP/1.1 in https://trac.webkit.org/r183623. No idea if that fixes anything. This test was already marked failing on Windows in http://trac.webkit.org/changeset/183573</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091045</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2015-05-01 22:12:38 -0700</bug_when>
    <thetext>To fix the test, please see the first part of my comment, and use the isset() function.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>