144398 2015-04-29 10:21:32 -0700 Evict IsEnvironmentRecord from inline type flags 2015-04-29 10:40:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 144397 1 fpizlo fpizlo barraclough benjamin ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1090054 0 fpizlo 2015-04-29 10:21:32 -0700 It's not important enough to be inline. This will make room for more important things. 1090056 1 251965 fpizlo 2015-04-29 10:25:54 -0700 Created attachment 251965 the patch 1090058 2 251965 mark.lam 2015-04-29 10:30:38 -0700 Comment on attachment 251965 the patch r=me 1090059 3 251965 msaboff 2015-04-29 10:31:36 -0700 Comment on attachment 251965 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=251965&action=review r=me with nit. > Source/JavaScriptCore/ChangeLog:9 > + type flags. This change picks the least important inline time flag - IsEnvironmentRecord - nit - should this say - "... important inline *type* flag."? 1090062 4 fpizlo 2015-04-29 10:40:03 -0700 Landed in http://trac.webkit.org/changeset/183557 251965 2015-04-29 10:25:54 -0700 2015-04-29 10:30:38 -0700 the patch blah.patch text/plain 4310 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgzNTU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE1LTA0LTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RXZpY3QgSXNFbnZpcm9ubWVudFJlY29yZCBmcm9tIGlubGluZSB0eXBlIGZsYWdzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQzOTgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEluIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQzOTcsIHdlJ2xsIG5lZWQgYW4g ZXh0cmEgYml0IGluIHRoZSBpbmxpbmUKKyAgICAgICAgdHlwZSBmbGFncy4gVGhpcyBjaGFuZ2Ug cGlja3MgdGhlIGxlYXN0IGltcG9ydGFudCBpbmxpbmUgdGltZSBmbGFnIC0gSXNFbnZpcm9ubWVu dFJlY29yZCAtCisgICAgICAgIGFuZCBldmljdHMgaXQgaW50byB0aGUgb3V0LW9mLWxpbmUgdHlw ZSBmbGFncy4gVGhpcyBjaGFuZ2UgaGFzIG5vIHBlcmZvcm1hbmNlIGltcGxpY2F0aW9ucworICAg ICAgICBiZWNhdXNlIHdlIG5ldmVyIGV2ZW4gYWNjZXNzZWQgSXNFbnZpcm9ubWVudFJlY29yZCB2 aWEgdGhlIFN0cnVjdHVyZUlEQmxvYi4gVGhlIG9ubHkgcGxhY2UKKyAgICAgICAgd2hlcmUgd2Ug YWNjZXNzIGl0IGF0IGFsbCBpcyBpbiBTdHJpbmcucHJvdG90eXBlLnJlcGVhdCwgYW5kIHRoZXJl IHdlIGFscmVhZHkgbG9hZCB0aGUKKyAgICAgICAgc3RydWN0dXJlIGFueXdheS4KKworICAgICAg ICAqIHJ1bnRpbWUvSlNUeXBlSW5mby5oOgorICAgICAgICAoSlNDOjpUeXBlSW5mbzo6aW1wbGVt ZW50c0hhc0luc3RhbmNlKToKKyAgICAgICAgKEpTQzo6VHlwZUluZm86OnN0cnVjdHVyZUlzSW1t b3J0YWwpOgorICAgICAgICAoSlNDOjpUeXBlSW5mbzo6aXNFbnZpcm9ubWVudFJlY29yZCk6CisK IDIwMTUtMDQtMjkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtF UzZdIEltcGxlbWVudCBVbmljb2RlIGNvZGUgcG9pbnQgZXNjYXBlcwpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNUeXBlSW5mby5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTVHlwZUluZm8uaAkocmV2aXNpb24gMTgzNTQ3KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNUeXBlSW5mby5oCSh3b3JraW5nIGNvcHkp CkBAIC0xLDYgKzEsNiBAQAogLy8gLSotIG1vZGU6IGMrKzsgYy1iYXNpYy1vZmZzZXQ6IDQgLSot CiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOCwgMjAxNSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTQwLDcgKzQwLDYgQEAg c3RhdGljIGNvbnN0IHVuc2lnbmVkIE1hc3F1ZXJhZGVzQXNVbmRlZgogc3RhdGljIGNvbnN0IHVu c2lnbmVkIEltcGxlbWVudHNIYXNJbnN0YW5jZSA9IDEgPDwgMTsKIHN0YXRpYyBjb25zdCB1bnNp Z25lZCBPdmVycmlkZXNIYXNJbnN0YW5jZSA9IDEgPDwgMjsKIHN0YXRpYyBjb25zdCB1bnNpZ25l ZCBJbXBsZW1lbnRzRGVmYXVsdEhhc0luc3RhbmNlID0gMSA8PCAzOwotc3RhdGljIGNvbnN0IHVu c2lnbmVkIElzRW52aXJvbm1lbnRSZWNvcmQgPSAxIDw8IDQ7CiBzdGF0aWMgY29uc3QgdW5zaWdu ZWQgT3ZlcnJpZGVzR2V0T3duUHJvcGVydHlTbG90ID0gMSA8PCA1Owogc3RhdGljIGNvbnN0IHVu c2lnbmVkIEludGVyY2VwdHNHZXRPd25Qcm9wZXJ0eVNsb3RCeUluZGV4RXZlbldoZW5MZW5ndGhJ c05vdFplcm8gPSAxIDw8IDY7CiBzdGF0aWMgY29uc3QgdW5zaWduZWQgU3RydWN0dXJlSXNJbW1v cnRhbCA9IDEgPDwgNzsKQEAgLTQ5LDYgKzQ4LDcgQEAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIE92 ZXJyaWRlc0dldFByb3Blcgogc3RhdGljIGNvbnN0IHVuc2lnbmVkIFByb2hpYml0c1Byb3BlcnR5 Q2FjaGluZyA9IDEgPDwgOTsKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBIYXNJbXB1cmVHZXRPd25Q cm9wZXJ0eVNsb3QgPSAxIDw8IDEwOwogc3RhdGljIGNvbnN0IHVuc2lnbmVkIE5ld0ltcHVyZVBy b3BlcnR5RmlyZXNXYXRjaHBvaW50cyA9IDEgPDwgMTE7CitzdGF0aWMgY29uc3QgdW5zaWduZWQg SXNFbnZpcm9ubWVudFJlY29yZCA9IDEgPDwgMTI7CiAKIGNsYXNzIFR5cGVJbmZvIHsKIHB1Ymxp YzoKQEAgLTgxLDE3ICs4MSwxNyBAQCBwdWJsaWM6CiAgICAgdW5zaWduZWQgZmxhZ3MoKSBjb25z dCB7IHJldHVybiAoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG1fZmxhZ3MyKSA8PCA4KSB8IHN0YXRp Y19jYXN0PHVuc2lnbmVkPihtX2ZsYWdzKTsgfQogICAgIGJvb2wgbWFzcXVlcmFkZXNBc1VuZGVm aW5lZCgpIGNvbnN0IHsgcmV0dXJuIGlzU2V0T25GbGFnczEoTWFzcXVlcmFkZXNBc1VuZGVmaW5l ZCk7IH0KICAgICBib29sIGltcGxlbWVudHNIYXNJbnN0YW5jZSgpIGNvbnN0IHsgcmV0dXJuIGlz U2V0T25GbGFnczEoSW1wbGVtZW50c0hhc0luc3RhbmNlKTsgfQotICAgIGJvb2wgaXNFbnZpcm9u bWVudFJlY29yZCgpIGNvbnN0IHsgcmV0dXJuIGlzU2V0T25GbGFnczEoSXNFbnZpcm9ubWVudFJl Y29yZCk7IH0KICAgICBib29sIG92ZXJyaWRlc0hhc0luc3RhbmNlKCkgY29uc3QgeyByZXR1cm4g aXNTZXRPbkZsYWdzMShPdmVycmlkZXNIYXNJbnN0YW5jZSk7IH0KICAgICBib29sIGltcGxlbWVu dHNEZWZhdWx0SGFzSW5zdGFuY2UoKSBjb25zdCB7IHJldHVybiBpc1NldE9uRmxhZ3MxKEltcGxl bWVudHNEZWZhdWx0SGFzSW5zdGFuY2UpOyB9CiAgICAgYm9vbCBvdmVycmlkZXNHZXRPd25Qcm9w ZXJ0eVNsb3QoKSBjb25zdCB7IHJldHVybiBvdmVycmlkZXNHZXRPd25Qcm9wZXJ0eVNsb3QoaW5s aW5lVHlwZUZsYWdzKCkpOyB9CiAgICAgc3RhdGljIGJvb2wgb3ZlcnJpZGVzR2V0T3duUHJvcGVy dHlTbG90KElubGluZVR5cGVGbGFncyBmbGFncykgeyByZXR1cm4gZmxhZ3MgJiBPdmVycmlkZXNH ZXRPd25Qcm9wZXJ0eVNsb3Q7IH0KICAgICBib29sIGludGVyY2VwdHNHZXRPd25Qcm9wZXJ0eVNs b3RCeUluZGV4RXZlbldoZW5MZW5ndGhJc05vdFplcm8oKSBjb25zdCB7IHJldHVybiBpc1NldE9u RmxhZ3MxKEludGVyY2VwdHNHZXRPd25Qcm9wZXJ0eVNsb3RCeUluZGV4RXZlbldoZW5MZW5ndGhJ c05vdFplcm8pOyB9CisgICAgYm9vbCBzdHJ1Y3R1cmVJc0ltbW9ydGFsKCkgY29uc3QgeyByZXR1 cm4gaXNTZXRPbkZsYWdzMShTdHJ1Y3R1cmVJc0ltbW9ydGFsKTsgfQogICAgIGJvb2wgb3ZlcnJp ZGVzR2V0UHJvcGVydHlOYW1lcygpIGNvbnN0IHsgcmV0dXJuIGlzU2V0T25GbGFnczIoT3ZlcnJp ZGVzR2V0UHJvcGVydHlOYW1lcyk7IH0KICAgICBib29sIHByb2hpYml0c1Byb3BlcnR5Q2FjaGlu ZygpIGNvbnN0IHsgcmV0dXJuIGlzU2V0T25GbGFnczIoUHJvaGliaXRzUHJvcGVydHlDYWNoaW5n KTsgfQogICAgIGJvb2wgaGFzSW1wdXJlR2V0T3duUHJvcGVydHlTbG90KCkgY29uc3QgeyByZXR1 cm4gaXNTZXRPbkZsYWdzMihIYXNJbXB1cmVHZXRPd25Qcm9wZXJ0eVNsb3QpOyB9CiAgICAgYm9v bCBuZXdJbXB1cmVQcm9wZXJ0eUZpcmVzV2F0Y2hwb2ludHMoKSBjb25zdCB7IHJldHVybiBpc1Nl dE9uRmxhZ3MyKE5ld0ltcHVyZVByb3BlcnR5RmlyZXNXYXRjaHBvaW50cyk7IH0KLSAgICBib29s IHN0cnVjdHVyZUlzSW1tb3J0YWwoKSBjb25zdCB7IHJldHVybiBpc1NldE9uRmxhZ3MxKFN0cnVj dHVyZUlzSW1tb3J0YWwpOyB9CisgICAgYm9vbCBpc0Vudmlyb25tZW50UmVjb3JkKCkgY29uc3Qg eyByZXR1cm4gaXNTZXRPbkZsYWdzMihJc0Vudmlyb25tZW50UmVjb3JkKTsgfQogCiAgICAgc3Rh dGljIHB0cmRpZmZfdCBmbGFnc09mZnNldCgpCiAgICAgewo=