144388 2015-04-29 06:39:21 -0700 REGRESSION(r182573): [GTK] The default context menu contains an empty item since r182573 2015-04-29 08:51:04 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned beidson darin thorton oldest_to_newest 1089979 0 cgarcia 2015-04-29 06:39:21 -0700 There used to be a method in ContextMenuItem to check if share menu item was supported or not, but since r182573, there's a method to get the share menu item. If the returned menu item is null, it's not added to the menu, but we are not returning a null ContextMenu item even though we don't support share menu item. 1089980 1 251948 cgarcia 2015-04-29 06:41:50 -0700 Created attachment 251948 Patch 1090005 2 cgarcia 2015-04-29 08:51:04 -0700 Committed r183547: <http://trac.webkit.org/changeset/183547> 251948 2015-04-29 06:41:50 -0700 2015-04-29 07:22:09 -0700 Patch wk2-share-context-menu-item.diff text/plain 5523 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZWEwMjIyLi5lZTZmM2EwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTUtMDQtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4MjU3Myk6IFtHVEtdIFRoZSBkZWZhdWx0IGNvbnRl eHQgbWVudSBjb250YWlucyBhbiBlbXB0eSBpdGVtIHNpbmNlIHIxODI1NzMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDM4OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIHVzZWQgdG8gYmUgYSBt ZXRob2QgaW4gQ29udGV4dE1lbnVJdGVtIHRvIGNoZWNrIGlmIHNoYXJlCisgICAgICAgIG1lbnUg aXRlbSB3YXMgc3VwcG9ydGVkIG9yIG5vdCwgYnV0IHNpbmNlIHIxODI1NzMsIHRoZXJlJ3MgYQor ICAgICAgICBtZXRob2QgdG8gZ2V0IHRoZSBzaGFyZSBtZW51IGl0ZW0uIElmIHRoZSByZXR1cm5l ZCBtZW51IGl0ZW0gaXMKKyAgICAgICAgbnVsbCwgaXQncyBub3QgYWRkZWQgdG8gdGhlIG1lbnUs IGJ1dCB3ZSBhcmUgbm90IHJldHVybmluZyBhIG51bGwKKyAgICAgICAgQ29udGV4dE1lbnUgaXRl bSBldmVuIHRob3VnaCB3ZSBkb24ndCBzdXBwb3J0IHNoYXJlIG1lbnUgaXRlbS4KKworICAgICAg ICAqIHBsYXRmb3JtL2d0ay9Db250ZXh0TWVudUl0ZW1HdGsuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q29udGV4dE1lbnVJdGVtOjpzaGFyZU1lbnVJdGVtKTogUmV0dXJuIGEgbnVsbCBDb250ZXh0 TWVudUl0ZW0uCisKIDIwMTUtMDQtMjkgIEh5dW5nd29vayBMZWUgIDxoeXVuZ3dvb2subGVlQG5h dmVyY29ycC5jb20+CiAKICAgICAgICAgRml4IGNyYXNoIGluIFdlYkNvcmU6OkxvZ2ljYWxTZWxl Y3Rpb25PZmZzZXRDYWNoZXM6OkNvbnRhaW5pbmdCbG9ja0luZm86OnNldEJsb2NrKCkuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ29udGV4dE1lbnVJdGVtR3RrLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Db250ZXh0TWVudUl0ZW1HdGsuY3BwCmlu ZGV4IGY3MGZmMjEuLmM0MGIzNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9Db250ZXh0TWVudUl0ZW1HdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9Db250ZXh0TWVudUl0ZW1HdGsuY3BwCkBAIC0yOTAsNyArMjkwLDcgQEAgR3RrQWN0aW9u KiBDb250ZXh0TWVudUl0ZW06Omd0a0FjdGlvbigpIGNvbnN0CiAKIENvbnRleHRNZW51SXRlbSBD b250ZXh0TWVudUl0ZW06OnNoYXJlTWVudUl0ZW0oY29uc3QgVVJMJiwgY29uc3QgVVJMJiwgSW1h Z2UqLCBjb25zdCBTdHJpbmcmKQogewotICAgIHJldHVybiBDb250ZXh0TWVudUl0ZW0oU3VibWVu dVR5cGUsIENvbnRleHRNZW51SXRlbVRhZ1NoYXJlTWVudSwgZW1wdHlTdHJpbmcoKSk7CisgICAg cmV0dXJuIENvbnRleHRNZW51SXRlbSgpOwogfQogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjg0M2Y1MC4u ZDUyN2NlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA0LTI5ICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9O KHIxODI1NzMpOiBbR1RLXSBUaGUgZGVmYXVsdCBjb250ZXh0IG1lbnUgY29udGFpbnMgYW4gZW1w dHkgaXRlbSBzaW5jZSByMTgyNTczCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDQzODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNb3ZlIHRoZSBXZWJDb250ZXh0TWVudUNsaWVudDo6c2hhcmVNZW51SXRl bSgpIGltcGxlbWVudGF0aW9uIHRvCisgICAgICAgIHBsYXRmb3JtIGZpbGVzLCBzaW5jZSBwbGF0 Zm9ybXMgbm90IHN1cHBvcnRpbmcgc2hhcmUgbWVudSBpdGVtCisgICAgICAgIHNob3VsZCByZXR1 cm4gYSBudWxsIENvbnRleHRNZW51SWVtIGluc3RlYWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViQ29udGV4dE1lbnVDbGllbnQ6OnNoYXJlTWVudUl0ZW0pOiBEZWxldGVkLgorICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkNvbnRleHRNZW51Q2xpZW50RWZs LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVDbGllbnQ6OnNoYXJlTWVudUl0 ZW0pOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZ3RrL1dlYkNvbnRleHRN ZW51Q2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVDbGllbnQ6 OnNoYXJlTWVudUl0ZW0pOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFj L1dlYkNvbnRleHRNZW51Q2xpZW50TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0 TWVudUNsaWVudDo6c2hhcmVNZW51SXRlbSk6CisKIDIwMTUtMDQtMjggIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBVc2UgeGF0dHJz IHRvIGdldC9zZXQgdGhlIGNyZWF0aW9uIHRpbWUgb2YgZGlzayBjYWNoZSBmaWxlcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0 TWVudUNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkNvbnRleHRNZW51Q2xpZW50LmNwcAppbmRleCBiMGE1ZGJjLi40MGE2MGQ4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRN ZW51Q2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYkNvbnRleHRNZW51Q2xpZW50LmNwcApAQCAtNzQsMTEgKzc0LDYgQEAgdm9pZCBXZWJD b250ZXh0TWVudUNsaWVudDo6ZG93bmxvYWRVUkwoY29uc3QgVVJMJikKICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKIH0KIAotQ29udGV4dE1lbnVJdGVtIFdlYkNvbnRleHRNZW51Q2xpZW50Ojpz aGFyZU1lbnVJdGVtKGNvbnN0IEhpdFRlc3RSZXN1bHQmKQotewotICAgIHJldHVybiBDb250ZXh0 TWVudUl0ZW0oU3VibWVudVR5cGUsIENvbnRleHRNZW51SXRlbVRhZ1NoYXJlTWVudSwgZW1wdHlT dHJpbmcoKSk7Ci19Ci0KICNpZiAhUExBVEZPUk0oQ09DT0EpCiB2b2lkIFdlYkNvbnRleHRNZW51 Q2xpZW50OjpzZWFyY2hXaXRoR29vZ2xlKGNvbnN0IEZyYW1lKiBmcmFtZSkKIHsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkNvbnRl eHRNZW51Q2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvZWZsL1dlYkNvbnRleHRNZW51Q2xpZW50RWZsLmNwcAppbmRleCAwYjAxMGVmLi4yNjFi MjU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L2VmbC9XZWJDb250ZXh0TWVudUNsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9lZmwvV2ViQ29udGV4dE1lbnVDbGllbnRFZmwuY3BwCkBA IC01Niw1ICs1NiwxMCBAQCB2b2lkIFdlYkNvbnRleHRNZW51Q2xpZW50OjpzdG9wU3BlYWtpbmco KQogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKK0NvbnRleHRNZW51SXRlbSBXZWJDb250ZXh0 TWVudUNsaWVudDo6c2hhcmVNZW51SXRlbShjb25zdCBIaXRUZXN0UmVzdWx0JikKK3sKKyAgICBy ZXR1cm4gQ29udGV4dE1lbnVJdGVtKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAogI2Vu ZGlmIC8vIEVOQUJMRShDT05URVhUX01FTlVTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9ndGsvV2ViQ29udGV4dE1lbnVDbGllbnRHdGsuY3Bw IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9ndGsvV2ViQ29udGV4 dE1lbnVDbGllbnRHdGsuY3BwCmluZGV4IDVhNDdhOTkuLjg5MDRhY2EgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZ3RrL1dlYkNvbnRleHRNZW51 Q2xpZW50R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L2d0ay9XZWJDb250ZXh0TWVudUNsaWVudEd0ay5jcHAKQEAgLTU2LDUgKzU2LDEwIEBAIHZv aWQgV2ViQ29udGV4dE1lbnVDbGllbnQ6OnN0b3BTcGVha2luZygpCiAgICAgbm90SW1wbGVtZW50 ZWQoKTsKIH0KIAorQ29udGV4dE1lbnVJdGVtIFdlYkNvbnRleHRNZW51Q2xpZW50OjpzaGFyZU1l bnVJdGVtKGNvbnN0IEhpdFRlc3RSZXN1bHQmKQoreworICAgIHJldHVybiBDb250ZXh0TWVudUl0 ZW0oKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAjZW5kaWYgLy8gRU5BQkxFKENPTlRF WFRfTUVOVVMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L21hYy9XZWJDb250ZXh0TWVudUNsaWVudE1hYy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkNvbnRleHRNZW51Q2xpZW50TWFjLm1tCmlu ZGV4IDhjNTJmNDQuLjQxYjUwNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkNvbnRleHRNZW51Q2xpZW50TWFjLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkNvbnRleHRNZW51 Q2xpZW50TWFjLm1tCkBAIC05NCw2ICs5NCwxMSBAQCB2b2lkIFdlYkNvbnRleHRNZW51Q2xpZW50 OjpzZWFyY2hXaXRoU3BvdGxpZ2h0KCkKICAgICBtX3BhZ2UtPnNlbmQoTWVzc2FnZXM6OldlYlBh Z2VQcm94eTo6U2VhcmNoV2l0aFNwb3RsaWdodChzZWxlY3RlZFN0cmluZykpOwogfQogCitDb250 ZXh0TWVudUl0ZW0gV2ViQ29udGV4dE1lbnVDbGllbnQ6OnNoYXJlTWVudUl0ZW0oY29uc3QgSGl0 VGVzdFJlc3VsdCYpCit7CisgICAgcmV0dXJuIENvbnRleHRNZW51SXRlbShTdWJtZW51VHlwZSwg Q29udGV4dE1lbnVJdGVtVGFnU2hhcmVNZW51LCBlbXB0eVN0cmluZygpKTsKK30KKwogfSAvLyBu YW1lc3BhY2UgV2ViS2l0CiAKICNlbmRpZiAvLyBFTkFCTEUoQ09OVEVYVF9NRU5VUykK