144386 2015-04-29 05:11:41 -0700 Main resource loaded via 304 response becomes empty if reloaded by user 2015-04-29 19:52:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=144416 InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue japhet oldest_to_newest 1089969 0 koivisto 2015-04-29 05:11:41 -0700 Main resource loaded via 304 response becomes empty if reloaded by user. 1089970 1 koivisto 2015-04-29 05:12:13 -0700 <rdar://problem/18480199> 1090000 2 251953 koivisto 2015-04-29 08:48:33 -0700 Created attachment 251953 patch 1090014 3 251953 darin 2015-04-29 09:08:37 -0700 Comment on attachment 251953 patch I’ve wondered about this kind of thing for years. Part of the general “what do we want to keep when we reload and what needs to start fresh” topic for requests in general. Also related is the scheme for making reloads bypass cache appropriately. Is this needed anywhere else? Does it only affect main resources? Is there some way to tie it more closely to other ways we have to change the request in a reloading situation? 1090020 4 koivisto 2015-04-29 09:20:21 -0700 > Is this needed anywhere else? Does it only affect main resources? Is there > some way to tie it more closely to other ways we have to change the request > in a reloading situation? Main document loading is a rare case where we have a long-lived ResourceRequest not owned by a CachedResource. The refactoring that moved us from entirely special main resource loading to CachedResources based loading (using CachedRawResource) is basically incomplete so we end up with weird special handling. 1090047 5 koivisto 2015-04-29 10:11:29 -0700 https://trac.webkit.org/r183555 1090110 6 ap 2015-04-29 12:17:34 -0700 http/tests/cache/main-resource-304-reload.html fails on Windows: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcache%2Fmain-resource-304-reload.html 1090140 7 koivisto 2015-04-29 13:30:17 -0700 Marked it failing on Windows in http://trac.webkit.org/changeset/183573 (like most of the cache test). 251953 2015-04-29 08:48:33 -0700 2015-04-29 09:08:37 -0700 patch main-resource-304-reload-2.patch text/plain 5905 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzU0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA0LTI5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBNYWluIHJlc291cmNlIGxvYWRl ZCB2aWEgMzA0IHJlc3BvbnNlIGJlY29tZXMgZW1wdHkgaWYgcmVsb2FkZWQgYnkgdXNlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0Mzg2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVtb3J5IGNhY2hl IGxheWVyIG1heSBtYWtlIGEgbWFpbiByZXNvdXJjZSByZXF1ZXN0IGNvbmRpdGlvbmFsIChhZGQg SWYtbW9kaWZpZWQtc2luY2UvSWYtbm9uZS1tYXRjaCBoZWFkZXIpLgorICAgICAgICBEb2N1bWVu dExvYWRlciBzdG9yZXMgdGhlIGZpbmFsIFJlc291cmNlUmVxdWVzdCBhc3NvY2lhdGVkIHdpdGgg ZG9jdW1lbnQuIElmIHVzZXIgdHJpZ2dlcmVkIHJlbG9hZCBmb3IKKyAgICAgICAgY29uZGl0aW9u YWxseSBsb2FkZWQgZG9jdW1lbnQgRG9jdW1lbnRMb2FkZXIgd291bGQgaW5jbHVkZSB0aGUgc2Ft ZSBjb25kaXRpb25hbHMgdG8gdGhlIG5ldyByZXF1ZXN0IGFzIHdlbGwuCisgICAgICAgIFNpbmNl IHRoZXNlIHdlcmUgbm90IGFkZGVkIGJ5IHRoZSBtZW1vcnkgY2FjaGUgaXQgd291bGQgcGFzcyBh bnkgMzA0IHJlc3BvbnNlIGJhY2sgdG8gdGhlIERvY3VtZW50TG9hZGVyLgorICAgICAgICBIb3dl dmVyIERvY3VtZW50TG9hZGVyIGhhcyBubyBjb2RlIHRvIGhhbmRsZSAzMDQgc28gd2Ugd291bGQg ZW5kIHVwIHdpdGggYW4gZW1wdHkgZG9jdW1lbnQuCisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0 cy9jYWNoZS9tYWluLXJlc291cmNlLTMwNC1yZWxvYWQuaHRtbAorCisgICAgICAgICogbG9hZGVy L0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpz dGFydExvYWRpbmdNYWluUmVzb3VyY2UpOgorCisgICAgICAgICAgICBFbnN1cmUgRG9jdW1lbnRM b2FkZXIgZG9lc24ndCBpc3N1ZSBjb25kaXRpb25hbCByZXF1ZXN0cy4KKwogMjAxNS0wNC0yOSAg SHl1bmd3b29rIExlZSAgPGh5dW5nd29vay5sZWVAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBG aXggY3Jhc2ggaW4gV2ViQ29yZTo6TG9naWNhbFNlbGVjdGlvbk9mZnNldENhY2hlczo6Q29udGFp bmluZ0Jsb2NrSW5mbzo6c2V0QmxvY2soKS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9E b2N1bWVudExvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0Rv Y3VtZW50TG9hZGVyLmNwcAkocmV2aXNpb24gMTgzNDY3KQorKysgU291cmNlL1dlYkNvcmUvbG9h ZGVyL0RvY3VtZW50TG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQwMCw3ICsxNDAwLDkg QEAgdm9pZCBEb2N1bWVudExvYWRlcjo6c3RhcnRMb2FkaW5nTWFpblJlcwogCiAgICAgUmVzb3Vy Y2VSZXF1ZXN0IHJlcXVlc3QobV9yZXF1ZXN0KTsKICAgICByZXF1ZXN0LnNldFJlcXVlc3RlcihS ZXNvdXJjZVJlcXVlc3Q6OlJlcXVlc3Rlcjo6TWFpbik7Ci0gICAgCisgICAgLy8gSWYgdGhpcyBp cyBhIHJlbG9hZCB0aGUgY2FjaGUgbGF5ZXIgbWlnaHQgaGF2ZSBtYWRlIHRoZSBwcmV2aW91cyBy ZXF1ZXN0IGNvbmRpdGlvbmFsLiBEb2N1bWVudExvYWRlciBjYW4ndCBoYW5kbGUgMzA0IHJlc3Bv bnNlcyBpdHNlbGYuCisgICAgcmVxdWVzdC5tYWtlVW5jb25kaXRpb25hbCgpOworCiAgICAgc3Rh dGljIE5ldmVyRGVzdHJveWVkPFJlc291cmNlTG9hZGVyT3B0aW9ucz4gbWFpblJlc291cmNlTG9h ZE9wdGlvbnMoU2VuZENhbGxiYWNrcywgU25pZmZDb250ZW50LCBCdWZmZXJEYXRhLCBBbGxvd1N0 b3JlZENyZWRlbnRpYWxzLCBBc2tDbGllbnRGb3JBbGxDcmVkZW50aWFscywgU2tpcFNlY3VyaXR5 Q2hlY2ssIFVzZURlZmF1bHRPcmlnaW5SZXN0cmljdGlvbnNGb3JUeXBlLCBJbmNsdWRlQ2VydGlm aWNhdGVJbmZvKTsKICAgICBDYWNoZWRSZXNvdXJjZVJlcXVlc3QgY2FjaGVkUmVzb3VyY2VSZXF1 ZXN0KHJlcXVlc3QsIG1haW5SZXNvdXJjZUxvYWRPcHRpb25zKTsKICAgICBjYWNoZWRSZXNvdXJj ZVJlcXVlc3Quc2V0SW5pdGlhdG9yKCp0aGlzKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzU0NSkK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTA0LTI5ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAg ICBNYWluIHJlc291cmNlIGxvYWRlZCB2aWEgMzA0IHJlc3BvbnNlIGJlY29tZXMgZW1wdHkgaWYg cmVsb2FkZWQgYnkgdXNlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ0Mzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBodHRwL3Rlc3RzL2NhY2hlL21haW4tcmVzb3VyY2UtMzA0LXJlbG9hZC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvY2FjaGUvbWFpbi1yZXNvdXJj ZS0zMDQtcmVsb2FkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvY2FjaGUvcmVz b3VyY2VzL2lmcmFtZTMwNGJvZHkucGhwOiBBZGRlZC4KKwogMjAxNS0wNC0yOSAgSHl1bmd3b29r IExlZSAgPGh5dW5nd29vay5sZWVAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBGaXggY3Jhc2gg aW4gV2ViQ29yZTo6TG9naWNhbFNlbGVjdGlvbk9mZnNldENhY2hlczo6Q29udGFpbmluZ0Jsb2Nr SW5mbzo6c2V0QmxvY2soKS4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUvbWFp bi1yZXNvdXJjZS0zMDQtcmVsb2FkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2NhY2hlL21haW4tcmVzb3VyY2UtMzA0LXJlbG9hZC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL21haW4tcmVz b3VyY2UtMzA0LXJlbG9hZC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwx MyBAQAorVmVyaWZ5IHRoYXQgZG9jdW1lbnQgbG9hZGVkIHdpdGggMzA0IHJlc3BvbnNlIGNhbiBi ZSByZWxvYWRlZCBjb3JyZWN0bHkuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmll cyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQ QVNTIGlmcmFtZS5jb250ZW50RG9jdW1lbnQuYm9keS50ZXh0Q29udGVudCBpcyAiYm9keSB0ZXh0 IgorUEFTUyBpZnJhbWUuY29udGVudERvY3VtZW50LmJvZHkudGV4dENvbnRlbnQgaXMgImJvZHkg dGV4dCIKK1JlbG9hZGluZworUEFTUyBpZnJhbWUuY29udGVudERvY3VtZW50LmJvZHkudGV4dENv bnRlbnQgaXMgImJvZHkgdGV4dCIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKwor VEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL21haW4t cmVzb3VyY2UtMzA0LXJlbG9hZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAv dGVzdHMvY2FjaGUvbWFpbi1yZXNvdXJjZS0zMDQtcmVsb2FkLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL21haW4tcmVzb3VyY2UtMzA0LXJlbG9hZC5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNDEgQEAKKzxzY3JpcHQgc3JjPSIvanMtdGVz dC1yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2pzVGVzdElz QXN5bmMgPSB0cnVlOworCitkZXNjcmlwdGlvbigiVmVyaWZ5IHRoYXQgZG9jdW1lbnQgbG9hZGVk IHdpdGggMzA0IHJlc3BvbnNlIGNhbiBiZSByZWxvYWRlZCBjb3JyZWN0bHkuIik7CisKK3ZhciBp ZnJhbWU7CisKK2Z1bmN0aW9uIGxvYWRGcmFtZShvbmxvYWQpCit7CisgICAgaWYgKGlmcmFtZSkK KyAgICAgICAgZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZChpZnJhbWUpOworICAgIGlmcmFtZSA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlmcmFtZSIpOworICAgIGlmcmFtZS5zcmMgPSAicmVz b3VyY2VzL2lmcmFtZTMwNGJvZHkucGhwIjsKKyAgICBpZnJhbWUub25sb2FkID0gb25sb2FkOwor ICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoaWZyYW1lKTsKK30KKworZnVuY3Rpb24gdmVy aWZ5KCkgeworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiaWZyYW1lLmNvbnRlbnREb2N1bWVu dC5ib2R5LnRleHRDb250ZW50IiwgImJvZHkgdGV4dCIpOworfQorCitmdW5jdGlvbiB0ZXN0KCkg eworICAgIGxvYWRGcmFtZShmdW5jdGlvbiAoKSB7CisgICAgICAgIHZlcmlmeSgpOworICAgICAg ICB2YXIgb25sb2FkQ291bnQgPSAwOworICAgICAgICBsb2FkRnJhbWUoZnVuY3Rpb24gKCkgewor ICAgICAgICAgICAgdmVyaWZ5KCk7CisgICAgICAgICAgICBpZiAoKytvbmxvYWRDb3VudCA8IDIp IHsKKyAgICAgICAgICAgICAgICBkZWJ1ZygiUmVsb2FkaW5nIik7CisgICAgICAgICAgICAgICAg aWZyYW1lLmNvbnRlbnRXaW5kb3cuaW50ZXJuYWxzLmZvcmNlUmVsb2FkKGZhbHNlKTsKKyAgICAg ICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CisgICAgICAgICAgICBmaW5pc2hKU1Rl c3QoKTsKKyAgICAgICAgfSk7CisgICAgfSk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 IG9ubG9hZD0idGVzdCgpIj4KKzxzY3JpcHQgc3JjPSIvanMtdGVzdC1yZXNvdXJjZXMvanMtdGVz dC1wb3N0LmpzIj48L3NjcmlwdD4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUv cmVzb3VyY2VzL2lmcmFtZTMwNGJvZHkucGhwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvY2FjaGUvcmVzb3VyY2VzL2lmcmFtZTMwNGJvZHkucGhwCShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJjZXMvaWZyYW1lMzA0Ym9keS5w aHAJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNCBAQAorPD9waHANCityZXF1aXJlX29uY2Ug Jy4uLy4uL3Jlc291cmNlcy9wb3J0YWJpbGl0eUxheWVyLnBocCc7DQorDQorY2xlYXJzdGF0Y2Fj aGUoKTsNCisNCitpZiAoJF9TRVJWRVJbIkhUVFBfSUZfTU9ESUZJRURfU0lOQ0UiXSkgew0KKyAg ICBoZWFkZXIoIkhUVFAvMS4wIDMwNCBOb3QgTW9kaWZpZWQiKTsNCisgICAgZXhpdCgpOw0KK30N CitoZWFkZXIoJ0NhY2hlLUNvbnRyb2w6IG5vLWNhY2hlJyk7DQoraGVhZGVyKCdDb250ZW50LVR5 cGU6IHRleHQvaHRtbCcpOw0KK2hlYWRlcignRXRhZzogMTIzNDU2Nzg5Jyk7DQorPz4NCitib2R5 IHRleHQKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==