144382 2015-04-29 03:06:17 -0700 [cmake] Disable GNU Gold linker on Cortex A53 2015-05-04 01:52:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 ossy ossy akiss berto cgarcia mcatanzaro mrobinson ossy oldest_to_newest 1089948 0 ossy 2015-04-29 03:06:17 -0700 https://bugs.webkit.org/show_bug.cgi?id=138840#c5 The problem is that -mfix-cortex-a53-835769 errata detection is placed before the gold linker detection. It tries to detect if the default system linker supports it and later uses gold linker for the real build. I can't found any commit in trunk gold linker, so the easiest fix is to disable gold linker on Cortex A53 to be able to use the necessary workaround. 1089949 1 berto 2015-04-29 03:11:56 -0700 Yeah, that looks like the best solution to me as well. 1089950 2 251941 ossy 2015-04-29 03:17:13 -0700 Created attachment 251941 Patch WIP patch, I'm going to check it on real hardware. 1089987 3 mcatanzaro 2015-04-29 08:02:31 -0700 OK... so CMAKE_DEPENDENT_OPTION is a thing.... There's a typo in the patch: workaroung -> workaround. 1090041 4 251961 ossy 2015-04-29 09:55:59 -0700 Created attachment 251961 Patch I fixed the mentioned typo, added the necessary include and negated CXX_ACCEPTS_MFIX_CORTEX_A53_835769 in CMAKE_DEPENDENT_OPTION which was wrong in my previous patch. (tested on real hw) 1090151 5 berto 2015-04-29 14:10:13 -0700 (In reply to comment #4) > Created attachment 251961 [details] > Patch > > I fixed the mentioned typo, added the necessary include and negated > CXX_ACCEPTS_MFIX_CORTEX_A53_835769 in CMAKE_DEPENDENT_OPTION which was wrong > in my previous patch. (tested on real hw) Looks good to me, thanks for testing it! 1091332 6 ossy 2015-05-04 01:50:46 -0700 I asked the authors of the errata fix in BFD linker and they said that only the BFD linker is supported and they aren't planning to add this fix to the gold linker. So this change is really the correct fix. 1091333 7 251961 ossy 2015-05-04 01:52:46 -0700 Comment on attachment 251961 Patch Clearing flags on attachment: 251961 Committed r183741: <http://trac.webkit.org/changeset/183741> 1091334 8 ossy 2015-05-04 01:52:53 -0700 All reviewed patches have been landed. Closing bug. 251941 2015-04-29 03:17:13 -0700 2015-04-29 09:55:52 -0700 Patch bug-144382-20150429031603.patch text/plain 1774 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDg2MjFkZWUzMjRiZDkyZTFhMTkyMDA3ZWNmYmExMjJmNzg5NTI5NTUuLjI3YjI3ZjIyMTVhNTI4 NDVmZjE5Yjk5NTI0MGFiOTcyYTIxNzk5YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC02MSwxNCArNjEsMTUgQEAgaWYgKFdURl9DUFVfQVJNNjRfQ09SVEVYQTUzKQogICAgIGlmIChD WFhfQUNDRVBUU19NRklYX0NPUlRFWF9BNTNfODM1NzY5KQogICAgICAgICBzZXQoQ01BS0VfQ19G TEFHUyAiJHtDTUFLRV9DX0ZMQUdTfSAtbWZpeC1jb3J0ZXgtYTUzLTgzNTc2OSIpCiAgICAgICAg IHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtbWZpeC1jb3J0ZXgtYTUz LTgzNTc2OSIpCi0gICAgICAgIG1lc3NhZ2UoU1RBVFVTICJFbmFibGluZyBDb3J0ZXgtQTUzIHdv cmthcm91bmQgZm9yIGNvbXBpbGVyIikKKyAgICAgICAgbWVzc2FnZShTVEFUVVMgIkVuYWJsaW5n IENvcnRleC1BNTMgd29ya2Fyb3VuZCBmb3IgY29tcGlsZXIgYW5kIGRpc2FibGluZyBHTlUgZ29s ZCBsaW5rZXIsIGJlY2F1c2UgaXQgZG9lc24ndCBzdXBwb3J0IHRoaXMgd29ya2Fyb3VuZy4iKQog ICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCiBFWFBPU0VfVkFSSUFCTEVfVE9fQlVJTEQoV1RGX0NQ VV9BUk02NF9DT1JURVhBNTMpCiAKICMgVXNlIGxkLmdvbGQgaWYgaXQgaXMgYXZhaWxhYmxlIGFu ZCBpc24ndCBkaXNhYmxlZCBleHBsaWNpdGx5Ci1vcHRpb24oVVNFX0xEX0dPTEQgIlVzZSBHTlUg Z29sZCBsaW5rZXIiIE9OKQorQ01BS0VfREVQRU5ERU5UX09QVElPTihVU0VfTERfR09MRCAiVXNl IEdOVSBnb2xkIGxpbmtlciIgT04KKyAgICAgICAgICAgICAgICAgICAgICAgIkNYWF9BQ0NFUFRT X01GSVhfQ09SVEVYX0E1M184MzU3NjkiIE9GRikKIGlmIChVU0VfTERfR09MRCkKICAgICBleGVj dXRlX3Byb2Nlc3MoQ09NTUFORCAke0NNQUtFX0NfQ09NUElMRVJ9IC1mdXNlLWxkPWdvbGQgLVds LC0tdmVyc2lvbiBFUlJPUl9RVUlFVCBPVVRQVVRfVkFSSUFCTEUgTERfVkVSU0lPTikKICAgICBp ZiAoIiR7TERfVkVSU0lPTn0iIE1BVENIRVMgIkdOVSBnb2xkIikKZGlmZiAtLWdpdCBhL0NoYW5n ZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlZmU1NGJhYzI4YWE4MTA2NDBhNjNmZGZmMzQyMmRjNTMz MThkZmY3Li5iZTFmZjZmYzdjOWIxYzUzMjNmOTQzZGVkNTI1N2IxZDEyNzgzMThkIDEwMDY0NAot LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMDQt MjkgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBbY21h a2VdIERpc2FibGUgR05VIEdvbGQgbGlua2VyIG9uIENvcnRleCBBNTMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDM4MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnND b21tb24uY21ha2U6CisKIDIwMTUtMDQtMjggIE1pY2hhZWwgQ2F0YW56YXJvIDxtY2F0YW56YXJv QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IEdUSyBidWlsZCBhZnRlciBy MTgzNDUyCg== 251961 2015-04-29 09:55:59 -0700 2015-05-04 01:52:46 -0700 Patch bug-144382-20150429095449.patch text/plain 1803 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDg2MjFkZWUzMjRiZDkyZTFhMTkyMDA3ZWNmYmExMjJmNzg5NTI5NTUuLmZjMzEyNTM1MDk4YjI4 ZDMxZjcwNTFiYzBjYzQxMzQ1ZjQzMjA2OTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC02MSwxNCArNjEsMTYgQEAgaWYgKFdURl9DUFVfQVJNNjRfQ09SVEVYQTUzKQogICAgIGlmIChD WFhfQUNDRVBUU19NRklYX0NPUlRFWF9BNTNfODM1NzY5KQogICAgICAgICBzZXQoQ01BS0VfQ19G TEFHUyAiJHtDTUFLRV9DX0ZMQUdTfSAtbWZpeC1jb3J0ZXgtYTUzLTgzNTc2OSIpCiAgICAgICAg IHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtbWZpeC1jb3J0ZXgtYTUz LTgzNTc2OSIpCi0gICAgICAgIG1lc3NhZ2UoU1RBVFVTICJFbmFibGluZyBDb3J0ZXgtQTUzIHdv cmthcm91bmQgZm9yIGNvbXBpbGVyIikKKyAgICAgICAgbWVzc2FnZShTVEFUVVMgIkVuYWJsaW5n IENvcnRleC1BNTMgd29ya2Fyb3VuZCBmb3IgY29tcGlsZXIgYW5kIGRpc2FibGluZyBHTlUgZ29s ZCBsaW5rZXIsIGJlY2F1c2UgaXQgZG9lc24ndCBzdXBwb3J0IHRoaXMgd29ya2Fyb3VuZC4iKQog ICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCiBFWFBPU0VfVkFSSUFCTEVfVE9fQlVJTEQoV1RGX0NQ VV9BUk02NF9DT1JURVhBNTMpCiAKICMgVXNlIGxkLmdvbGQgaWYgaXQgaXMgYXZhaWxhYmxlIGFu ZCBpc24ndCBkaXNhYmxlZCBleHBsaWNpdGx5Ci1vcHRpb24oVVNFX0xEX0dPTEQgIlVzZSBHTlUg Z29sZCBsaW5rZXIiIE9OKQoraW5jbHVkZShDTWFrZURlcGVuZGVudE9wdGlvbikKK0NNQUtFX0RF UEVOREVOVF9PUFRJT04oVVNFX0xEX0dPTEQgIlVzZSBHTlUgZ29sZCBsaW5rZXIiIE9OCisgICAg ICAgICAgICAgICAgICAgICAgICJOT1QgQ1hYX0FDQ0VQVFNfTUZJWF9DT1JURVhfQTUzXzgzNTc2 OSIgT0ZGKQogaWYgKFVTRV9MRF9HT0xEKQogICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5EICR7 Q01BS0VfQ19DT01QSUxFUn0gLWZ1c2UtbGQ9Z29sZCAtV2wsLS12ZXJzaW9uIEVSUk9SX1FVSUVU IE9VVFBVVF9WQVJJQUJMRSBMRF9WRVJTSU9OKQogICAgIGlmICgiJHtMRF9WRVJTSU9OfSIgTUFU Q0hFUyAiR05VIGdvbGQiKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4 IDY3YmMxZjFjMmM2ZWY3YmQxY2UwMTdiYTM5NGFjMzQxMTBiMjUyODAuLjE1OTlmNjQxM2JiYjA0 ZWZhNjdiNzc3ZjYzZTk2ZjE0MzgyNGY2NTYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNS0wNC0yOSAgQ3NhYmEgT3N6dHJvZ29uw6Fj ICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFtjbWFrZV0gRGlzYWJsZSBHTlUgR29sZCBs aW5rZXIgb24gQ29ydGV4IEE1MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ0MzgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZToKKwogMjAxNS0w NC0yOSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBb RUZMXSBCdWlsZCBmYWlsdXJlIHRvIGZpbmQgZ2lvLXVuaXgK