144375 2015-04-28 21:26:41 -0700 Make a non-static version of FrameView::yPositionForRootContentLayer() 2015-04-28 22:52:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser thorton oldest_to_newest 1089880 0 simon.fraser 2015-04-28 21:26:41 -0700 Make a non-static version of FrameView::yPositionForRootContentLayer() 1089881 1 251922 simon.fraser 2015-04-28 21:28:16 -0700 Created attachment 251922 Patch 1089895 2 251922 commit-queue 2015-04-28 22:52:45 -0700 Comment on attachment 251922 Patch Clearing flags on attachment: 251922 Committed r183530: <http://trac.webkit.org/changeset/183530> 1089896 3 commit-queue 2015-04-28 22:52:50 -0700 All reviewed patches have been landed. Closing bug. 251922 2015-04-28 21:28:16 -0700 2015-04-28 22:52:45 -0700 Patch bug-144375-20150428212706.patch text/plain 5891 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ0Y2RiZmZmZThjZjQ0 Yzk5ODk0MjQzODE1YTk5ZGViNzU2YzUyYi4uZDM3MjZjMTRmOWRiODQ5OTRiNmVjNTg5ZmJlN2Q5 YzMzNDAxYjc5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA0LTI4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgYSBub24t c3RhdGljIHZlcnNpb24gb2YgRnJhbWVWaWV3Ojp5UG9zaXRpb25Gb3JSb290Q29udGVudExheWVy KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDM3 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJl IHdlcmUgdHdvIGNhbGxzIHRvIHRoZSBzdGF0aWMgRnJhbWVWaWV3Ojp5UG9zaXRpb25Gb3JSb290 Q29udGVudExheWVyKCkKKyAgICAgICAgd2hpY2ggcGFzc2VkIGluIGFsbCB0aGUgYXJndW1lbnRz IGZvciB0aGUgc2FtZSBGcmFtZVZpZXcuIE1ha2UgYSBtZW1iZXIKKyAgICAgICAgZnVuY3Rpb24g Zm9yIGNvbnZlbmllbmNlLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RnJhbWVWaWV3Ojp5UG9zaXRpb25Gb3JSb290Q29udGVudExheWVyKToKKyAg ICAgICAgKiBwYWdlL0ZyYW1lVmlldy5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXll ckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9y Ojp1cGRhdGVSb290TGF5ZXJQb3NpdGlvbik6CisKIDIwMTUtMDQtMjggIEFuZHJlYXMgS2xpbmcg IDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IERPTSB3cmFwcGVyIGRlc3Ry dWN0aW9uLCBkb24ndCBkZXJlZigpIGluIGZpbmFsaXplcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjdmZTM4 YTNhZTcwMjBhOWVjMTNlYTQyMmJhZTFkM2U0NDE5MzhjNy4uNDg1ZGI3OWU1ZjYyYjM3N2Q5OWZj YWFhZDM5ODYxMjQxMzFjYzk2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0 LTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1h a2UgYSBub24tc3RhdGljIHZlcnNpb24gb2YgRnJhbWVWaWV3Ojp5UG9zaXRpb25Gb3JSb290Q29u dGVudExheWVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NDM3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZXJlIHdlcmUgdHdvIGNhbGxzIHRvIHRoZSBzdGF0aWMgRnJhbWVWaWV3Ojp5UG9zaXRp b25Gb3JSb290Q29udGVudExheWVyKCkKKyAgICAgICAgd2hpY2ggcGFzc2VkIGluIGFsbCB0aGUg YXJndW1lbnRzIGZvciB0aGUgc2FtZSBGcmFtZVZpZXcuIE1ha2UgYSBtZW1iZXIKKyAgICAgICAg ZnVuY3Rpb24gZm9yIGNvbnZlbmllbmNlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbToKKyAgICAgICAgKFdlYktpdDo6 c2hhZG93TGF5ZXJQb3NpdGlvbkZvckZyYW1lKToKKwogMjAxNS0wNC0yOCAgVGltb3RoeSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1RleHRJbmRpY2F0b3Jd IFllbGxvdyBoaWdobGlnaHQgdGFrZXMgdG9vIGxvbmcgdG8gZmFkZSBvdXQgb24gc2Nyb2xsCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggOGU0MmE2MGFjM2YwNzRlNDY5ZWZhNzdjZDZh YjEyOGFlY2YxZjEzMi4uNWJmYTZlMDU4ODdjNzMzNWJmNDJmZjJiYTAxYmViYmE0ODM0MDE3MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMTY4OCw2ICsxNjg4LDExIEBAIGZsb2F0 IEZyYW1lVmlldzo6eVBvc2l0aW9uRm9yRm9vdGVyTGF5ZXIoY29uc3QgRmxvYXRQb2ludCYgc2Ny b2xsUG9zaXRpb24sIGZsb2F0CiAgICAgcmV0dXJuIHlQb3NpdGlvbkZvckhlYWRlckxheWVyKHNj cm9sbFBvc2l0aW9uLCB0b3BDb250ZW50SW5zZXQpICsgdG90YWxDb250ZW50c0hlaWdodCAtIGZv b3RlckhlaWdodDsKIH0KIAorZmxvYXQgRnJhbWVWaWV3Ojp5UG9zaXRpb25Gb3JSb290Q29udGVu dExheWVyKCkgY29uc3QKK3sKKyAgICByZXR1cm4geVBvc2l0aW9uRm9yUm9vdENvbnRlbnRMYXll cihzY3JvbGxQb3NpdGlvbigpLCB0b3BDb250ZW50SW5zZXQoKSwgaGVhZGVySGVpZ2h0KCkpOwor fQorCiAjaWYgUExBVEZPUk0oSU9TKQogTGF5b3V0UmVjdCBGcmFtZVZpZXc6OnJlY3RGb3JWaWV3 cG9ydENvbnN0cmFpbmVkT2JqZWN0cyhjb25zdCBMYXlvdXRSZWN0JiB2aXNpYmxlQ29udGVudFJl Y3QsIGNvbnN0IExheW91dFNpemUmIHRvdGFsQ29udGVudHNTaXplLCBmbG9hdCBmcmFtZVNjYWxl RmFjdG9yLCBib29sIGZpeGVkRWxlbWVudHNMYXlvdXRSZWxhdGl2ZVRvRnJhbWUsIFNjcm9sbEJl aGF2aW9yRm9yRml4ZWRFbGVtZW50cyBzY3JvbGxCZWhhdmlvcikKIHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5oCmluZGV4IDA2YTcyMjkwYTc4ZjQ5OGQ2ZmNiYzQ1ZDBhMzFmMWUzZTY1ZjdiYzIuLjNh YWY2YmZlZWQ4MjVmNjU0MGU3Y2Q5NTU1MDU1ZDliYTVlZmFkYzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuaApAQCAtMjg0LDYgKzI4NCw4IEBAIHB1YmxpYzoKICAgICAvLyBvbiBib3RoIHRoZSBt YWluIHRocmVhZCBhbmQgdGhlIHNjcm9sbGluZyB0aHJlYWQuCiAgICAgc3RhdGljIGZsb2F0IHlQ b3NpdGlvbkZvckluc2V0Q2xpcExheWVyKGNvbnN0IEZsb2F0UG9pbnQmIHNjcm9sbFBvc2l0aW9u LCBmbG9hdCB0b3BDb250ZW50SW5zZXQpOwogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBmbG9h dCB5UG9zaXRpb25Gb3JSb290Q29udGVudExheWVyKGNvbnN0IEZsb2F0UG9pbnQmIHNjcm9sbFBv c2l0aW9uLCBmbG9hdCB0b3BDb250ZW50SW5zZXQsIGZsb2F0IGhlYWRlckhlaWdodCk7CisgICAg V0VCQ09SRV9FWFBPUlQgZmxvYXQgeVBvc2l0aW9uRm9yUm9vdENvbnRlbnRMYXllcigpIGNvbnN0 OworCiAgICAgc3RhdGljIGZsb2F0IHlQb3NpdGlvbkZvckhlYWRlckxheWVyKGNvbnN0IEZsb2F0 UG9pbnQmIHNjcm9sbFBvc2l0aW9uLCBmbG9hdCB0b3BDb250ZW50SW5zZXQpOwogICAgIHN0YXRp YyBmbG9hdCB5UG9zaXRpb25Gb3JGb290ZXJMYXllcihjb25zdCBGbG9hdFBvaW50JiBzY3JvbGxQ b3NpdGlvbiwgZmxvYXQgdG9wQ29udGVudEluc2V0LCBmbG9hdCB0b3RhbENvbnRlbnRzSGVpZ2h0 LCBmbG9hdCBmb290ZXJIZWlnaHQpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDg1NjZhZDY4MDJkY2RiMzEwZmQ3MDkw YzVhM2Y0MjRkNDM5OWNlZTAuLmM1ZTM2MzE3Y2E4MjhlYzY2ZWZhOTVmMzA0YjY2NGMwOTZlNTM0 ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBv c2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBv c2l0b3IuY3BwCkBAIC0yMDgxLDggKzIwODEsNyBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRv cjo6dXBkYXRlUm9vdExheWVyUG9zaXRpb24oKQogICAgIGlmIChtX3Jvb3RDb250ZW50TGF5ZXIp IHsKICAgICAgICAgY29uc3QgSW50UmVjdCYgZG9jdW1lbnRSZWN0ID0gbV9yZW5kZXJWaWV3LmRv Y3VtZW50UmVjdCgpOwogICAgICAgICBtX3Jvb3RDb250ZW50TGF5ZXItPnNldFNpemUoZG9jdW1l bnRSZWN0LnNpemUoKSk7ICAgICAgICAKLSAgICAgICAgbV9yb290Q29udGVudExheWVyLT5zZXRQ b3NpdGlvbihGbG9hdFBvaW50KGRvY3VtZW50UmVjdC54KCksIGRvY3VtZW50UmVjdC55KCkKLSAg ICAgICAgICAgICsgRnJhbWVWaWV3Ojp5UG9zaXRpb25Gb3JSb290Q29udGVudExheWVyKG1fcmVu ZGVyVmlldy5mcmFtZVZpZXcoKS5zY3JvbGxQb3NpdGlvbigpLCBtX3JlbmRlclZpZXcuZnJhbWVW aWV3KCkudG9wQ29udGVudEluc2V0KCksIG1fcmVuZGVyVmlldy5mcmFtZVZpZXcoKS5oZWFkZXJI ZWlnaHQoKSkpKTsKKyAgICAgICAgbV9yb290Q29udGVudExheWVyLT5zZXRQb3NpdGlvbihGbG9h dFBvaW50KGRvY3VtZW50UmVjdC54KCksIGRvY3VtZW50UmVjdC55KCkgKyBtX3JlbmRlclZpZXcu ZnJhbWVWaWV3KCkueVBvc2l0aW9uRm9yUm9vdENvbnRlbnRMYXllcigpKSk7CiAgICAgICAgIG1f cm9vdENvbnRlbnRMYXllci0+c2V0QW5jaG9yUG9pbnQoRmxvYXRQb2ludDNEKCkpOwogICAgIH0K ICAgICBpZiAobV9jbGlwTGF5ZXIpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0gYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdp bmdBcmVhLm1tCmluZGV4IGQ3MzEwNGYyMDU3MzY3OWNkYjhkYjBlM2Q2ZDk5OTU4NTY2MmZhNjgu LjU1MzhhMzg3MzY1MGFmZmY4YzI1ZGU4YTNlNDkwZDMzZmMzOGMxYmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJh d2luZ0FyZWEubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9U aWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQpAQCAtNTcyLDggKzU3Miw3IEBAIFBsYXRm b3JtQ0FMYXllciogVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNoYWRvd0xheWVyRm9y VHJhbnNpZW50Wm9vbSgpIGNvCiAgICAgCiBzdGF0aWMgRmxvYXRQb2ludCBzaGFkb3dMYXllclBv c2l0aW9uRm9yRnJhbWUoRnJhbWVWaWV3JiBmcmFtZVZpZXcsIEZsb2F0UG9pbnQgb3JpZ2luKQog ewotICAgIEZsb2F0UG9pbnQgcG9zaXRpb24gPSBmcmFtZVZpZXcucmVuZGVyVmlldygpLT5kb2N1 bWVudFJlY3QoKS5sb2NhdGlvbigpICsgRmxvYXRQb2ludCgwLCBGcmFtZVZpZXc6OnlQb3NpdGlv bkZvclJvb3RDb250ZW50TGF5ZXIoZnJhbWVWaWV3LnNjcm9sbFBvc2l0aW9uKCksIGZyYW1lVmll dy50b3BDb250ZW50SW5zZXQoKSwgZnJhbWVWaWV3LmhlYWRlckhlaWdodCgpKSk7Ci0KKyAgICBG bG9hdFBvaW50IHBvc2l0aW9uID0gZnJhbWVWaWV3LnJlbmRlclZpZXcoKS0+ZG9jdW1lbnRSZWN0 KCkubG9jYXRpb24oKSArIEZsb2F0UG9pbnQoMCwgZnJhbWVWaWV3LnlQb3NpdGlvbkZvclJvb3RD b250ZW50TGF5ZXIoKSk7CiAgICAgcmV0dXJuIHBvc2l0aW9uICsgb3JpZ2luLmV4cGFuZGVkVG8o RmxvYXRQb2ludCgpKTsKIH0KIAo=