144366 2015-04-28 17:53:33 -0700 REGRESSION(180076): [Mac, iOS] Correct possible null dereference in printing code 2015-04-28 19:27:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 141569 1 bfulgham bfulgham bfulgham commit-queue esprehn+autocc glenn kondapallykalyan webkit-bug-importer oldest_to_newest 1089808 0 bfulgham 2015-04-28 17:53:33 -0700 My patch for Bug 141569 introduced a possible nullptr dereference. This patch corrects that bug. 1089809 1 bfulgham 2015-04-28 17:54:36 -0700 <rdar://problem/20533513> 1089810 2 251905 bfulgham 2015-04-28 17:58:06 -0700 Created attachment 251905 Patch 1089847 3 251905 commit-queue 2015-04-28 19:27:22 -0700 Comment on attachment 251905 Patch Clearing flags on attachment: 251905 Committed r183524: <http://trac.webkit.org/changeset/183524> 1089848 4 commit-queue 2015-04-28 19:27:26 -0700 All reviewed patches have been landed. Closing bug. 251905 2015-04-28 17:58:06 -0700 2015-04-28 19:27:22 -0700 Patch bug-144366-20150428175657.patch text/plain 1955 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzUyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTI4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04oMTgwMDc2 KTogW01hYywgaU9TXSBDb3JyZWN0IHBvc3NpYmxlIG51bGwgZGVyZWZlcmVuY2UgaW4gcHJpbnRp bmcgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ0MzY2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMDUzMzUxMz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9j a0Zsb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bmVlZHNBcHBsZU1haWxQYWdpbmF0aW9uUXVp cmspOiBDaGVjayBpZiB0aGUgZG9jdW1lbnQgc2V0dGluZ3MgaXMgYSBudWxscHRyCisgICAgICAg IGJlZm9yZSBhdHRlbXB0aW5nIHRvIGRlcmVmZXJlbmNlIGl0LiAKKwogMjAxNS0wNC0yOCAgU2Ft IFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDb250ZW50IEV4dGVuc2lvbnNd IFByb2Nlc3MgTkZBcyBpbmRpdmlkdWFsbHkgdG8gYXZvaWQgaGF2aW5nIGFsbCBORkFzIGxpdmUg YXQgdGhlIHNhbWUgdGltZQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrRmxvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrRmxvdy5jcHAJKHJldmlzaW9uIDE4MzQ4OSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjEyLDggKzE2MTIs MTUgQEAgc3RhdGljIGlubGluZSBMYXlvdXRVbml0IGNhbGN1bGF0ZU1pbmltdQogCiBzdGF0aWMg aW5saW5lIGJvb2wgbmVlZHNBcHBsZU1haWxQYWdpbmF0aW9uUXVpcmsoUm9vdElubGluZUJveCYg bGluZUJveCkKIHsKLSAgICBib29sIGFwcGxlTWFpbFBhZ2luYXRpb25RdWlya0VuYWJsZWQgPSBs aW5lQm94LnJlbmRlcmVyKCkuZG9jdW1lbnQoKS5zZXR0aW5ncygpLT5hcHBsZU1haWxQYWdpbmF0 aW9uUXVpcmtFbmFibGVkKCk7Ci0gICAgaWYgKGFwcGxlTWFpbFBhZ2luYXRpb25RdWlya0VuYWJs ZWQgJiYgbGluZUJveC5yZW5kZXJlcigpLmVsZW1lbnQoKSAmJiBsaW5lQm94LnJlbmRlcmVyKCku ZWxlbWVudCgpLT5pZEZvclN0eWxlUmVzb2x1dGlvbigpID09IEF0b21pY1N0cmluZygibWVzc2Fn ZUNvbnRlbnRDb250YWluZXIiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKSkK KyAgICBjb25zdCBhdXRvJiByZW5kZXJlciA9IGxpbmVCb3gucmVuZGVyZXIoKTsKKworICAgIGlm ICghcmVuZGVyZXIuZG9jdW1lbnQoKS5zZXR0aW5ncygpKQorICAgICAgICByZXR1cm4gZmFsc2U7 CisKKyAgICBpZiAoIXJlbmRlcmVyLmRvY3VtZW50KCkuc2V0dGluZ3MoKS0+YXBwbGVNYWlsUGFn aW5hdGlvblF1aXJrRW5hYmxlZCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAo cmVuZGVyZXIuZWxlbWVudCgpICYmIHJlbmRlcmVyLmVsZW1lbnQoKS0+aWRGb3JTdHlsZVJlc29s dXRpb24oKSA9PSBBdG9taWNTdHJpbmcoIm1lc3NhZ2VDb250ZW50Q29udGFpbmVyIiwgQXRvbWlj U3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCiAg ICAgcmV0dXJuIGZhbHNlOwo=