144356 2015-04-28 14:09:17 -0700 Failure when building WebKit for appletvsimulator 2015-04-30 05:23:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jacob_nielsen jake.nielsen.webkit commit-queue dbates ddkilzer jake.nielsen.webkit joepeck oldest_to_newest 1089734 0 jacob_nielsen 2015-04-28 14:09:17 -0700 See rdar://problem/20641901 for details 1089737 1 251886 jake.nielsen.webkit 2015-04-28 14:18:09 -0700 Created attachment 251886 Patch 1090185 2 251886 commit-queue 2015-04-29 15:42:35 -0700 Comment on attachment 251886 Patch Clearing flags on attachment: 251886 Committed r183583: <http://trac.webkit.org/changeset/183583> 1090186 3 commit-queue 2015-04-29 15:42:40 -0700 All reviewed patches have been landed. Closing bug. 1090251 4 251886 joepeck 2015-04-29 17:42:36 -0700 Comment on attachment 251886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251886&action=review > Tools/WebKitTestRunner/Makefile:11 > -ifneq (,$(findstring iphone,$(SDKROOT))) > +ifeq (,$(findstring macosx,$(SDKROOT))) > ifeq (,$(findstring clean,$(MAKECMDGOALS))) > OTHER_OPTIONS += -target WebKitTestRunnerApp > endif This seems to cause "WebKitTestRunnerApp" to sometimes build on Mac, which causes failures, since the target won't build with macosx SDKs. 1090253 5 251886 joepeck 2015-04-29 17:43:18 -0700 Comment on attachment 251886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251886&action=review >> Tools/WebKitTestRunner/Makefile:11 >> endif > > This seems to cause "WebKitTestRunnerApp" to sometimes build on Mac, which causes failures, since the target won't build with macosx SDKs. To test, on a Mac: shell> cd Tools/WebKitTestRunner; make => errors building WebKitTestRunnerApp 1090259 6 joepeck 2015-04-29 17:48:42 -0700 Ahh, interesting. This tends to be the case when SDKROOT is not set. shell> make SDKROOT=macosx release => all is fine shell> make release => failures trying to build WebKitTestRunnerApp We probably should treat an empty SDKROOT as macosx. 1090260 7 jake.nielsen.webkit 2015-04-29 17:50:12 -0700 :( 251886 2015-04-28 14:18:09 -0700 2015-04-29 15:42:35 -0700 Patch bug-144356-20150428141700.patch text/plain 2879 jake.nielsen.webkit SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzUw NykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0 LTI4ICBKYWtlIE5pZWxzZW4gIDxqYWNvYl9uaWVsc2VuQGFwcGxlLmNvbT4KKworICAgICAgICBG YWlsdXJlIHdoZW4gYnVpbGRpbmcgV2ViS2l0IGZvciBhcHBsZXR2c2ltdWxhdG9yLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MzU2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlcyBNYWtlZmls ZSBsb2dpYyB0byBjaGVjayBmb3IgIm5vdCBPUyBYIiByYXRoZXIgdGhhbiAiaXMgaU9TIiB0bwor ICAgICAgICBtYWtlIFRWT1MgYW5kIFdhdGNoT1MgYmVoYXZlIGNvcnJlY3RseS4KKworICAgICAg ICAqIFNvdXJjZS9NYWtlZmlsZToKKwogMjAxNS0wNC0yOCAgTWljaGFlbCBDYXRhbnphcm8gIDxt Y2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IHR5cG8gaW4g cHJldmlvdXMgY29tbWl0CkluZGV4OiBTb3VyY2UvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL01ha2VmaWxlCShyZXZpc2lvbiAxODM1MDcpCisrKyBTb3VyY2UvTWFrZWZpbGUJKHdvcmtp bmcgY29weSkKQEAgLTEsOCArMSw2IEBACiBNT0RVTEVTID0gYm1hbGxvYyBXVEYgSmF2YVNjcmlw dENvcmUgVGhpcmRQYXJ0eS9BTkdMRSBXZWJDb3JlIFdlYkluc3BlY3RvclVJIFdlYktpdCBXZWJL aXQyCiAKLWlmbmVxICgsJChmaW5kc3RyaW5nIGlwaG9uZW9zLCQoU0RLUk9PVCkpKQotCU1PRFVM RVMgPSBibWFsbG9jIFdURiBKYXZhU2NyaXB0Q29yZSBUaGlyZFBhcnR5L0FOR0xFIFdlYkNvcmUg V2ViS2l0IFdlYktpdDIKLWVsc2UgaWZuZXEgKCwkKGZpbmRzdHJpbmcgaXBob25lc2ltdWxhdG9y LCQoU0RLUk9PVCkpKQoraWZlcSAoLCQoZmluZHN0cmluZyBtYWNvc3gsJChTREtST09UKSkpCiAJ TU9EVUxFUyA9IGJtYWxsb2MgV1RGIEphdmFTY3JpcHRDb3JlIFRoaXJkUGFydHkvQU5HTEUgV2Vi Q29yZSBXZWJLaXQgV2ViS2l0MgogZW5kaWYKIApJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTgzNTA3KQorKysgVG9vbHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMDQtMjggIEpha2Ug TmllbHNlbiAgPGphY29iX25pZWxzZW5AYXBwbGUuY29tPgorCisgICAgICAgIEZhaWx1cmUgd2hl biBidWlsZGluZyBXZWJLaXQgZm9yIGFwcGxldHZzaW11bGF0b3IuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQzNTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VzIE1ha2VmaWxlIGxvZ2ljIHRv IGNoZWNrIGZvciAibm90IE9TIFgiIHJhdGhlciB0aGFuICJpcyBpT1MiIHRvCisgICAgICAgIG1h a2UgVFZPUyBhbmQgV2F0Y2hPUyBiZWhhdmUgY29ycmVjdGx5LgorCisgICAgICAgICogTWFrZWZp bGU6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9NYWtlZmlsZToKKwogMjAxNS0wNC0yOCAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBjb21t b24gdHlwbyAidGFyZ2V0dGluZyIgPT4gInRhcmdldGluZyIKSW5kZXg6IFRvb2xzL01ha2VmaWxl Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL01ha2VmaWxlCShyZXZpc2lvbiAxODM1MDcpCisrKyBUb29s cy9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMSw2ICsxLDYgQEAKIE1PRFVMRVMgPSBEdW1w UmVuZGVyVHJlZSBXZWJLaXRUZXN0UnVubmVyIE1pbmlCcm93c2VyIC4uL1NvdXJjZS9UaGlyZFBh cnR5L2d0ZXN0L3hjb2RlIFRlc3RXZWJLaXRBUEkKIAotaWZuZXEgKCwkKGZpbmRzdHJpbmcgaXBo b25lLCQoU0RLUk9PVCkpKQoraWZlcSAoLCQoZmluZHN0cmluZyBtYWNvc3gsJChTREtST09UKSkp CiAJTU9EVUxFUyA9IER1bXBSZW5kZXJUcmVlIFdlYktpdFRlc3RSdW5uZXIgLi4vU291cmNlL1Ro aXJkUGFydHkvZ3Rlc3QveGNvZGUgVGVzdFdlYktpdEFQSQogZW5kaWYKIApJbmRleDogVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0 UnVubmVyL01ha2VmaWxlCShyZXZpc2lvbiAxODM1MDcpCisrKyBUb29scy9XZWJLaXRUZXN0UnVu bmVyL01ha2VmaWxlCSh3b3JraW5nIGNvcHkpCkBAIC01LDcgKzUsNyBAQCBCVUlMRF9XRUJLSVRU RVNUUlVOTkVSID0gJChzaGVsbCAoKCAkKE9TCiAKIGlmZXEgIiQoQlVJTERfV0VCS0lUVEVTVFJV Tk5FUikiICJZRVMiCiAKLWlmbmVxICgsJChmaW5kc3RyaW5nIGlwaG9uZSwkKFNES1JPT1QpKSkK K2lmZXEgKCwkKGZpbmRzdHJpbmcgbWFjb3N4LCQoU0RLUk9PVCkpKQogCWlmZXEgKCwkKGZpbmRz dHJpbmcgY2xlYW4sJChNQUtFQ01ER09BTFMpKSkKIAkJT1RIRVJfT1BUSU9OUyArPSAtdGFyZ2V0 IFdlYktpdFRlc3RSdW5uZXJBcHAKIAllbmRpZgo=