144354 2015-04-28 13:43:33 -0700 Web Inspector: Copy not working in Console 2015-04-30 01:55:25 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1089721 0 joepeck 2015-04-28 13:43:33 -0700 * SUMMARY Copy not working in Console. I swear I had this working recently. * STEPS TO REPRODUCE 1. Evaluate something in the console. 2. Select the evaluated code 3. Try to copy => does not copy 1089722 1 webkit-bug-importer 2015-04-28 13:44:13 -0700 <rdar://problem/20733625> 1090349 2 joepeck 2015-04-29 21:17:31 -0700 My guess is that "beforecopy" is stopping at the TabContentView without checking the TabContentView's inner content view. 1090350 3 timothy 2015-04-29 21:24:04 -0700 Likely so. I'll take a look tomorrow. 1090351 4 252037 joepeck 2015-04-29 21:26:41 -0700 Created attachment 252037 [PATCH] Proposed Fix 1090384 5 252037 timothy 2015-04-30 01:09:07 -0700 Comment on attachment 252037 [PATCH] Proposed Fix Thanks Joe! 1090392 6 252037 commit-queue 2015-04-30 01:55:21 -0700 Comment on attachment 252037 [PATCH] Proposed Fix Clearing flags on attachment: 252037 Committed r183625: <http://trac.webkit.org/changeset/183625> 1090393 7 commit-queue 2015-04-30 01:55:25 -0700 All reviewed patches have been landed. Closing bug. 252037 2015-04-29 21:26:41 -0700 2015-04-30 01:55:21 -0700 [PATCH] Proposed Fix fix-copy.patch text/plain 1756 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGIzMzBmMjUuLjI3MmU1N2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ29weSBu b3Qgd29ya2luZyBpbiBDb25zb2xlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDQzNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLl9mb2N1c2VkQ29udGVudFZpZXcpOgorICAgICAgICBTZWxlY3QgdGhlIGlubmVy IG1vc3QgY29udGVudCB2aWV3IHRvIGNoZWNrIGlmIGhhbmRsZUNvcHlFdmVudCBleGlzdHMuCisg ICAgICAgIFByZXZpb3VzbHkgd2Ugd2VyZSBzdG9wcGluZyBhdCB0aGUgdG9wIGxldmVsIFRhYkNv bnRlbnRWaWV3LgorCiAyMDE1LTA0LTI5ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgc29tZSB1bnVzZWQgSW1hZ2Vz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01h aW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMK aW5kZXggNzcxNmM4My4uZWExYmY0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMTUzNCw4ICsxNTM0LDEyIEBAIFdlYkluc3Bl Y3Rvci5fc2hvd0NvbnNvbGVUYWIgPSBmdW5jdGlvbihldmVudCkKIAogV2ViSW5zcGVjdG9yLl9m b2N1c2VkQ29udGVudFZpZXcgPSBmdW5jdGlvbigpCiB7Ci0gICAgaWYgKHRoaXMudGFiQnJvd3Nl ci5lbGVtZW50LmlzU2VsZk9yQW5jZXN0b3IodGhpcy5jdXJyZW50Rm9jdXNFbGVtZW50KSkKLSAg ICAgICAgcmV0dXJuIHRoaXMudGFiQnJvd3Nlci5zZWxlY3RlZFRhYkNvbnRlbnRWaWV3OworICAg IGlmICh0aGlzLnRhYkJyb3dzZXIuZWxlbWVudC5pc1NlbGZPckFuY2VzdG9yKHRoaXMuY3VycmVu dEZvY3VzRWxlbWVudCkpIHsKKyAgICAgICAgdmFyIHRhYkNvbnRlbnRWaWV3ID0gdGhpcy50YWJC cm93c2VyLnNlbGVjdGVkVGFiQ29udGVudFZpZXc7CisgICAgICAgIGlmICh0YWJDb250ZW50Vmll dyBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5Db250ZW50QnJvd3NlclRhYkNvbnRlbnRWaWV3KQor ICAgICAgICAgICAgcmV0dXJuIHRhYkNvbnRlbnRWaWV3LmNvbnRlbnRCcm93c2VyLmN1cnJlbnRD b250ZW50VmlldzsKKyAgICAgICAgcmV0dXJuIHRhYkNvbnRlbnRWaWV3OworICAgIH0KICAgICBp ZiAodGhpcy5zcGxpdENvbnRlbnRCcm93c2VyLmVsZW1lbnQuaXNTZWxmT3JBbmNlc3Rvcih0aGlz LmN1cnJlbnRGb2N1c0VsZW1lbnQpKQogICAgICAgICByZXR1cm4gIHRoaXMuc3BsaXRDb250ZW50 QnJvd3Nlci5jdXJyZW50Q29udGVudFZpZXc7CiAgICAgcmV0dXJuIG51bGw7Cg==