<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>144342</bug_id>
          
          <creation_ts>2015-04-28 11:21:26 -0700</creation_ts>
          <short_desc>Add support for lookup on iOS</short_desc>
          <delta_ts>2015-04-28 13:19:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Enrica Casucci">enrica</reporter>
          <assigned_to name="Enrica Casucci">enrica</assigned_to>
          <cc>bdakin</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1089639</commentid>
    <comment_count>0</comment_count>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2015-04-28 11:21:26 -0700</bug_when>
    <thetext>This tracks the work required to support lookup in WK2 on iOS.

rdar://problem/19994090</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089646</commentid>
    <comment_count>1</comment_count>
      <attachid>251870</attachid>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2015-04-28 11:31:47 -0700</bug_when>
    <thetext>Created attachment 251870
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089649</commentid>
    <comment_count>2</comment_count>
      <attachid>251870</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2015-04-28 11:39:12 -0700</bug_when>
    <thetext>Comment on attachment 251870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251870&amp;action=review

&gt; Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1309
&gt; +        CGRect presentationRect = view-&gt;_page-&gt;editorState().selectionIsRange ? view-&gt;_page-&gt;editorState().postLayoutData().selectionRects[0].rect() : view-&gt;_page-&gt;editorState().postLayoutData().caretRectAtStart;

Why do we only use the first rect? What happens if you have a multi-line selection?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089701</commentid>
    <comment_count>3</comment_count>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2015-04-28 13:08:47 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Comment on attachment 251870 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=251870&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1309
&gt; &gt; +        CGRect presentationRect = view-&gt;_page-&gt;editorState().selectionIsRange ? view-&gt;_page-&gt;editorState().postLayoutData().selectionRects[0].rect() : view-&gt;_page-&gt;editorState().postLayoutData().caretRectAtStart;
&gt; 
&gt; Why do we only use the first rect? What happens if you have a multi-line
&gt; selection?

We could in theory compute the union of the rects, but this is used only to position the popover. I don&apos;t have clear indication of what is expected here and I think this is  good enough to start.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089708</commentid>
    <comment_count>4</comment_count>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2015-04-28 13:19:59 -0700</bug_when>
    <thetext>Committed revision 183503.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>251870</attachid>
            <date>2015-04-28 11:31:47 -0700</date>
            <delta_ts>2015-04-28 13:12:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>lookup.txt</filename>
            <type>text/plain</type>
            <size>8229</size>
            <attacher name="Enrica Casucci">enrica</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzQ5MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA0LTI4ICBFbnJpY2Eg
Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGxv
b2t1cCBvbiBpT1MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xNDQzNDIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTk5OTQwOTAKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdl
UHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv
bi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfbG9va3VwOl0pOgorICAgICAgICAoLVtX
S0NvbnRlbnRWaWV3IGNhblBlcmZvcm1BY3Rpb246d2l0aFNlbmRlcjpdKToKKyAgICAgICAgKiBV
SVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn
ZVByb3h5OjpnZXRMb29rdXBDb250ZXh0QXRQb2ludCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9X
ZWJQYWdlL1dlYlBhZ2UuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5t
ZXNzYWdlcy5pbjoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1Mu
bW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmdldExvb2t1cENvbnRleHRBdFBvaW50KToK
KwogMjAxNS0wNC0yOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg
IFtXSzJdW01hY10gVXBkYXRlIFdlYkNvbnRlbnQgcHJvY2Vzcycgc2FuZGJveCBwcm9maWxlIGZv
ciBBV0QKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgJKHJldmlz
aW9uIDE4MzQ5MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAko
d29ya2luZyBjb3B5KQpAQCAtNTAxLDYgKzUwMSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHZpZXdw
b3J0TWV0YVRhZ1dpZHRoRGlkQ2hhbmdlKGZsb2F0IHdpZHRoKTsKICAgICB2b2lkIGRpZEZpbmlz
aERyYXdpbmdQYWdlc1RvUERGKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYpOwogICAgIHZvaWQg
Y29udGVudFNpemVDYXRlZ29yeURpZENoYW5nZShjb25zdCBTdHJpbmcmIGNvbnRlbnRTaXplQ2F0
ZWdvcnkpOworICAgIHZvaWQgZ2V0TG9va3VwQ29udGV4dEF0UG9pbnQoY29uc3QgV2ViQ29yZTo6
SW50UG9pbnQmLCBzdGQ6OmZ1bmN0aW9uPHZvaWQoY29uc3QgU3RyaW5nJiwgQ2FsbGJhY2tCYXNl
OjpFcnJvcik+KTsKICNlbmRpZgogCiAgICAgdm9pZCBkaWRDb21taXRMYXllclRyZWUoY29uc3Qg
V2ViS2l0OjpSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbiYpOwpJbmRleDogU291cmNlL1dlYktp
dDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u
bW0JKHJldmlzaW9uIDE4MzQ5MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tD
b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xODIsMTEgKzE4Miwx
MyBAQCAtICh2b2lkKXNjaGVkdWxlUmVwbGFjZW1lbnRzRm9yVGV4dDooTlNTCiAtICh2b2lkKXNo
b3dUZXh0U2VydmljZUZvcjooTlNTdHJpbmcgKilzZWxlY3RlZFRlcm0gZnJvbVJlY3Q6KENHUmVj
dClwcmVzZW50YXRpb25SZWN0OwogLSAodm9pZClzY2hlZHVsZUNoaW5lc2VUcmFuc2xpdGVyYXRp
b25Gb3JUZXh0OihOU1N0cmluZyAqKXRleHQ7CiAtICh2b2lkKXNob3dTaGFyZVNoZWV0Rm9yOihO
U1N0cmluZyAqKXNlbGVjdGVkVGVybSBmcm9tUmVjdDooQ0dSZWN0KXByZXNlbnRhdGlvblJlY3Q7
CistICh2b2lkKWxvb2t1cDooTlNTdHJpbmcgKil0ZXh0V2l0aENvbnRleHQgZnJvbVJlY3Q6KENH
UmVjdClwcmVzZW50YXRpb25SZWN0OwogQGVuZAogCiBAaW50ZXJmYWNlIFVJV0tTZWxlY3Rpb25B
c3Npc3RhbnQgKFN0YWdpbmdUb1JlbW92ZSkKIC0gKHZvaWQpc2hvd1RleHRTZXJ2aWNlRm9yOihO
U1N0cmluZyAqKXNlbGVjdGVkVGVybSBmcm9tUmVjdDooQ0dSZWN0KXByZXNlbnRhdGlvblJlY3Q7
CiAtICh2b2lkKXNob3dTaGFyZVNoZWV0Rm9yOihOU1N0cmluZyAqKXNlbGVjdGVkVGVybSBmcm9t
UmVjdDooQ0dSZWN0KXByZXNlbnRhdGlvblJlY3Q7CistICh2b2lkKWxvb2t1cDooTlNTdHJpbmcg
Kil0ZXh0V2l0aENvbnRleHQgZnJvbVJlY3Q6KENHUmVjdClwcmVzZW50YXRpb25SZWN0OwogQGVu
ZAogCiBAaW50ZXJmYWNlIFVJS2V5Ym9hcmRJbXBsIChTdGFnaW5nVG9SZW1vdmUpCkBAIC0xMjk1
LDYgKzEyOTcsMjQgQEAgLSAoTlNBcnJheSAqKXN1cHBvcnRlZFBhc3RlYm9hcmRUeXBlc0Zvcgog
ICAgIHJldHVybiAoX3BhZ2UtPmVkaXRvclN0YXRlKCkuaXNDb250ZW50UmljaGx5RWRpdGFibGUp
ID8gcmljaFR5cGVzIDogcGxhaW5UZXh0VHlwZXM7CiB9CiAKKy0gKHZvaWQpX2xvb2t1cDooQ0dQ
b2ludClwb2ludAoreworICAgIFJldGFpblB0cjxXS0NvbnRlbnRWaWV3PiB2aWV3ID0gc2VsZjsK
KyAgICBfcGFnZS0+Z2V0TG9va3VwQ29udGV4dEF0UG9pbnQoV2ViQ29yZTo6SW50UG9pbnQocG9p
bnQpLCBbdmlld10oY29uc3QgU3RyaW5nJiBzdHJpbmcsIENhbGxiYWNrQmFzZTo6RXJyb3IgZXJy
b3IpIHsKKyAgICAgICAgaWYgKGVycm9yICE9IENhbGxiYWNrQmFzZTo6RXJyb3I6Ok5vbmUpCisg
ICAgICAgICAgICByZXR1cm47CisgICAgICAgIGlmICghc3RyaW5nKQorICAgICAgICAgICAgcmV0
dXJuOworICAgICAgICAKKyAgICAgICAgQ0dSZWN0IHByZXNlbnRhdGlvblJlY3QgPSB2aWV3LT5f
cGFnZS0+ZWRpdG9yU3RhdGUoKS5zZWxlY3Rpb25Jc1JhbmdlID8gdmlldy0+X3BhZ2UtPmVkaXRv
clN0YXRlKCkucG9zdExheW91dERhdGEoKS5zZWxlY3Rpb25SZWN0c1swXS5yZWN0KCkgOiB2aWV3
LT5fcGFnZS0+ZWRpdG9yU3RhdGUoKS5wb3N0TGF5b3V0RGF0YSgpLmNhcmV0UmVjdEF0U3RhcnQ7
CisgICAgICAgIAorICAgICAgICBpZiAodmlldy0+X3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgJiYg
W3ZpZXctPl90ZXh0U2VsZWN0aW9uQXNzaXN0YW50IHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0
b3IobG9va3VwOmZyb21SZWN0OildKQorICAgICAgICAgICAgW3ZpZXctPl90ZXh0U2VsZWN0aW9u
QXNzaXN0YW50IGxvb2t1cDpzdHJpbmcgZnJvbVJlY3Q6cHJlc2VudGF0aW9uUmVjdF07CisgICAg
ICAgIGVsc2UgaWYgKHZpZXctPl93ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgJiYgW3ZpZXctPl93ZWJT
ZWxlY3Rpb25Bc3Npc3RhbnQgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihsb29rdXA6ZnJv
bVJlY3Q6KV0pCisgICAgICAgICAgICBbdmlldy0+X3dlYlNlbGVjdGlvbkFzc2lzdGFudCBsb29r
dXA6c3RyaW5nIGZyb21SZWN0OnByZXNlbnRhdGlvblJlY3RdOworICAgIH0pOworfQorCiAtICh2
b2lkKV9zaGFyZTooaWQpc2VuZGVyCiB7CiAgICAgUmV0YWluUHRyPFdLQ29udGVudFZpZXc+IHZp
ZXcgPSBzZWxmOwpAQCAtMTQ0Myw2ICsxNDYzLDE2IEBAICAgICAgICAgLy8gYWNjZXB0YWJsZSwg
YnV0IHRoZSBpbnRlcmZhY2UKICAgICAgICAgcmV0dXJuIFlFUzsKICAgICB9CiAKKyAgICBpZiAo
YWN0aW9uID09IEBzZWxlY3RvcihfbG9va3VwOikpIHsKKyAgICAgICAgaWYgKF9wYWdlLT5lZGl0
b3JTdGF0ZSgpLmlzSW5QYXNzd29yZEZpZWxkKQorICAgICAgICAgICAgcmV0dXJuIE5POworICAg
ICAgICAKKyAgICAgICAgaWYgKFtbZ2V0TUNQcm9maWxlQ29ubmVjdGlvbkNsYXNzKCkgc2hhcmVk
Q29ubmVjdGlvbl0gZWZmZWN0aXZlQm9vbFZhbHVlRm9yU2V0dGluZzpNQ0ZlYXR1cmVEZWZpbml0
aW9uTG9va3VwQWxsb3dlZF0gPT0gTUNSZXN0cmljdGVkQm9vbEV4cGxpY2l0Tm8pCisgICAgICAg
ICAgICByZXR1cm4gTk87CisgICAgICAgIAorICAgICAgICByZXR1cm4gWUVTOworICAgIH0KKwog
ICAgIGlmIChhY3Rpb24gPT0gQHNlbGVjdG9yKF9zaGFyZTopKSB7CiAgICAgICAgIGlmIChfcGFn
ZS0+ZWRpdG9yU3RhdGUoKS5pc0luUGFzc3dvcmRGaWVsZCB8fCAhKGhhc1dlYlNlbGVjdGlvbiB8
fCBfcGFnZS0+ZWRpdG9yU3RhdGUoKS5zZWxlY3Rpb25Jc1JhbmdlKSkKICAgICAgICAgICAgIHJl
dHVybiBOTzsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5
SU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFn
ZVByb3h5SU9TLm1tCShyZXZpc2lvbiAxODM0OTMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTEzLDYgKzUxMywx
NyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6Z2V0QXV0b2NvcnJlY3Rpb25Db250CiAgICAgbV9wcm9j
ZXNzLT5zZW5kU3luYyhNZXNzYWdlczo6V2ViUGFnZTo6R2V0QXV0b2NvcnJlY3Rpb25Db250ZXh0
KCksIE1lc3NhZ2VzOjpXZWJQYWdlOjpHZXRBdXRvY29ycmVjdGlvbkNvbnRleHQ6OlJlcGx5KGJl
Zm9yZUNvbnRleHQsIG1hcmtlZFRleHQsIHNlbGVjdGVkVGV4dCwgYWZ0ZXJDb250ZXh0LCBsb2Nh
dGlvbiwgbGVuZ3RoKSwgbV9wYWdlSUQpOwogfQogCit2b2lkIFdlYlBhZ2VQcm94eTo6Z2V0TG9v
a3VwQ29udGV4dEF0UG9pbnQoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIHBvaW50LCBzdGQ6OmZ1
bmN0aW9uPHZvaWQoY29uc3QgU3RyaW5nJiwgQ2FsbGJhY2tCYXNlOjpFcnJvcik+IGNhbGxiYWNr
RnVuY3Rpb24pCit7CisgICAgaWYgKCFpc1ZhbGlkKCkpIHsKKyAgICAgICAgY2FsbGJhY2tGdW5j
dGlvbihTdHJpbmcoKSwgQ2FsbGJhY2tCYXNlOjpFcnJvcjo6VW5rbm93bik7CisgICAgICAgIHJl
dHVybjsKKyAgICB9CisgICAgCisgICAgdWludDY0X3QgY2FsbGJhY2tJRCA9IG1fY2FsbGJhY2tz
LnB1dChXVEY6Om1vdmUoY2FsbGJhY2tGdW5jdGlvbiksIG1fcHJvY2Vzcy0+dGhyb3R0bGVyKCku
YmFja2dyb3VuZEFjdGl2aXR5VG9rZW4oKSk7CisgICAgbV9wcm9jZXNzLT5zZW5kKE1lc3NhZ2Vz
OjpXZWJQYWdlOjpHZXRMb29rdXBDb250ZXh0QXRQb2ludChwb2ludCwgY2FsbGJhY2tJRCksIG1f
cGFnZUlEKTsKK30KKwogdm9pZCBXZWJQYWdlUHJveHk6OnNlbGVjdFdpdGhUd29Ub3VjaGVzKGNv
bnN0IFdlYkNvcmU6OkludFBvaW50IGZyb20sIGNvbnN0IFdlYkNvcmU6OkludFBvaW50IHRvLCB1
aW50MzJfdCBnZXN0dXJlVHlwZSwgdWludDMyX3QgZ2VzdHVyZVN0YXRlLCBzdGQ6OmZ1bmN0aW9u
PHZvaWQgKGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiwgdWludDMyX3QsIHVpbnQzMl90LCB1aW50
MzJfdCwgQ2FsbGJhY2tCYXNlOjpFcnJvcik+IGNhbGxiYWNrRnVuY3Rpb24pCiB7CiAgICAgaWYg
KCFpc1ZhbGlkKCkpIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9X
ZWJQYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl
L1dlYlBhZ2UuaAkocmV2aXNpb24gMTgzNDkzKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz
cy9XZWJQYWdlL1dlYlBhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtNTI2LDYgKzUyNiw3IEBAIHB1
YmxpYzoKICAgICB2b2lkIHJlc2V0QXNzaXN0ZWROb2RlRm9yRnJhbWUoV2ViRnJhbWUqKTsKICAg
ICBXZWJDb3JlOjpJbnRSZWN0IHJlY3RGb3JFbGVtZW50QXRJbnRlcmFjdGlvbkxvY2F0aW9uKCk7
CiAgICAgdm9pZCB1cGRhdGVTZWxlY3Rpb25BcHBlYXJhbmNlKCk7CisgICAgdm9pZCBnZXRMb29r
dXBDb250ZXh0QXRQb2ludChjb25zdCBXZWJDb3JlOjpJbnRQb2ludCwgdWludDY0X3QgY2FsbGJh
Y2tJRCk7CiAKICNpZiBFTkFCTEUoSU9TX1RPVUNIX0VWRU5UUykKICAgICB2b2lkIGRpc3BhdGNo
QXN5bmNocm9ub3VzVG91Y2hFdmVudHMoY29uc3QgVmVjdG9yPFdlYlRvdWNoRXZlbnQsIDE+JiBx
dWV1ZSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5t
ZXNzYWdlcy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh
Z2UvV2ViUGFnZS5tZXNzYWdlcy5pbgkocmV2aXNpb24gMTgzNDkzKQorKysgU291cmNlL1dlYktp
dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4JKHdvcmtpbmcgY29weSkK
QEAgLTkxLDYgKzkxLDcgQEAgbWVzc2FnZXMgLT4gV2ViUGFnZSBMZWdhY3lSZWNlaXZlciB7CiAg
ICAgQXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmUoKQogICAgIENvbnRlbnRTaXplQ2F0ZWdvcnlE
aWRDaGFuZ2UoU3RyaW5nIGNvbnRlbnRTaXplQ2F0ZWdvcnkpCiAgICAgRXhlY3V0ZUVkaXRDb21t
YW5kV2l0aENhbGxiYWNrKFN0cmluZyBuYW1lLCB1aW50NjRfdCBjYWxsYmFja0lEKQorICAgIEdl
dExvb2t1cENvbnRleHRBdFBvaW50KFdlYkNvcmU6OkludFBvaW50IHBvaW50LCB1aW50NjRfdCBj
YWxsYmFja0lEKQogI2VuZGlmCiAKICNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKSW5kZXg6
IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJ
T1MubW0JKHJldmlzaW9uIDE4MzQ5MykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi
UGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtNDA2LDYgKzQwNiwyMCBA
QCBib29sIFdlYlBhZ2U6OnBlcmZvcm1EZWZhdWx0QmVoYXZpb3JGb3JLCiAgICAgcmV0dXJuIGZh
bHNlOwogfQogCit2b2lkIFdlYlBhZ2U6OmdldExvb2t1cENvbnRleHRBdFBvaW50KGNvbnN0IFdl
YkNvcmU6OkludFBvaW50IHBvaW50LCB1aW50NjRfdCBjYWxsYmFja0lEKQoreworICAgIEZyYW1l
JiBmcmFtZSA9IG1fcGFnZS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNlZE9yTWFpbkZyYW1lKCk7
CisgICAgVmlzaWJsZVBvc2l0aW9uIHBvc2l0aW9uID0gZnJhbWUudmlzaWJsZVBvc2l0aW9uRm9y
UG9pbnQocG9pbnQpOworICAgIFN0cmluZyByZXN1bHRTdHJpbmc7CisgICAgaWYgKCFwb3NpdGlv
bi5pc051bGwoKSkgeworICAgICAgICAvLyBBcyBjb250ZXh0LCB3ZSBhcmUgZ29pbmcgdG8gdXNl
IDI1MCBjaGFyYWN0ZXJzIG9mIHRleHQgYmVmb3JlIGFuZCBhZnRlciB0aGUgcG9pbnQuCisgICAg
ICAgIFJlZlB0cjxSYW5nZT4gZnVsbENoYXJhY3RlclJhbmdlID0gcmFuZ2VFeHBhbmRlZEFyb3Vu
ZFBvc2l0aW9uQnlDaGFyYWN0ZXJzKHBvc2l0aW9uLCAyNTApOworICAgICAgICBpZiAoZnVsbENo
YXJhY3RlclJhbmdlKQorICAgICAgICAgICAgcmVzdWx0U3RyaW5nID0gcGxhaW5UZXh0KGZ1bGxD
aGFyYWN0ZXJSYW5nZS5nZXQoKSk7CisgICAgfQorICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQ
cm94eTo6U3RyaW5nQ2FsbGJhY2socmVzdWx0U3RyaW5nLCBjYWxsYmFja0lEKSk7Cit9CisKIE5T
T2JqZWN0ICpXZWJQYWdlOjphY2Nlc3NpYmlsaXR5T2JqZWN0Rm9yTWFpbkZyYW1lUGx1Z2luKCkK
IHsKICAgICBpZiAoIW1fcGFnZSkK
</data>
<flag name="review"
          id="276673"
          type_id="1"
          status="+"
          setter="thorton"
    />
          </attachment>
      

    </bug>

</bugzilla>