144317 2015-04-28 00:09:36 -0700 DFG+FTL should generate efficient code for branching on a string's boolean value. 2015-04-28 11:55:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling fpizlo ggaren kling oldest_to_newest 1089429 0 kling 2015-04-28 00:09:36 -0700 We shouldn't drop out to operationConvertJSValueToBoolean if we know the value to be a string. 1089431 1 251830 kling 2015-04-28 00:17:41 -0700 Created attachment 251830 Proposed patch All right, let's see if I got this right. 1089617 2 251830 ggaren 2015-04-28 11:01:10 -0700 Comment on attachment 251830 Proposed patch r=me Can has FTL? 1089620 3 251830 fpizlo 2015-04-28 11:02:56 -0700 Comment on attachment 251830 Proposed patch This needs to have the FTL implementation as well. Otherwise you're actually reducing FTL coverage with this patch. So, please implement both DFG and FTL functionality in the same patch. 1089630 4 kling 2015-04-28 11:14:29 -0700 (In reply to comment #3) > Comment on attachment 251830 [details] > Proposed patch > > This needs to have the FTL implementation as well. Otherwise you're > actually reducing FTL coverage with this patch. > > So, please implement both DFG and FTL functionality in the same patch. FTL already uses boolify() to implement compileBranch(). boolify() knows how to handle StringUse and generates nice code for it. Doesn't this mean that the FTL support is already in-place? 1089631 5 fpizlo 2015-04-28 11:15:31 -0700 (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 251830 [details] > > Proposed patch > > > > This needs to have the FTL implementation as well. Otherwise you're > > actually reducing FTL coverage with this patch. > > > > So, please implement both DFG and FTL functionality in the same patch. > > FTL already uses boolify() to implement compileBranch(). boolify() knows how > to handle StringUse and generates nice code for it. Doesn't this mean that > the FTL support is already in-place? Oh! That's true. 1089632 6 251830 fpizlo 2015-04-28 11:16:13 -0700 Comment on attachment 251830 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=251830&action=review > LayoutTests/ChangeLog:3 > + DFG should generate efficient code for branching on a string's boolean value. Please make sure you note that this is about both DFG and FTL. Either change the bug title, or put some blurb in the changelog. 1089657 7 kling 2015-04-28 11:55:28 -0700 Committed r183495: <http://trac.webkit.org/changeset/183495> 251830 2015-04-28 00:17:41 -0700 2015-04-28 11:15:44 -0700 Proposed patch bug-144317.diff text/plain 6814 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMTU5Yjg3Li4zNWJlMzljIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDQt MjggIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAgICAgIERGRyBzaG91 bGQgZ2VuZXJhdGUgZWZmaWNpZW50IGNvZGUgZm9yIGJyYW5jaGluZyBvbiBhIHN0cmluZydzIGJv b2xlYW4gdmFsdWUuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDQzMTc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqcy9yZWdyZXNz L2JyYW5jaC1vbi1zdHJpbmctYXMtYm9vbGVhbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGpzL3JlZ3Jlc3MvYnJhbmNoLW9uLXN0cmluZy1hcy1ib29sZWFuLmh0bWw6IEFkZGVkLgor ICAgICAgICAqIGpzL3JlZ3Jlc3Mvc2NyaXB0LXRlc3RzL2JyYW5jaC1vbi1zdHJpbmctYXMtYm9v bGVhbi5qczogQWRkZWQuCisKIDIwMTUtMDQtMjcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBh cHBsZS5jb20+CiAKICAgICAgICAgcmRhcjovL3Byb2JsZW0vMTY2NzgzOTIgUGFnZSB2aXNpYmls aXR5IHRlc3RzIGFyZSBicm9rZW4gaW4gWW9zZW1pdGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2pzL3JlZ3Jlc3MvYnJhbmNoLW9uLXN0cmluZy1hcy1ib29sZWFuLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2pzL3JlZ3Jlc3MvYnJhbmNoLW9uLXN0cmluZy1hcy1ib29sZWFuLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lZDliMmY5Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvanMvcmVncmVzcy9icmFuY2gtb24tc3RyaW5nLWFzLWJv b2xlYW4tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK0pTUmVncmVzcy9icmFuY2gtb24t c3RyaW5nLWFzLWJvb2xlYW4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1Mg bm8gZXhjZXB0aW9uIHRocm93bgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitU RVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL3JlZ3Jlc3MvYnJhbmNo LW9uLXN0cmluZy1hcy1ib29sZWFuLmh0bWwgYi9MYXlvdXRUZXN0cy9qcy9yZWdyZXNzL2JyYW5j aC1vbi1zdHJpbmctYXMtYm9vbGVhbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLjFjYzIyMzAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9qcy9yZWdyZXNz L2JyYW5jaC1vbi1zdHJpbmctYXMtYm9vbGVhbi5odG1sCkBAIC0wLDAgKzEsMTIgQEAKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9yZWdyZXNzLXBy ZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL2JyYW5jaC1vbi1zdHJp bmctYXMtYm9vbGVhbi5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2Vz L3JlZ3Jlc3MtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2Vz L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy9icmFuY2gtb24tc3RyaW5nLWFz LWJvb2xlYW4uanMgYi9MYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy9icmFuY2gt b24tc3RyaW5nLWFzLWJvb2xlYW4uanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uZTAxNTQ5MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2pzL3JlZ3Jlc3Mvc2Ny aXB0LXRlc3RzL2JyYW5jaC1vbi1zdHJpbmctYXMtYm9vbGVhbi5qcwpAQCAtMCwwICsxLDEyIEBA CisvLyBUaGlzIHRlc3QgYnJhbmNoZXMgb24gdGhlIGJvb2xlYW4gdmFsdWUgb2YgYSBzdHJpbmcs IHdoaWNoIHNob3VsZCBiZSBmYXN0IGluIHRoZSBERkcuCisKK2Z1bmN0aW9uIGZvbyhzdHJpbmcp IHsKKyAgICB2YXIgYmFyOworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwMDA7ICsraSkg eworICAgICAgICBpZiAoc3RyaW5nKQorICAgICAgICAgICAgYmFyKys7CisgICAgfQorICAgIHJl dHVybiBiYXI7Cit9CisKK3Jlc3VsdCA9IGZvbygnaHVyciBpbSBhIHN0cmluZycpOwpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKaW5kZXggZjA3NDJkMy4uNzBlY2NmZiAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTUtMDQtMjggIEFuZHJlYXMgS2xpbmcgIDxha2xp bmdAYXBwbGUuY29tPgorCisgICAgICAgIERGRyBzaG91bGQgZ2VuZXJhdGUgZWZmaWNpZW50IGNv ZGUgZm9yIGJyYW5jaGluZyBvbiBhIHN0cmluZydzIGJvb2xlYW4gdmFsdWUuCisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xNDQzMTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGVhY2ggQnJhbmNoIG5vZGVzIGFib3V0IFN0cmluZ1VzZSBh bmQgaGF2ZSB0aGVtIGdlbmVyYXRlIGFuIGVmZmljaWVudCB6ZXJvLWxlbmd0aCBzdHJpbmcgY2hl Y2sKKyAgICAgICAgaW5zdGVhZCBvZiBkcm9wcGluZyBvdXQgdG8gQysrIHdoZW5ldmVyIHdlIGJy YW5jaCBvbiBhIHN0cmluZy4KKworICAgICAgICBUZXN0OiBqcy9yZWdyZXNzL2JyYW5jaC1vbi1z dHJpbmctYXMtYm9vbGVhbi5qcyAofjQuNXggc3BlZWR1cCkKKworICAgICAgICAqIGRmZy9ERkdG aXh1cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpGaXh1cFBoYXNlOjpmaXh1cE5vZGUp OgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRG Rzo6U3BlY3VsYXRpdmVKSVQ6OmVtaXRTdHJpbmdCcmFuY2gpOgorICAgICAgICAqIGRmZy9ERkdT cGVjdWxhdGl2ZUpJVC5oOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNw cDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6ZW1pdEJyYW5jaCk6CisgICAg ICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNw ZWN1bGF0aXZlSklUOjplbWl0QnJhbmNoKToKKwogMjAxNS0wNC0yNyAgQW5kcmVhcyBLbGluZyAg PGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVnRXhwIG1hdGNoZXMgYXJyYXlzIHNob3Vs ZCB1c2UgY29udGlndW91cyBpbmRleGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0ZpeHVwUGhhc2UuY3BwCmluZGV4IGY3NGVjYmQuLmNiYWMzNzEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcApAQCAtNzM3LDYgKzczNyw4IEBAIHByaXZh dGU6CiAgICAgICAgICAgICAgICAgZml4RWRnZTxJbnQzMlVzZT4obm9kZS0+Y2hpbGQxKCkpOwog ICAgICAgICAgICAgZWxzZSBpZiAobm9kZS0+Y2hpbGQxKCktPnNob3VsZFNwZWN1bGF0ZU51bWJl cigpKQogICAgICAgICAgICAgICAgIGZpeEVkZ2U8RG91YmxlUmVwVXNlPihub2RlLT5jaGlsZDEo KSk7CisgICAgICAgICAgICBlbHNlIGlmIChub2RlLT5jaGlsZDEoKS0+c2hvdWxkU3BlY3VsYXRl U3RyaW5nKCkpCisgICAgICAgICAgICAgICAgZml4RWRnZTxTdHJpbmdVc2U+KG5vZGUtPmNoaWxk MSgpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgICAgICAKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKaW5kZXggYTc0 MTdkZi4uNjczMmVhNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdT cGVjdWxhdGl2ZUpJVC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVC5jcHAKQEAgLTQwNDAsNiArNDA0MCwxNSBAQCB2b2lkIFNwZWN1bGF0aXZlSklU Ojpjb21waWxlU3RyaW5nWmVyb0xlbmd0aChOb2RlKiBub2RlKQogICAgIHVuYmxlc3NlZEJvb2xl YW5SZXN1bHQoZXFHUFIsIG5vZGUpOwogfQogCit2b2lkIFNwZWN1bGF0aXZlSklUOjplbWl0U3Ry aW5nQnJhbmNoKEVkZ2Ugbm9kZVVzZSwgQmFzaWNCbG9jayogdGFrZW4sIEJhc2ljQmxvY2sqIG5v dFRha2VuKQoreworICAgIFNwZWN1bGF0ZUNlbGxPcGVyYW5kIHN0cih0aGlzLCBub2RlVXNlKTsK KyAgICBzcGVjdWxhdGVTdHJpbmcobm9kZVVzZSwgc3RyLmdwcigpKTsKKyAgICBicmFuY2hUZXN0 MzIoSklUQ29tcGlsZXI6Ok5vblplcm8sIE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKHN0ci5ncHIo KSwgSlNTdHJpbmc6Om9mZnNldE9mTGVuZ3RoKCkpLCB0YWtlbik7CisgICAganVtcChub3RUYWtl bik7CisgICAgbm9SZXN1bHQobV9jdXJyZW50Tm9kZSk7Cit9CisKIHZvaWQgU3BlY3VsYXRpdmVK SVQ6OmNvbXBpbGVDb25zdGFudFN0b3JhZ2VQb2ludGVyKE5vZGUqIG5vZGUpCiB7CiAgICAgR1BS VGVtcG9yYXJ5IHN0b3JhZ2UodGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1NwZWN1bGF0aXZlSklULmgKaW5kZXggODViMzVkYy4uYTY4ODQxZCAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaApAQCAtMjEwMyw2ICsyMTAzLDcg QEAgcHVibGljOgogICAgIHZvaWQgY29tcGlsZU1pc2NTdHJpY3RFcShOb2RlKik7CiAKICAgICB2 b2lkIGVtaXRPYmplY3RPck90aGVyQnJhbmNoKEVkZ2UgdmFsdWUsIEJhc2ljQmxvY2sqIHRha2Vu LCBCYXNpY0Jsb2NrKiBub3RUYWtlbik7CisgICAgdm9pZCBlbWl0U3RyaW5nQnJhbmNoKEVkZ2Ug dmFsdWUsIEJhc2ljQmxvY2sqIHRha2VuLCBCYXNpY0Jsb2NrKiBub3RUYWtlbik7CiAgICAgdm9p ZCBlbWl0QnJhbmNoKE5vZGUqKTsKICAgICAKICAgICBzdHJ1Y3QgU3RyaW5nU3dpdGNoQ2FzZSB7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklU MzJfNjQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMy XzY0LmNwcAppbmRleCBkNDU1NmM0Li4yNTRiYjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKQEAgLTE1NzMsNyArMTU3 MywxMiBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjplbWl0QnJhbmNoKE5vZGUqIG5vZGUpCiAgICAg ICAgIGVtaXRPYmplY3RPck90aGVyQnJhbmNoKG5vZGUtPmNoaWxkMSgpLCB0YWtlbiwgbm90VGFr ZW4pOwogICAgICAgICByZXR1cm47CiAgICAgfQotICAgIAorCisgICAgY2FzZSBTdHJpbmdVc2U6 IHsKKyAgICAgICAgZW1pdFN0cmluZ0JyYW5jaChub2RlLT5jaGlsZDEoKSwgdGFrZW4sIG5vdFRh a2VuKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGNhc2UgRG91YmxlUmVwVXNlOgog ICAgIGNhc2UgSW50MzJVc2U6IHsKICAgICAgICAgaWYgKG5vZGUtPmNoaWxkMSgpLnVzZUtpbmQo KSA9PSBJbnQzMlVzZSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdTcGVjdWxhdGl2ZUpJVDY0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Bl Y3VsYXRpdmVKSVQ2NC5jcHAKaW5kZXggZTg1MmY3Mi4uYjI0ZDUyYiAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCkBAIC0xNzQyLDYg KzE3NDIsMTEgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6ZW1pdEJyYW5jaChOb2RlKiBub2RlKQog ICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgY2FzZSBTdHJpbmdVc2U6IHsKKyAgICAgICAg ZW1pdFN0cmluZ0JyYW5jaChub2RlLT5jaGlsZDEoKSwgdGFrZW4sIG5vdFRha2VuKTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KKwogICAgIGNhc2UgVW50eXBlZFVzZToKICAgICBjYXNlIEJvb2xl YW5Vc2U6IHsKICAgICAgICAgSlNWYWx1ZU9wZXJhbmQgdmFsdWUodGhpcywgbm9kZS0+Y2hpbGQx KCksIE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbik7Cg==