144308 2015-04-27 19:46:18 -0700 Disable App Nap in WebKitTestRunner UI process 2015-04-28 10:46:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=108400 https://bugs.webkit.org/show_bug.cgi?id=144155 P2 Normal --- 1 ap ap andersca barraclough cdumez dbates sam oldest_to_newest 1089346 0 ap 2015-04-27 19:46:18 -0700 DumpRenderTree disables App Nap since bug 108400, and I just made WebKit2 secondary processes not app nap in bug 144155. But WebKitTestRunner itself can still be suppressed, as far as I can tell. 1089350 1 251808 ap 2015-04-27 19:52:03 -0700 Created attachment 251808 proposed patch This changes process role from TASK_BACKGROUND_APPLICATION to TASK_UNSPECIFIED. I don't know all the ramifications, but at least the patch is not a no-op, and it makes WKTR more like DRT. 1089547 2 251808 dbates 2015-04-28 09:15:51 -0700 Comment on attachment 251808 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=251808&action=review This looks sane to me. > Tools/WebKitTestRunner/mac/main.mm:45 > + static id assertion = [[[NSProcessInfo processInfo] beginActivityWithOptions:options reason:@"DumpRenderTree should not be subject to process suppression"] retain]; DumpRenderTree => WebKitTestRunner 1089607 3 ap 2015-04-28 10:46:25 -0700 Committed r183488. 251808 2015-04-27 19:52:03 -0700 2015-04-28 09:15:51 -0700 proposed patch WKTR-AppNap.txt text/plain 1827 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MzQ0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTA0LTI3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIERpc2FibGUgQXBwIE5hcCBpbiBXZWJLaXRUZXN0UnVubmVyIFVJIHByb2Nl c3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDMw OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi S2l0VGVzdFJ1bm5lci9tYWMvbWFpbi5tbToKKyAgICAgICAgKGRpc2FibGVBcHBOYXBJblVJUHJv Y2Vzcyk6CisgICAgICAgIChtYWluKToKKwogMjAxNS0wNC0yNyAgRGV3ZWkgWmh1ICA8ZGV3ZWlf emh1QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgJ19faW5pdF9fLnB5JyBhbmQgZml4IGtub3du IGJ1ZyBpbiBiZW5jaG1hcmsgcnVubmVyLgpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9t YWMvbWFpbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9tYWlu Lm1tCShyZXZpc2lvbiAxODI3NzMpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9tYWlu Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zOSwxMSArMzksMTkgQEAgc3RhdGljIHZvaWQgc2V0RGVm YXVsdHNUb0NvbnNpc3RlbnRWYWx1ZQogICAgIFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2Vy RGVmYXVsdHNdIHNldFZhbHVlc0ZvcktleXNXaXRoRGljdGlvbmFyeTpkaWN0XTsKIH0KIAorc3Rh dGljIHZvaWQgZGlzYWJsZUFwcE5hcEluVUlQcm9jZXNzKCkKK3sKKyAgICBOU0FjdGl2aXR5T3B0 aW9ucyBvcHRpb25zID0gKE5TQWN0aXZpdHlVc2VySW5pdGlhdGVkQWxsb3dpbmdJZGxlU3lzdGVt U2xlZXAgfCBOU0FjdGl2aXR5TGF0ZW5jeUNyaXRpY2FsKSAmIH4oTlNBY3Rpdml0eVN1ZGRlblRl cm1pbmF0aW9uRGlzYWJsZWQgfCBOU0FjdGl2aXR5QXV0b21hdGljVGVybWluYXRpb25EaXNhYmxl ZCk7CisgICAgc3RhdGljIGlkIGFzc2VydGlvbiA9IFtbW05TUHJvY2Vzc0luZm8gcHJvY2Vzc0lu Zm9dIGJlZ2luQWN0aXZpdHlXaXRoT3B0aW9uczpvcHRpb25zIHJlYXNvbjpAIkR1bXBSZW5kZXJU cmVlIHNob3VsZCBub3QgYmUgc3ViamVjdCB0byBwcm9jZXNzIHN1cHByZXNzaW9uIl0gcmV0YWlu XTsKKyAgICBBU1NFUlRfVU5VU0VEKGFzc2VydGlvbiwgYXNzZXJ0aW9uKTsKK30KKwogaW50IG1h aW4oaW50IGFyZ2MsIGNvbnN0IGNoYXIqIGFyZ3ZbXSkKIHsKICAgICBOU0F1dG9yZWxlYXNlUG9v bCAqcG9vbCA9IFtbTlNBdXRvcmVsZWFzZVBvb2wgYWxsb2NdIGluaXRdOwogICAgIFtOU0FwcGxp Y2F0aW9uIHNoYXJlZEFwcGxpY2F0aW9uXTsKICAgICBzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZh bHVlc0ZvclRlc3RpbmcoKTsKKyAgICBkaXNhYmxlQXBwTmFwSW5VSVByb2Nlc3MoKTsgLy8gRm9y IHNlY29uZGFyeSBwcm9jZXNzZXMsIGFwcCBuYXAgaXMgZGlzYWJsZWQgdXNpbmcgV0tQcmVmZXJl bmNlc1NldFBhZ2VWaXNpYmlsaXR5QmFzZWRQcm9jZXNzU3VwcHJlc3Npb25FbmFibGVkKCkuCiAK ICAgICB7CiAgICAgICAgIFdUUjo6VGVzdENvbnRyb2xsZXIgY29udHJvbGxlcihhcmdjLCBhcmd2 KTsK