144299 2015-04-27 17:52:58 -0700 PDF action menu fixes 2015-04-27 19:44:50 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 144307 1 bfulgham bfulgham bfulgham webkit-bug-importer oldest_to_newest 1089308 0 bfulgham 2015-04-27 17:52:58 -0700 After playing with the recent PDF updates, we noticed two problems: 1. The TextIdentifier (yellow highlights) shown when displaying a definition for a word were slightly offset. 2. Zooming out the PDF so that multiple pages were shown in the same WebView caused improper display of the dictionary overlay. 1089309 1 bfulgham 2015-04-27 17:53:38 -0700 <rdar://problem/20702215> 1089311 2 251799 bfulgham 2015-04-27 17:58:47 -0700 Created attachment 251799 Patch 1089330 3 251799 thorton 2015-04-27 18:26:57 -0700 Comment on attachment 251799 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251799&action=review > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:625 > + // Based on TextIndicator implementation: > + CGFloat verticalMargin = 2.5; > + CGFloat horizontalMargin = 0.5; We should (separately) figure out a way to make this not be copied into clients who aren't TextIndicator 1089345 4 bfulgham 2015-04-27 19:44:50 -0700 Committed r183447: <http://trac.webkit.org/changeset/183447> 251799 2015-04-27 17:58:47 -0700 2015-04-27 18:26:57 -0700 Patch bug-144299-20150427175739.patch text/plain 4820 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzQ0MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE1LTA0LTI3ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFBERiBhY3Rpb24gbWVudSBm aXhlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0 Mjk5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMDcwMjIxNT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHR3byBjb3JyZWN0aW9ucyB0byBo b3cgUERGcyBhcmUgaGFuZGxlZDoKKyAgICAgICAgMS4gV2hlbiBjYWxjdWxhdGluZyB0aGUgdmll dyByZWN0IGZvciB0aGUgdXNlcidzIHNlbGVjdGlvbiwgbWFrZSBzdXJlCisgICAgICAgIHRoYXQg d2UgZ2V0IGNvb3JkaW5hdGVzIGZvciB0aGUgY29ycmVjdCBQREYgcGFnZS4gVGhlIGV4aXN0aW5n IGNvZGUgYXNzdW1lZAorICAgICAgICB0aGF0IHRoZSBjdXJyZW50IFBERkxheWVyQ29udHJvbGVy J3MgY3VycmVudCBwYWdlIHdhcyBjb3JyZWN0LCBidXQgdGhpcyB3aWxsCisgICAgICAgIG5vdCBi ZSB0cnVlIGlmIHlvdSB6b29tIHRoZSBQREYgb3V0IHNvIHRoYXQgc2V2ZXJhbCBwYWdlcyBhcmUg ZGlzcGxheWVkIGF0CisgICAgICAgIG9uY2UuIEVhY2ggc2VsZWN0aW9uIGtlZXBzIHRyYWNrIG9m IHRoZSBwYWdlIGl0IGlzIHJlZmVyZW5jZWQgYWdhaW5zdC4KKyAgICAgICAgCisgICAgICAgIDIu IFJldmlzZSB0aGUgb2Zmc2V0cyBjYWxjdWxhdGVkIGZvciB0aGUgVGV4dEluZGljYXRvciB0byB0 YWtlIGludG8gYWNjb3VudAorICAgICAgICB0aGUgZm9udCBkZXNjZW5kZXIgKGFzIHdlbGwgYXMg dGhlIGFzY2VuZGVyKSwgYW5kIHRvIGFkanVzdCBieSB0aGUgc2NhbGVkCisgICAgICAgIGFtb3Vu dCBvZiBtYXJnaW4gYXJvdW5kIHRoZSBzZWxlY3RlZCB0ZXh0LgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW06CisgICAgICAgIChXZWJLaXQ6OlBERlBsdWdp bjo6dmlld1JlY3RGb3JTZWxlY3Rpb24pOiBVc2UgY29ycmVjdCBwYWdlIGZvciBjYWxjdWxhdGlu ZworICAgICAgICB0aGUgY29vcmRpbmF0ZXMuCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9XZWJQYWdlTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpkaWN0aW9uYXJ5 UG9wdXBJbmZvRm9yU2VsZWN0aW9uSW5QREZQbHVnaW4pOiBJbmNsdWRlIGZvbnQgJ2Rlc2NlbmRh bnQnCisgICAgICAgIGFuZCAoc2NhbGVkKSBtYXJnaW4gd2hlbiBhZGp1c3RpbmcgdGhlIGhpdCB0 YXJnZXQgZm9yIHRoZSBUZXh0SW5kaWNhdG9yIHRvIGRyYXcuCisKIDIwMTUtMDQtMjcgIE1pY2hh ZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlbmFtZSBX VEZfVVNFXzNEX0dSQVBISUNTIHRvIEVOQUJMRV9HUkFQSElDU19DT05URVhUXzNECkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5t bQkocmV2aXNpb24gMTgzNDAyKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L1BERi9QREZQbHVnaW4ubW0JKHdvcmtpbmcgY29weSkKQEAgLTE5NTcsNyArMTk1NywxMyBAQCBz dGF0aWMgTlNSZWN0IHJlY3RJblZpZXdTcGFjZUZvclJlY3RJbkxhCiAKIFdlYkNvcmU6OkZsb2F0 UmVjdCBQREZQbHVnaW46OnZpZXdSZWN0Rm9yU2VsZWN0aW9uKFBERlNlbGVjdGlvbiAqc2VsZWN0 aW9uKSBjb25zdAogewotICAgIFBERlBhZ2UgKmN1cnJlbnRQYWdlID0gW21fcGRmTGF5ZXJDb250 cm9sbGVyIGN1cnJlbnRQYWdlXTsKKyAgICBQREZQYWdlICpjdXJyZW50UGFnZSA9IG5pbDsKKyAg ICBOU0FycmF5KiBwYWdlcyA9IHNlbGVjdGlvbi5wYWdlczsKKyAgICBpZiAocGFnZXMuY291bnQp CisgICAgICAgIGN1cnJlbnRQYWdlID0gKFBERlBhZ2UgKilbcGFnZXMgb2JqZWN0QXRJbmRleDow XTsKKworICAgIGlmICghY3VycmVudFBhZ2UpCisgICAgICAgIGN1cnJlbnRQYWdlID0gW21fcGRm TGF5ZXJDb250cm9sbGVyIGN1cnJlbnRQYWdlXTsKICAgICAKICAgICBOU1JlY3QgcmVjdEluUGFn ZVNwYWNlID0gW3NlbGVjdGlvbiBib3VuZHNGb3JQYWdlOmN1cnJlbnRQYWdlXTsKICAgICBOU1Jl Y3QgcmVjdEluTGF5b3V0U3BhY2UgPSBbW21fcGRmTGF5ZXJDb250cm9sbGVyIGxheW91dF0gY29u dmVydFJlY3Q6cmVjdEluUGFnZVNwYWNlIGZyb21QYWdlOmN1cnJlbnRQYWdlIGZvclNjYWxlRmFj dG9yOjEuMF07CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dl YlBhZ2VNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9XZWJQYWdlTWFjLm1tCShyZXZpc2lvbiAxODM0MDIpCisrKyBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0JKHdvcmtpbmcgY29weSkKQEAg LTYwNSwxMiArNjA1LDE0IEBAIERpY3Rpb25hcnlQb3B1cEluZm8gV2ViUGFnZTo6ZGljdGlvbmFy eVAKICAgICBDR0Zsb2F0IHNjYWxlRmFjdG9yID0gcGRmUGx1Z2luLnNjYWxlRmFjdG9yKCk7CiAK ICAgICBfX2Jsb2NrIENHRmxvYXQgbWF4QXNjZW5kZXIgPSAwOworICAgIF9fYmxvY2sgQ0dGbG9h dCBtYXhEZXNjZW5kZXIgPSAwOwogICAgIFtuc0F0dHJpYnV0ZWRTdHJpbmcgZW51bWVyYXRlQXR0 cmlidXRlc0luUmFuZ2U6TlNNYWtlUmFuZ2UoMCwgW25zQXR0cmlidXRlZFN0cmluZyBsZW5ndGhd KSBvcHRpb25zOjAgdXNpbmdCbG9jazpeKE5TRGljdGlvbmFyeSAqYXR0cmlidXRlcywgTlNSYW5n ZSByYW5nZSwgQk9PTCAqc3RvcCkgewogICAgICAgICBSZXRhaW5QdHI8TlNNdXRhYmxlRGljdGlv bmFyeT4gc2NhbGVkQXR0cmlidXRlcyA9IGFkb3B0TlMoW2F0dHJpYnV0ZXMgbXV0YWJsZUNvcHld KTsKICAgICAgICAgCiAgICAgICAgIE5TRm9udCAqZm9udCA9IFtzY2FsZWRBdHRyaWJ1dGVzIG9i amVjdEZvcktleTpOU0ZvbnRBdHRyaWJ1dGVOYW1lXTsKICAgICAgICAgaWYgKGZvbnQpIHsKICAg ICAgICAgICAgIG1heEFzY2VuZGVyID0gc3RkOjptYXgobWF4QXNjZW5kZXIsIGZvbnQuYXNjZW5k ZXIgKiBzY2FsZUZhY3Rvcik7CisgICAgICAgICAgICBtYXhEZXNjZW5kZXIgPSBzdGQ6Om1pbiht YXhEZXNjZW5kZXIsIGZvbnQuZGVzY2VuZGVyICogc2NhbGVGYWN0b3IpOwogICAgICAgICAgICAg Zm9udCA9IFtmb250TWFuYWdlciBjb252ZXJ0Rm9udDpmb250IHRvU2l6ZTpbZm9udCBwb2ludFNp emVdICogc2NhbGVGYWN0b3JdOwogICAgICAgICAgICAgW3NjYWxlZEF0dHJpYnV0ZXMgc2V0T2Jq ZWN0OmZvbnQgZm9yS2V5Ok5TRm9udEF0dHJpYnV0ZU5hbWVdOwogICAgICAgICB9CkBAIC02MTgs MTQgKzYyMCwxNiBAQCBEaWN0aW9uYXJ5UG9wdXBJbmZvIFdlYlBhZ2U6OmRpY3Rpb25hcnlQCiAg ICAgICAgIFtzY2FsZWROU0F0dHJpYnV0ZWRTdHJpbmcgYWRkQXR0cmlidXRlczpzY2FsZWRBdHRy aWJ1dGVzLmdldCgpIHJhbmdlOnJhbmdlXTsKICAgICB9XTsKIAotICAgIENHRmxvYXQgdGV4dElu c2V0ID0gcmFuZ2VSZWN0LnNpemUuaGVpZ2h0IC0gbWF4QXNjZW5kZXI7Ci0gICAgcmFuZ2VSZWN0 Lm9yaWdpbi55IC09IHRleHRJbnNldDsKKyAgICAvLyBCYXNlZCBvbiBUZXh0SW5kaWNhdG9yIGlt cGxlbWVudGF0aW9uOgorICAgIENHRmxvYXQgdmVydGljYWxNYXJnaW4gPSAyLjU7CisgICAgQ0dG bG9hdCBob3Jpem9udGFsTWFyZ2luID0gMC41OworCisgICAgcmFuZ2VSZWN0Lm9yaWdpbi55IC09 IENHQ2VpbGluZyhyYW5nZVJlY3Quc2l6ZS5oZWlnaHQgLSBtYXhBc2NlbmRlciAtIHN0ZDo6YWJz KG1heERlc2NlbmRlcikgKyB2ZXJ0aWNhbE1hcmdpbiAqIHNjYWxlRmFjdG9yKTsKKyAgICByYW5n ZVJlY3Qub3JpZ2luLnggKz0gQ0dGbG9vcihob3Jpem9udGFsTWFyZ2luICogc2NhbGVGYWN0b3Ip OwogICAgIAogICAgIFRleHRJbmRpY2F0b3JEYXRhIGRhdGFGb3JTZWxlY3Rpb247CiAgICAgZGF0 YUZvclNlbGVjdGlvbi5zZWxlY3Rpb25SZWN0SW5Sb290Vmlld0Nvb3JkaW5hdGVzID0gcmFuZ2VS ZWN0OwotCi0gICAgQ0dGbG9hdCBpbnNldEFtb3VudCA9IDAuNSAqIHRleHRJbnNldDsKLSAgICBk YXRhRm9yU2VsZWN0aW9uLnRleHRCb3VuZGluZ1JlY3RJblJvb3RWaWV3Q29vcmRpbmF0ZXMgPSBO U0luc2V0UmVjdChyYW5nZVJlY3QsIGluc2V0QW1vdW50LCBpbnNldEFtb3VudCk7CisgICAgZGF0 YUZvclNlbGVjdGlvbi50ZXh0Qm91bmRpbmdSZWN0SW5Sb290Vmlld0Nvb3JkaW5hdGVzID0gcmFu Z2VSZWN0OwogICAgIGRhdGFGb3JTZWxlY3Rpb24uY29udGVudEltYWdlU2NhbGVGYWN0b3IgPSBz Y2FsZUZhY3RvcjsKICAgICBkYXRhRm9yU2VsZWN0aW9uLnByZXNlbnRhdGlvblRyYW5zaXRpb24g PSBwcmVzZW50YXRpb25UcmFuc2l0aW9uOwogICAgIAo=