144284 2015-04-27 15:38:29 -0700 Extending undefined in class syntax should throw a TypeError 2015-05-04 12:24:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140491 1 arv rniwa barraclough benjamin darin fpizlo ggaren oldest_to_newest 1089234 0 arv 2015-04-27 15:38:29 -0700 http://trac.webkit.org/browser/trunk/LayoutTests/js/script-tests/class-syntax-extends.js#L73 shouldThrow('new (class extends undefined { constructor () { this } })', '"ReferenceError: Cannot access uninitialized variable."'); the `extends undefined` should throw a TypeError. 1091294 1 252294 rniwa 2015-05-03 17:04:49 -0700 Created attachment 252294 Fixes the bug 1091474 2 rniwa 2015-05-04 12:24:15 -0700 Thanks for the reviews, Darin! 1091477 3 252294 rniwa 2015-05-04 12:24:40 -0700 Comment on attachment 252294 Fixes the bug Clearing flags on attachment: 252294 Committed r183759: <http://trac.webkit.org/changeset/183759> 1091479 4 rniwa 2015-05-04 12:24:46 -0700 All reviewed patches have been landed. Closing bug. 252294 2015-05-03 17:04:49 -0700 2015-05-04 12:24:40 -0700 Fixes the bug bug-144284-20150503170336.patch text/plain 7348 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy MzI2N2QwNGQ5N2EyNGY3ZWVhNGJmOThlYjIyODI3ZDlkZGRlMTNhLi42ZmUzZGI2ZDM5MmMyN2U3 OGI1MTkyNjlhYzBiZDEyMDY3NThmY2ZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNS0wNS0wMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAorICAgICAgICBFeHRlbmRpbmcgdW5kZWZpbmVkIGluIGNsYXNzIHN5bnRheCBzaG91bGQgdGhy b3cgYSBUeXBlRXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDI4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBidWcgd2FzIGNhdXNlZCBieSBvcF9lcV9udWxsIGV2YWx1YXRpbmcgdG8gdHJ1 ZSB3aGVuIGNvbXBhcmVkIHRvIHVuZGVmaW5lZC4KKyAgICAgICAgRXhwbGljaXRseSBjaGVjayBv cF9lcV91bmRlZmluZWQgZmlyc3QgdG8gZGV0ZWN0IHRoZSBjYXNlIHdoZXJlIHdlJ3JlIGV4dGVu ZGluZyB1bmRlZmluZWQuCisKKyAgICAgICAgV2UgYWxzbyBoYWQgYm9ndXMgdGVzdCBjYXNlcyBj aGVja2VkIGluIGNsYXNzLXN5bnRheC1leHRlbmRzLmh0bWwuIFRoaXMgcGF0Y2ggYWxzbyBmaXhl cyB0aGVtLgorCisgICAgICAgICogYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAg ICAgIChKU0M6OkNsYXNzRXhwck5vZGU6OmVtaXRCeXRlY29kZSk6CisKKzIwMTUtMDUtMDMgIFJ5 b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKICAgICAgICAgRVM2IGNsYXNzZTogbmV3 IHN1cGVyIGlzIG5vdCBhbGxvd2VkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDQyODIKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCmluZGV4IDBmMGI3OGYwZTU5MWQ5YmIxNmI5NTgx ZDVkNTYwNGQ0OGU1Yjc3NmYuLjAyOTBjODFhYjA5NzNjZWQwNmQ1YTZkZmU3OGMyMjUxOTZiMjJi MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXND b2RlZ2VuLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVz Q29kZWdlbi5jcHAKQEAgLTI5MzcsMTIgKzI5MzcsMTcgQEAgUmVnaXN0ZXJJRCogQ2xhc3NFeHBy Tm9kZTo6ZW1pdEJ5dGVjb2RlKEJ5dGVjb2RlR2VuZXJhdG9yJiBnZW5lcmF0b3IsIFJlZ2lzdGVy SUQKICAgICAgICAgZ2VuZXJhdG9yLmVtaXRMb2FkKHByb3RvUGFyZW50LmdldCgpLCBqc051bGwo KSk7CiAKICAgICAgICAgUmVmUHRyPFJlZ2lzdGVySUQ+IHRlbXBSZWdpc3RlciA9IGdlbmVyYXRv ci5uZXdUZW1wb3JhcnkoKTsKKworICAgICAgICAvLyBGSVhNRTogVGhyb3cgVHlwZUVycm9yIGlm IGl0J3MgYSBnZW5lcmF0b3IgZnVuY3Rpb24uCisgICAgICAgIFJlZlB0cjxMYWJlbD4gc3VwZXJj bGFzc0lzVW5kZWZpbmVkTGFiZWwgPSBnZW5lcmF0b3IubmV3TGFiZWwoKTsKKyAgICAgICAgZ2Vu ZXJhdG9yLmVtaXRKdW1wSWZUcnVlKGdlbmVyYXRvci5lbWl0SXNVbmRlZmluZWQodGVtcFJlZ2lz dGVyLmdldCgpLCBzdXBlcmNsYXNzLmdldCgpKSwgc3VwZXJjbGFzc0lzVW5kZWZpbmVkTGFiZWwu Z2V0KCkpOworCiAgICAgICAgIFJlZlB0cjxMYWJlbD4gc3VwZXJjbGFzc0lzTnVsbExhYmVsID0g Z2VuZXJhdG9yLm5ld0xhYmVsKCk7CiAgICAgICAgIGdlbmVyYXRvci5lbWl0SnVtcElmVHJ1ZShn ZW5lcmF0b3IuZW1pdFVuYXJ5T3Aob3BfZXFfbnVsbCwgdGVtcFJlZ2lzdGVyLmdldCgpLCBzdXBl cmNsYXNzLmdldCgpKSwgc3VwZXJjbGFzc0lzTnVsbExhYmVsLmdldCgpKTsKIAotICAgICAgICAv LyBGSVhNRTogVGhyb3cgVHlwZUVycm9yIGlmIGl0J3MgYSBnZW5lcmF0b3IgZnVuY3Rpb24uCiAg ICAgICAgIFJlZlB0cjxMYWJlbD4gc3VwZXJjbGFzc0lzT2JqZWN0TGFiZWwgPSBnZW5lcmF0b3Iu bmV3TGFiZWwoKTsKICAgICAgICAgZ2VuZXJhdG9yLmVtaXRKdW1wSWZUcnVlKGdlbmVyYXRvci5l bWl0SXNPYmplY3QodGVtcFJlZ2lzdGVyLmdldCgpLCBzdXBlcmNsYXNzLmdldCgpKSwgc3VwZXJj bGFzc0lzT2JqZWN0TGFiZWwuZ2V0KCkpOworICAgICAgICBnZW5lcmF0b3IuZW1pdExhYmVsKHN1 cGVyY2xhc3NJc1VuZGVmaW5lZExhYmVsLmdldCgpKTsKICAgICAgICAgZ2VuZXJhdG9yLmVtaXRU aHJvd1R5cGVFcnJvcihBU0NJSUxpdGVyYWwoIlRoZSBzdXBlcmNsYXNzIGlzIG5vdCBhbiBvYmpl Y3QuIikpOwogICAgICAgICBnZW5lcmF0b3IuZW1pdExhYmVsKHN1cGVyY2xhc3NJc09iamVjdExh YmVsLmdldCgpKTsKICAgICAgICAgZ2VuZXJhdG9yLmVtaXRHZXRCeUlkKHByb3RvUGFyZW50Lmdl dCgpLCBzdXBlcmNsYXNzLmdldCgpLCBnZW5lcmF0b3IucHJvcGVydHlOYW1lcygpLnByb3RvdHlw ZSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggYmRjYzZkMjk0ZGY3M2EzYWVjYzQzNTRiMWE5ZjZiMmZhOTE2OGYxMC4uMjJh MzRhZDRhOTBkZmI2MWUyYTZjOTY1NzBiNWE3YTRiZGIzYWVjYSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDE1LTA1LTAzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCisgICAg ICAgIEV4dGVuZGluZyB1bmRlZmluZWQgaW4gY2xhc3Mgc3ludGF4IHNob3VsZCB0aHJvdyBhIFR5 cGVFcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ0Mjg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4ZWQgdGhlIGV4cGVjdGF0aW9uIGZvciBleHRlbmRpbmcgdW5kZWZpbmVkIGFuZCByZW1vdmVk IGlycmVsZXZhbnQgdGVzdCBjYXNlcyBmb3IgZXh0ZW5kaW5nIHVuZGVmaW5lZAorICAgICAgICBz aW5jZSB3ZSdsbCBuZXZlciBnZXQgdG8gaW5zdGFudGlhdGUgdGhlc2UgY2xhc3NlcyBub3cuCisK KyAgICAgICAgKiBqcy9jbGFzcy1zeW50YXgtZXh0ZW5kcy1leHBlY3RlZC50eHQ6CisgICAgICAg ICoganMvc2NyaXB0LXRlc3RzL2NsYXNzLXN5bnRheC1leHRlbmRzLmpzOgorCisyMDE1LTA1LTAz ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCiAgICAgICAgIEVTNiBjbGFzc2Vz OiBJbnZhbGlkIHRlc3QgZm9yIGNvbnN0cnVjdG9yIHByb3BlcnR5CiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQyNzgKIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvanMvY2xhc3Mtc3ludGF4LWV4dGVuZHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvanMvY2xhc3Mtc3ludGF4LWV4dGVuZHMtZXhwZWN0ZWQudHh0CmluZGV4IDkyNjUxZTE2Yzcy ODI4ODRlYzA4NjBiNjg2NWU5YjgyYWU1MWVlYTMuLmNlMTgyOGNlZTlhMWJiYTUxZWRjYmZiOTc5 N2Y5ODQ5NmRkOTVhZTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL2NsYXNzLXN5bnRheC1l eHRlbmRzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9qcy9jbGFzcy1zeW50YXgtZXh0 ZW5kcy1leHBlY3RlZC50eHQKQEAgLTU0LDEwICs1NCw4IEBAIFBBU1MgeCA9IDE7IG5hbWVzcGFj ZSA9IHt9OyBuYW1lc3BhY2UuQSA9IGNsYXNzIHsgY29uc3RydWN0b3IoKSB7IH0gfTsgdHJ5IHsg bmFtCiBQQVNTIHggPSAxOyBuYW1lc3BhY2UgPSB7fTsgbmFtZXNwYWNlLkEgPSBjbGFzcyB7IGNv bnN0cnVjdG9yKCkgeyB9IH07IHRyeSB7IG5hbWVzcGFjZS5CID0gY2xhc3MgZXh0ZW5kcyAobmFt ZXNwYWNlLkEsIHgrKykgeyBjb25zdHJ1Y3RvcigpIHsgfSB9IH0gY2F0Y2ggKGUpIHsgfSB4IGlz IDIKIFBBU1MgT2JqZWN0LmdldFByb3RvdHlwZU9mKChjbGFzcyB7IGNvbnN0cnVjdG9yICgpIHsg fSB9KS5wcm90b3R5cGUpIGlzIE9iamVjdC5wcm90b3R5cGUKIFBBU1MgT2JqZWN0LmdldFByb3Rv dHlwZU9mKChjbGFzcyBleHRlbmRzIG51bGwgeyBjb25zdHJ1Y3RvciAoKSB7IHN1cGVyKCk7IH0g fSkucHJvdG90eXBlKSBpcyBudWxsCi1QQVNTIG5ldyAoY2xhc3MgZXh0ZW5kcyB1bmRlZmluZWQg eyBjb25zdHJ1Y3RvciAoKSB7IHRoaXMgfSB9KSB0aHJldyBleGNlcHRpb24gUmVmZXJlbmNlRXJy b3I6IENhbm5vdCBhY2Nlc3MgdW5pbml0aWFsaXplZCB2YXJpYWJsZS4uCi1QQVNTIG5ldyAoY2xh c3MgZXh0ZW5kcyB1bmRlZmluZWQgeyBjb25zdHJ1Y3RvciAoKSB7IHN1cGVyKCk7IH0gfSkgdGhy ZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogdW5kZWZpbmVkIGlzIG5vdCBhbiBvYmplY3QgKGV2YWx1 YXRpbmcgJ3N1cGVyKCknKS4KLVBBU1MgeCA9IHt9OyBuZXcgKGNsYXNzIGV4dGVuZHMgdW5kZWZp bmVkIHsgY29uc3RydWN0b3IgKCkgeyByZXR1cm4geDsgfSB9KSBpcyB4Ci1QQVNTIHkgPSAxMjsg bmV3IChjbGFzcyBleHRlbmRzIHVuZGVmaW5lZCB7IGNvbnN0cnVjdG9yICgpIHsgcmV0dXJuIHk7 IH0gfSkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogQ2Fubm90IHJldHVybiBhIG5vbi1vYmpl Y3QgdHlwZSBpbiB0aGUgY29uc3RydWN0b3Igb2YgYSBkZXJpdmVkIGNsYXNzLi4KK1BBU1MgbmV3 IChjbGFzcyBleHRlbmRzIHVuZGVmaW5lZCB7IGNvbnN0cnVjdG9yICgpIHsgdGhpcyB9IH0pIHRo cmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IFRoZSBzdXBlcmNsYXNzIGlzIG5vdCBhbiBvYmplY3Qu LgorUEFTUyB4ID0gdW5kZWZpbmVkOyBuZXcgKGNsYXNzIGV4dGVuZHMgeCB7IGNvbnN0cnVjdG9y ICgpIHsgc3VwZXIoKTsgfSB9KSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBUaGUgc3VwZXJj bGFzcyBpcyBub3QgYW4gb2JqZWN0Li4KIFBBU1MgY2xhc3MgeCB7fTsgbmV3IChjbGFzcyBleHRl bmRzIG51bGwgeyBjb25zdHJ1Y3RvciAoKSB7IHJldHVybiBuZXcgeDsgfSB9KSBpbnN0YW5jZW9m IHggaXMgdHJ1ZQogUEFTUyBuZXcgKGNsYXNzIGV4dGVuZHMgbnVsbCB7IGNvbnN0cnVjdG9yICgp IHsgdGhpczsgfSB9KSB0aHJldyBleGNlcHRpb24gUmVmZXJlbmNlRXJyb3I6IENhbm5vdCBhY2Nl c3MgdW5pbml0aWFsaXplZCB2YXJpYWJsZS4uCiBQQVNTIG5ldyAoY2xhc3MgZXh0ZW5kcyBudWxs IHsgY29uc3RydWN0b3IgKCkgeyBzdXBlcigpOyB9IH0pIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJy b3I6IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdzdXBlcigpJykuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvY2xhc3Mtc3ludGF4LWV4dGVu ZHMuanMgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvY2xhc3Mtc3ludGF4LWV4dGVuZHMu anMKaW5kZXggZWNjMTE3N2ZlZDQwMWU3MzlmMGM1M2JmYTM1NWQ5NWVmZDQ0ZWUyZi4uNmZmMGMz ZDZmZjM2NDY5ZTYzMmI3YzExMjBlNTA2MjFhZjUyOTg3MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvanMvc2NyaXB0LXRlc3RzL2NsYXNzLXN5bnRheC1leHRlbmRzLmpzCisrKyBiL0xheW91dFRl c3RzL2pzL3NjcmlwdC10ZXN0cy9jbGFzcy1zeW50YXgtZXh0ZW5kcy5qcwpAQCAtNzAsMTAgKzcw LDggQEAgc2hvdWxkQmUoJ3ggPSAxOyBuYW1lc3BhY2UgPSB7fTsgbmFtZXNwYWNlLkEgPSBjbGFz cyB7IGNvbnN0cnVjdG9yKCkgeyB9IH07IHRyeQogCiBzaG91bGRCZSgnT2JqZWN0LmdldFByb3Rv dHlwZU9mKChjbGFzcyB7IGNvbnN0cnVjdG9yICgpIHsgfSB9KS5wcm90b3R5cGUpJywgJ09iamVj dC5wcm90b3R5cGUnKTsKIHNob3VsZEJlKCdPYmplY3QuZ2V0UHJvdG90eXBlT2YoKGNsYXNzIGV4 dGVuZHMgbnVsbCB7IGNvbnN0cnVjdG9yICgpIHsgc3VwZXIoKTsgfSB9KS5wcm90b3R5cGUpJywg J251bGwnKTsKLXNob3VsZFRocm93KCduZXcgKGNsYXNzIGV4dGVuZHMgdW5kZWZpbmVkIHsgY29u c3RydWN0b3IgKCkgeyB0aGlzIH0gfSknLCAnIlJlZmVyZW5jZUVycm9yOiBDYW5ub3QgYWNjZXNz IHVuaW5pdGlhbGl6ZWQgdmFyaWFibGUuIicpOwotc2hvdWxkVGhyb3coJ25ldyAoY2xhc3MgZXh0 ZW5kcyB1bmRlZmluZWQgeyBjb25zdHJ1Y3RvciAoKSB7IHN1cGVyKCk7IH0gfSknLCAnIlR5cGVF cnJvcjogdW5kZWZpbmVkIGlzIG5vdCBhbiBvYmplY3QgKGV2YWx1YXRpbmcgXCdzdXBlcigpXCcp IicpOwotc2hvdWxkQmUoJ3ggPSB7fTsgbmV3IChjbGFzcyBleHRlbmRzIHVuZGVmaW5lZCB7IGNv bnN0cnVjdG9yICgpIHsgcmV0dXJuIHg7IH0gfSknLCAneCcpOwotc2hvdWxkVGhyb3coJ3kgPSAx MjsgbmV3IChjbGFzcyBleHRlbmRzIHVuZGVmaW5lZCB7IGNvbnN0cnVjdG9yICgpIHsgcmV0dXJu IHk7IH0gfSknLCAnIlR5cGVFcnJvcjogQ2Fubm90IHJldHVybiBhIG5vbi1vYmplY3QgdHlwZSBp biB0aGUgY29uc3RydWN0b3Igb2YgYSBkZXJpdmVkIGNsYXNzLiInKTsKK3Nob3VsZFRocm93KCdu ZXcgKGNsYXNzIGV4dGVuZHMgdW5kZWZpbmVkIHsgY29uc3RydWN0b3IgKCkgeyB0aGlzIH0gfSkn LCAnIlR5cGVFcnJvcjogVGhlIHN1cGVyY2xhc3MgaXMgbm90IGFuIG9iamVjdC4iJyk7CitzaG91 bGRUaHJvdygneCA9IHVuZGVmaW5lZDsgbmV3IChjbGFzcyBleHRlbmRzIHggeyBjb25zdHJ1Y3Rv ciAoKSB7IHN1cGVyKCk7IH0gfSknLCAnIlR5cGVFcnJvcjogVGhlIHN1cGVyY2xhc3MgaXMgbm90 IGFuIG9iamVjdC4iJyk7CiBzaG91bGRCZVRydWUgKCdjbGFzcyB4IHt9OyBuZXcgKGNsYXNzIGV4 dGVuZHMgbnVsbCB7IGNvbnN0cnVjdG9yICgpIHsgcmV0dXJuIG5ldyB4OyB9IH0pIGluc3RhbmNl b2YgeCcpOwogc2hvdWxkVGhyb3coJ25ldyAoY2xhc3MgZXh0ZW5kcyBudWxsIHsgY29uc3RydWN0 b3IgKCkgeyB0aGlzOyB9IH0pJywgJyJSZWZlcmVuY2VFcnJvcjogQ2Fubm90IGFjY2VzcyB1bmlu aXRpYWxpemVkIHZhcmlhYmxlLiInKTsKIHNob3VsZFRocm93KCduZXcgKGNsYXNzIGV4dGVuZHMg bnVsbCB7IGNvbnN0cnVjdG9yICgpIHsgc3VwZXIoKTsgfSB9KScsICciVHlwZUVycm9yOiB1bmRl ZmluZWQgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyBcJ3N1cGVyKClcJykiJyk7Cg==