144282 2015-04-27 15:17:49 -0700 new super should be a syntax error 2015-05-04 12:24:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140491 1 arv rniwa barraclough benjamin eric.carlson fpizlo ggaren joepeck kling oldest_to_newest 1089225 0 arv 2015-04-27 15:17:49 -0700 http://trac.webkit.org/browser/trunk/LayoutTests/js/script-tests/class-syntax-super.js#L44 shouldNotThrow('x = class extends Base { constructor() { super(); } method() { return new super } }'); This is invalid. `new super` is not allowed. 1089230 1 rniwa 2015-04-27 15:28:50 -0700 *** Bug 144281 has been marked as a duplicate of this bug. *** 1091284 2 252291 rniwa 2015-05-03 16:26:39 -0700 Created attachment 252291 Fixes the bug 1091463 3 252291 joepeck 2015-05-04 12:08:11 -0700 Comment on attachment 252291 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=252291&action=review r=me > Source/JavaScriptCore/ChangeLog:3 > + ES6 classe: new super is not allowed Typo: "classe" => "classes" > Source/JavaScriptCore/parser/Parser.cpp:2527 > + semanticFailIfTrue(baseIsSuper && newCount, "Cannot new super"); I think there is room for improvement with this error message. The statement "Cannot new super" feels incomplete. Maybe "Cannot use new with super"? "Cannot call super as a constructor"? 1091470 4 252291 rniwa 2015-05-04 12:21:33 -0700 Comment on attachment 252291 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=252291&action=review >> Source/JavaScriptCore/parser/Parser.cpp:2527 >> + semanticFailIfTrue(baseIsSuper && newCount, "Cannot new super"); > > I think there is room for improvement with this error message. The statement "Cannot new super" feels incomplete. Maybe "Cannot use new with super"? "Cannot call super as a constructor"? Let's go with "Cannot use new with super". 1091471 5 rniwa 2015-05-04 12:22:44 -0700 Committed r183757: <http://trac.webkit.org/changeset/183757> 1091475 6 rniwa 2015-05-04 12:24:30 -0700 Thanks for the review, Joe! 252291 2015-05-03 16:26:39 -0700 2015-05-04 12:08:11 -0700 Fixes the bug bug-144282-20150503162525.patch text/plain 5348 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MjM3MmFiYmNkODA1MWM3ZjZlNzI0NGY5NGQzMmEwMTE5ZjMyZGIyLi4yMzI2N2QwNGQ5N2EyNGY3 ZWVhNGJmOThlYjIyODI3ZDlkZGRlMTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNS0wNS0wMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K KworICAgICAgICBFUzYgY2xhc3NlOiBuZXcgc3VwZXIgaXMgbm90IGFsbG93ZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDI4MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FsbG93ICJuZXcgc3Vw ZXIiIGFzIEVTNiBzcGVjIGRvZXNuJ3QgYWxsb3cgdGhpcy4KKworICAgICAgICAqIHBhcnNlci9Q YXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VNZW1iZXJF eHByZXNzaW9uKToKKwogMjAxNS0wNS0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBDbGFzcyBzeW50YXggc2hvdWxkIGFsbG93IHN0cmluZyBhbmQgbnVtZXJp YyBpZGVudGlmaWVycyBmb3IgbWV0aG9kIG5hbWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2Vy L1BhcnNlci5jcHAKaW5kZXggZWNhZWFkOWJhZjdiMDkzNDJkMDcxNGM0MmFlMGQ4MzFmNjQwNjZh OS4uNDAxYjZlZWRjODc3N2EzNjcwOWY1OTMwNzI4Y2M3ZjAwMGMyZjgzOSAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcApAQCAtMjUyNCw2ICsyNTI0LDcgQEAgdGVtcGxh dGUgPGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVlRXhwcmVzc2lvbiBQYXJzZXI8TGV4ZXJUeXBlPjo6 cGFyc2VNZW1iZXJFeHByZXMKIAogI2lmIEVOQUJMRShFUzZfQ0xBU1NfU1lOVEFYKQogICAgIGJv b2wgYmFzZUlzU3VwZXIgPSBtYXRjaChTVVBFUik7CisgICAgc2VtYW50aWNGYWlsSWZUcnVlKGJh c2VJc1N1cGVyICYmIG5ld0NvdW50LCAiQ2Fubm90IG5ldyBzdXBlciIpOwogI2Vsc2UKICAgICBi b29sIGJhc2VJc1N1cGVyID0gZmFsc2U7CiAjZW5kaWYKQEAgLTI1ODcsNyArMjU4OCw3IEBAIHRl bXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZUV4cHJlc3Npb24gUGFyc2VyPExleGVyVHlw ZT46OnBhcnNlTWVtYmVyRXhwcmVzCiAgICAgICAgIGJhc2VJc1N1cGVyID0gZmFsc2U7CiAgICAg fQogZW5kTWVtYmVyRXhwcmVzc2lvbjoKLSAgICBzZW1hbnRpY0ZhaWxJZlRydWUoYmFzZUlzU3Vw ZXIgJiYgIW5ld0NvdW50LCAiQ2Fubm90IHJlZmVyZW5jZSBzdXBlciIpOworICAgIHNlbWFudGlj RmFpbElmVHJ1ZShiYXNlSXNTdXBlciwgIkNhbm5vdCByZWZlcmVuY2Ugc3VwZXIiKTsKICAgICB3 aGlsZSAobmV3Q291bnQtLSkKICAgICAgICAgYmFzZSA9IGNvbnRleHQuY3JlYXRlTmV3RXhwcihs b2NhdGlvbiwgYmFzZSwgZXhwcmVzc2lvblN0YXJ0LCBsYXN0VG9rZW5FbmRQb3NpdGlvbigpKTsK ICAgICByZXR1cm4gYmFzZTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwODgxMjE3OTJhMzhmYjY2ODRiMzgxOWVmN2QxM2Y0 NWQyYmIxN2JmLi4xZTE5MWEyODllZjJlY2QyNjgxNDg0YTlhNmRkMmQ0M2JmZTFkODc1IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDUtMDMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtp dC5vcmc+CisKKyAgICAgICAgRVM2IGNsYXNzZTogbmV3IHN1cGVyIGlzIG5vdCBhbGxvd2VkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQyODIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWJhc2VsaW5l ZCB0aGUgdGVzdC4KKworICAgICAgICAqIGpzL2NsYXNzLXN5bnRheC1zdXBlci1leHBlY3RlZC50 eHQ6CisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL2NsYXNzLXN5bnRheC1zdXBlci5qczoKKwog MjAxNS0wNS0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBD bGFzcyBzeW50YXggc2hvdWxkIGFsbG93IHN0cmluZyBhbmQgbnVtZXJpYyBpZGVudGlmaWVycyBm b3IgbWV0aG9kIG5hbWVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qcy9jbGFzcy1zeW50YXgt c3VwZXItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvanMvY2xhc3Mtc3ludGF4LXN1cGVyLWV4 cGVjdGVkLnR4dAppbmRleCAzOTdlNmQxMjNmMTlmNDMxMWNhNjE5YWZkYmZhZjNhMmIxZTg1Y2Nj Li41ZjlmN2FlYzg1YmQwZTFjMTM4MDU5YjA3ZjMzZTc2MWI5MmY0MWFlIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9qcy9jbGFzcy1zeW50YXgtc3VwZXItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2pzL2NsYXNzLXN5bnRheC1zdXBlci1leHBlY3RlZC50eHQKQEAgLTE2LDkgKzE2LDcg QEAgUEFTUyAobmV3IFNlY29uZERlcml2ZWQpLmNoYWluTWV0aG9kKCkgaXMgWyJiYXNlIiwgImRl cml2ZWQiLCAic2Vjb25kRGVyaXZlZCJdCiBQQVNTIHggPSBjbGFzcyBleHRlbmRzIEJhc2UgeyBj b25zdHJ1Y3RvcigpIHsgc3VwZXIoKTsgfSBzdXBlcigpIHt9IH0gdGhyZXcgZXhjZXB0aW9uIFN5 bnRheEVycm9yOiBVbmV4cGVjdGVkIGtleXdvcmQgJ3N1cGVyJy4KIFBBU1MgeCA9IGNsYXNzIGV4 dGVuZHMgQmFzZSB7IGNvbnN0cnVjdG9yKCkgeyBzdXBlcigpOyB9IG1ldGhvZCgpIHsgc3VwZXIo KSB9IH0gdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBDYW5ub3QgY2FsbCBzdXBlcigpIG91 dHNpZGUgb2YgYSBjbGFzcyBjb25zdHJ1Y3Rvci4uCiBQQVNTIHggPSBjbGFzcyBleHRlbmRzIEJh c2UgeyBjb25zdHJ1Y3RvcigpIHsgc3VwZXIoKTsgfSBtZXRob2QoKSB7IHN1cGVyIH0gfSB0aHJl dyBleGNlcHRpb24gU3ludGF4RXJyb3I6IENhbm5vdCByZWZlcmVuY2Ugc3VwZXIuLgotUEFTUyB4 ID0gY2xhc3MgZXh0ZW5kcyBCYXNlIHsgY29uc3RydWN0b3IoKSB7IHN1cGVyKCk7IH0gbWV0aG9k KCkgeyByZXR1cm4gbmV3IHN1cGVyIH0gfSBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KLVBBU1Mg KG5ldyB4KS5tZXRob2QoKSBpbnN0YW5jZW9mIEJhc2UgaXMgdHJ1ZQotUEFTUyAobmV3IHgpLm1l dGhvZCgpIGluc3RhbmNlb2YgeCBpcyBmYWxzZQorUEFTUyB4ID0gY2xhc3MgZXh0ZW5kcyBCYXNl IHsgY29uc3RydWN0b3IoKSB7IHN1cGVyKCk7IH0gbWV0aG9kKCkgeyByZXR1cm4gbmV3IHN1cGVy IH0gfSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IENhbm5vdCBuZXcgc3VwZXIuLgogUEFT UyB4ID0gY2xhc3MgZXh0ZW5kcyBCYXNlIHsgY29uc3RydWN0b3IoKSB7IHN1cGVyKCk7IH0gbWV0 aG9kMSgpIHsgZGVsZXRlIChzdXBlci5mb28pIH0gbWV0aG9kMigpIHsgZGVsZXRlIHN1cGVyWyJm b28iXSB9IH0gZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCiBQQVNTIChuZXcgeCkubWV0aG9kMSgp IHRocmV3IGV4Y2VwdGlvbiBSZWZlcmVuY2VFcnJvcjogQ2Fubm90IGRlbGV0ZSBhIHN1cGVyIHBy b3BlcnR5LgogUEFTUyAobmV3IHgpLm1ldGhvZDIoKSB0aHJldyBleGNlcHRpb24gUmVmZXJlbmNl RXJyb3I6IENhbm5vdCBkZWxldGUgYSBzdXBlciBwcm9wZXJ0eS4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9jbGFzcy1zeW50YXgtc3VwZXIuanMgYi9MYXlvdXRUZXN0 cy9qcy9zY3JpcHQtdGVzdHMvY2xhc3Mtc3ludGF4LXN1cGVyLmpzCmluZGV4IGEzMTg1YWIxZGM1 MjQ0YWU4ZjgwMGU1OGIyYzljZjBlZGNjM2EyMTQuLjk1ZDMyM2M4NTE2MzVmNGY5ODYyMzlhN2Yx OTk5MGQ5MzBkYzY0YWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9j bGFzcy1zeW50YXgtc3VwZXIuanMKKysrIGIvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2Ns YXNzLXN5bnRheC1zdXBlci5qcwpAQCAtNDEsOSArNDEsNyBAQCBzaG91bGRUaHJvdygneCA9IGNs YXNzIGV4dGVuZHMgQmFzZSB7IGNvbnN0cnVjdG9yKCkgeyBzdXBlcigpOyB9IHN1cGVyKCkge30g fScsCiBzaG91bGRUaHJvdygneCA9IGNsYXNzIGV4dGVuZHMgQmFzZSB7IGNvbnN0cnVjdG9yKCkg eyBzdXBlcigpOyB9IG1ldGhvZCgpIHsgc3VwZXIoKSB9IH0nLAogICAgICciU3ludGF4RXJyb3I6 IENhbm5vdCBjYWxsIHN1cGVyKCkgb3V0c2lkZSBvZiBhIGNsYXNzIGNvbnN0cnVjdG9yLiInKTsK IHNob3VsZFRocm93KCd4ID0gY2xhc3MgZXh0ZW5kcyBCYXNlIHsgY29uc3RydWN0b3IoKSB7IHN1 cGVyKCk7IH0gbWV0aG9kKCkgeyBzdXBlciB9IH0nLCAnIlN5bnRheEVycm9yOiBDYW5ub3QgcmVm ZXJlbmNlIHN1cGVyLiInKTsKLXNob3VsZE5vdFRocm93KCd4ID0gY2xhc3MgZXh0ZW5kcyBCYXNl IHsgY29uc3RydWN0b3IoKSB7IHN1cGVyKCk7IH0gbWV0aG9kKCkgeyByZXR1cm4gbmV3IHN1cGVy IH0gfScpOwotc2hvdWxkQmVUcnVlKCcobmV3IHgpLm1ldGhvZCgpIGluc3RhbmNlb2YgQmFzZScp Owotc2hvdWxkQmVGYWxzZSgnKG5ldyB4KS5tZXRob2QoKSBpbnN0YW5jZW9mIHgnKTsKK3Nob3Vs ZFRocm93KCd4ID0gY2xhc3MgZXh0ZW5kcyBCYXNlIHsgY29uc3RydWN0b3IoKSB7IHN1cGVyKCk7 IH0gbWV0aG9kKCkgeyByZXR1cm4gbmV3IHN1cGVyIH0gfScsICciU3ludGF4RXJyb3I6IENhbm5v dCBuZXcgc3VwZXIuIicpOwogc2hvdWxkTm90VGhyb3coJ3ggPSBjbGFzcyBleHRlbmRzIEJhc2Ug eyBjb25zdHJ1Y3RvcigpIHsgc3VwZXIoKTsgfSBtZXRob2QxKCkgeyBkZWxldGUgKHN1cGVyLmZv bykgfSBtZXRob2QyKCkgeyBkZWxldGUgc3VwZXJbImZvbyJdIH0gfScpOwogc2hvdWxkVGhyb3co JyhuZXcgeCkubWV0aG9kMSgpJywgJyJSZWZlcmVuY2VFcnJvcjogQ2Fubm90IGRlbGV0ZSBhIHN1 cGVyIHByb3BlcnR5IicpOwogc2hvdWxkVGhyb3coJyhuZXcgeCkubWV0aG9kMigpJywgJyJSZWZl cmVuY2VFcnJvcjogQ2Fubm90IGRlbGV0ZSBhIHN1cGVyIHByb3BlcnR5IicpOwo=