144279 2015-04-27 14:52:44 -0700 Pages encoded with "cp949" are garbled 2015-04-27 15:27:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 mmaxfield mmaxfield ap dino jonlee simon.fraser thorton webkit-bug-importer oldest_to_newest 1089208 0 mmaxfield 2015-04-27 14:52:44 -0700 Pages encoded with "cp949" are garbled 1089209 1 251778 mmaxfield 2015-04-27 14:53:47 -0700 Created attachment 251778 Patch 1089210 2 mmaxfield 2015-04-27 14:54:47 -0700 <rdar://problem/16179744> 1089220 3 251778 ap 2015-04-27 15:11:32 -0700 Comment on attachment 251778 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251778&action=review > Source/WebCore/platform/text/TextCodecICU.cpp:178 > + // CFStringConvertEncodingToIANACharSetName(kCFStringEncodingDOSKorean) returns "cp949" instead of "windows-949" > + registrar("cp949", "windows-949"); This change adds support for this alias to web content, which looks like the wrong things to do. Firefox and Chrome don't support it (haven't checked IE), and it's not part of the new standard <https://encoding.spec.whatwg.org>. The only registered alias for cp949 is in Java, and it uses a different codec. What is the user observable issue that you are fixing? We probably need to fix it at a different level. There is already one workaround for this CFString behavior in defaultTextEncodingNameForSystemLanguage() function. 1089222 4 ap 2015-04-27 15:13:46 -0700 Found the description in Radar, I think that we shouldn't do anything here. 251778 2015-04-27 14:53:47 -0700 2015-04-27 15:27:25 -0700 Patch bug-144279-20150427145239.patch text/plain 3074 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2I4NTk1YWE0ZTU4MTJk YTM5NTNiZmMwNjc5ZWM1ZjcxODM4YjdjOC4uNDQ1YjcxNDc2N2QxYzE0YTljY2U2OTk5NmY0OTFm NDVkZDVlMjYyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTI3ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgUGFnZXMgZW5j b2RlZCB3aXRoICJjcDk0OSIgYXJlIGdhcmJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDI3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNpbXBseSBhZGQgYSBtYXBwaW5nIHRvIGEgZGVjb2RlciB0 aGF0IHN1cHBvcnRzIHRoaXMuCisKKyAgICAgICAgVGVzdDogZmFzdC9lbmNvZGluZy9jcDk0OS5o dG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L1RleHRDb2RlY0lDVS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpUZXh0Q29kZWNJQ1U6OnJlZ2lzdGVyRW5jb2RpbmdOYW1lcyk6CisKIDIwMTUt MDQtMjcgIEphdmllciBGZXJuYW5kZXogIDxqZmVybmFuZGV6QGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0NTUyBHcmlkIExheW91dF0gU3VwcG9ydCBmb3IgdGhlIGp1c3RpZnktc2VsZiBhbmQganVz dGlmeS1pdGVtcyBpbiBncmlkIGxheW91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC9UZXh0Q29kZWNJQ1UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4 dC9UZXh0Q29kZWNJQ1UuY3BwCmluZGV4IGRkNmZmMDY3NWJiMWE5MjY1NzBkZTQ0ODVlZWRiMTc2 YWFjZTcxNWEuLjdhMzA1NmJlNDk2ZTU4ZTkwMWVkMzYyNjJhMTIwYTVjNTYzMmI0ZGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dENvZGVjSUNVLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRDb2RlY0lDVS5jcHAKQEAgLTE3NCw2 ICsxNzQsOSBAQCB2b2lkIFRleHRDb2RlY0lDVTo6cmVnaXN0ZXJFbmNvZGluZ05hbWVzKEVuY29k aW5nTmFtZVJlZ2lzdHJhciByZWdpc3RyYXIpCiAgICAgcmVnaXN0cmFyKCJkb3MtNzIwIiwgImNw ODY0Iik7CiAgICAgcmVnaXN0cmFyKCJqaXM3IiwgIklTTy0yMDIyLUpQIik7CiAKKyAgICAvLyBD RlN0cmluZ0NvbnZlcnRFbmNvZGluZ1RvSUFOQUNoYXJTZXROYW1lKGtDRlN0cmluZ0VuY29kaW5n RE9TS29yZWFuKSByZXR1cm5zICJjcDk0OSIgaW5zdGVhZCBvZiAid2luZG93cy05NDkiCisgICAg cmVnaXN0cmFyKCJjcDk0OSIsICJ3aW5kb3dzLTk0OSIpOworCiAgICAgLy8gQWx0ZXJuYXRpdmUg c3BlbGxpbmcgb2YgSVNPIGVuY29kaW5nIG5hbWVzLgogICAgIHJlZ2lzdHJhcigiSVNPODg1OS0x IiwgIklTTy04ODU5LTEiKTsKICAgICByZWdpc3RyYXIoIklTTzg4NTktMiIsICJJU08tODg1OS0y Iik7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggMzhjOTlhZjJhMjJmYjZkMzY4M2E3NWQxMmY0NDQ5ODdjMGQ0MjgwMS4uNGJk ZWU0NDcyYzhhYTE5MDk2MTIyZjI2OWE2NzVhYTZiODkzNTE5MyAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA0LTI3ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgUGFnZXMgZW5jb2RlZCB3aXRoICJjcDk0OSIgYXJlIGdhcmJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDI3OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBhcmUgZW5jb2Rl ZCB0ZXh0IHdpdGggdW5lbmNvZGVkIHRleHQuCisKKyAgICAgICAgKiBmYXN0L2VuY29kaW5nL2Nw OTQ5LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZW5jb2RpbmcvY3A5NDku aHRtbDogQWRkZWQuCisKIDIwMTUtMDQtMjcgIEphdmllciBGZXJuYW5kZXogIDxqZmVybmFuZGV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NTUyBHcmlkIExheW91dF0gU3VwcG9ydCBmb3IgdGhl IGp1c3RpZnktc2VsZiBhbmQganVzdGlmeS1pdGVtcyBpbiBncmlkIGxheW91dApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9jcDk0OS1leHBlY3RlZC5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9lbmNvZGluZy9jcDk0OS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjEzYWQ3 NmZmYjAxNmNhNjM1ZmFjOGRiMGMxYWZjMWQ0MThjZmFjYWEKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2NwOTQ5LWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw3 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxoZWFkPgorPC9oZWFkPgorPGJvZHk+CismI3hEMTRDOyYj eEMyQTQ7Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Vu Y29kaW5nL2NwOTQ5Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2NwOTQ5Lmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uMmRkMjNlYTJlOWQ2ZjY1NTg2ZTljZmZkNGQ5ZjdiZTBiOTRiNThhMgotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvY3A5NDkuaHRtbApAQCAt MCwwICsxLDkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxtZXRhIGNoYXJz ZXQ9ImNwOTQ5Ij4KKzwvaGVhZD4KKzxib2R5Pgorxde9ugorPC9ib2R5PgorPC9odG1sPgo=