144271 2015-04-27 11:18:05 -0700 WirelessTargetPicker should not be visible unless a file is playable 2015-05-04 11:11:39 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer oldest_to_newest 1089092 0 eric.carlson 2015-04-27 11:18:05 -0700 Don't show the picker button until we know a file can be played. 1089095 1 eric.carlson 2015-04-27 11:23:06 -0700 <rdar://problem/20712003> 1089096 2 251761 eric.carlson 2015-04-27 11:24:59 -0700 Created attachment 251761 Proposed patch. 1089097 3 251761 jer.noble 2015-04-27 11:29:59 -0700 Comment on attachment 251761 Proposed patch. Nit: it'd be nice if we could pull out the logic in updateStatusDisplay() into something like "isPlayable()", but this is fine as-is. 1089137 4 251770 eric.carlson 2015-04-27 12:39:57 -0700 Created attachment 251770 Patch for landing. 1089160 5 251770 commit-queue 2015-04-27 13:34:29 -0700 Comment on attachment 251770 Patch for landing. Clearing flags on attachment: 251770 Committed r183417: <http://trac.webkit.org/changeset/183417> 251761 2015-04-27 11:24:59 -0700 2015-04-27 11:29:59 -0700 Proposed patch. picker_button_patch.txt text/plain 1943 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzM5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTI3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFdpcmVsZXNzVGFyZ2V0 UGlja2VyIHNob3VsZCBub3QgYmUgdmlzaWJsZSB1bmxlc3MgYSBmaWxlIGlzIHBsYXlhYmxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQyNzEKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwNzEyMDAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29u dHJvbHNBcHBsZS5qczoKKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLnNldFN0YXR1c0hp ZGRlbik6IENhbGwgdXBkYXRlV2lyZWxlc3NUYXJnZXRBdmFpbGFibGUuCisgICAgICAgIChDb250 cm9sbGVyLnByb3RvdHlwZS51cGRhdGVXaXJlbGVzc1RhcmdldEF2YWlsYWJsZSk6IERvbid0IHNo b3cgdGhlIGJ1dHRvbiB1bnRpbCB0aGUKKyAgICAgICAgICAgIHN0YXR1cyBtZXNzYWdlIGhhcyBi ZWVuIGhpZGRlbi4KKwogMjAxNS0wNC0yNyAgSmF2aWVyIEZlcm5hbmRleiAgPGpmZXJuYW5kZXpA aWdhbGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBTdXBwb3J0IGZvciB0aGUg anVzdGlmeS1zZWxmIGFuZCBqdXN0aWZ5LWl0ZW1zIGluIGdyaWQgbGF5b3V0CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNv bnRyb2xzQXBwbGUuanMJKHJldmlzaW9uIDE4MzIwNSkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJKHdvcmtpbmcgY29weSkKQEAg LTE0MDksNiArMTQwOSw3IEBAIENvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAgICAgICAg dGhpcy5jb250cm9scy5yZW1haW5pbmdUaW1lLmNsYXNzTGlzdC5hZGQodGhpcy5DbGFzc05hbWVz LmhpZGRlbik7CiAgICAgICAgICAgICB0aGlzLmhpZGVDb250cm9scygpOwogICAgICAgICB9Cisg ICAgICAgIHRoaXMudXBkYXRlV2lyZWxlc3NUYXJnZXRBdmFpbGFibGUoKTsKICAgICB9LAogCiAg ICAgdHJhY2tIYXNUaHVtYm5haWxzOiBmdW5jdGlvbih0cmFjaykKQEAgLTE4MjQsNyArMTgyNSw3 IEBAIENvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLndpcmVsZXNzUGxheWJh Y2tEaXNhYmxlZCA9IHRoaXMudmlkZW8ud2Via2l0V2lyZWxlc3NWaWRlb1BsYXliYWNrRGlzYWJs ZWQ7CiAKICAgICAgICAgdmFyIHdpcmVsZXNzUGxheWJhY2tUYXJnZXRzQXZhaWxhYmxlID0gQ29u dHJvbGxlci5nU2ltdWxhdGVXaXJlbGVzc1BsYXliYWNrVGFyZ2V0IHx8IHRoaXMuaGFzV2lyZWxl c3NQbGF5YmFja1RhcmdldHM7Ci0gICAgICAgIGlmICh0aGlzLndpcmVsZXNzUGxheWJhY2tEaXNh YmxlZCkKKyAgICAgICAgaWYgKHRoaXMud2lyZWxlc3NQbGF5YmFja0Rpc2FibGVkIHx8ICF0aGlz LnN0YXR1c0hpZGRlbikKICAgICAgICAgICAgIHdpcmVsZXNzUGxheWJhY2tUYXJnZXRzQXZhaWxh YmxlID0gZmFsc2U7CiAKICAgICAgICAgaWYgKHdpcmVsZXNzUGxheWJhY2tUYXJnZXRzQXZhaWxh YmxlKQo= 251770 2015-04-27 12:39:57 -0700 2015-04-27 13:34:29 -0700 Patch for landing. picker_button_patch_2.txt text/plain 2676 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzM5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTI3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFdpcmVsZXNzVGFyZ2V0 UGlja2VyIHNob3VsZCBub3QgYmUgdmlzaWJsZSB1bmxlc3MgYSBmaWxlIGlzIHBsYXlhYmxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQyNzEKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwNzEyMDAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IEpl ciBOb2JsZS4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xz QXBwbGUuanM6CisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS5pc1BsYXlhYmxlKTogTmV3 LgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuc2V0U3RhdHVzSGlkZGVuKTogQ2FsbCB1 cGRhdGVXaXJlbGVzc1RhcmdldEF2YWlsYWJsZS4KKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90 eXBlLnVwZGF0ZVdpcmVsZXNzVGFyZ2V0QXZhaWxhYmxlKTogRG9uJ3Qgc2hvdyB0aGUgYnV0dG9u IHVudGlsIHRoZQorICAgICAgICAgICAgc3RhdHVzIG1lc3NhZ2UgaGFzIGJlZW4gaGlkZGVuLgor CiAyMDE1LTA0LTI3ICBKYXZpZXIgRmVybmFuZGV6ICA8amZlcm5hbmRlekBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIFN1cHBvcnQgZm9yIHRoZSBqdXN0aWZ5LXNlbGYg YW5kIGp1c3RpZnktaXRlbXMgaW4gZ3JpZCBsYXlvdXQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5q cwkocmV2aXNpb24gMTgzNDAwKQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRy b2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwkod29ya2luZyBjb3B5KQpAQCAtNTk3LDYgKzU5Nywx MSBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5zZXROZWVkc1RpbWVs aW5lTWV0cmljc1VwZGF0ZSgpOwogICAgIH0sCiAKKyAgICBpc1BsYXlhYmxlOiBmdW5jdGlvbigp CisgICAgeworICAgICAgICByZXR1cm4gdGhpcy52aWRlby5yZWFkeVN0YXRlID4gSFRNTE1lZGlh RWxlbWVudC5IQVZFX05PVEhJTkcgJiYgIXRoaXMudmlkZW8uZXJyb3I7CisgICAgfSwKKwogICAg IHVwZGF0ZVN0YXR1c0Rpc3BsYXk6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAgICAgdGhp cy51cGRhdGVTaG91bGRMaXN0ZW5Gb3JQbGF5YmFja1RhcmdldEF2YWlsYWJpbGl0eUV2ZW50KCk7 CkBAIC02MDksNyArNjE0LDcgQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIGVs c2UKICAgICAgICAgICAgIHRoaXMuY29udHJvbHMuc3RhdHVzRGlzcGxheS5pbm5lclRleHQgPSAn JzsKIAotICAgICAgICB0aGlzLnNldFN0YXR1c0hpZGRlbighdGhpcy5pc0xpdmUgJiYgdGhpcy52 aWRlby5yZWFkeVN0YXRlID4gSFRNTE1lZGlhRWxlbWVudC5IQVZFX05PVEhJTkcgJiYgIXRoaXMu dmlkZW8uZXJyb3IpOworICAgICAgICB0aGlzLnNldFN0YXR1c0hpZGRlbighdGhpcy5pc0xpdmUg JiYgdGhpcy5pc1BsYXlhYmxlKCkpOwogICAgIH0sCiAKICAgICBoYW5kbGVMb2FkU3RhcnQ6IGZ1 bmN0aW9uKGV2ZW50KQpAQCAtMTQxMSw2ICsxNDE2LDcgQEAgQ29udHJvbGxlci5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnJlbWFpbmluZ1RpbWUuY2xhc3NMaXN0LmFk ZCh0aGlzLkNsYXNzTmFtZXMuaGlkZGVuKTsKICAgICAgICAgICAgIHRoaXMuaGlkZUNvbnRyb2xz KCk7CiAgICAgICAgIH0KKyAgICAgICAgdGhpcy51cGRhdGVXaXJlbGVzc1RhcmdldEF2YWlsYWJs ZSgpOwogICAgIH0sCiAKICAgICB0cmFja0hhc1RodW1ibmFpbHM6IGZ1bmN0aW9uKHRyYWNrKQpA QCAtMTgyOSw3ICsxODM1LDcgQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlm ICh0aGlzLndpcmVsZXNzUGxheWJhY2tEaXNhYmxlZCkKICAgICAgICAgICAgIHdpcmVsZXNzUGxh eWJhY2tUYXJnZXRzQXZhaWxhYmxlID0gZmFsc2U7CiAKLSAgICAgICAgaWYgKHdpcmVsZXNzUGxh eWJhY2tUYXJnZXRzQXZhaWxhYmxlKQorICAgICAgICBpZiAod2lyZWxlc3NQbGF5YmFja1Rhcmdl dHNBdmFpbGFibGUgJiYgdGhpcy5pc1BsYXlhYmxlKCkpCiAgICAgICAgICAgICB0aGlzLmNvbnRy b2xzLndpcmVsZXNzVGFyZ2V0UGlja2VyLmNsYXNzTGlzdC5yZW1vdmUodGhpcy5DbGFzc05hbWVz LmhpZGRlbik7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHRoaXMuY29udHJvbHMud2lyZWxl c3NUYXJnZXRQaWNrZXIuY2xhc3NMaXN0LmFkZCh0aGlzLkNsYXNzTmFtZXMuaGlkZGVuKTsK