144268 2015-04-27 10:53:25 -0700 LLInt's code path for get_from_scope with case GlobalVarWithVarInjectionChecks has dead code 2015-06-16 11:35:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam commit-queue fpizlo ggaren mark.lam mmirman msaboff oliver oldest_to_newest 1089077 0 saam 2015-04-27 10:53:25 -0700 The call to loadVariable(.) both for 32bit and 64bit seems unnecessary. It grabs a value that is immediately overwritten by a call to getGlobalVar(). It should be safe to just delete these calls. 1102116 1 254916 saam 2015-06-15 18:35:31 -0700 Created attachment 254916 patch Let's see what EWS thinks. Running tests locally, too. 1102293 2 254916 commit-queue 2015-06-16 11:35:04 -0700 Comment on attachment 254916 patch Clearing flags on attachment: 254916 Committed r185596: <http://trac.webkit.org/changeset/185596> 1102294 3 commit-queue 2015-06-16 11:35:07 -0700 All reviewed patches have been landed. Closing bug. 254916 2015-06-15 18:35:31 -0700 2015-06-16 11:35:04 -0700 patch work-backup.diff text/plain 1960 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1NTczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA2LTE1ICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBMTEludCdzIGNvZGUgcGF0aCBmb3IgZ2V0X2Zyb21fc2NvcGUgd2l0aCBjYXNlIEdsb2Jh bFZhcldpdGhWYXJJbmplY3Rpb25DaGVja3MgaGFzIGRlYWQgY29kZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MjY4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNhbGwgdG8gbG9hZFZhcmlhYmxl KC4pIGJvdGggZm9yIDMyYml0IGFuZCA2NGJpdCBpcyB1bm5lY2Vzc2FyeS4gCisgICAgICAgIEl0 IGdyYWJzIGEgdmFsdWUgdGhhdCBpcyBpbW1lZGlhdGVseSBvdmVyd3JpdHRlbiBieSBhIGNhbGwg dG8gZ2V0R2xvYmFsVmFyKCkuIAorCisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl cjMyXzY0LmFzbToKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtOgor CiAyMDE1LTA2LTE1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAg ICAgIEpJVCBidWcgLSBmYWlscyB3aGVuIGluc3BlY3RvciBjbG9zZWQsIHdvcmtzIHdoZW4gb3Bl bgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIz Ml82NC5hc20KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHJldmlzaW9uIDE4NTU0NCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCSh3b3JraW5nIGNv cHkpCkBAIC0yMTk3LDcgKzIxOTcsNiBAQCBfbGxpbnRfb3BfZ2V0X2Zyb21fc2NvcGU6CiAuZ0ds b2JhbFZhcldpdGhWYXJJbmplY3Rpb25DaGVja3M6CiAgICAgYmluZXEgdDAsIEdsb2JhbFZhcldp dGhWYXJJbmplY3Rpb25DaGVja3MsIC5nQ2xvc3VyZVZhcldpdGhWYXJJbmplY3Rpb25DaGVja3MK ICAgICB2YXJJbmplY3Rpb25DaGVjayguZ0R5bmFtaWMpCi0gICAgbG9hZFZhcmlhYmxlKDIsIHQy LCB0MSwgdDApCiAgICAgZ2V0R2xvYmFsVmFyKCkKICAgICBkaXNwYXRjaCg4KQogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl cjY0LmFzbQkocmV2aXNpb24gMTg1NTQ0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50 L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc20JKHdvcmtpbmcgY29weSkKQEAgLTIwNjMsNyArMjA2 Myw2IEBAIF9sbGludF9vcF9nZXRfZnJvbV9zY29wZToKIC5nR2xvYmFsVmFyV2l0aFZhckluamVj dGlvbkNoZWNrczoKICAgICBiaW5lcSB0MCwgR2xvYmFsVmFyV2l0aFZhckluamVjdGlvbkNoZWNr cywgLmdDbG9zdXJlVmFyV2l0aFZhckluamVjdGlvbkNoZWNrcwogICAgIHZhckluamVjdGlvbkNo ZWNrKC5nRHluYW1pYykKLSAgICBsb2FkVmFyaWFibGUoMiwgdDApCiAgICAgZ2V0R2xvYmFsVmFy KCkKICAgICBkaXNwYXRjaCg4KQogCg==