144267 2015-04-27 10:41:40 -0700 REGRESSION(r182879): Images and video can no longer be downloaded 2015-04-27 11:39:40 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 143794 1 bfulgham bfulgham bfulgham webkit-bug-importer oldest_to_newest 1089072 0 bfulgham 2015-04-27 10:41:40 -0700 While working on Bug 143794, I broke the ability to download image and media content (see <http://trac.webkit.org/changeset/182879>) because I enable the download state on whether the link protocol is type 'file'. Instead, I should have been checking for NOT file. 1089073 1 bfulgham 2015-04-27 10:45:24 -0700 <rdar://problem/20702844> 1089074 2 251757 bfulgham 2015-04-27 10:46:14 -0700 Created attachment 251757 Patch 1089075 3 251757 simon.fraser 2015-04-27 10:50:19 -0700 Comment on attachment 251757 Patch Is this not testable? Also sad that we have the same code in 4 places. Can you at least reduce that to 2? 1089104 4 bfulgham 2015-04-27 11:38:11 -0700 Added tests to TestWebKITAPI while landing. 1089106 5 bfulgham 2015-04-27 11:39:40 -0700 Committed r183403: <http://trac.webkit.org/changeset/183403> 251757 2015-04-27 10:46:14 -0700 2015-04-27 10:50:19 -0700 Patch bug-144267-20150427104518.patch text/plain 4272 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzM5OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTI3ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4Mjg3 OSk6IEltYWdlcyBhbmQgdmlkZW8gY2FuIG5vIGxvbmdlciBiZSBkb3dubG9hZGVkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQyNjcKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzIwNzAyODQ0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVy Lm1tOgorICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250cm9sbGVyIF9jcmVhdGVBY3Rpb25NZW51 SXRlbUZvclRhZzpdKTogQ2hlY2sgZm9yCisgICAgICAgICIhV2ViQ29yZTo6cHJvdG9jb2xJcygu Li4sICJmaWxlIikiIGZvciBpbWFnZSBhbmQgbWVkaWEgZG93bmxvYWRzLgorCiAyMDE1LTA0LTI3 ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0g VGVzdFdlYktpdEFQSSdzIGZvcndhcmRpbmcgaGVhZGVyIGdlbmVyYXRvciBzaG91bGQgZGVwZW5k IG9uIFdlYktpdDIncyBnZW5lcmF0b3IKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9t YWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE4MzM5 NykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxl ci5tbQkod29ya2luZyBjb3B5KQpAQCAtNTkwLDcgKzU5MCw3IEBAIC0gKFJldGFpblB0cjxOU01l bnVJdGVtPilfY3JlYXRlQWN0aW9uTWUKICAgICAgICAgc2VsZWN0b3IgPSBAc2VsZWN0b3IoX3Nh dmVJbWFnZVRvRG93bmxvYWRzOik7CiAgICAgICAgIHRpdGxlID0gV0VCX1VJX1NUUklOR19LRVko IlNhdmUgdG8gRG93bmxvYWRzIiwgIlNhdmUgdG8gRG93bmxvYWRzIChpbWFnZSBhY3Rpb24gbWVu dSBpdGVtKSIsICJpbWFnZSBhY3Rpb24gbWVudSBpdGVtIik7CiAgICAgICAgIGltYWdlID0gW05T SW1hZ2UgaW1hZ2VOYW1lZDpAIk5TQWN0aW9uTWVudVNhdmVUb0Rvd25sb2FkcyJdOwotICAgICAg ICBlbmFibGVkID0gV2ViQ29yZTo6cHJvdG9jb2xJcyhoaXRUZXN0UmVzdWx0LT5hYnNvbHV0ZUlt YWdlVVJMKCksICJmaWxlIik7CisgICAgICAgIGVuYWJsZWQgPSAhV2ViQ29yZTo6cHJvdG9jb2xJ cyhoaXRUZXN0UmVzdWx0LT5hYnNvbHV0ZUltYWdlVVJMKCksICJmaWxlIik7CiAgICAgICAgIGJy ZWFrOwogCiAgICAgY2FzZSBrV0tDb250ZXh0QWN0aW9uSXRlbVRhZ0NvcHlUZXh0OgpAQCAtNjIx LDcgKzYyMSw3IEBAIC0gKFJldGFpblB0cjxOU01lbnVJdGVtPilfY3JlYXRlQWN0aW9uTWUKICAg ICAgICAgc2VsZWN0b3IgPSBAc2VsZWN0b3IoX3NhdmVWaWRlb1RvRG93bmxvYWRzOik7CiAgICAg ICAgIHRpdGxlID0gV0VCX1VJX1NUUklOR19LRVkoIlNhdmUgdG8gRG93bmxvYWRzIiwgIlNhdmUg dG8gRG93bmxvYWRzICh2aWRlbyBhY3Rpb24gbWVudSBpdGVtKSIsICJ2aWRlbyBhY3Rpb24gbWVu dSBpdGVtIik7CiAgICAgICAgIGltYWdlID0gW05TSW1hZ2UgaW1hZ2VOYW1lZDpAIk5TQWN0aW9u TWVudVNhdmVUb0Rvd25sb2FkcyJdOwotICAgICAgICBlbmFibGVkID0gV2ViQ29yZTo6cHJvdG9j b2xJcyhoaXRUZXN0UmVzdWx0LT5hYnNvbHV0ZU1lZGlhVVJMKCksICJmaWxlIik7CisgICAgICAg IGVuYWJsZWQgPSAhV2ViQ29yZTo6cHJvdG9jb2xJcyhoaXRUZXN0UmVzdWx0LT5hYnNvbHV0ZU1l ZGlhVVJMKCksICJmaWxlIik7CiAgICAgICAgIGJyZWFrOwogCiAgICAgZGVmYXVsdDoKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzM5OSkKKysrIFNvdXJjZS9XZWJLaXQvbWFjL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTI3ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4 Mjg3OSk6IEltYWdlcyBhbmQgdmlkZW8gY2FuIG5vIGxvbmdlciBiZSBkb3dubG9hZGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQyNjcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzIwNzAyODQ0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy9XZWJBY3Rpb25NZW51Q29udHJvbGxlci5t bToKKyAgICAgICAgKC1bV2ViQWN0aW9uTWVudUNvbnRyb2xsZXIgX2NyZWF0ZUFjdGlvbk1lbnVJ dGVtRm9yVGFnOl0pOiBDaGVjayBmb3IKKyAgICAgICAgIiFXZWJDb3JlOjpwcm90b2NvbElzKC4u LiwgImZpbGUiKSIgZm9yIGltYWdlIGFuZCBtZWRpYSBkb3dubG9hZHMuCisKIDIwMTUtMDQtMjYg IFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0VTNl0g SW1wbGVtZW50IEVTNiB0ZW1wbGF0ZSBsaXRlcmFscwpJbmRleDogU291cmNlL1dlYktpdC9tYWMv V2ViVmlldy9XZWJBY3Rpb25NZW51Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9XZWJWaWV3L1dlYkFjdGlvbk1lbnVDb250cm9sbGVyLm1tCShyZXZpc2lvbiAx ODMzOTcpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkFjdGlvbk1lbnVDb250cm9s bGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02OTEsNyArNjkxLDcgQEAgLSAoUmV0YWluUHRyPE5T TWVudUl0ZW0+KV9jcmVhdGVBY3Rpb25NZQogICAgICAgICBzZWxlY3RvciA9IEBzZWxlY3Rvcihf c2F2ZUltYWdlVG9Eb3dubG9hZHM6KTsKICAgICAgICAgdGl0bGUgPSBXRUJfVUlfU1RSSU5HX0tF WSgiU2F2ZSB0byBEb3dubG9hZHMiLCAiU2F2ZSB0byBEb3dubG9hZHMgKGltYWdlIGFjdGlvbiBt ZW51IGl0ZW0pIiwgImltYWdlIGFjdGlvbiBtZW51IGl0ZW0iKTsKICAgICAgICAgaW1hZ2UgPSBb TlNJbWFnZSBpbWFnZU5hbWVkOkAiTlNBY3Rpb25NZW51U2F2ZVRvRG93bmxvYWRzIl07Ci0gICAg ICAgIGVuYWJsZWQgPSBXZWJDb3JlOjpwcm90b2NvbElzKF9oaXRUZXN0UmVzdWx0LmFic29sdXRl SW1hZ2VVUkwoKSwgImZpbGUiKTsKKyAgICAgICAgZW5hYmxlZCA9ICFXZWJDb3JlOjpwcm90b2Nv bElzKF9oaXRUZXN0UmVzdWx0LmFic29sdXRlSW1hZ2VVUkwoKSwgImZpbGUiKTsKICAgICAgICAg YnJlYWs7CiAKICAgICBjYXNlIFdlYkFjdGlvbk1lbnVJdGVtVGFnQ29weVZpZGVvVVJMOgpAQCAt NzA0LDcgKzcwNCw3IEBAIC0gKFJldGFpblB0cjxOU01lbnVJdGVtPilfY3JlYXRlQWN0aW9uTWUK ICAgICAgICAgc2VsZWN0b3IgPSBAc2VsZWN0b3IoX3NhdmVWaWRlb1RvRG93bmxvYWRzOik7CiAg ICAgICAgIHRpdGxlID0gV0VCX1VJX1NUUklOR19LRVkoIlNhdmUgdG8gRG93bmxvYWRzIiwgIlNh dmUgdG8gRG93bmxvYWRzICh2aWRlbyBhY3Rpb24gbWVudSBpdGVtKSIsICJ2aWRlbyBhY3Rpb24g bWVudSBpdGVtIik7CiAgICAgICAgIGltYWdlID0gW05TSW1hZ2UgaW1hZ2VOYW1lZDpAIk5TQWN0 aW9uTWVudVNhdmVUb0Rvd25sb2FkcyJdOwotICAgICAgICBlbmFibGVkID0gV2ViQ29yZTo6cHJv dG9jb2xJcyhfaGl0VGVzdFJlc3VsdC5hYnNvbHV0ZU1lZGlhVVJMKCksICJmaWxlIik7CisgICAg ICAgIGVuYWJsZWQgPSAhV2ViQ29yZTo6cHJvdG9jb2xJcyhfaGl0VGVzdFJlc3VsdC5hYnNvbHV0 ZU1lZGlhVVJMKCksICJmaWxlIik7CiAgICAgICAgIGJyZWFrOwogCiAgICAgZGVmYXVsdDoK