144258 2015-04-27 03:11:40 -0700 Redefining a method of the same name hits an assertion 2016-04-08 11:18:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140491 1 rniwa webkit-unassigned joepeck mark.lam ossy rniwa saam oldest_to_newest 1088981 0 rniwa 2015-04-27 03:11:40 -0700 class A { get foo() {} get foo() {} } hits an assertion. 1088985 1 ossy 2015-04-27 03:21:22 -0700 re https://trac.webkit.org/changeset/183391 - run-javascriptcore-tests doesn't use TestExpectations file at all. If you want to skip it on JSC bots too, you need to add "//@ skip" into the test js file. 1088986 2 rniwa 2015-04-27 03:22:50 -0700 (In reply to comment #1) > re https://trac.webkit.org/changeset/183391 - run-javascriptcore-tests > doesn't > use TestExpectations file at all. If you want to skip it on JSC bots too, you > need to add "//@ skip" into the test js file. That's a good point. We should do that. 1088987 3 rniwa 2015-04-27 03:24:35 -0700 Done that in http://trac.webkit.org/changeset/183392. 1091025 4 rniwa 2015-05-01 18:44:23 -0700 *** Bug 144514 has been marked as a duplicate of this bug. *** 1141189 5 rniwa 2015-11-11 12:04:34 -0800 This has been fixed. 1182019 6 275967 joepeck 2016-04-07 20:11:17 -0700 Created attachment 275967 [PATCH] Proposed Fix - Unskip Reopen to unskip. 1182216 7 275967 joepeck 2016-04-08 11:14:35 -0700 Comment on attachment 275967 [PATCH] Proposed Fix - Unskip Try again to get commit-queue to notice this. 1182219 8 275967 joepeck 2016-04-08 11:17:12 -0700 Comment on attachment 275967 [PATCH] Proposed Fix - Unskip Ugh, I'll just land manually. 1182221 9 joepeck 2016-04-08 11:18:39 -0700 <http://trac.webkit.org/changeset/199236> 275967 2016-04-07 20:11:17 -0700 2016-04-08 11:17:12 -0700 [PATCH] Proposed Fix - Unskip unskip.patch text/plain 1786 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYTExNjljLi4wOGEyYWEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDQt MDcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSZWRl ZmluaW5nIGEgbWV0aG9kIG9mIHRoZSBzYW1lIG5hbWUgaGl0cyBhbiBhc3NlcnRpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDI1OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0 aW9uczoKKyAgICAgICAgKiBqcy9zY3JpcHQtdGVzdHMvY2xhc3Mtc3ludGF4LXNlbWljb2xvbi5q czoKKyAgICAgICAgVGhpcyB0ZXN0IG5vIGxvbmdlciBhc3NlcnRzLgorCiAyMDE2LTA0LTA3ICBG aWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50aW5nIGNh Y2hpbmcgdHJhbnNpdGlvbiBwdXRzIHRoYXQgbmVlZCB0byByZWFsbG9jYXRlIHdpdGggaW5kZXhp bmcgc3RvcmFnZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xh eW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYjU0NDY4Ni4uOTZmNTJlNyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0 RXhwZWN0YXRpb25zCkBAIC02NzUsOCArNjc1LDYgQEAgd2Via2l0Lm9yZy9iLzE0MjkzNyBpZXRl c3RjZW50ZXIvSmF2YXNjcmlwdC8xNS4yLjMuMTQtMS0zLmh0bWwgWyBGYWlsdXJlIF0KIAogWyBE ZWJ1ZyBdIGpzL3JlZ3Jlc3MtMTQxMDk4Lmh0bWwgWyBTbG93IF0KIAotd2Via2l0Lm9yZy9iLzE0 NDI1OCBbIERlYnVnIF0ganMvY2xhc3Mtc3ludGF4LXNlbWljb2xvbi5odG1sIFsgU2tpcCBdCi0K ICMgSURCVmVyc2lvbkNoYW5nZUV2ZW50IHRlc3RzIG5lZWQgdG8gYmUgcmV3cml0dGVuIHRvIHVz ZSBldmVudCBjb25zdHJ1Y3RvcnMgaW5zdGVhZCBvZiBjcmVhdGVFdmVudCwKICMgYWZ0ZXIgd2Ug aW1wbGVtZW50IHRoZSBJREJWZXJzaW9uQ2hhbmdlRXZlbnQgY29uc3RydWN0b3IuCiB3ZWJraXQu b3JnL2IvMTQ1MzkwIHN0b3JhZ2UvaW5kZXhlZGRiL2V2ZW50cy5odG1sIFsgRmFpbHVyZSBdCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvY2xhc3Mtc3ludGF4LXNlbWlj b2xvbi5qcyBiL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9jbGFzcy1zeW50YXgtc2VtaWNv bG9uLmpzCmluZGV4IGVlYWY3OTAuLjg2YjNkNTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pz L3NjcmlwdC10ZXN0cy9jbGFzcy1zeW50YXgtc2VtaWNvbG9uLmpzCisrKyBiL0xheW91dFRlc3Rz L2pzL3NjcmlwdC10ZXN0cy9jbGFzcy1zeW50YXgtc2VtaWNvbG9uLmpzCkBAIC0xLDUgKzEsMyBA QAotLy9AIHNraXAKLQogZGVzY3JpcHRpb24oJ1Rlc3RzIGZvciBFUzYgY2xhc3Mgc3ludGF4IGNv bnRhaW5pbmcgc2VtaWNvbG9uIGluIHRoZSBjbGFzcyBib2R5Jyk7CiAKIHNob3VsZFRocm93KCJj bGFzcyBBIHsgZm9vOygpIHsgfSB9IiwgIidTeW50YXhFcnJvcjogVW5leHBlY3RlZCB0b2tlbiBc XCc7XFwnLiBFeHBlY3RlZCBhbiBvcGVuaW5nIFxcJyhcXCcgYmVmb3JlIGEgbWV0aG9kXFwncyBw YXJhbWV0ZXIgbGlzdC4nIik7Cg==