144255 2015-04-27 02:21:59 -0700 Fix the !ENABLE(CSS_GRID_LAYOUT) build after r183370 2015-04-27 04:12:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy commit-queue darin esprehn+autocc glenn jfernandez kondapallykalyan rego svillar oldest_to_newest 1088964 0 ossy 2015-04-27 02:21:59 -0700 build log: ../../Source/WebCore/rendering/RenderBox.cpp: In member function 'virtual void WebCore::RenderBox::computeLogicalHeight(WebCore::LayoutUnit, WebCore::LayoutUnit, WebCore::RenderBox::LogicalExtentComputedValues&) const': ../../Source/WebCore/rendering/RenderBox.cpp:2715:109: error: 'class WebCore::RenderElement' has no member named 'isRenderGrid' ninja: build stopped: subcommand failed. Fix is coming. 1088967 1 251731 ossy 2015-04-27 02:26:45 -0700 Created attachment 251731 Patch 1088969 2 jfernandez 2015-04-27 02:52:31 -0700 Wow, I totally forgot about the flag. Sorry about it, the patch indeed fixes the bug. 1088995 3 251731 commit-queue 2015-04-27 04:12:02 -0700 Comment on attachment 251731 Patch Clearing flags on attachment: 251731 Committed r183394: <http://trac.webkit.org/changeset/183394> 1088996 4 commit-queue 2015-04-27 04:12:07 -0700 All reviewed patches have been landed. Closing bug. 251731 2015-04-27 02:26:45 -0700 2015-04-27 04:12:02 -0700 Patch bug-144255-20150427022537.patch text/plain 1695 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQ1MTY5ZTEyNDFkZDJk ZDA4ZTM4ZjEwM2NmMThlMzgzMDIxZDE5My4uNTdhZGM4YWRjZDM0OGYzNzdjNDkwNDIwMDhhNzFk YzY0ZjQyM2M2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA0LTI3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKENTU19HUklEX0xBWU9VVCkgYnVpbGQgYWZ0ZXIgcjE4MzM3MAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MjU1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Y29tcHV0ZUxvZ2ljYWxIZWlnaHQpOgor CiAyMDE1LTA0LTI0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbSkhCdWlsZF0gTW92ZSB0byB1cHN0cmVhbSBPcGVuV2ViUlRDCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCmluZGV4IGQ0NzRjMWIyZmU0MzgzNmY3ZTFkMTYyMTA1 MTE2ZDdjYTA1YTI1NmYuLmI1ZTlmMWY3YWZkMjMwNDAwYTE3MTI5NzAxYjZlMjg2MDdmZTU3ZjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCkBAIC0yNzEyLDcgKzI3MTIs MTEgQEAgdm9pZCBSZW5kZXJCb3g6OmNvbXB1dGVMb2dpY2FsSGVpZ2h0KExheW91dFVuaXQgbG9n aWNhbEhlaWdodCwgTGF5b3V0VW5pdCBsb2dpY2EKICAgICAgICAgLy8gZ3JhYiBvdXIgY2FjaGVk IGZsZXhpYmxlIGhlaWdodC4KICAgICAgICAgLy8gRklYTUU6IEFjY291bnQgZm9yIGJsb2NrLWZs b3cgaW4gZmxleGlibGUgYm94ZXMuCiAgICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NjQxOAotICAgICAgICBpZiAoaGFzT3ZlcnJpZGVMb2dpY2FsQ29u dGVudEhlaWdodCgpICYmIChwYXJlbnQoKS0+aXNGbGV4aWJsZUJveEluY2x1ZGluZ0RlcHJlY2F0 ZWQoKSB8fCBwYXJlbnQoKS0+aXNSZW5kZXJHcmlkKCkpKQorICAgICAgICBpZiAoaGFzT3ZlcnJp ZGVMb2dpY2FsQ29udGVudEhlaWdodCgpICYmIChwYXJlbnQoKS0+aXNGbGV4aWJsZUJveEluY2x1 ZGluZ0RlcHJlY2F0ZWQoKQorI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCisgICAgICAgICAg ICB8fCBwYXJlbnQoKS0+aXNSZW5kZXJHcmlkKCkKKyNlbmRpZgorICAgICAgICApKQogICAgICAg ICAgICAgaCA9IExlbmd0aChvdmVycmlkZUxvZ2ljYWxDb250ZW50SGVpZ2h0KCksIEZpeGVkKTsK ICAgICAgICAgZWxzZSBpZiAodHJlYXRBc1JlcGxhY2VkKQogICAgICAgICAgICAgaCA9IExlbmd0 aChjb21wdXRlUmVwbGFjZWRMb2dpY2FsSGVpZ2h0KCksIEZpeGVkKTsK