144253 2015-04-27 01:56:28 -0700 Map#entries and Map#keys error for non-Maps is swapped 2015-04-27 14:52:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ljharb ljharb commit-queue joepeck oldest_to_newest 1088960 0 ljharb 2015-04-27 01:56:28 -0700 Map.prototype.entries.call({}) gives an error about a "key iterator", and Map.prototype.keys.call({}) gives an error about an "entry iterator". 1088962 1 251729 ljharb 2015-04-27 01:59:56 -0700 Created attachment 251729 Patch 1089080 2 joepeck 2015-04-27 11:01:33 -0700 Good fix. Can we have a test for these? var nonMapObject = {}; Map.prototype.entries.call(nonMapObject); 1089085 3 ljharb 2015-04-27 11:07:00 -0700 (In reply to comment #2) > Good fix. Can we have a test for these? > > var nonMapObject = {}; > Map.prototype.entries.call(nonMapObject); Sure, I'll do that in a followup. Where would you recommend I create them? It looks like `Source/JavaScriptCore/tests/stress/iterators-other-receivers` might be a good filename? 1089103 4 251729 commit-queue 2015-04-27 11:37:42 -0700 Comment on attachment 251729 Patch Clearing flags on attachment: 251729 Committed r183402: <http://trac.webkit.org/changeset/183402> 1089105 5 commit-queue 2015-04-27 11:38:33 -0700 All reviewed patches have been landed. Closing bug. 1089207 6 joepeck 2015-04-27 14:52:07 -0700 (In reply to comment #3) > (In reply to comment #2) > > Good fix. Can we have a test for these? > > > > var nonMapObject = {}; > > Map.prototype.entries.call(nonMapObject); > > Sure, I'll do that in a followup. Where would you recommend I create them? > It looks like `Source/JavaScriptCore/tests/stress/iterators-other-receivers` > might be a good filename? Yeah, that sounds fine. Feel free to CC me! 251729 2015-04-27 01:59:56 -0700 2015-04-27 11:37:42 -0700 Patch bug-144253-20150427015849.patch text/plain 3356 ljharb U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ZjFiYjIwMzNlYmY2NzU2ZWIxMDZlZmI0MzcxYjIxNDUwZjVhOGI4Li4wNjcwN2RhNTU5MDI3OWQw ZTEyZDJjMmY3Mjg5ZGFhM2I5MmIxY2QzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNS0wNC0yNyAgSm9yZGFuIEhhcmJhbmQgIDxsamhhcmJAZ21haWwuY29t PgorCisgICAgICAgIE1hcCNlbnRyaWVzIGFuZCBNYXAja2V5cyBlcnJvciBmb3Igbm9uLU1hcHMg aXMgc3dhcHBlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ0MjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ29ycmVjdGluZyBlcnJvciBtZXNzYWdlcyBvbiBTZXQvTWFwIG1ldGhvZHMgd2hlbiBjYWxs ZWQgb24KKyAgICAgICAgaW5jb21wYXRpYmxlIG9iamVjdHMuCisKKyAgICAgICAgKiBydW50aW1l L01hcFByb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6Om1hcFByb3RvRnVuY0VudHJpZXMpOgor ICAgICAgICAoSlNDOjptYXBQcm90b0Z1bmNLZXlzKToKKyAgICAgICAgKiBydW50aW1lL1NldFBy b3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OnNldFByb3RvRnVuY0VudHJpZXMpOgorCiAyMDE1 LTA0LTI2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENsYXNz IGJvZHkgZW5kaW5nIHdpdGggYSBzZW1pY29sb24gdGhyb3dzIGEgU3ludGF4RXJyb3IKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcFByb3RvdHlwZS5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXBQcm90b3R5cGUuY3BwCmluZGV4IDFkYzU1 ZDc2ZTZhZTBmNGI0ODQ0YzI3ZGU5OGRkNmI2OWQ0ZDQ5ZWYuLjk2ZGVhZTcxNGNhNTFhNjdmZDE2 NDA4ZTVjMzlkM2M2NTY3Mzg5NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL01hcFByb3RvdHlwZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvTWFwUHJvdG90eXBlLmNwcApAQCAtMTkzLDcgKzE5Myw3IEBAIEVuY29kZWRKU1ZhbHVlIEpT Q19IT1NUX0NBTEwgbWFwUHJvdG9GdW5jRW50cmllcyhDYWxsRnJhbWUqIGNhbGxGcmFtZSkKIHsK ICAgICBKU01hcCogdGhpc09iaiA9IGpzRHluYW1pY0Nhc3Q8SlNNYXAqPihjYWxsRnJhbWUtPnRo aXNWYWx1ZSgpKTsKICAgICBpZiAoIXRoaXNPYmopCi0gICAgICAgIHJldHVybiBKU1ZhbHVlOjpl bmNvZGUodGhyb3dUeXBlRXJyb3IoY2FsbEZyYW1lLCBBU0NJSUxpdGVyYWwoIkNhbm5vdCBjcmVh dGUgYSBNYXAga2V5IGl0ZXJhdG9yIGZvciBhIG5vbi1NYXAgb2JqZWN0LiIpKSk7CisgICAgICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUodGhyb3dUeXBlRXJyb3IoY2FsbEZyYW1lLCBBU0NJSUxp dGVyYWwoIkNhbm5vdCBjcmVhdGUgYSBNYXAgZW50cnkgaXRlcmF0b3IgZm9yIGEgbm9uLU1hcCBv YmplY3QuIikpKTsKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTTWFwSXRlcmF0b3I6OmNy ZWF0ZShjYWxsRnJhbWUtPnZtKCksIGNhbGxGcmFtZS0+Y2FsbGVlKCktPmdsb2JhbE9iamVjdCgp LT5tYXBJdGVyYXRvclN0cnVjdHVyZSgpLCB0aGlzT2JqLCBNYXBJdGVyYXRlS2V5VmFsdWUpKTsK IH0KIApAQCAtMjAxLDcgKzIwMSw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgbWFw UHJvdG9GdW5jS2V5cyhDYWxsRnJhbWUqIGNhbGxGcmFtZSkKIHsKICAgICBKU01hcCogdGhpc09i aiA9IGpzRHluYW1pY0Nhc3Q8SlNNYXAqPihjYWxsRnJhbWUtPnRoaXNWYWx1ZSgpKTsKICAgICBp ZiAoIXRoaXNPYmopCi0gICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUodGhyb3dUeXBlRXJy b3IoY2FsbEZyYW1lLCBBU0NJSUxpdGVyYWwoIkNhbm5vdCBjcmVhdGUgYSBNYXAgZW50cnkgaXRl cmF0b3IgZm9yIGEgbm9uLU1hcCBvYmplY3QuIikpKTsKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6 OmVuY29kZSh0aHJvd1R5cGVFcnJvcihjYWxsRnJhbWUsIEFTQ0lJTGl0ZXJhbCgiQ2Fubm90IGNy ZWF0ZSBhIE1hcCBrZXkgaXRlcmF0b3IgZm9yIGEgbm9uLU1hcCBvYmplY3QuIikpKTsKICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTTWFwSXRlcmF0b3I6OmNyZWF0ZShjYWxsRnJhbWUtPnZt KCksIGNhbGxGcmFtZS0+Y2FsbGVlKCktPmdsb2JhbE9iamVjdCgpLT5tYXBJdGVyYXRvclN0cnVj dHVyZSgpLCB0aGlzT2JqLCBNYXBJdGVyYXRlS2V5KSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NldFByb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9TZXRQcm90b3R5cGUuY3BwCmluZGV4IDllZmZlNDA1YWIyOTQxNGE0 YWM3Nzk4MzFkNmQ1ODRhNTA5OTU4OGEuLmU4M2UzODMyNThmOTliYjA1YmJlMTFlMGM2NWRlMDRi OGUwNDllMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NldFBy b3RvdHlwZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2V0UHJvdG90 eXBlLmNwcApAQCAtMTgzLDcgKzE4Myw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwg c2V0UHJvdG9GdW5jRW50cmllcyhDYWxsRnJhbWUqIGNhbGxGcmFtZSkKIHsKICAgICBKU1NldCog dGhpc09iaiA9IGpzRHluYW1pY0Nhc3Q8SlNTZXQqPihjYWxsRnJhbWUtPnRoaXNWYWx1ZSgpKTsK ICAgICBpZiAoIXRoaXNPYmopCi0gICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUodGhyb3dU eXBlRXJyb3IoY2FsbEZyYW1lLCBBU0NJSUxpdGVyYWwoIkNhbm5vdCBjcmVhdGUgYSBTZXQga2V5 IGl0ZXJhdG9yIGZvciBhIG5vbi1TZXQgb2JqZWN0LiIpKSk7CisgICAgICAgIHJldHVybiBKU1Zh bHVlOjplbmNvZGUodGhyb3dUeXBlRXJyb3IoY2FsbEZyYW1lLCBBU0NJSUxpdGVyYWwoIkNhbm5v dCBjcmVhdGUgYSBTZXQgZW50cnkgaXRlcmF0b3IgZm9yIGEgbm9uLVNldCBvYmplY3QuIikpKTsK ICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTU2V0SXRlcmF0b3I6OmNyZWF0ZShjYWxsRnJh bWUtPnZtKCksIGNhbGxGcmFtZS0+Y2FsbGVlKCktPmdsb2JhbE9iamVjdCgpLT5zZXRJdGVyYXRv clN0cnVjdHVyZSgpLCB0aGlzT2JqLCBTZXRJdGVyYXRlS2V5VmFsdWUpKTsKIH0KIAo=